[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
gerritbot added a comment. Change 348048 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Consider languages being it's own parent in LanguageFallbackChainFactory https://gerrit.wikimedia.org/r/348048TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
gerritbot added a comment. Change 348229 abandoned by C. Scott Ananian: Don't trust LanguageConverter::$languagesWithVariants Reason: It turns out that $language->getParentLanguage() already has the desired call to $parentLanguage->hasVariant($language) and so this patch is not needed. https://gerrit.wikimedia.org/r/348229TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
gerritbot added a comment. Change 348229 had a related patch set uploaded (by C. Scott Ananian): [mediawiki/extensions/Wikibase@master] Don't trust LanguageConverter::$languagesWithVariants https://gerrit.wikimedia.org/r/348229TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
gerritbot added a comment. Change 348048 had a related patch set uploaded (by Thiemo Mättig (WMDE)): [mediawiki/extensions/Wikibase@master] Consider languages being it's own parent in LanguageFallbackChainFactory https://gerrit.wikimedia.org/r/348048TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. @cscott The Wikibase code looks at LanguageConverter::$languagesWithVariants. The problem is that before the patch that list did not contain en but now it does. And depending on whether the language is there or not, getParentLanguage() for en returns different results - it returned null before, but with the patch it returns object for en so English is parent of itself now. The description of FALLBACK_VARIANTS suggests that's what languages with variants should do, but not what languages without variants do. The problem seems to be Wikibase assumes en is the latter, but the patch changes it to the former. I'm not sure it's a good idea to have certain languages behave completely different from others on the same calls, but that's how the code seems to go now.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
cscott added a comment. The correct logic to determine if a language has variants doesn't involve looking at the fallback chain. See discussion in T153341.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: cscottCc: daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. @thiemowmde https://gerrit.wikimedia.org/r/#/c/72053 was rebased and now shows the error again.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: daniel, hoo, aude, Lydia_Pintscher, thiemowmde, Smalyshev, Aklapper, cscott, QZanden, Izno, Wikidata-bugs, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. Looked more into it, and looks like fallback chain is supposed to return language itself if it's specified as "language with variants"... So looks like maybe making it somehow conditional may work, but I couldn't figure out code fix for it.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T156280: WikiBase assumes English doesn't have a variant
Smalyshev added a comment. It looks like what is happening is that "en" language is resolved to be it's own variant even if pig latin is not enabled. It's not exactly right, and I'm not sure it's Wikibase test's fault - I think actually Wikibase is not at fault here. It's the code that says "we have variants, but we don't actually have variants". So we should either not declare variants, or at least not declare "en" to be its own variant.TASK DETAILhttps://phabricator.wikimedia.org/T156280EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Smalyshev, Aklapper, cscott, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
