[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lea_Lacroix_WMDE added a comment. In T169224#4468922, @Lucas_Werkmeister_WMDE wrote: you can get statement IDs from the query service Well, that's a start :) Can you build an example of query that I can share?TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDECc: Lea_Lacroix_WMDE, Marsupium, Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lucas_Werkmeister_WMDE added a comment. I don’t think we have anything to make that easy for the moment :/ you can get statement IDs from the query service, but we haven’t updated the redirect yet to make use of this feature. Personally, when I want to link to a statement, I use the browser’s dev tools to copy the statement ID, but that’s not a good answer for the announcement :/TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lea_Lacroix_WMDE, Marsupium, Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lea_Lacroix_WMDE added a comment. @Lucas_Werkmeister_WMDE Just a question for the announcement: how people are supposed to generate the link? Is there something clickable somewhere? How are they supposed to find out the part at the end of the URL?TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lea_Lacroix_WMDECc: Lea_Lacroix_WMDE, Marsupium, Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
gerritbot added a comment. Change 445977 merged by jenkins-bot: [mediawiki/extensions/WikibaseQualityConstraints@master] Link to constraint statement instead of statement group https://gerrit.wikimedia.org/r/445977TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lea_Lacroix_WMDE, Marsupium, Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
gerritbot added a comment. Change 445977 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseQualityConstraints@master] Link to constraint statement instead of statement group https://gerrit.wikimedia.org/r/445977TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: Lea_Lacroix_WMDE, Marsupium, Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lydia_Pintscher added a comment. Thanks! I guess it is not rolled out on Wikidata yet?TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Jonas added a comment. @Lydia_Pintscher for me link provided in the patch does not work: https://www.wikidata.org/wiki/Q1#Q1$8983b0ea-4a9c-0902-c0db-785db33f767cTASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, JonasCc: Jonas, Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lydia_Pintscher added a comment. Could you give an example link please? (A bit hard to test :D) Also: Does this work fine with several statement sections on the same page potentially having the same statement like on Lexemes)?TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, Lydia_PintscherCc: Lydia_Pintscher, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
gerritbot added a comment. Change 440850 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add statement ID as id attribute to statements https://gerrit.wikimedia.org/r/440850TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
gerritbot added a comment. Change 440850 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Add statement ID as id attribute to statements https://gerrit.wikimedia.org/r/440850TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T169224: Add support for linking to a particular statement
Lucas_Werkmeister_WMDE added a comment. The simplest fix for this is trivial: diff --git a/view/resources/templates.php b/view/resources/templates.php index 5efe5bd65..5da5e66e7 100644 --- a/view/resources/templates.php +++ b/view/resources/templates.php @@ -90,7 +90,7 @@ $templates['wikibase-statementview'] = <<- + $3 $4 HTML5 allows any characters in the id attribute, including $. MDN warns against this because it wasn’t allowed in HTML4, but does anyone know what old browsers do in that case? As long as they don’t crash, I’m not convinced this is something we need to watch out for.TASK DETAILhttps://phabricator.wikimedia.org/T169224EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Aklapper, Lahi, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
