[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Ladsgroup added a comment. Thank you @minhhuy and @Kenrick95. I really appreciate itTASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: minhhuy, Kenrick95, Mr.Ibrahem, Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
minhhuy added a comment. Change done in viwiki: https://vi.wikipedia.org/w/index.php?title=M%C3%B4_%C4%91un:Wikidata&diff=37494708&oldid=29164668 Thank you for notification :)TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, minhhuyCc: minhhuy, Kenrick95, Mr.Ibrahem, Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Kenrick95 added a comment. Change done in idwiki: https://id.wikipedia.org/w/index.php?title=Modul:Wikidata&diff=13739172&oldid=10246681 Thanks @Ladsgroup for the notification in [Wikitech-ambassadors]TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Kenrick95Cc: Kenrick95, Mr.Ibrahem, Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Ladsgroup added a comment. Thank you very much @Mr.IbrahemTASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Mr.Ibrahem, Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Mr.Ibrahem added a comment. done arwiki https://ar.wikipedia.org/w/index.php?title=Module:wikidata&type=revision&diff=27580612&oldid=20545352TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Ladsgroup, Mr.IbrahemCc: Mr.Ibrahem, Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Ladsgroup added a comment. I wrote an script and fixed all of them in one go except the ones that were protected. ladsgroup@terbium:~$ mwgrep --module "otherwise, iterate over all properties, fetch their labels and compare this to the given property name" --max-results 200 arwiki Module:Wikidata bgwiki Module:Wikidata iawiki Module:Wikidata idwiki Module:Wikidata incubatorwiki Module:Wp/lrc/Wikidata kuwiki Module:Wikidata mywiki Module:Wikidata ptwiki Module:Wikidata thwiki Module:Wikidata viwiki Module:Wikidata zhwiki Module:Wikidata zhwiki Module:Wikidata2 zhwiki Module:沙盒/Dabao qian/Wikidata zhwiki Module:沙盒/PhiLiP/Wikidata I think getting this done is good because they would get only related notifications instead of getting it for every edit that happens on the statements.TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
eranroz added a comment. I think this task can be considered as resolved (mainly thanks to T185693) from engineering POV. If there are still wikis using such iterations - they should fix it, but it is now on their (community) hands. I suggest that before moving this task to resolved, we should ask #Community-Liaisons to communicate to wikis to be aware to it. Anyway, we should keep an open eyes on wikis with abnormal usage tracking - this may be more fruitful and surely more fun to do with ML/outliers detection based on the data (wbc_entity_usage) rather than greping the code :) BTW I fixed it in the following diffs for some wikis: MW template: https://www.mediawiki.org/w/index.php?title=Module:Wikidata&diff=2728318&oldid=2412211 Wikipedias and other projects (not all projects...): https://sq.wikipedia.org/w/index.php?title=Moduli:Wikidata&diff=1844990&oldid=1757199 https://ps.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=217026 https://ne.wikipedia.org/w/index.php?title=%E0%A4%AE%E0%A5%8B%E0%A4%A1%E0%A5%8D%E0%A4%AF%E0%A5%81%E0%A4%B2:Wikidata&diff=prev&oldid=633773 https://mn.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=538250 https://mk.wikipedia.org/w/index.php?title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB:Wikidata&diff=prev&oldid=3689944 https://lv.wikipedia.org/w/index.php?title=Modulis:Wikidata&diff=prev&oldid=2816246 https://lt.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=5336632 https://pt.wikivoyage.org/w/index.php?title=M%C3%B3dulo:Wikidata&diff=prev&oldid=123281 https://hi.wikipedia.org/w/index.php?title=Module:Wikidata&diff=prev&oldid=3728109 https://en.wiktionary.org/w/index.php?title=Module:wikidata&diff=prev&oldid=49084837 https://bs.wikipedia.org/w/index.php?title=Modul:Wikidata&diff=prev&oldid=2914902TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
eranroz added a comment. In T178114#3888964, @Ladsgroup wrote: This will go live this week, Would be good to measure the impact. The above patch (383990) doesn't have any impact. wikis have to adopt it, and this is just a convenient method to avoid improper property usageTASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: eranrozCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
Ladsgroup added a comment. This will go live this week, Would be good to measure the impact.TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LadsgroupCc: Ladsgroup, Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
gerritbot added a comment. Change 383990 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] getAllStatements and access to property by name https://gerrit.wikimedia.org/r/383990TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: Capankajsmilyo, gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
hoo added a comment. Brought up on enwiki: https://en.wikipedia.org/wiki/Module_talk:Wikidata#Critical_performance_improvementTASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hooCc: gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T178114: Many Wikipedia's Wikidata module iterate over all entity claims if a Statement is searched for by property label
gerritbot added a comment. Change 383990 had a related patch set uploaded (by Eranroz; owner: Eranroz): [mediawiki/extensions/Wikibase@master] Access to property by name https://gerrit.wikimedia.org/r/383990TASK DETAILhttps://phabricator.wikimedia.org/T178114EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, eranroz, daniel, Lydia_Pintscher, hoo, GoranSMilovanovic, QZanden, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
