[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Greta_Doci_WMDE]

Greta_Doci_WMDE added a comment.


  In T212869#5152180 , 
@Lea_Lacroix_WMDE wrote:
  
  > I tested it on beta and prod and both seems to work, but now I'm a bit 
confused. Is it already live, or did I test the wrong thing?
  
  
  It is already live and it should work on both. I guess if you followed the 
steps written in the description, then you tested it right.

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE
Cc: Pablo-WMDE, Lea_Lacroix_WMDE, hoo, Lucas_Werkmeister_WMDE, alaa_wmde, 
abian, Aklapper, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Lea_Lacroix_WMDE]

Lea_Lacroix_WMDE added a comment.


  I tested it on beta and prod and both seems to work, but now I'm a bit 
confused. Is it already live, or did I test the wrong thing?

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, Lea_Lacroix_WMDE
Cc: Lea_Lacroix_WMDE, hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506182 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Use LabelDescriptionNotEqualValidator 
in TermValidatorFactory
  
  https://gerrit.wikimedia.org/r/506182

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506181 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add CompositeFingerprintValidator
  
  https://gerrit.wikimedia.org/r/506181

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506172 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Add LabelDescriptionNotEqualValidator
  
  https://gerrit.wikimedia.org/r/506172

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[alaa_wmde]

alaa_wmde added a comment.


  @Lucas_Werkmeister_WMDE gold 
  
  Just wanted to raise awareness of that aspect, and seems I was lacking behind 
the current awareness around the topic.. that's awesome news!

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, alaa_wmde
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T212869#5135925 , @hoo 
wrote:
  
  > In T212869#5122970 , 
@Lucas_Werkmeister_WMDE wrote:
  >
  > > Unfortunately the `ChangeOp` approach seems to have the same problem: it 
uses the base revision, not the parent revision, to check if the label and the 
description are the same :(
  >
  >
  > But you still went with it (indirectly, as the FingerprintValidator you're 
adding is used there)? Does that cause problems elsewhere? Is there a task for 
that?
  
  
  We might have tested something wrong – with the changes linked above, I can’t 
reproduce this problem anymore.

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, Lucas_Werkmeister_WMDE
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[alaa_wmde]

alaa_wmde added a comment.


  Sorry to come late to this one. I can still see one problem here even if we 
find a way to tell the second request to look at the right revision id.
  
  The problem comes from the fact that UI is making two separate requests for 
what appears to be an atomic action (save all changed terms) to the editor. 
While that haven't caused any issues, and probably was decided to be done that 
way so that changing labels, descriptions and aliases get their own edit 
revisions separate from each other (for easier rollbacks and more atomic 
history on level of term edits), bubbling up this kind of separation up to the 
UI is problematic in this case.
  
  **Why is that a problem now?**
  Let's assume that second request (description in this case) is "fixed" and 
will look at the parent revision id instead of baserevid and it will detect the 
duplication correctly and fail.
  In that case, the label will be changed, but the description will not, which 
is not the right thing to do here from UX perspective. The editor is editing 
both, and press `save` expecting both to be saved or nothing to be saved if 
they did a mistake or didn't know they can't use same label and description. 
Their next step will be to go and rollback their edit to the label, given they 
actually noticed that it was saved after they get an error message (due to the 
failing second request)
  
  **How to solve UX issue?**
  If that part of editing does not work without javascript anyway, we can add 
some client-side validation. If not, then we have to do one request for saving 
(can we use wbeditentity endpoint instead for instance?).

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, alaa_wmde
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[hoo]

hoo added a comment.


  In T212869#5122970 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Unfortunately the `ChangeOp` approach seems to have the same problem: it 
uses the base revision, not the parent revision, to check if the label and the 
description are the same :(
  
  
  But you still went with it (indirectly, as the FingerprintValidator you're 
adding is used there)? Does that cause problems elsewhere? Is there a task for 
that?

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, hoo
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506182 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Use LabelDescriptionNotEqualValidator 
in TermValidatorFactory
  
  https://gerrit.wikimedia.org/r/506182

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506181 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Add CompositeFingerprintValidator
  
  https://gerrit.wikimedia.org/r/506181

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 506172 had a related patch set uploaded (by Greta WMDE; owner: Greta 
Doçi):
  [mediawiki/extensions/Wikibase@master] Add LabelDescriptionNotEqualValidator
  
  https://gerrit.wikimedia.org/r/506172

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Unfortunately the `ChangeOp` approach seems to have the same problem: it uses 
the base revision, not the parent revision, to check if the label and the 
description are the same :(

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, Lucas_Werkmeister_WMDE
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 504283 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Prevent label = description to 
Special:NewProperty
  
  https://gerrit.wikimedia.org/r/504283

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[hoo]

hoo added a comment.


  Why not do this as part of `ChangeOpDescription` and `ChangeOpLabel`? I know 
some places don't use this, but this seems to be the right place to me.

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, hoo
Cc: hoo, Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[abian]

abian added a comment.


  In T212869#5114173 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > But this might also affect undo/restore/rollback…
  
  
  I don't think (as an editor) that's a problem. The wrong edit, and the one 
that should be reverted, is the one with identical label and description. 
Unless low-level data looses its integrity or Wikidata crashes (I don't think 
so) in the very unlikely event of reverting to an edit with identical label and 
description, I think this option would be equally great.

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, abian
Cc: Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Greta and I tried yesterday to implement this in the `SetLabel` and 
`SetDescription` APIs. Their parent class `ModifyEntity` has a convenient 
`validateEntitySpecificParameters` method, where you can validate the `array 
$preparedParameters` against the `EntityDocument $entity` and raise an error if 
the new label/description in the `$preparedParameters` matches the 
description/label in the `$entity`. However, we found that it didn’t work 
correctly in the case where you set both label and description to the same new 
value in the UI. That’s because in that case, the second API request (to set 
the description) specifies `baserevid` as the revision ID of the original 
loaded page, not the new revision ID returned by the first API request (to set 
the label); and `ModifyEntity` loads the entity at the base revision and runs 
`validateEntitySpecificParameters` against that, so it would check if the new 
description doesn’t match the //old// label, rather than the new one in the 
latest revision.
  
  Also, this approach requires separate implementations in `Special:SetLabel`, 
`Special:SetDescription`, `Special:SetLabelDescriptionAliases`, `wbeditentity`, 
and possibly more places that we forgot.
  
  An alternative place to implement this check would be deep in the bowels of 
the entity saving code (at the point where we actually have the parent 
revision), e. g. in `MediawikiEditEntity::attemptSave()`, which ends up calling 
the `EditFilterMergedContent` hook. But this might also affect 
undo/restore/rollback…

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, alaa_wmde, abian, Aklapper, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[gerritbot]

gerritbot added a comment.


  Change 504283 had a related patch set uploaded (by Greta WMDE; owner: Greta 
Doçi):
  [mediawiki/extensions/Wikibase@master] Prevent label = description to 
Special:NewProperty
  
  https://gerrit.wikimedia.org/r/504283

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, gerritbot
Cc: alaa_wmde, abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[alaa_wmde]

alaa_wmde added a comment.


  For `Special:NewProperty` yes it is part of the acceptance criteria so it 
should also fix that one.
  
  For rollback, I think that it should not, because it will get us stuck in 
situation where a vandal might introduce a change that we want to revert. If 
the item/property had same label before that vandal have made their 
change, editor's only option is to make a new edit instead of rolling back. 
That sounds less ideal for editors, I think. Sounds sensible to you?

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE, alaa_wmde
Cc: alaa_wmde, abian, Aklapper, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T212869: Make it impossible to set the same content in the same language for label and description

[Greta_Doci_WMDE]

Greta_Doci_WMDE added a comment.


  A few questions: should this affect Special:NewProperty? 
  Should it also prevent undo/restore/rollback, if the resulting content has 
labels and descriptions that are the same?

TASK DETAIL
  https://phabricator.wikimedia.org/T212869

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Greta_Doci_WMDE
Cc: abian, Aklapper, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs