[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-07-15T12:07:15Z] 
 Synchronized wmf-config/Wikibase.php: SWAT: 
[[gerrit:522126|Specify $wgWBRepoSettings['conceptBaseUri'] again (T225212 
)]] (duration: 00m 50s)

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 522126 **merged** by jenkins-bot:
  [operations/mediawiki-config@master] Specify 
$wgWBRepoSettings['conceptBaseUri'] again
  
  https://gerrit.wikimedia.org/r/522126

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[Stashbot]

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2019-07-15T12:00:40Z] 
 Synchronized wmf-config/: SWAT: 
[[gerrit:522125|Specify $wmgWBRepoConceptBaseUri again (T225212 
)]] (duration: 00m 51s)

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 522125 **merged** by jenkins-bot:
  [operations/mediawiki-config@master] Specify $wmgWBRepoConceptBaseUri again
  
  https://gerrit.wikimedia.org/r/522125

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 522125 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [operations/mediawiki-config@master] Specify $wmgWBRepoConceptBaseUri again
  
  https://gerrit.wikimedia.org/r/522125

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 518239 abandoned by Lucas Werkmeister (WMDE):
  Specify $wgWBRepoSettings['conceptBaseUri'] again
  
  Reason:
  split into Ib3584f456e and I04d74a42c4
  
  https://gerrit.wikimedia.org/r/518239

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 522126 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [operations/mediawiki-config@master] Specify 
$wgWBRepoSettings['conceptBaseUri'] again
  
  https://gerrit.wikimedia.org/r/522126

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[gerritbot]

gerritbot added a comment.


  Change 518239 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [operations/mediawiki-config@master] Specify 
$wgWBRepoSettings['conceptBaseUri'] again
  
  https://gerrit.wikimedia.org/r/518239

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[Krinkle]

Krinkle added a comment.


  In T225212#5241912 , @hoo 
wrote:
  
  > >   Notice: Undefined variable: wmgWBRepoConceptBaseUri in 
/srv/mediawiki/wmf-config/Wikibase.php on line 149 
  >
  > This is because the default was set to `null` and that makes 
`SiteConfiguration::getAll` [..] omit the variable completely.
  
  
  This seems like something we should fix. Variable existence is not something 
we normally use intentionally to inform behaviour, so I think SiteConfiguration 
should always export the variable. On top of that, the patch even explicitly 
specified `'default' => null` which means even if we were to support variables 
that only conditionally exist, this would be a condition in which it should 
exist.

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > I'm not sure what level exactly it logs at, but it at very least debug 
logs… and given we resolve this on almost every Wikidata related request, we 
should try to avoid this also for performance reasons (even if no one listens 
to that log).
  
  Found it, it’s in `SettingsArray::getSetting()`:
  
$this->logger->debug(
'{method}: setting {settingName} was given as a closure, resolve it to 
{logValue}',
[
'method' => __METHOD__,
'settingName' => $settingName,
'logValue' => $logValue,
]
);
  
  
  
  >>   Notice: Undefined variable: wmgWBRepoConceptBaseUri in 
/srv/mediawiki/wmf-config/Wikibase.php on line 149 
  > 
  > This is because the default was set to `null` and that makes 
`SiteConfiguration::getAll` (which mediawiki-config uses to propagate the 
setting globals) omit the variable completely, so this is just another symptom 
of the incomplete set of wikis this was defined for.
  
  Ah, thanks.

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Premeditated, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

[hoo]

hoo added a comment.


  > I dimly remember @hoo saying that this would cause debug log warnings and 
we should expliclitly specify the correct value in mediawiki-config instead.
  
  I'm not sure what level exactly it logs at, but it at very least debug logs… 
and given we resolve this on almost every Wikidata related request, we should 
try to avoid this also for performance reasons (even if no one listens to that 
log).
  
  >   Notice: Undefined variable: wmgWBRepoConceptBaseUri in 
/srv/mediawiki/wmf-config/Wikibase.php on line 149 
  
  This is because the default was set to `null` and that makes 
`SiteConfiguration::getAll` (which mediawiki-config uses to propagate the 
setting globals) omit the variable completely, so this is just another symptom 
of the incomplete set of wikis this was defined for.

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hoo
Cc: Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Premeditated, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs