[Wikidata-bugs] [Maniphest] [Commented On] T85414: wikibase: synchronize schema on production with what is created on install
Marostegui added a comment. In T85414#4661580, @WMDE-leszek wrote: wb_terms_entity_id only uses the "old", numeric-only term_entity_id column, hence it probably has been kind of replaced by term_full_entity index. As mentioned above by @Marostegui it dos not seem used, so I would guess it would be fine to just drop it from production. But sure, let's re-add to the git repo, and have it removed once we've dropped from the production DBs. This seems a sane way of proceeding to me. I am not sure if it is worth the time and specially the risk, if wb_terms is going to disappear at some pointTASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarosteguiCc: WMDE-leszek, Marostegui, Addshore, hoo, Ladsgroup, JanZerebecki, aude, Aklapper, daniel, Nandana, Banyek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85414: wikibase: synchronize schema on production with what is created on install
WMDE-leszek added a comment. wb_terms_entity_id only uses the "old", numeric-only term_entity_id column, hence it probably has been kind of replaced by term_full_entity index. As mentioned above by @Marostegui it dos not seem used, so I would guess it would be fine to just drop it from production. But sure, let's re-add to the git repo, and have it removed once we've dropped from the production DBs. This seems a sane way of proceeding to me.TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-leszekCc: WMDE-leszek, Marostegui, Addshore, hoo, Ladsgroup, JanZerebecki, aude, Aklapper, daniel, Nandana, Banyek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85414: wikibase: synchronize schema on production with what is created on install
Addshore added a comment. All of the sub tasks have been created. Once all complete we should compare the production vs install schema again and make sure we didn't miss anything before closing this.TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Marostegui, Addshore, hoo, Ladsgroup, JanZerebecki, aude, Aklapper, daniel, Banyek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T85414: wikibase: synchronize schema on production with what is created on install
Marostegui added a comment. A quick check about unused indexes on that table reports that only wb_terms_entity_id and wb_terms_search_key aren't in use: root@neodymium:/home/marostegui# ./section s8 | grep codfw | egrep -v "dbstore|db2094" | while read host port; do echo "$host:$port"; mysql.py -h$host:$port sys -e "select * from schema_unused_indexes where object_name='wb_terms';";done db2086.codfw.wmnet:3318 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2085.codfw.wmnet:3318 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2083.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2082.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2081.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2080.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2079.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key db2045.codfw.wmnet:3306 object_schema object_name index_name wikidatawiki wb_terms wb_terms_entity_id wikidatawiki wb_terms wb_terms_search_key TASK DETAILhttps://phabricator.wikimedia.org/T85414EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: MarosteguiCc: Marostegui, Addshore, hoo, Ladsgroup, JanZerebecki, aude, Aklapper, daniel, Banyek, AndyTan, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Minhnv-2809, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
