[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[amy_rc]

amy_rc closed this task as "Resolved".
amy_rc added a comment.


   closing the ticket as the investigation is done.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, amy_rc
Cc: amy_rc, ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  In T273039#676 , 
@Sarai-WMDE wrote:
  
  >> It is entirely possible to instead have a prop that says something like 
inheritStyles=true or isStandalone=false.
  >
  > The prop option sounds good to me too.
  >
  > Can we consider the investigation done, then? I'd update the component 
ticket accordingly. Thanks again for the enlightenment 
  
  yesss!!!
  very good insights from @Michael and @ItamarWMDE

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Sarai-WMDE]

Sarai-WMDE added a comment.


  > It is entirely possible to instead have a prop that says something like 
inheritStyles=true or isStandalone=false.
  
  The prop option sounds good to me too.
  
  Can we consider the investigation done, then? I'd update the component ticket 
accordingly. Thanks again for the enlightenment 

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Sarai-WMDE
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  In T273039#6799706 , 
@ItamarWMDE wrote:
  
  >> We could, in the future, extend that to support routing libraries like 
vue-router.
  >
  > This argument is enough to win me over. Usually I'm not in favor of 
creating components simply for styling purposes, and since we already expose a 
global CSS file that is used by consuming applications 
, I don't 
necessarily see it as a problem to scope styles as a reusable CSS class that is 
available to implementing applications. However, once you add state and 
behavioral considerations into the mix, it makes a little more sense to me.
  >
  > Either or, I will back your decision even if there were no such 
considerations, as the research seems well thought of and there are other 
compelling arguments.
  >
  > I would ask though, how do you envision the API of this component to work? 
Is it something like `...`?
  
  yes, that was my idea for the API

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[ItamarWMDE]

ItamarWMDE added a comment.


  > We could, in the future, extend that to support routing libraries like 
vue-router.
  
  This argument is enough to win me over. Usually I'm not in favor of creating 
components simply for styling purposes, and since we already expose a global 
CSS file that is used by consuming applications 
, I don't 
necessarily see it as a problem to scope styles as a reusable CSS class that is 
available to implementing applications. However, once you add state and 
behavioral considerations into the mix, it makes a little more sense to me.
  
  Either or, I will back up your decision even if there were no such 
consideration, as the research seems well thought of and there are other 
compelling arguments.
  
  I would ask though, how do you envision the API of this component to work? Is 
it something like `...`?

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, ItamarWMDE
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  In T273039#6799656 , 
@Michael wrote:
  
  > In T273039#6799614 , 
@Sarai-WMDE wrote:
  >
  >> Is it safe to assume that we'd probably need two link variants then? A 
//Link// (with its own, autonomous style – e.g. our "Show query in the Query 
Service") and an //Inline link// (which style blends with that of the text 
where it's embedded, but that it's still recognizable as a link, e.g. the 
"SPARQL" and "Feedback is welcomed here" links in the QB introductory 
description).
  >
  > It is entirely possible to instead have a prop that says something like 
`inheritStyles=true` or `isStandalone=false`.
  >
  > Rather, I wonder if a standalone component would make more sense in cases 
where the standalone-link is supposed to be more prominent. Like the "Get 
Started >"-Link on https://design-system.service.gov.uk/. It is clearly a link 
- conceptually, visually, behaviorally, technically:
  > F34089032: image.png 
  
  I'd go with the props option. having two separate types of links might create 
confusion

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Michael]

Michael added a comment.


  In T273039#6799614 , 
@Sarai-WMDE wrote:
  
  > Is it safe to assume that we'd probably need two link variants then? A 
//Link// (with its own, autonomous style – e.g. our "Show query in the Query 
Service") and an //Inline link// (which style blends with that of the text 
where it's embedded, but that it's still recognizable as a link, e.g. the 
"SPARQL" and "Feedback is welcomed here" links in the QB introductory 
description).
  
  It is entirely possible to instead have a prop that says something like 
`inheritStyles=true` or `isStandalone=false`.
  
  Rather, I wonder if a standalone component would make more sense in cases 
where the standalone-link is supposed to be more prominent. Like the "Get 
Started >"-Link on https://design-system.service.gov.uk/. It is clearly a link 
- conceptually, visually, behaviorally, technically:
  F34089032: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Michael
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Sarai-WMDE]

Sarai-WMDE added a comment.


  The color of links should never be inherited, exactly; only the font-family, 
size, weight and line-height of embedded links should be adjusted.
  
  Is it safe to assume that we'd probably need two link variants then? A 
//Link// (with its own, autonomous style – e.g. our "Show query in the Query 
Service") and an //Inline link// (which style blends with that of the text 
where it's embedded, but that it's still recognizable as a link, e.g. the 
"SPARQL" and "Feedback is welcomed here" links in the QB introductory 
description).

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Sarai-WMDE
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Michael]

Michael added a comment.


  In T273039#6799559 , 
@Sarai-WMDE wrote:
  
  > Regarding the component approach, and related to the second criteria: how 
can we make sure the component is embeddable? Meaning, that it can inherit the 
styles of surrounding text when used inline. (I believe this could probably be 
a variant or a prop, but just wanted to make sure we keep this in mind)
  
  That depends on the specific declarations. For example a `font-size` of `1em` 
will exactly use the font-size of the surrounding ``. Also, `line-height` 
could either be plainly not defined or be set to `line-height: inherit;`. 
Similarly, for `font-family`, etc.
  
  On the other hand, there might be cases where we don't want inheritance, for 
example `color: #3366cc;` will use exactly that color,and in that case this is 
what we almost always want.
  
  We might be able to gain some insights by considering the "embedded" link the 
default and try to think about situations where it is not embedded. Maybe 
something like a "Next" link when flipping through some pagination?

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Michael
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Sarai-WMDE]

Sarai-WMDE added a comment.


  Itamar and I had only an initial discussion on Mattermost, where the working 
idea of creating the WiKit link as a set of classes rather than as a component 
was introduced by him. I later brought up that approach to the hike while 
looking at the Link component ticket 
 together, and detected the need for 
an investigation tick. I believe that the outcome of this investigation is an 
excellent starting point! Thanks so much, Bereket and Michael.
  
  Regarding the component approach, and related to the second criteria: how can 
we make sure the component is embeddable? Meaning, that it can inherit the 
styles of surrounding text when used inline. (I believe this could probably be 
a variant or a prop, but just wanted to make sure we keep this in mind)

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Sarai-WMDE
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  @Michael unfortunately , I don't have the notes, as I was note part of the 
meeting.
  but maybe @Sarai-WMDE has them ?

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Michael]

Michael added a comment.


  In T273039#6799165 , @bete 
wrote:
  
  > @Michael yes! future extensions are another good reason for components.
  > I believe @ItamarWMDE and @Sarai-WMDE already had a deep dive into this 
topic. but maybe with the points mentioned above, that might help them get 
closer to a decision
  
  Yes, the task description also mentions some "initial discussions". Could you 
point me to the notes of those initial discussions? That would enable us to 
take their insights into account and would allow us to build on top of it 
instead of duplicating effort.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Michael
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  @Michael yes! future extensions are another good reason for components.
  I believe @ItamarWMDE and @Sarai-WMDE already had a deep dive into this 
topic. but maybe with the points mentioned above, that might help them get 
closer to a decision

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Michael]

Michael added a subscriber: ItamarWMDE.
Michael added a comment.


  I looked it up and vuetify uses their button component v-btn 
 for links, which is The Wrong Thing To Do. 
So that isn't providing any insight for us.
  
  While I also slightly lean towards a component, I'm not sure that this is 
only our decision. I feel that the perspective of @ItamarWMDE and @Sarai-WMDE 
is needed as well.
  
  The links to material-ui and bootstrap-vue point to another argument in favor 
of a component: We could, in the future, extend that to support routing 
libraries like vue-router.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Michael
Cc: ItamarWMDE, bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, 
Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  @Lydia_Pintscher
  
  I put all my findings here. please feel free if you've any questions

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  **conclusion:**
  
  As far as implementation goes, there doesn't seem to be too much technical 
difficulty in going either way. echoing on some of the points @Michael 
mentioned above, I'll list some of the pros and cons.
  I haven't found much info on veutify but on here 
 and here 
 , Links are used as components.
  
  **Pros: of component**
  
  - Consistency: No need to create unnecessary learning curve, i.e. not 
introducing  new way of doing things. we already use styled components so there 
no need to introduce a new way of doing things.
  - easy to publish a component to NPM and ensure that it is not only super 
customizable for the user through props and/or extending via styled(Component) 
but that it always looks & behaves as it did locally due to zero chance of 
clashing selectors.
  - easy to handle edge cases on the behavior of the link. e.g links with 
href="#". on click scroll to top of the page or what ?
  - we already have a story book
  
  **Pros of CSS styles: **
  
  - easier to implement. i.e at least, code size wise
  
  **Cons of using CSS:**
  
  - will be an additional way of implementing things, creating potential 
maintenance issues
  - has no story book. therefore difficult to document

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  Implementation using props (vue components) can be accomplished easily.
  
  an example can be found here 

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  **regarding the second acceptance criteria:**
  
  Its a much rarer case. However, we can expand our mixin to accept a third 
parameter (font-size) to override the size. default value can just be set to 
'inherit' so the link can inherit the font-size of the parent.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  So far, I focused mostly on implementation using mixing (since we have more 
experience with the component approach).
  
  **regarding the first criteria**, mentioned above: It's possible to achieve 
the desired effect with mixins.
  
  code snippet:
  
@mixin link($icon:url("/icons/link-icon.svg"), $position: 'left') {

   @if $position == 'left' {
   a:before {
 content: $icon;
 padding-right: 4px;
   }
} @else {
 a:after {
content: $icon;
padding-right: 4px;
   }
}
}

.text {
  @include link(url("/icons/custom-link-icon.svg"), 'right');
}



#HTML
 about Wikimedia 
  
  as can be seen from the above sample code, we can pass two parameters to the 
mixin (the icon itself and the position of the icon)

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Sarai-WMDE]

Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete, Sarai-WMDE
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[bete]

bete added a comment.


  In T273039#6790844 , 
@Michael wrote:
  
  > Some initial brainstormy thoughts:
  >
  > Pro Component
  >
  > - better abstraction/encapsulation of "internals"
  > - same argument as to why a button is a DS component and not just a set of 
styles
  > - could maybe apply //some// validation on the URL to prevent mistakes like 
`href="javascript:void(0)"`
  > - not providing two ways of doing things: components and classes
  >
  > Pro CSS class
  >
  > - less confusing to translators if it appears in a i18n message
  > - full control over all the possible behavior
  >
  > Ideas for further investigation:
  >
  > - look at what vuetify and other component libraries are doing and try to 
infer their reasoning
  
  thanks for the points you made. I was originally pro css class. but I might 
be coming around to the component side. 
  I couldn't find much info on vuetify but I found another bootstrap library 
here 
  
  I think the encapsulation point you made is a solid one. especially, when it 
comes to behavior. e.g things like "href='#'" issue mentioned in the 
documentation.
  also, I think the link is also supposed to support icons (optional), so I 
think cases like that make the case for components instead of css classes

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: bete
Cc: bete, Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Michael]

Michael added a comment.


  Some initial brainstormy thoughts:
  
  Pro Component
  
  - better abstraction/encapsulation of "internals"
  - same argument as to why a button is a DS component and not just a set of 
styles
  - could maybe apply //some// validation on the URL to prevent mistakes like 
`href="javascript:void(0)"`
  - not providing two ways of doing things: components and classes
  
  Pro CSS class
  
  - less confusing to translators if it appears in a i18n message
  - full control over all the possible behavior
  
  Ideas for further investigation:
  
  - look at what vuetify and other component libraries are doing and try to 
infer their reasoning

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273039: investigation: links as components vs. reusable styles [timebox: 1d]

[Lydia_Pintscher]

Lydia_Pintscher renamed this task from "investigation: links as components vs. 
reusable styles" to "investigation: links as components vs. reusable styles 
[timebox: 1d]".
Lydia_Pintscher added a project: Wikidata Design System.
Lydia_Pintscher updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T273039

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Sarai-WMDE, Aklapper, Ladsgroup, Lydia_Pintscher, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs