[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, Maintenance_bot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16). TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, ReleaseTaggerBot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
Lucas_Werkmeister_WMDE closed this task as "Resolved". Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board. TASK DETAIL https://phabricator.wikimedia.org/T277021 WORKBOARD https://phabricator.wikimedia.org/project/board/5203/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
gerritbot added a comment. Change 670555 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] WikibaseRepo: Get settings from service container https://gerrit.wikimedia.org/r/670555 TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
gerritbot added a comment. Change 670429 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] WikibaseClient: Get settings from service container https://gerrit.wikimedia.org/r/670429 TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
gerritbot added a comment. Change 670555 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon): [mediawiki/extensions/Wikibase@master] WikibaseRepo: Get settings from service container https://gerrit.wikimedia.org/r/670555 TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE, gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
ItamarWMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
Lucas_Werkmeister_WMDE added a comment. I noticed one of those places in the client wiring and uploaded the above change to fix it, but then saw that the same thing happens in other places too, so I figure this deserves a proper task and should go through all the columns. Feel free to pick this up. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
gerritbot added a comment. Change 670429 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] WIP: Get settings from service container https://gerrit.wikimedia.org/r/670429 TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T277021: Stop calling WikibaseSettings::getRepoSettings()/getClientSettings()
Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Several places in Wikibase call `WikibaseSettings::getRepoSettings()` or `WikibaseSettings::getClientSettings()` directly, instead of getting the settings from elsewhere. This is wasteful, because `WikibaseSettings` doesn’t cache the settings – each time it’s called, the work of loading the settings and merging them with the default settings is repeated. (Also, settings that are specified as callbacks may be recalculated, even if another settings instance already resolved the callback.) Most of these calls should be replaced with calls to `WikibaseRepo::getSettings()` or `WikibaseClient::getSettings()`, optionally passing a `$services` container into them if available. TASK DETAIL https://phabricator.wikimedia.org/T277021 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
