[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-30 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, 
Lalamarie69, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-30 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-30 Thread ItamarWMDE 
ItamarWMDE closed this task as "Resolved".
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service 
Migration board.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-30 Thread gerritbot 
gerritbot added a comment.


  Change 683665 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Remove PrefetchingTermLookup from 
WikibaseServices
  
  https://gerrit.wikimedia.org/r/683665

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-30 Thread gerritbot 
gerritbot added a comment.


  Change 683664 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Remove getTermBuffer from 
DataAccessServices
  
  https://gerrit.wikimedia.org/r/683664

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-29 Thread gerritbot 
gerritbot added a comment.


  Change 683665 had a related patch set uploaded (by Itamar Givon; author: 
Itamar Givon):
  
  [mediawiki/extensions/Wikibase@master] Remove PrefetchingTermLookup from 
WikibaseServices
  
  https://gerrit.wikimedia.org/r/683665

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-29 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
Lalamarie69, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-29 Thread gerritbot 
gerritbot added a comment.


  Change 683664 had a related patch set uploaded (by Itamar Givon; author: 
Itamar Givon):
  
  [mediawiki/extensions/Wikibase@master] Remove getTermBuffer from 
DataAccessServices
  
  https://gerrit.wikimedia.org/r/683664

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-29 Thread ItamarWMDE 
ItamarWMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-28 Thread ItamarWMDE 
ItamarWMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-07 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  The `WikibaseClient` method is gone, so now the `TermSearchInteractorFactory` 
is only used in WikibaseRepo.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-04-06 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  And as for TermSearchInteractorFactory, it’s worth noting that 
`WikibaseClient` has a method
  
/**
 * XXX: This is not used by client itself, but is used by 
ArticlePlaceholder!
 */
public function newTermSearchInteractor( string $displayLanguageCode ): 
TermSearchInteractor {
return 
self::getWikibaseServices()->getTermSearchInteractorFactory()
->newInteractor( $displayLanguageCode );
}
  
  but ArticlePlaceholder hasn’t actually used this method since March 2020 
(removed in rEARP3c9ae982ece3: Drop legacy database search integration code 
).
 So as far as I can tell, we can remove the WikibaseClient use of that service 
directly.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, ItamarWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-03-29 Thread ItamarWMDE 
ItamarWMDE removed ItamarWMDE as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-03-29 Thread ItamarWMDE 
ItamarWMDE added a comment.


  In fact, this cannot yet be picked up, until we remove 
TermSearchInteractorFactory from Wikibase Services, as 
getPrefetchingTermLookup, is used in that method on SingleEntitySourceServices.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-03-29 Thread ItamarWMDE 
ItamarWMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T277856: Remove PrefetchingTermLookup from WikibaseServices

2021-03-19 Thread ItamarWMDE 
ItamarWMDE created this task.
ItamarWMDE added projects: Wikibase Service Migration, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Depends on T277304: Move WikibaseClient PrefetchingTermLookup to service 
container 
  
  **AC**
  
  Method removed from
  
  [ ] WikibaseServices Interface
  [ ] MultipleEntitySourceServices
  [ ] SingleEntitySourceServices

TASK DETAIL
  https://phabricator.wikimedia.org/T277856

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5203/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Aklapper, ItamarWMDE, maantietaja, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs