subject:"\[Wikidata\-bugs\] \[Maniphest\] T288639\: SpamBlacklistHooks\:\:onEditFilterMergedContent causes every edit to be rendered twice"

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-13 Thread Ladsgroup

Ladsgroup closed this task as "Resolved".
Ladsgroup claimed this task.
Ladsgroup added a comment.


  SpamBlacklist shows up in the list of duplicated parses and that confused me 
a lot. After checking in depth, it turned out that SpamBlacklist is just one of 
the traces, the other one is always the problematic one. This is resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-10 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.17; 
2022-01-10); removed MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, ReleaseTaggerBot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-10 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-01-10T14:49:46Z] 
 Synchronized 
php-1.38.0-wmf.16/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:752277|Give priority to PreparedUpdate (T288639 
)]] (duration: 01m 00s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Stashbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-10 Thread gerritbot

gerritbot added a comment.


  Change 752529 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@master] Give priority to PreparedUpdate
  
  https://gerrit.wikimedia.org/r/752529

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-10 Thread gerritbot

gerritbot added a comment.


  Change 752277 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.38.0-wmf.16] Give priority to 
PreparedUpdate
  
  https://gerrit.wikimedia.org/r/752277

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-10 Thread gerritbot

gerritbot added a comment.


  Change 752277 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.38.0-wmf.16] Give priority to 
PreparedUpdate
  
  https://gerrit.wikimedia.org/r/752277

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-09 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.16; 
2022-01-03); removed MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, ReleaseTaggerBot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-09 Thread gerritbot

gerritbot added a comment.


  Change 752529 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@master] Give priority to PreparedUpdate
  
  https://gerrit.wikimedia.org/r/752529

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-09 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2022-01-10T06:15:59Z] 
 Synchronized 
php-1.38.0-wmf.16/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:752270|Use PreparedUpdate to avoid double parse (T288639 
)]] (duration: 01m 00s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Stashbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-09 Thread gerritbot

gerritbot added a comment.


  Change 752270 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.38.0-wmf.16] Use PreparedUpdate to 
avoid double parse
  
  https://gerrit.wikimedia.org/r/752270

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-09 Thread gerritbot

gerritbot added a comment.


  Change 752270 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.38.0-wmf.16] Use PreparedUpdate to 
avoid double parse
  
  https://gerrit.wikimedia.org/r/752270

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-07 Thread ReleaseTaggerBot

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, ReleaseTaggerBot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2022-01-07 Thread gerritbot

gerritbot added a comment.


  Change 749807 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@master] Use PreparedUpdate to avoid 
double parse
  
  https://gerrit.wikimedia.org/r/749807

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-12-23 Thread gerritbot

gerritbot added a comment.


  Change 749807 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@master] Use PreparedUpdate to avoid 
double parse
  
  https://gerrit.wikimedia.org/r/749807

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-11-15 Thread Michael

Michael removed a project: Wikidata-Campsite (Team A Hearth ).
Michael added a comment.


  Removing #wikidata-team-a-hearth 
 as it seems like there 
is nothing for us to do here. Please add it back if there is any support needed 
from us!

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Michael
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Jackmcbarn, 
Mbch331, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-11-10 Thread Michael

Michael added a comment.


  Is there anything that we (=WMDE) can do to help with this moving forward? 
(This task is on one of our workboards, but I'm not sure if there is anything 
that we can contribute, that's why I'm asking.)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Michael
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-11-05 Thread Manuel

Manuel edited projects, added Wikidata-Campsite (Team A Hearth ); removed 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Manuel
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, 786, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331, Iflorez, alaa_wmde
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-10-07 Thread Ladsgroup

Ladsgroup reassigned this task from Ladsgroup to Pchelolo.
Ladsgroup added a comment.


  It's being done by Petr, I'm mostly here for emotional support.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pchelolo, Ladsgroup
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-10-05 Thread gerritbot

gerritbot added a comment.


  Change 726739 had a related patch set uploaded (by Ppchelko; author: 
Ppchelko):
  
  [mediawiki/extensions/SpamBlacklist@master] Implement MultiContentSave hook 
insted of EditFilter
  
  https://gerrit.wikimedia.org/r/726739

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-10-01 Thread Pchelolo

Pchelolo added a comment.


  A different approach could be to implement MultiContentSave hook instead of 
EditFilterMergedContent hook. MultiSaveComplete already gives us a 
RenderedRevision that should be reused for page saving. Additional benefit - we 
can replace multiple hook handlers with this one.
  
  Possible drawback - need to test how well the status set in MultiContentSave 
hook is propagated back to the UI in various scenarios.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Pchelolo
Cc: Pchelolo, WMDE-leszek, daniel, toan, Michael, Addshore, 
Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Suran38, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-10-01 Thread Pchelolo

Pchelolo added a parent task: T292300: Tracking: duplicate parses.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Pchelolo
Cc: WMDE-leszek, daniel, toan, Michael, Addshore, Lucas_Werkmeister_WMDE, 
Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-23 Thread Ladsgroup

Ladsgroup moved this task from Peer Review to Stalled/Waiting on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  stalled in wmde on the refactors in core getting merged: 
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/701074
  
  Once these are done, We should double check and make sure this doesn't happen 
again.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: WMDE-leszek, daniel, toan, Michael, Addshore, Lucas_Werkmeister_WMDE, 
Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-17 Thread Ladsgroup

Ladsgroup added a comment.


  I'm okay with undeprecating that function but I want to emphasize that even 
with using the deprecated function, every edit would trigger a render twice 
(three times if you count the edit stash). The xhgui link in the task 
description is for when it was using the good but then-deprecated function.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: daniel, toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, 
Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-17 Thread daniel

daniel added a comment.


  I agree: keep using WikiPage::prepareContentForEdit() until  Id5ba40a21 
 lands, then start 
using that. Feedback on that patch would be appreciated.
  
  I'm sorry for the confusion that was caused by that deprecation. The original 
plan was to make WikiPage::getDerivedDataUpdater() public. When we changed that 
decision, we failed to provide a viable alternative to 
WikiPage::prepareContentForEdit().
  
  Conceptually, managing the state of an ongoing edit in WikiPage is pretty 
terrible. But until all the relevant hooks have been changed to pass along all 
the relevant info, there really is no alternative.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, daniel
Cc: daniel, toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, 
Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Krinkle

Krinkle added a comment.


  I suggest reverting the changes that moved away from the (soft-deprecated) 
`WikiPage::prepareContentForEdit` method. This method is to my knowledge the 
only appropiate way we have for extension hooks during an edit stash or edit 
submit request to obtain the ParserOutput in a shared and cached way.
  
  The method was prematurely deprecated in T242249 
. The recommended replacement 
involves boilerplate that's inappropiate for extension code (and nobody seems 
to have followed that recommendation). And what people actually did in some 
cases (call Content->getParserOutput) is problematic for performance. This 
method should only be called by code in charge of authorotativey parsing 
something for its own purpose, e.g. core when submitting an edit, or in rare 
cases where an extension perhaps constructs an unsaved Content object to render 
ad-hoc outside any revision or parsercache. In general that's not the case and 
such method should not be called.
  
  Then after the regression is fixed attention can focus on revisiting that 
unfinished deprecation (T242249 ), 
and on detecting future regressions (T288707 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Krinkle
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 
2021-08-16); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2021-08-16T17:33:18Z] 
 Synchronized 
php-1.37.0-wmf.18/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:712965|Try to use EditStash before re-rendering (T288639 
)]] (duration: 00m 59s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread gerritbot

gerritbot added a comment.


  Change 712965 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Try to use EditStash 
before re-rendering
  
  https://gerrit.wikimedia.org/r/712965

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread gerritbot

gerritbot added a comment.


  Change 713262 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@master] Try to use EditStash before 
re-rendering
  
  https://gerrit.wikimedia.org/r/713262

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread gerritbot

gerritbot added a comment.


  Change 712965 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Try to use EditStash 
before re-rendering
  
  https://gerrit.wikimedia.org/r/712965

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Ladsgroup

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  Tested in mwdebug2001 ^ works just fine and finds the stash

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Ladsgroup

Ladsgroup added a comment.


  At least PageImages only renders the first section, maybe a bit better?

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Ladsgroup

Ladsgroup added a comment.


  Guess what I found, another extension that trigger an extra render:
  
https://performance.wikimedia.org/xhgui/run/symbol?id=611a5306f8b9883f5f87dc9e=AbstractContent%3A%3AgetParserOutput

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread gerritbot

gerritbot added a comment.


  Change 713262 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@master] Try to use EditStash before 
re-rendering
  
  https://gerrit.wikimedia.org/r/713262

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Ladsgroup

Ladsgroup added a comment.


  Yes and no. It still shouldn't trigger a double render and use edit stash. 
Problem is that Parser just combines everything together.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Lucas_Werkmeister_WMDE

Lucas_Werkmeister_WMDE added a comment.


  Well, yes, for wikitext you actually need to do almost all the parsing work 
in order to fill links tables, headings, and all sorts of other metadata. 
Wikidata content, where you can get the metadata without generating HTML, is a 
special case. (Technically, I suppose you could skip actually generating HTML 
for wikitext too, but you’ll still need to do all the work of parsing, 
expanding templates, calling Lua modules, and so on, so I wouldn’t expect a 
significant difference there.)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lucas_Werkmeister_WMDE
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-16 Thread Ladsgroup

Ladsgroup moved this task from Test (Verification) to Doing on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  Found out why it only improved wikidata editing save time:
  F34597546: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: toan, Michael, Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, 
Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-13 Thread Ladsgroup

Ladsgroup moved this task from Peer Review to Test (Verification) on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  Some nice numbers
  
https://grafana.wikimedia.org/d/00559/api-requests-breakdown?viewPanel=19=1=1628763472923=1628842508524=p95=wbeditentity
  F34594247: image.png 
  
  
https://grafana.wikimedia.org/d/00559/api-requests-breakdown?viewPanel=19=1=1628785652820=1628826309564=p50=wbeditentity
  F34594249: image.png 
  
  Save timing in general has too much noise but might show improvements when 
some time passes.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, 
ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-13 Thread Addshore

Addshore added a comment.


  ostrich-what 


TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Addshore
Cc: Addshore, Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, 
ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, 
Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 
2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2021-08-12T21:57:16Z] 
 Synchronized 
php-1.37.0-wmf.18/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:711721|Don't generate HTML when asking for ParserOutput 
(T288639 )]] (duration: 00m 58s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a comment.


  Change 711721 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Don't generate HTML 
when asking for ParserOutput
  
  https://gerrit.wikimedia.org/r/711721

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a comment.


  Change 711721 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Don't generate HTML 
when asking for ParserOutput
  
  https://gerrit.wikimedia.org/r/711721

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.19; 
2021-08-16); removed MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread Maintenance_bot

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, 
Mbch331, Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a comment.


  Change 712121 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@master] Don't generate HTML when asking 
for ParserOutput
  
  https://gerrit.wikimedia.org/r/712121

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, 
Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread gerritbot

gerritbot added a comment.


  Change 712121 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@master] Don't generate HTML when asking 
for PArserOutput
  
  https://gerrit.wikimedia.org/r/712121

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread Ladsgroup

Ladsgroup added a subscriber: Lucas_Werkmeister_WMDE.
Ladsgroup added a comment.


  @Lucas_Werkmeister_WMDE suggested we can still trigger a double render but 
with generate_html to false for SpamBlacklist which would speed it up 
drastically.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Lucas_Werkmeister_WMDE, Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, 
Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, 
Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread Ladsgroup

Ladsgroup added a comment.


  Yup, `AbstractContent::getParserOutput` creates a new PO, renders it and send 
it back every time it's called and it's called in lots of places.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, 
alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-12 Thread Ladsgroup

Ladsgroup added a comment.


  The calls to that certain part has been removed but the save timing hasn't 
improved. My working hypothesis is that I just moved double rendering from one 
function call to another. Is there any function in mediawiki that wouldn't 
trigger a render?

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, 
alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Krinkle

Krinkle added a comment.


  In T288639#7277104 , 
@Legoktm wrote:
  
  > For reference, this is at least the *fourth* time this has happened:
  >
  > - T59026#639359  (Nov. 
2013)
  > - T198483#4404330  (July 
2018)
  > - T205369#4743547  (Nov. 
2018)
  >
  > I think this merits some kind of deeper analysis / proper fixing so it 
stops regressing.
  
  Yes. I filed T288707: Detect and monitor against multiple Parser invocation 
during edit requests .

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Krinkle
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, 
alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Maintenance_bot

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, 
alaa_wmde, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331, Biggs657, 
Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread ReleaseTaggerBot

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.18; 
2021-08-09); removed MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2021-08-11T21:42:02Z] 
 Synchronized 
php-1.37.0-wmf.17/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:710725|Avoid using deprecated 
WikiPage::prepareContentForEdit (T288639 
)]] (duration: 01m 08s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Legoktm

Legoktm added a comment.


  For reference, this is at least the *fourth* time this has happened:
  
  - T59026#639359  (Nov. 2013)
  - T198483#4404330  (July 
2018)
  - T205369#4743547  (Nov. 
2018)
  
  I think this merits some kind of deeper analysis / proper fixing so it stops 
regressing.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Legoktm
Cc: Legoktm, Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, 
Ladsgroup, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, 
Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Stashbot

Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2021-08-11T21:29:29Z] 
 Synchronized 
php-1.37.0-wmf.18/extensions/SpamBlacklist/includes/SpamBlacklistHooks.php: 
Backport: [[gerrit:711706|Avoid using deprecated 
WikiPage::prepareContentForEdit (T288639 
)]] (duration: 01m 07s)

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Stashbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 710725 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.17] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/710725

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 711706 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/711706

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 711706 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.18] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/711706

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 710725 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@wmf/1.37.0-wmf.17] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/710725

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread ReleaseTaggerBot

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 711662 **merged** by jenkins-bot:
  
  [mediawiki/extensions/SpamBlacklist@master] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/711662

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Jdforrester-WMF

Jdforrester-WMF added a comment.


  In T288639#7276542 , 
@Ladsgroup wrote:
  
  > I don't know how it managed to caused such a big fix for wikidata but it is 
the result of before and after:
  > 
https://performance.wikimedia.org/xhgui/run/symbol?id=6114280a2df779cbf2be4232=MediaWiki%5CRevision%5CRenderedRevision%3A%3AgetSlotParserOutput
  > 
https://performance.wikimedia.org/xhgui/run/symbol?id=61142762fcbdc7ca7a4d0b62=MediaWiki%5CRevision%5CRenderedRevision%3A%3AgetSlotParserOutput
  
  2,478,623 µs -> 281,268 µs is quite a change, yes!

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Jdforrester-WMF
Cc: Jdforrester-WMF, Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, 
alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Jayprakash12345, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Ladsgroup

Ladsgroup added a comment.


  I don't know how it managed to caused such a big fix for wikidata but it is 
the result of before and after:
  
https://performance.wikimedia.org/xhgui/run/symbol?id=6114280a2df779cbf2be4232=MediaWiki%5CRevision%5CRenderedRevision%3A%3AgetSlotParserOutput
  
https://performance.wikimedia.org/xhgui/run/symbol?id=61142762fcbdc7ca7a4d0b62=MediaWiki%5CRevision%5CRenderedRevision%3A%3AgetSlotParserOutput

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Marostegui, ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Ladsgroup

Ladsgroup added a comment.


  I see that the patch doesn't change any behavior (and doesn't let you save 
page with spam in them) while reducing the CPU time to half and wall time drops 
drastically as well:
  
  To compare, these two are basically the try of the same edit, one with the 
patch, the other without:
  
  - https://performance.wikimedia.org/xhgui/run/view?id=61142317d3295678cc349962
  - https://performance.wikimedia.org/xhgui/run/view?id=611424580399bb5b4aa92e88

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: ori, Krinkle, Aklapper, dpifke, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Hazizibinmahdi, Beast1978, 
Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, 
Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wong128hk, 
Wikidata-bugs, aude, Lydia_Pintscher, Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread gerritbot

gerritbot added a comment.


  Change 711662 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [mediawiki/extensions/SpamBlacklist@master] Avoid using deprecated 
WikiPage::prepareContentForEdit
  
  https://gerrit.wikimedia.org/r/711662

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: ori, Krinkle, Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, 
Hazizibinmahdi, Akuckartz, Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice

2021-08-11 Thread Maintenance_bot

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T288639

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: ori, Krinkle, Aklapper, dpifke, Ladsgroup, Invadibot, maantietaja, 
Hazizibinmahdi, Akuckartz, Iflorez, alaa_wmde, Nandana, Jony, Lahi, Gq86, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Vali.matei, _jensen, 
rosalieper, Scott_WUaS, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, 
Jackmcbarn, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

70 matches

Mail list logo