[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Looks fixed on Test Wikidata 
:
  F35323222: image.png 
  Compare Wikidata 
,
 where the fix isn’t deployed yet:
  F35323224: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Astuthiodit_1, Prufkick, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Amorymeltzer, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, 
abian, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-19 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Astuthiodit_1, Prufkick, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Amorymeltzer, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, 
abian, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.21; 2022-07-18).

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Astuthiodit_1, Prufkick, 
karapayneWMDE, Invadibot, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Amorymeltzer, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, 
abian, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Astuthiodit_1, Prufkick, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, 
Amorymeltzer, Lahi, Gq86, Lsherwinforone, GoranSMilovanovic, Jayprakash12345, 
QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, 
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g, Hellket777, 
786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread gerritbot 
gerritbot added a comment.


  Change 814830 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t escape special 
page description
  
  https://gerrit.wikimedia.org/r/814830

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Hellket777, Astuthiodit_1, 786, 
Prufkick, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Srdjan, 
MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, Wikidata-bugs, aude, 
Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread Amire80 
Amire80 added a comment.


  Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Amire80
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Hellket777, Astuthiodit_1, 786, 
Prufkick, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Srdjan, 
MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, Wikidata-bugs, aude, 
Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Probably not the only place where WikibaseQualityConstraints uses 
`->escaped()` when another message method would be more appropriate (in this 
case it was `->text()`, often it would be `->parse()`). I definitely didn’t 
properly understand MediaWiki’s `Message` class when I started working on the 
extension, and I probably wasn’t the only one :)

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Amire80, Aklapper, Hellket777, Astuthiodit_1, 786, 
Prufkick, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, Lsherwinforone, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Srdjan, 
MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, Wikidata-bugs, aude, 
Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Amire80, Aklapper, Hellket777, Astuthiodit_1, 786, Prufkick, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, Lsherwinforone, Lucas_Werkmeister_WMDE, GoranSMilovanovic, 
Jayprakash12345, QZanden, Esc3300, LawExplorer, Sethakill, Lewizho99, 
Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Srdjan, 
MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, Wikidata-bugs, aude, 
Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-18 Thread gerritbot 
gerritbot added a comment.


  Change 814830 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Don’t escape special 
page description
  
  https://gerrit.wikimedia.org/r/814830

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Amire80, Aklapper, Astuthiodit_1, Prufkick, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Amorymeltzer, Lahi, Gq86, 
Lsherwinforone, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, 
QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, 
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T313181: Unnecessary escaping in a Wikibase Quality Constraints message on Special:SpecialPages

2022-07-17 Thread Amire80 
Amire80 created this task.
Amire80 added projects: MediaWiki-Special-pages, I18n, Wikidata, 
Wikibase-Quality-Constraints.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: wdwb-tech.

TASK DESCRIPTION
  **Steps to replicate the issue** (include links if applicable):
  
  - Go to the "Wikibase" section on Special:SpecialPages on wikidata.org, using 
the Hebrew user interface: 
https://www.wikidata.org/wiki/Special:SpecialPages?uselang=he#mw-specialpagesgroup-wikibase
  
  **What happens?**:
  
  - The first item in the list includes ``.
  
  **What should have happened instead?**:
  
  - The first item in the list must not include ``, and must look like 
"דו"ח אילוצים".
  
  **Other information** (browser name/version, screenshots, etc.):
  The source message is wbqc-constraintreport/he 
. It 
includes a usual double quotation mark, `"`, and the full message is דו"ח 
אילוצים. This is a correct translation: in Hebrew, double quotation marks are 
often used in the middle of the word. It looks like this quotation mark is 
escaped. This is unnecessary.
  
  On the same page, a link to Special:ChangeEmail appears. This Hebrew message 
(changeemail ) also 
includes the double quotation mark in the word דוא"ל, and it's displayed 
correctly. So, strangely enough, it looks like this bug is unique to 
#wikibase-quality-constraints 
.
  
  I tried reproducing it on my local wiki. I didn't install Wikibase (it's 
complicated...), and simply tried adding the quotation marks to the title of 
other special pages from core MediaWiki and other extensions. They were 
displayed correctly. So perhaps there's some extra security setting on 
wikidata.org or in this particular extension, which forces escaping where it's 
not supposed to be necessary, but I might be wrong.

TASK DETAIL
  https://phabricator.wikimedia.org/T313181

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Amire80
Cc: Amire80, Aklapper, Astuthiodit_1, Prufkick, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Amorymeltzer, Lahi, Gq86, 
Lsherwinforone, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Jayprakash12345, 
QZanden, Esc3300, LawExplorer, Sethakill, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wong128hk, abian, 
Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org