[Wikidata-bugs] [Maniphest] [Changed CC] T268: Decide on Priority field values for Maniphest tasks
mmodell added a subscriber: mmodell. mmodell added a comment. I agree with @Gryllida on this one. Having a needs volunteer priority sorta sounds disingenuous. Might as well call a duck a duck and name it priority: none TASK DETAIL https://phabricator.wikimedia.org/T268 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Qgil, mmodell Cc: Qgil, chasemp, scfc, Lydia_Pintscher, Aklapper, hoo, Awjrichards, Gryllida, mmodell, Wikidata-bugs, aude, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit
mmodell added a comment. In https://phabricator.wikimedia.org/T74907#1109504, @thiemowmde wrote: Erm, not what I meant. Will Phabricator support chains of patches and if it does, how? In https://phabricator.wikimedia.org/T74907#1109505, @Qgil wrote: @mmodell, @chasemp, please check the question above. Last time I checked, arcanist/differential do not have any have explicit support for chains of dependent patches. You can submit multiple commits to a single differential changeset ( it takes care of squashing when you submit, but still tracks individual local commits for posterity ) ... But the lack of dependencies between multiple differential changes is a fairly significant limitation. I suspect it will be added some day, it may even worth our time to implement a rudimentary dependency feature, if we could get it accepted upstream. TASK DETAIL https://phabricator.wikimedia.org/T74907 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T84923: Reliable publish / subscribe event bus
mmodell added a subscriber: mmodell. TASK DETAIL https://phabricator.wikimedia.org/T84923 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign username. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Eevans, chasemp, brion, Krenair, Halfak, JanZerebecki, bd808, MZMcBride, mobrovac, GWicke, aaron, daniel, Hardikj, yuvipanda, JAllemandou, jkroll, Smalyshev, Wikidata-bugs, Jdouglas, RobH, aude, marcoil, Manybubbles, mark, RobLa-WMF, faidon, fgiunchedi, Dzahn ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T99998: make-wmf-branch should check if it is up to date
mmodell closed this task as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: gerritbot, mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T74907: move git repositories that are dependencies of wikidata to gerrit
mmodell added a comment. In https://phabricator.wikimedia.org/T74907#1218316, @mmodell wrote: Last time I checked, arcanist/differential do not have any have explicit support for chains of dependent patches. I was wrong, it does have dependencies now. One differential revision can depend on another revision. TASK DETAIL https://phabricator.wikimedia.org/T74907 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Addshore, Liuxinyu970226, Ricordisamoa, chasemp, mmodell, Abraham, Aklapper, thiemowmde, Qgil, Snaterlicious, daniel, adrianheine, Tobi_WMDE_SW, GPHemsley, Legoktm, JeroenDeDauw, JanZerebecki, aude, Glaisher, MZMcBride, Lydia_Pintscher, Dereckson, hoo, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Claimed] T99998: make-wmf-branch should check if it is up to date
mmodell claimed this task. mmodell added a comment. I'll implement this TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T99998: make-wmf-branch should check if it is up to date
mmodell triaged this task as High priority. TASK DETAIL https://phabricator.wikimedia.org/T8 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, aude, hoo, JanZerebecki, Aklapper, Wikidata-bugs, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T109603: Undefined index: descriptions in extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483
mmodell created this task. mmodell added a subscriber: mmodell. mmodell added projects: WikibaseDatabase, Wikimedia-log-errors. Herald added a subscriber: Aklapper. Herald added a project: Wikidata. TASK DESCRIPTION Apologies if I tagged the wrong project, is this #WikibaseDatabase or #WikibaseQueryEngine? New logspam appearing as of 1.26wmf19: ``` Undefined index: descriptions in /srv/mediawiki/php-1.26wmf19/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483 ``` TASK DETAIL https://phabricator.wikimedia.org/T109603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Aklapper, mmodell, Wikidata-bugs, aude, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T109603: Undefined index: descriptions in extensions/Wikidata/extensions/Wikibase/repo/includes/api/ResultBuilder.php on line 483
mmodell closed this task as Resolved. mmodell claimed this task. mmodell added a comment. Hotfix deployed, I can confirm that the error is no longer showing up in production logs. TASK DETAIL https://phabricator.wikimedia.org/T109603 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: JanZerebecki, gerritbot, aude, Aklapper, mmodell, Wikidata-bugs, Krenair, greg, Malyacko ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage
mmodell added a comment. what came of this meeting? TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: greg, tstarling, aude, hoo, daniel, zeljkofilipin, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, Lynhg, Wikidata-bugs, Malyacko, GWicke, Qgil, P.Copp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Block] T118363: widar oauth broken - magical script elves are temporarily ill
mmodell reopened blocking task T118372: OAuth broken as "Open". TASK DETAIL https://phabricator.wikimedia.org/T118363 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Sjoerddebruin, yuvipanda, Magnus, Harmonia_Amanda, Aklapper, Dzahn, StudiesWorld, Wikidata-bugs, aude, Gryllida, jayvdb, scfc, coren, Mbch331, valhallasw ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T105638: RFC: Streamlining Composer usage
mmodell added a comment. @gwicke: very interesting suggestion. I like it, though I think I need to think it over a bit more before I can say for sure that it would work for mediawiki deployments. TASK DETAIL https://phabricator.wikimedia.org/T105638 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: mobrovac, GWicke, Addshore, Qgil, Spage, greg, tstarling, aude, hoo, daniel, zeljkofilipin, thcipriani, mmodell, bd808, csteipp, Legoktm, Krinkle, hashar, JanZerebecki, Aklapper, Lynhg, Wikidata-bugs, Malyacko, Mbch331, Jay8g, Ltrlg, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: [Task] make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. But I thought that mediawiki core __is__ updated when a patch is merged to an extension. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: hashar, gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Wikidata-bugs, AndyRussG, Pcoombe, atgo, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T110375: [Bug] Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string g
mmodell added a subscriber: mmodell. mmodell added a comment. I'm seeing this in 1.27.0-wmf.5: Catchable fatal error: Argument 1 passed to Wikibase\Repo\Api\EditEntity::getRemoveStatementChangeOps() must be an instance of array, string given in /srv/mediawiki/php-1.27.0-wmf.5/extensions/Wikidata/extensions/Wikibase/r epo/includes/api/EditEntity.php on line 562 TASK DETAIL https://phabricator.wikimedia.org/T110375 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Ricordisamoa, demon, Aklapper, aude, Luke081515, Wikidata-bugs, Mbch331, Jay8g, Krenair, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T111304: Fatal error: Call to undefined method OOUI\Element::serializeForApiResult() in /srv/mediawiki/php-1.26wmf21/vendor/oojs/oojs-ui/php/Element.php on l
mmodell added a comment. The patch breaks unit tests. The tests need to be fixed along with this change. TASK DETAIL https://phabricator.wikimedia.org/T111304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, mmodell Cc: Bene, gerritbot, Lydia_Pintscher, ori, greg, Jdlrobson, Anomie, Legoktm, Krenair, Jdforrester-WMF, Aklapper, mmodell, Wikidata-bugs, aude, jayvdb, Ricordisamoa, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. I don't quite understand the problem, and I really don't understand how changing the make-wmf-branch config is going to resolve it? This sounds like a bug in the way CI testing is configured. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Liudvikas, Wikidata-bugs, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T113731: make core wmf branches only use submodule branches that run with it in CI
mmodell added a comment. CI should just check out all the submodules by following the submodule sha1 references in the core branch, then it wouldn't matter how the branches are named, ci would do the right thing by simply letting git do the right thing. If CI isn't doing that now then it's a bug in the CI setup. TASK DETAIL https://phabricator.wikimedia.org/T113731 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, mmodell Cc: gerritbot, mmodell, aude, hoo, Krinkle, JanZerebecki, Aklapper, Wikidata-bugs, hashar, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T126597: [Task] Move WikibaseDataModel to Gerrit
mmodell added a comment. Have you considered moving to Phabricator + Differential instead of gerrit? TASK DETAIL https://phabricator.wikimedia.org/T126597 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: Jonas, hoo, Dereckson, Lydia_Pintscher, MZMcBride, aude, JanZerebecki, JeroenDeDauw, Legoktm, GPHemsley, Tobi_WMDE_SW, adrianheine, daniel, thiemowmde, Aklapper, mmodell, chasemp, Ricordisamoa, Liuxinyu970226, Addshore, Bene, Lazowik, Tpt, Krenair, Izno, Luke081515, Wikidata-bugs, Mbch331, QChris, greg ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a comment. @daniel: Thanks, removing it from blockingTASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell removed a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171370: ERROR: "LBFactory::getEmptyTransactionTicket: WikiPageUpdater::injectRCRecords does not have outer scope"
mmodell added a comment. The patch appears to be merged on master but the wmf.10 cherry-pick is still open? I've added this as a blocker to wmf.12 since it's still open and I need to verify that the issue isn't affecting wmf.12 after I cut the branch tomorrow.TASK DETAILhttps://phabricator.wikimedia.org/T171370EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Addshore, demon, thcipriani, daniel, aaron, greg, TerraCodes, Jay8g, Liuxinyu970226, jcrespo, gerritbot, Aklapper, Krinkle, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. Thanks Daniel, hotfix is not necessary.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell triaged this task as "Unbreak Now!" priority.mmodell added a comment.Herald added subscribers: Liuxinyu970226, Jay8g, TerraCodes. This is blocking the train due to more than doubling the error rate in fatalmonitor.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a commit: rEWBA2987fe5bcf62: Move injection of RC records to a separate job.. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. In T172320#3494790, @Paladox wrote: Caused by https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/2987fe5bcf6223d03835670f7a6832e6a41a51ef that commit is rEWBA2987fe5bcf62: Move injection of RC records to a separate job.TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell created this task.mmodell added projects: Wikimedia-log-errors, wikiba.se, MediaWiki-extensions-WikibaseClient.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONphp-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/client/includes/Changes/InjectRCRecordsJob.phpTASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aude, Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aude, Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a comment. After rolling forward with wmf.12 I saw this error showing up again. Apparently the hotfix didn't work?TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a commit: rEWBA11aad9d2dbc8: Hot fix for InjectRCRecordsJob: disable coalescing. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T172443: Wikibase: Unresolved redirect in WikiPageEntityRevisionLookup.php:103
mmodell updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION== Message == `[WYN9oQpAEDEAAGN4QXYAAADK] /w/api.php Wikibase\Lib\Store\RevisionedUnresolvedRedirectException from line 103 of /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php: Unresolved redirect to Q1898919` == Stack == ```#0 /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(258): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string)...TASK DETAILhttps://phabricator.wikimedia.org/T172443EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T172443: /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:103
mmodell created this task.mmodell added projects: Wikimedia-log-errors, MediaWiki-extensions-WikibaseRepository.Herald added subscribers: PokestarFan, Aklapper.Herald added a project: Wikidata. TASK DESCRIPTION#0 /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(258): Wikibase\Lib\Store\Sql\WikiPageEntityRevisionLookup->getEntityRevision(Wikibase\DataModel\Entity\ItemId, integer, string) #1 /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(582): Wikibase\EditEntity->getLatestRevision() #2 /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(349): Wikibase\EditEntity->attemptSave(string, integer, string) #3 /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/repo/includes/Api/SetClaim.php(137): Wikibase\Repo\Api\EntitySavingHelper->attemptSaveEntity(Wikibase\DataModel\Entity\Item, string) #4 /srv/mediawiki/php-1.30.0-wmf.12/includes/api/ApiMain.php(1583): Wikibase\Repo\Api\SetClaim->execute() #5 /srv/mediawiki/php-1.30.0-wmf.12/includes/api/ApiMain.php(546): ApiMain->executeAction() #6 /srv/mediawiki/php-1.30.0-wmf.12/includes/api/ApiMain.php(517): ApiMain->executeActionWithErrorHandling() #7 /srv/mediawiki/php-1.30.0-wmf.12/api.php(94): ApiMain->execute() #8 /srv/mediawiki/w/api.php(3): include(string) #9 {main}TASK DETAILhttps://phabricator.wikimedia.org/T172443EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172443: /srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:103
mmodell added a parent task: T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T172443EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Retitled] T172443: Wikibase: Unresolved redirect in WikiPageEntityRevisionLookup.php:103
mmodell renamed this task from "/srv/mediawiki/php-1.30.0-wmf.12/extensions/Wikidata/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityRevisionLookup.php:103" to "Wikibase: Unresolved redirect in WikiPageEntityRevisionLookup.php:103".mmodell triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T172443EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, PokestarFan, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
mmodell edited parent tasks, added: T170632: 1.30.0-wmf.14 deployment blockers; removed: T170631: 1.30.0-wmf.13 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jrbranaa, PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell edited parent tasks, added: T170632: 1.30.0-wmf.14 deployment blockers; removed: T170631: 1.30.0-wmf.13 deployment blockers, T168053: 1.30.0-wmf.12 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T171667: Mirror wikibase/wikiba.se from Gerrit to Diffusion
mmodell added a comment. +1 just set up a repo in diffusion to track github.TASK DETAILhttps://phabricator.wikimedia.org/T171667EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, greg, MarcoAurelio, demon, Aklapper, Ladsgroup, PokestarFan, GoranSMilovanovic, Gentlejack35, QZanden, Izno, Luke081515, Wikidata-bugs, aude, Florian, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T172320: Error in Wikibase/client/includes/Changes/InjectRCRecordsJob.php line 120: Bad value for parameter $params: $params['change'] not set.
mmodell added a parent task: T170631: 1.30.0-wmf.13 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T172320EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: Jdforrester-WMF, Lucas_Werkmeister_WMDE, daniel, IKhitron, Paladox, TerraCodes, Jay8g, Liuxinyu970226, Stashbot, gerritbot, aude, Aklapper, mmodell, PokestarFan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T164173: Cache invalidations coming from the JobQueue are causing lag on several wikis
mmodell added a parent task: T170631: 1.30.0-wmf.13 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T164173EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, mmodellCc: PokestarFan, Agabi10, gerritbot, Krinkle, aaron, MZMcBride, daniel, Ladsgroup, hoo, Marostegui, Aklapper, jcrespo, GoranSMilovanovic, Jrbranaa, Th3d3v1ls, Hfbn0, QZanden, Vali.matei, Minhnv-2809, Zppix, Izno, Luke081515, Wikidata-bugs, aude, faidon, Mbch331, Jay8g, Krenair, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T173433: Expand on the incident report for wikidata wmf.10 - wmf.14 train deployment
mmodell triaged this task as "Normal" priority. TASK DETAILhttps://phabricator.wikimedia.org/T173433EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Krinkle, thcipriani, demon, greg, daniel, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T173433: Expand on the incident report for wikidata wmf.10 - wmf.14 train deployment
mmodell created this task.mmodell added projects: Wikimedia-Incident, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONI started the incident report page on wikitech but I could use some help with fleshing out the details: https://wikitech.wikimedia.org/wiki/Incident_documentation/20170721-Train-WikidataTASK DETAILhttps://phabricator.wikimedia.org/T173433EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Krinkle, thcipriani, demon, greg, daniel, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, ArielGlenn, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/
mmodell lowered the priority of this task from "Unbreak Now!" to "High".mmodell added a comment. ok this error seems to have disappeared as mysteriously as it appeared.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Changed Subscribers] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vend
mmodell added subscribers: aude, Addshore.mmodell added a comment. @aude or @Addshore: Any clue what might be causing this? I'm not sure how vendor'd code works in the wikidata extension. This error started showing up suddenly after the most recent SWAT even though no code was deployed which should have affected this.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/d
mmodell raised the priority of this task from "High" to "Unbreak Now!".Herald added subscribers: Jay8g, TerraCodes. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data-valu
mmodell triaged this task as "High" priority.mmodell added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data-valu
mmodell added a parent task: T167535: MW-1.30.0-wmf.6 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data
mmodell added a comment. That's what I don't understand, the code didn't change... So you think this is just invalid data passed to the API and the timing (which coincided with SWAT) was just a coincidence?TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Dereckson, JeroenDeDauw, Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Raised Priority] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/d
mmodell raised the priority of this task from "High" to "Unbreak Now!".mmodell added a comment. Spoke too soon, now it's back.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T168681: Argument 1 passed to DataValues\UnboundedQuantityValue::newFromArray() must be an instance of array, string given in extensions/Wikidata/vendor/data
mmodell added a comment. What I want to know is why this just started happening. If it's not really related to today's SWAT then perhaps it shouldn't block the train.TASK DETAILhttps://phabricator.wikimedia.org/T168681EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Dereckson, JeroenDeDauw, Lucas_Werkmeister_WMDE, TerraCodes, Jay8g, greg, Addshore, aude, Stashbot, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T167238: Fatal Error: "Tag hook for noexternallanglinks is not callable" (1.30.0-wmf.4/includes/parser/Parser.php)
mmodell closed this task as "Resolved".mmodell added a comment. I take it this is fixed then.TASK DETAILhttps://phabricator.wikimedia.org/T167238EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Mattflaschen-WMF, mmodellCc: mmodell, Stashbot, Lydia_Pintscher, thiemowmde, gerritbot, TerraCodes, Aklapper, Krinkle, Jay8g, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, aude, Mbch331, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T167360: Warning: in_array() expects parameter 2 to be an array or collection
mmodell added a parent task: T166829: MW-1.30.0-wmf.4 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, aude, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T167360: Warning: in_array() expects parameter 2 to be an array or collection
mmodell created this task.mmodell added projects: Wikidata, Wikimedia-log-errors.Herald added a subscriber: Aklapper. TASK DESCRIPTIONWarning: in_array() expects parameter 2 to be an array or collection in /srv/mediawiki/php-1.30.0-wmf.4/extensions/Wikidata/extensions/Wikibase/lib/includes/Formatters/MwTimeIsoFormatter.php on line 109TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, aude, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter
mmodell closed this task as "Resolved".mmodell assigned this task to aude. TASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aude, mmodellCc: gerritbot, Aklapper, aude, mmodell, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T167360: "Warning: in_array() expects parameter 2 to be an array or collection" from Wikibase MwTimeIsoFormatter
mmodell added a comment. Thanks @audeTASK DETAILhttps://phabricator.wikimedia.org/T167360EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: gerritbot, Aklapper, aude, mmodell, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Lewizho99, Maathavan, Izno, Wikidata-bugs, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T173433: Expand on the incident report for wikidata wmf.10 - wmf.14 train deployment
mmodell added a comment. I've filled in some details on the timeline that I pieced together from phabricator transaction logs.TASK DETAILhttps://phabricator.wikimedia.org/T173433EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, aude, Jrbranaa, Krinkle, thcipriani, demon, greg, daniel, Aklapper, mmodell, GoranSMilovanovic, QZanden, Izno, Wikidata-bugs, ArielGlenn, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T99357: [Story] Review and deploy Wikibase-Quality-External-Validation on wikidata.org
mmodell added a project: wikimedia-extension-review-queue. TASK DETAILhttps://phabricator.wikimedia.org/T99357EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Bene, Tamslo, JanZerebecki, Liuxinyu970226, Ricordisamoa, Wikibase-Quality-External-Validation, Aklapper, Lydia_Pintscher, GoranSMilovanovic, QZanden, Scott_WUaS, Izno, abian, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T159708: Deploy WikibaseMediaInfo extension to production
mmodell added a project: wikimedia-extension-review-queue. TASK DETAILhttps://phabricator.wikimedia.org/T159708EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Ricordisamoa, Aklapper, Lydia_Pintscher, SandraF_WMF, GoranSMilovanovic, QZanden, Acer, Urbanecm, Susannaanas, Izno, Luke081515, Yann, Wikidata-bugs, PKM, Base, matthiasmullie, aude, Fabrice_Florin, Raymond, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T173433: Expand on the incident report for wikidata wmf.10 - wmf.14 train deployment
mmodell closed this task as "Resolved".mmodell claimed this task.Herald added a project: Release-Engineering-Team (Kanban). TASK DETAILhttps://phabricator.wikimedia.org/T173433EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, aude, Jrbranaa, Krinkle, thcipriani, demon, greg, daniel, Aklapper, mmodell, GoranSMilovanovic, QZanden, Liudvikas, Izno, Luke081515, Wikidata-bugs, ArielGlenn, zeljkofilipin, He7d3r, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Reassigned] T174142: Build up and facilitate a focus group of Commons and Wikidata contributors for (long-term) feedback and input on Structured Data on Commons
mmodell reassigned this task from R3609901 to SandraF_WMF.mmodell added a subscriber: R3609901. TASK DETAILhttps://phabricator.wikimedia.org/T174142EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SandraF_WMF, mmodellCc: R3609901, Anooprao, Liuxinyu970226, Elitre, Steinsplitter, Abit, Raymond, SandraF_WMF, Aklapper, Lahi, PDrouin-WMF, E1presidente, Ramsey-WMF, GoranSMilovanovic, Ivana_Isadora, QZanden, Acer, Poyekhali, Jseddon, FloNight, Johan, Trizek-WMF, Susannaanas, Wong128hk, Luke081515, Jane023, Wikidata-bugs, PKM, Base, matthiasmullie, aude, El_Grafo, Ricordisamoa, Fabrice_Florin, TheDJ, Mbch331, Jay8g, Keegan, Qgil___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T194339: Invalid callback Wikibase\LibHooks::onGalleryGetModes in hooks for GalleryGetModes
mmodell added a parent task: T191049: 1.32.0-wmf.3 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T194339EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, V4switch, Wong128hk, Wikidata-bugs, matthiasmullie, Fabrice_Florin, Matanya, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T194339: Invalid callback Wikibase\LibHooks::onGalleryGetModes in hooks for GalleryGetModes
mmodell created this task.mmodell added projects: Wikimedia-log-errors, wikiba.se, MediaWiki-Gallery.Herald added a subscriber: Aklapper.Herald added a project: Multimedia. TASK DESCRIPTIONError Message /wiki/Special:UnusedFiles MWException from line 167 of /srv/mediawiki/php-1.32.0-wmf.3/includes/Hooks.php: Invalid callback Wikibase\LibHooks::onGalleryGetModes in hooks for GalleryGetModes Stack Trace #0 /srv/mediawiki/php-1.32.0-wmf.3/includes/Hooks.php(205): Hooks::callHook(string, array, array, NULL) #1 /srv/mediawiki/php-1.32.0-wmf.3/includes/gallery/ImageGalleryBase.php(133): Hooks::run(string, array) #2 /srv/mediawiki/php-1.32.0-wmf.3/includes/gallery/ImageGalleryBase.php(103): ImageGalleryBase::loadModes() #3 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/ImageQueryPage.php(48): ImageGalleryBase::factory(boolean, RequestContext) #4 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/QueryPage.php(671): ImageQueryPage->outputResults(OutputPage, SkinVector, Wikimedia\Rdbms\DatabaseMysqli, Wikimedia\Rdbms\ResultWrapper, integer, integer) #5 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPage.php(522): QueryPage->execute(NULL) #6 /srv/mediawiki/php-1.32.0-wmf.3/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(NULL) #7 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext) #8 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(861): MediaWiki->performRequest() #9 /srv/mediawiki/php-1.32.0-wmf.3/includes/MediaWiki.php(524): MediaWiki->main() #10 /srv/mediawiki/php-1.32.0-wmf.3/index.php(42): MediaWiki->run() #11 /srv/mediawiki/w/index.php(3): include(string) #12 {main} Notes file/srv/mediawiki/php-1.32.0-wmf.3/includes/Hooks.php:167 urlhttps://en.wikibooks.org/wiki/Special:UnusedFiles TASK DETAILhttps://phabricator.wikimedia.org/T194339EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, V4switch, Wong128hk, Wikidata-bugs, matthiasmullie, Fabrice_Florin, Matanya, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Triaged] T194339: Invalid callback Wikibase\LibHooks::onGalleryGetModes in hooks for GalleryGetModes
mmodell triaged this task as "High" priority. TASK DETAILhttps://phabricator.wikimedia.org/T194339EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, V4switch, Wong128hk, Wikidata-bugs, matthiasmullie, Fabrice_Florin, Matanya, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194316: Wikibooks Special:UnusedFiles throws Internal Error
mmodell added a comment. thanks @hooTASK DETAILhttps://phabricator.wikimedia.org/T194316EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hoo, mmodellCc: mmodell, hoo, Stashbot, gerritbot, Az1568, Cameron11598, Aklapper, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189811: Set up user for automatic WDQS GUI builds
mmodell added a comment. ok I +2'd it.TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Dzahn, gerritbot, greg, mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, God, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Tommy_Kronkvist, Bsandipan, Lordiis, herron, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Avner, Lewizho99, Maathavan, Gehel, D3r1ck01, Liudvikas, FloNight, Xmlizer, Luke081515, Barras, jkroll, Wikidata-bugs, Jdouglas, RobH, aude, Tobias1984, Manybubbles, Jalexander, zeljkofilipin, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T191282: Wikimedia\Rdbms\LoadBalancer::{closure}: found writes pending
mmodell added a comment. @jcrespo: should we close this then? Have you been able to verify that all are gone?TASK DETAILhttps://phabricator.wikimedia.org/T191282EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Joe, Ladsgroup, hoo, RazShuty, gerritbot, Tgr, Pchelolo, mmodell, Marostegui, aaron, mobrovac, Aklapper, jcrespo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Eevans, JAllemandou, Hardikj, Wikidata-bugs, aude, GWicke, Mbch331, Jay8g, Krenair, jeremyb___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T195402: Form and Lexeme datatypes don't work anymore
mmodell added a comment. What version do you see on https://www.wikidata.org/wiki/Special:VersionTASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Mbch331, Smalyshev, TerraCodes, Liuxinyu970226, Lea_Lacroix_WMDE, Denny, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T195402: Form and Lexeme datatypes don't work anymore
mmodell added a comment. I see 1.32.0-wmf.5 (fda06ee) 14:24, 23 May 2018TASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Mbch331, Smalyshev, TerraCodes, Liuxinyu970226, Lea_Lacroix_WMDE, Denny, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T195402: Form and Lexeme datatypes don't work anymore
mmodell added a comment. We are definitely running the same version of the code everywhere, it must be something else causing the inconsistent results.TASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, mmodell, Mbch331, Smalyshev, TerraCodes, Liuxinyu970226, Lea_Lacroix_WMDE, Denny, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T195402: Form and Lexeme datatypes don't work anymore
mmodell added a comment. @Mbch331: I'm also getting the same for WikibaseLexeme. That is the current deployed version.TASK DETAILhttps://phabricator.wikimedia.org/T195402EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, mmodell, Mbch331, Smalyshev, TerraCodes, Liuxinyu970226, Lea_Lacroix_WMDE, Denny, Aklapper, Lydia_Pintscher, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Darkdadaah___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T200009: Archive mediawiki/extensions/Wikidata (Wikidata build)
mmodell added a comment. What is the benefit to emptying the repository? It seems to me that archiving it would be enough, no need to obscure it from history.TASK DETAILhttps://phabricator.wikimedia.org/T29EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Zoranzoki21, mmodellCc: mmodell, Repository-Admins, Liuxinyu970226, Aklapper, Bugreporter, Reari, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T191465: Exception: Bad value for parameter $pageTitle: must be a string
mmodell created this task.mmodell added projects: Wikimedia-log-errors, Wikibase-DataModel, Wikidata.Herald added a subscriber: Aklapper. TASK DESCRIPTIONMessage Bad value for parameter $pageTitle: must be a string from /srv/mediawiki/php-1.31.0-wmf.28/vendor/wikimedia/assert/src/Assert.php:89 Details sitewww.wikidata.org uri/wiki/Special:ItemByTitle/idwiki/efisiensi_irigasi referrerhttps://id.m.wiktionary.org/ request idWsUo-wpAMFkAAKxK4dYAAABG Stack Trace #0 /srv/mediawiki/php-1.31.0-wmf.28/extensions/Wikibase/lib/includes/Store/Sql/SiteLinkTable.php(216): Wikimedia\Assert\Assert::parameterType(string, boolean, string) #1 /srv/mediawiki/php-1.31.0-wmf.28/extensions/Wikibase/repo/includes/Specials/SpecialItemByTitle.php(125): Wikibase\Lib\Store\Sql\SiteLinkTable->getItemIdForLink(string, boolean) #2 /srv/mediawiki/php-1.31.0-wmf.28/includes/specialpage/SpecialPage.php(522): Wikibase\Repo\Specials\SpecialItemByTitle->execute(string) #3 /srv/mediawiki/php-1.31.0-wmf.28/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(string) #4 /srv/mediawiki/php-1.31.0-wmf.28/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext) #5 /srv/mediawiki/php-1.31.0-wmf.28/includes/MediaWiki.php(861): MediaWiki->performRequest() #6 /srv/mediawiki/php-1.31.0-wmf.28/includes/MediaWiki.php(524): MediaWiki->main() #7 /srv/mediawiki/php-1.31.0-wmf.28/index.php(42): MediaWiki->run() #8 /srv/mediawiki/w/index.php(3): include(string) #9 {main}TASK DETAILhttps://phabricator.wikimedia.org/T191465EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189762: selenium test for Wikibase is unstable
mmodell added a comment. Ok I +2'd the change to integration config. Someone with more knowledge of the problem will have to address the broken test.TASK DETAILhttps://phabricator.wikimedia.org/T189762EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Jdforrester-WMF, Lucas_Werkmeister_WMDE, Tgr, Jonas, WMDE-leszek, gerritbot, hoo, greg, zeljkofilipin, Legoktm, Aklapper, Smalyshev, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Liudvikas, Volker_E, Luke081515, thcipriani, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair, hashar___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189811: Set up user for automatic WDQS GUI builds
mmodell added a comment. I can add a password to the jenkins credential store but need to have that communicated to me in a secure way. Should we create a private phabricator task or exchange pgp keys?TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, God, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Liudvikas, FloNight, Xmlizer, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, zeljkofilipin, Mbch331, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189811: Set up user for automatic WDQS GUI builds
mmodell added a comment. In T189811#4150831, @Smalyshev wrote: We already have the user in LDAP (wdqsguibuilder) though for now it uses my email address. But I think we could try running it with this address, to ensure the procedure works? @Smalyshev Sure I don't see why not.TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: greg, mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, God, Lahi, Gq86, Darkminds3113, Tommy_Kronkvist, herron, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, elukey, Gehel, D3r1ck01, Liudvikas, FloNight, Xmlizer, Luke081515, Barras, jkroll, Wikidata-bugs, Jdouglas, RobH, aude, Tobias1984, Manybubbles, Jalexander, zeljkofilipin, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189811: Set up user for automatic WDQS GUI builds
mmodell added a comment. @Smalyshev: Ok that's set up in jenkins: https://integration.wikimedia.org/ci/credentials/store/system/domain/_/credential/WDQSGUIBuilder/TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, God, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Liudvikas, FloNight, Xmlizer, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, zeljkofilipin, Mbch331, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T189811: Set up user for automatic WDQS GUI builds
mmodell updated the task description. (Show Details) CHANGES TO TASK DESCRIPTION...[x] releng get the password added to Jenkins credential store and releng secret store...TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, God, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, Liudvikas, FloNight, Xmlizer, Luke081515, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, zeljkofilipin, Mbch331, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T190955: Undefined index in extensions/WikibaseQualityConstraints/src/Api/CachingResultsBuilder.php on line 242
mmodell closed this task as a duplicate of T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity. TASK DETAILhttps://phabricator.wikimedia.org/T190955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, Aklapper, mmodell, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Merged] T189842: Undefined index error in CachingResultsBuilder when checking constraints on empty entity
mmodell merged a task: T190955: Undefined index in extensions/WikibaseQualityConstraints/src/Api/CachingResultsBuilder.php on line 242. TASK DETAILhttps://phabricator.wikimedia.org/T189842EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, mmodellCc: mmodell, thiemowmde, Jonas, gerritbot, Lucas_Werkmeister_WMDE, Aklapper, Reedy, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T190955: Undefined index in extensions/WikibaseQualityConstraints/src/Api/CachingResultsBuilder.php on line 242
mmodell created this task.mmodell added projects: Wikimedia-log-errors, Wikibase-Quality.Herald added a subscriber: Aklapper.Herald added a project: Wikidata. TASK DESCRIPTIONError Message Notice: Undefined index: Q16415620 in /srv/mediawiki/php-1.31.0-wmf.26/extensions/WikibaseQualityConstraints/src/Api/CachingResultsBuilder.php on line 242 Stack Trace NotesTASK DETAILhttps://phabricator.wikimedia.org/T190955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, mmodell, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T190955: Undefined index in extensions/WikibaseQualityConstraints/src/Api/CachingResultsBuilder.php on line 242
mmodell added a comment. @Lucas_Werkmeister_WMDE indeed wmf.26 not 27. I apologize for the dupe, My search didn't match T189842TASK DETAILhttps://phabricator.wikimedia.org/T190955EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Lucas_Werkmeister_WMDE, Aklapper, mmodell, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Agabi10, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T189811: Set up user for automatic WDQS GUI builds
mmodell added a comment. Ok I fixed the credentials (Added the private key and removed the ldap user/password) ... @Smalyshev you will need to add the coresponding public key to gerrit if you have not done so already. I re-ran the jenkins job and it failed with a seemingly unrelated error about missing grunt.TASK DETAILhttps://phabricator.wikimedia.org/T189811EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: greg, mmodell, Lucas_Werkmeister_WMDE, Jonas, Smalyshev, hashar, Aklapper, God, Lahi, Gq86, Darkminds3113, Tommy_Kronkvist, herron, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, D3r1ck01, Liudvikas, FloNight, Xmlizer, Luke081515, Barras, jkroll, Wikidata-bugs, Jdouglas, RobH, aude, Tobias1984, Manybubbles, Jalexander, zeljkofilipin, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T205664: Re-organise Phabricator projects for the Structured Data on Commons programme
mmodell added a comment. Ok done - the project hierarchy is created, please feel free to edit the project icons, colors, descriptions and hashtags as appropriate. I tried to set them to sensible baseline but your team would know better.TASK DETAILhttps://phabricator.wikimedia.org/T205664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMF, mmodellCc: mmodell, Jdforrester-WMF, Aklapper, Nandana, Majesticalreaper22, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Framawiki, JJMC89, Susannaanas, Luke081515, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Krenair, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T205664: Re-organise Phabricator projects for the Structured Data on Commons programme
mmodell closed this task as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T205664EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jdforrester-WMF, mmodellCc: mmodell, Jdforrester-WMF, Aklapper, Nandana, Majesticalreaper22, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Framawiki, JJMC89, Susannaanas, Luke081515, Aschroet, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Jay8g, Krenair, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Created] T207394: Argument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must implement interface Wikibase\Lib\Store\Sql\PageTableEntityQu
mmodell created this task.mmodell added projects: Wikimedia-production-error, Wikibase-DataModel.mmodell triaged this task as "Unbreak Now!" priority.Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper.Restricted Application added a project: Wikidata. TASK DESCRIPTIONError Request ID: AWaH0llmOf1_EDXpgw3k messageArgument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must implement interface Wikibase\Lib\Store\Sql\PageTableEntityQuery, MediaWiki\Storage\NameTableStore given in /srv/mediawiki/php-1.32.0-wmf.26/extensions/WikibaseQualityConstraints/src/ServiceWiring.php on line 254 tracen/a Impact High volume of fatals in logstash immediately upon promoting group1 wikis to 1.32.0-wmf.26 NotesTASK DETAILhttps://phabricator.wikimedia.org/T207394EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, TerraCodes, Liuxinyu970226, mmodell, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T207394: Argument 2 passed to Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup::__construct() must implement interface Wikibase\Lib\Store\Sql\PageTableEntityQue
mmodell closed this task as "Resolved".mmodell added a comment. Fixed in wmf.26, thanks @Addshore!TASK DETAILhttps://phabricator.wikimedia.org/T207394EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, mmodellCc: Stashbot, gerritbot, Aklapper, TerraCodes, Liuxinyu970226, mmodell, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T207817: WDQS Updater ran into issue and stopped working
mmodell added a comment. Do we have a patch or should we roll back group0?TASK DETAILhttps://phabricator.wikimedia.org/T207817EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Stashbot, 20after4, TerraCodes, Liuxinyu970226, gerritbot, Gehel, Smalyshev, Mathew.onipe, Aklapper, Dzahn, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Zppix, Maathavan, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T207817: WDQS Updater ran into issue and stopped working
mmodell added a comment. ok anyone care to give the ol' +2 to revert this on the branch? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/469451/TASK DETAILhttps://phabricator.wikimedia.org/T207817EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Ottomata, Pchelolo, Tarrow, WMDE-leszek, Addshore, mmodell, Stashbot, 20after4, TerraCodes, Liuxinyu970226, gerritbot, Gehel, Smalyshev, Mathew.onipe, Aklapper, Dzahn, CucyNoiD, Nandana, NebulousIris, thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, Th3d3v1ls, Hfbn0, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, Lewizho99, Zppix, Maathavan, Jonas, Xmlizer, Wong128hk, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, Mbch331, Jay8g, fgiunchedi___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T208103: Wikibase Lexeme emits "PHP Warning: Class __PHP_Incomplete_Class has no unserializer"
mmodell closed this task as "Resolved".mmodell claimed this task.mmodell added a comment. I only see one instance of this in all of logstash's history. I think it is safe to assume that it was transient. Alternatively, this is likely dupe of T195615TASK DETAILhttps://phabricator.wikimedia.org/T208103EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, WMDE-leszek, Addshore, Jakob_WMDE, Krinkle, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T207881: excessive "lock wait timeout exceeded " error rate after deploying 1.33.0-wmf.1 to group1
mmodell added a project: MediaWiki-extensions-WikibaseRepository.Restricted Application added a project: Wikidata. TASK DETAILhttps://phabricator.wikimedia.org/T207881EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Paladox, gerritbot, Banyek, Stashbot, TerraCodes, Liuxinyu970226, Aklapper, mmodell, CucyNoiD, Nandana, NebulousIris, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
mmodell added a comment. In T194299#4713400, @daniel wrote: For context, note that we are not using an auto-increment field, we are doing the increment in code, and write it back to the database. Why not do something like this? INSERT INTO sequence_table ('sequence_name', 'sequence_value') VALUES (?, 1) ON DUPLICATE KEY UPDATE sequence_value = LAST_INSERT_ID(sequence_value + 1); SELECT LAST_INSERT_ID(); Wouldn't that at least reduce the time to hold a lock while still being atomic?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T207881: excessive "lock wait timeout exceeded " error rate after deploying 1.33.0-wmf.1 to group1
mmodell removed a parent task: T206655: 1.33.0-wmf.1 deployment blockers. TASK DETAILhttps://phabricator.wikimedia.org/T207881EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, Paladox, gerritbot, Banyek, Stashbot, TerraCodes, Liuxinyu970226, Aklapper, mmodell, CucyNoiD, Nandana, NebulousIris, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Lowered Priority] T207881: excessive "lock wait timeout exceeded " error rate after deploying 1.33.0-wmf.1 to group1
mmodell lowered the priority of this task from "Unbreak Now!" to "High". TASK DETAILhttps://phabricator.wikimedia.org/T207881EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Addshore, Paladox, gerritbot, Banyek, Stashbot, TerraCodes, Liuxinyu970226, Aklapper, mmodell, CucyNoiD, Nandana, NebulousIris, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Rayssa-, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Marostegui, LawExplorer, Lewizho99, Minhnv-2809, Maathavan, Luke081515, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
mmodell added a comment. Yeah it's definitely a mysql-specific technique but it's atomic, fast and recommended in the mysql documentation.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T204721: Wikidata board on phabricator returns UNRECOVERABLE FATAL ERROR when viewing all tasks (including closed ones)
mmodell added a comment. I don't think there is any way to solve this. There are just too many tasks to render within a reasonable time limit.TASK DETAILhttps://phabricator.wikimedia.org/T204721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: mmodell, Aklapper, Lydia_Pintscher, Addshore, Majesticalreaper22, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Framawiki, JJMC89, Luke081515, Wikidata-bugs, aude, Mbch331, Jay8g, greg___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T218683: extract throttling filter form wdqs so that it can be reused in other projects
mmodell added a comment. ref {T218636} TASK DETAIL https://phabricator.wikimedia.org/T218683 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Smalyshev, Aklapper, Gehel, alaa_wmde, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T218683: extract throttling filter form wdqs so that it can be reused in other projects
mmodell added a project: Restricted Project. TASK DETAIL https://phabricator.wikimedia.org/T218683 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: mmodell Cc: mmodell, Smalyshev, Aklapper, Gehel, alaa_wmde, Dsharpe, Nandana, jijiki, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, alanajjar, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, MarcoAurelio, aude, Tobias1984, Bawolff, Manybubbles, Mbch331, Rxy, chasemp ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215380: Content too big! Entity: Q27972199
mmodell added a comment. This seems like a error that should be handled gracefully in the UI instead of bubbling up to the fatal monitor. I'd be satisfied if we simply reported this as a DEBUG or INFO level log entry.TASK DETAILhttps://phabricator.wikimedia.org/T215380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Daimona, Lydia_Pintscher, Addshore, Aklapper, mmodell, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, Jonas, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Closed] T208499: Stop branching & deploying WikibaseQuality extension
mmodell closed this task as "Resolved".mmodell assigned this task to Legoktm.mmodell added a comment. Indeed I verified that WikibaseQuality was not included in 1.33.0-wmf.16TASK DETAILhttps://phabricator.wikimedia.org/T208499EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Legoktm, mmodellCc: mmodell, Lucas_Werkmeister_WMDE, hashar, Stashbot, Zoranzoki21, greg, gerritbot, Addshore, Aklapper, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, Liudvikas, Wikidata-bugs, aude, Mbch331___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Unblock] T205065: Archive the WikibaseQuality extension
mmodell closed subtask T208499: Stop branching & deploying WikibaseQuality extension as "Resolved". TASK DETAILhttps://phabricator.wikimedia.org/T205065EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: Aklapper, Addshore, Nandana, Reari, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Gentlejack35, QZanden, merbst, LawExplorer, _jensen, Agabi10, MGChecker, Luke081515, Wikidata-bugs, aude, Dinoguy1000, Florian, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T215380: Content too big! Entity: Q27972199
mmodell added a comment. In T215380#4944667, @thcipriani wrote: +1 Having this show up as in ERROR means we see it on the dashboards in logstash that we use to determine if something went wrong when we deploy. This problem doesn't indicate something is wrong with code/data/environment/config, but just an unhandled (but known and understood) data state that could cause spikes in error logs that reduce our confidence in a deployment. I'm not really sure what transient condition caused it to spike and then subside, however, I believe it's an indicator of a somewhat problematic trend: I've noticed quite a lot of instances similar to this where api-level or library level code is written to strictly and thoroughly validate data, complete with many specific exceptions that log as ERROR. Meanwhile callers of said code are much less thorough and so un-handled errors are regularly bubbling up into fatalmonitor. I don't think we can expect a revolutionary improvement in the discipline of developers calling these APIs but I do think that it's fair to ask the developers implementing thorough validation regimens to exercise some discipline in exception level logging. What might be the best venue to advocate for better error level classification when raising exceptions? It seems fairly obvious to me that this (and similar) validation errors should be DEBUG or INFO level as they are only useful to the consumer of an API and not relevant to the overall health and operation of the software itself. Thinking about this a bit deeper, what it seems like we need is a way to differentiate between user-input-validation-exceptions and filter them out of deployment dashboards, etc. These are only bugs in the sense that front-end code should have caught the exception. In the case of an API call coming from 3rd party callers there is absolutely nothing we can do to act on the error and it's not at all useful to surface it in places where we regularly monitor for operational or deployment-related issues.TASK DETAILhttps://phabricator.wikimedia.org/T215380EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: thcipriani, Daimona, Lydia_Pintscher, Addshore, Aklapper, mmodell, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, Jonas, Volker_E, Wikidata-bugs, aude, GWicke, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs