Re: [Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-10-11 Thread Antonin Delpeuch (lists) 
On 11/10/2019 16:11, Lydia Pintscher wrote:
> We hadn't looked at edits other than terms as part of the change but
> it's something I agree we should have. I'll bump it up and see what we
> can do.

Awesome! I understand that this might require complicated refactoring on
your side, it's probably easier said than done. There is no particular
rush for this as far as Wikidata-Toolkit is concerned, I just thought I
would mention the issue since it is related.

Best,
Antonin

___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Re: [Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-10-03 Thread Antonin Delpeuch (lists) 
In Phabricator terms, this corresponds to the following tickets:
https://phabricator.wikimedia.org/T191885
https://phabricator.wikimedia.org/T67846

Antonin

On 02/10/2019 09:52, Antonin Delpeuch (lists) wrote:
> Hi Léa,
> 
> Sorry, my question was not very clear. Let us take the example of
> creating a new statement on an item. This can be done with wbeditentity
> but also with other actions such as wbcreateclaim or wbsetclaim.
> 
> Is there any plan to reuse the summaries of these latter actions when
> creating a single claim via wbeditentity, rather than the current
> uninformative one?
> 
> Broadly speaking, this is something that could be done for all wb*
> actions whose result can also be achieved via wbeditentity. This does
> not even require designing new summary messages (as they already exist,
> they are just not used by wbeditentity yet as far as I am aware).
> 
> This would allow clients such as Wikidata-Toolkit to always use
> wbeditentity, no matter what sort of edit they are doing, and still get
> informative edit summaries.
> 
> Currently, Wikidata-Toolkit has a fairly complicated logic [1] to choose
> which API action to use depending on the sort of edit. It would
> intuitively make sense to push that logic in Wikibase itself, so that it
> could benefit others.
> 
> Cheers,
> Antonin
> 
> [1] :
> https://github.com/Wikidata/Wikidata-Toolkit/blob/master/wdtk-wikibaseapi/src/main/java/org/wikidata/wdtk/wikibaseapi/TermStatementUpdate.java#L388
> 
> On 30/09/2019 17:16, Léa Lacroix wrote:
>> In the near future, we will have different edit summaries depending on
>> how many actions are made through the API.
>> # If 5 or less terms (item, description or alias) are changed, we will
>> display the expanded version:  []
>> : 
>> # Does that answer your question or did you mean something else? :)
>> # Cheers,
>> # Léa
>>
>> On Mon, 30 Sep 2019 at 16:23, Antonin Delpeuch (lists)
>> mailto:li...@antonin.delpeuch.eu>> wrote:
>>
>> This is great news! Thank you so much for working on this!
>>
>> It must be hard to figure out how to generate summaries for a wide range
>> of edit shapes, but it is definitely useful.
>>
>> I cannot tell from the Phab ticket whether you considered to reuse
>> existing summaries from atomic actions (such as addition of a single
>> description) when the edit was made through wbeditentity?
>>
>> For instance, as an API user it would be great if I could always use
>> wbeditentity regardless of the change I am making, and Wikibase would
>> automatically use a more granular edit summary if possible.
>>
>> Best,
>> Antonin
>>
>>
>> On 30/09/2019 16:07, Léa Lacroix wrote:
>> > Hello all,
>> >
>> > We are about to make some changes to edit summaries that appear
>> when an
>> > edit is made using wbeditentity API, which includes for example
>> editing
>> > terms (labels, descriptions, aliases) from the new mobile termbox. The
>> > summary messages currently contain “Changed an Item” as a comment. The
>> > new summaries will include the message "/Changed label, description
>> > and/or aliases in # languages/", where # is the count of distinct
>> > languages that terms in them have been affected.
>> >
>> > This change will be deployed on Wednesday, October 2nd, and the
>> new edit
>> > summaries will start changing from that point. The old edit summaries
>> > will not be changed. More improvements will follow in the future (for
>> > example, more details regarding the terms that have been changed
>> and the
>> > languages).
>> >
>> > You can see more details in this ticket
>> > . If you encounter any
>> > issues, please let me know. Thanks,
>> >
>> > --
>> > Léa Lacroix
>> > Project Manager Community Communication for Wikidata
>> >
>> > Wikimedia Deutschland e.V.
>> > Tempelhofer Ufer 23-24
>> > 10963 Berlin
>> > www.wikimedia.de  
>> >
>> > Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens
>> e. V.
>> >
>> > Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg
>> > unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das
>> > Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.
>> >
>> > ___
>> > Wikidata-tech mailing list
>> > Wikidata-tech@lists.wikimedia.org
>> 
>> > https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
>> >
>>
>>
>> ___
>> Wikidata-tech mailing list
>> Wikidata-tech@lists.wikimedia.org
>> 
>> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
>>
>>
>>
>> -- 
>> Léa Lacroix
>> Project

Re: [Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-10-02 Thread Antonin Delpeuch (lists) 
Hi Léa,

Sorry, my question was not very clear. Let us take the example of
creating a new statement on an item. This can be done with wbeditentity
but also with other actions such as wbcreateclaim or wbsetclaim.

Is there any plan to reuse the summaries of these latter actions when
creating a single claim via wbeditentity, rather than the current
uninformative one?

Broadly speaking, this is something that could be done for all wb*
actions whose result can also be achieved via wbeditentity. This does
not even require designing new summary messages (as they already exist,
they are just not used by wbeditentity yet as far as I am aware).

This would allow clients such as Wikidata-Toolkit to always use
wbeditentity, no matter what sort of edit they are doing, and still get
informative edit summaries.

Currently, Wikidata-Toolkit has a fairly complicated logic [1] to choose
which API action to use depending on the sort of edit. It would
intuitively make sense to push that logic in Wikibase itself, so that it
could benefit others.

Cheers,
Antonin

[1] :
https://github.com/Wikidata/Wikidata-Toolkit/blob/master/wdtk-wikibaseapi/src/main/java/org/wikidata/wdtk/wikibaseapi/TermStatementUpdate.java#L388

On 30/09/2019 17:16, Léa Lacroix wrote:
> In the near future, we will have different edit summaries depending on
> how many actions are made through the API.
> # If 5 or less terms (item, description or alias) are changed, we will
> display the expanded version:  []
> : 
> # Does that answer your question or did you mean something else? :)
> # Cheers,
> # Léa
> 
> On Mon, 30 Sep 2019 at 16:23, Antonin Delpeuch (lists)
> mailto:li...@antonin.delpeuch.eu>> wrote:
> 
> This is great news! Thank you so much for working on this!
> 
> It must be hard to figure out how to generate summaries for a wide range
> of edit shapes, but it is definitely useful.
> 
> I cannot tell from the Phab ticket whether you considered to reuse
> existing summaries from atomic actions (such as addition of a single
> description) when the edit was made through wbeditentity?
> 
> For instance, as an API user it would be great if I could always use
> wbeditentity regardless of the change I am making, and Wikibase would
> automatically use a more granular edit summary if possible.
> 
> Best,
> Antonin
> 
> 
> On 30/09/2019 16:07, Léa Lacroix wrote:
> > Hello all,
> >
> > We are about to make some changes to edit summaries that appear
> when an
> > edit is made using wbeditentity API, which includes for example
> editing
> > terms (labels, descriptions, aliases) from the new mobile termbox. The
> > summary messages currently contain “Changed an Item” as a comment. The
> > new summaries will include the message "/Changed label, description
> > and/or aliases in # languages/", where # is the count of distinct
> > languages that terms in them have been affected.
> >
> > This change will be deployed on Wednesday, October 2nd, and the
> new edit
> > summaries will start changing from that point. The old edit summaries
> > will not be changed. More improvements will follow in the future (for
> > example, more details regarding the terms that have been changed
> and the
> > languages).
> >
> > You can see more details in this ticket
> > . If you encounter any
> > issues, please let me know. Thanks,
> >
> > --
> > Léa Lacroix
> > Project Manager Community Communication for Wikidata
> >
> > Wikimedia Deutschland e.V.
> > Tempelhofer Ufer 23-24
> > 10963 Berlin
> > www.wikimedia.de  
> >
> > Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens
> e. V.
> >
> > Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg
> > unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das
> > Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.
> >
> > ___
> > Wikidata-tech mailing list
> > Wikidata-tech@lists.wikimedia.org
> 
> > https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
> >
> 
> 
> ___
> Wikidata-tech mailing list
> Wikidata-tech@lists.wikimedia.org
> 
> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
> 
> 
> 
> -- 
> Léa Lacroix
> Project Manager Community Communication for Wikidata
> 
> Wikimedia Deutschland e.V.
> Tempelhofer Ufer 23-24
> 10963 Berlin
> www.wikimedia.de 
> 
> Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
> 
> Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg
> unter der Nummer 23855 Nz. Als

Re: [Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-09-30 Thread Léa Lacroix 
In the near future, we will have different edit summaries depending on how
many actions are made through the API.
- If 5 or less terms (item, description or alias) are changed, we will
display the expanded version:  []
: 
- Does that answer your question or did you mean something else? :)
- Cheers,
- Léa

On Mon, 30 Sep 2019 at 16:23, Antonin Delpeuch (lists) <
li...@antonin.delpeuch.eu> wrote:

> This is great news! Thank you so much for working on this!
>
> It must be hard to figure out how to generate summaries for a wide range
> of edit shapes, but it is definitely useful.
>
> I cannot tell from the Phab ticket whether you considered to reuse
> existing summaries from atomic actions (such as addition of a single
> description) when the edit was made through wbeditentity?
>
> For instance, as an API user it would be great if I could always use
> wbeditentity regardless of the change I am making, and Wikibase would
> automatically use a more granular edit summary if possible.
>
> Best,
> Antonin
>
>
> On 30/09/2019 16:07, Léa Lacroix wrote:
> > Hello all,
> >
> > We are about to make some changes to edit summaries that appear when an
> > edit is made using wbeditentity API, which includes for example editing
> > terms (labels, descriptions, aliases) from the new mobile termbox. The
> > summary messages currently contain “Changed an Item” as a comment. The
> > new summaries will include the message "/Changed label, description
> > and/or aliases in # languages/", where # is the count of distinct
> > languages that terms in them have been affected.
> >
> > This change will be deployed on Wednesday, October 2nd, and the new edit
> > summaries will start changing from that point. The old edit summaries
> > will not be changed. More improvements will follow in the future (for
> > example, more details regarding the terms that have been changed and the
> > languages).
> >
> > You can see more details in this ticket
> > . If you encounter any
> > issues, please let me know. Thanks,
> >
> > --
> > Léa Lacroix
> > Project Manager Community Communication for Wikidata
> >
> > Wikimedia Deutschland e.V.
> > Tempelhofer Ufer 23-24
> > 10963 Berlin
> > www.wikimedia.de 
> >
> > Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
> >
> > Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg
> > unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das
> > Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.
> >
> > ___
> > Wikidata-tech mailing list
> > Wikidata-tech@lists.wikimedia.org
> > https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
> >
>
>
> ___
> Wikidata-tech mailing list
> Wikidata-tech@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
>


-- 
Léa Lacroix
Project Manager Community Communication for Wikidata

Wikimedia Deutschland e.V.
Tempelhofer Ufer 23-24
10963 Berlin
www.wikimedia.de

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.

Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.
___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Re: [Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-09-30 Thread Antonin Delpeuch (lists) 
This is great news! Thank you so much for working on this!

It must be hard to figure out how to generate summaries for a wide range
of edit shapes, but it is definitely useful.

I cannot tell from the Phab ticket whether you considered to reuse
existing summaries from atomic actions (such as addition of a single
description) when the edit was made through wbeditentity?

For instance, as an API user it would be great if I could always use
wbeditentity regardless of the change I am making, and Wikibase would
automatically use a more granular edit summary if possible.

Best,
Antonin


On 30/09/2019 16:07, Léa Lacroix wrote:
> Hello all,
> 
> We are about to make some changes to edit summaries that appear when an
> edit is made using wbeditentity API, which includes for example editing
> terms (labels, descriptions, aliases) from the new mobile termbox. The
> summary messages currently contain “Changed an Item” as a comment. The
> new summaries will include the message "/Changed label, description
> and/or aliases in # languages/", where # is the count of distinct
> languages that terms in them have been affected.
> 
> This change will be deployed on Wednesday, October 2nd, and the new edit
> summaries will start changing from that point. The old edit summaries
> will not be changed. More improvements will follow in the future (for
> example, more details regarding the terms that have been changed and the
> languages).
> 
> You can see more details in this ticket
> . If you encounter any
> issues, please let me know. Thanks,
> 
> -- 
> Léa Lacroix
> Project Manager Community Communication for Wikidata
> 
> Wikimedia Deutschland e.V.
> Tempelhofer Ufer 23-24
> 10963 Berlin
> www.wikimedia.de 
> 
> Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.
> 
> Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg
> unter der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das
> Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.
> 
> ___
> Wikidata-tech mailing list
> Wikidata-tech@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
> 


___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

[Wikidata-tech] Improved edit summaries for edits coming from wbeditentity API

2019-09-30 Thread Léa Lacroix 
Hello all,

We are about to make some changes to edit summaries that appear when an
edit is made using wbeditentity API, which includes for example editing
terms (labels, descriptions, aliases) from the new mobile termbox. The
summary messages currently contain “Changed an Item” as a comment. The new
summaries will include the message "*Changed label, description and/or
aliases in # languages*", where # is the count of distinct languages that
terms in them have been affected.

This change will be deployed on Wednesday, October 2nd, and the new edit
summaries will start changing from that point. The old edit summaries will
not be changed. More improvements will follow in the future (for example,
more details regarding the terms that have been changed and the languages).

You can see more details in this ticket
. If you encounter any issues,
please let me know. Thanks,
-- 
Léa Lacroix
Project Manager Community Communication for Wikidata

Wikimedia Deutschland e.V.
Tempelhofer Ufer 23-24
10963 Berlin
www.wikimedia.de

Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V.

Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter
der Nummer 23855 Nz. Als gemeinnützig anerkannt durch das Finanzamt für
Körperschaften I Berlin, Steuernummer 27/029/42207.
___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech