[MediaWiki-CodeReview] [MediaWiki r85847]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85847. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85847#c15855 Comment: Release notes should be added, in case some non wmf-wikis are still using this code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85776]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r85776. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r85776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85776#c15856 Comment: Needs to be redone in a proper way or reverted like other similar revisions, because not every DB behaves like MySQL in such cases. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85776]: New comment added
User Reedy posted a comment on MediaWiki.r85776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85776#c15857 Comment: So, to make it more database agnostic, have a couple of methods that return either the DB_MASTER where applicable (Or more probably, the LB), else for sqlite etc, it just returns the current? Though, I'm still quite confused why it caused more issues for MySQL users... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85706]: New comment added
User Happy-melon posted a comment on MediaWiki.r85706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85706#c15858 Comment: tt\o//tt Go Brion!! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85704]: Revision status changed
User Happy-melon changed the status of MediaWiki.r85704. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85704#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85638]: Revision status changed
User Happy-melon changed the status of MediaWiki.r85638. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85638#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85654]: New comment added
User Catrope posted a comment on MediaWiki.r85654. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85654#c15859 Comment: We've attempted to implement this in CodeReview once, but it didn't really take off. Mark H has some cruisecontrol system that runs tests, but I'm not sure how stable that is right now. In theory, you should be running the tests yourself, of course :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85876]: New comment added
User Raymond posted a comment on MediaWiki.r85876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876#c15860 Comment: Please add new message keys to maintenance/languages/messages.inc. Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85876]: New comment added
User Purodha posted a comment on MediaWiki.r85876. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85876#c15861 Comment: Thank you for the hint. I was not aware of the need. Done with r85877. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Actions and Special Pages
On Thu, Apr 7, 2011 at 19:39, Krinkle krinklem...@gmail.com wrote:
Op 8 apr 2011, om 01:11 heeft MZMcBride het volgende geschreven:
I mostly agree with you, I think, but you seem to be side-stepping the
linking issue. The fact that it's currently quite ugly to make an
edit link
or a protect link is one of the biggest arguments in favor of using
Special
pages.
Assuming all actions were standardized to use the ?action=
parameter, what
do you think about an {{#action:}} parser function? It would allow for
something like [[{{#action:move|Main Page}}]]. Does this seem
reasonable? If
so, I think a page on MediaWiki with some transition information and
a more
in-depth look at what's actually needed to get to a consistent state
would
be a good next step (assuming such a page doesn't exist already).
Thoughts?
MZMcBride
Indeed, the linking issue is one of the things action-parameters does
not fix.
But like you say, those could be solved in another way.
I like the {{#action}} idea. I'm not sure [[ and ]] can or should
still be needed though.
--
Krinkle
This reminds me of Bug 14892 (Allow external links in edit summary and
log reason):
https://bugzilla.wikimedia.org/show_bug.cgi?id=14892
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85862]: Revision status changed
User Platonides changed the status of MediaWiki.r85862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85862#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85669]: Revision status changed
User Platonides changed the status of MediaWiki.r85669. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85669#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added
User Platonides posted a comment on MediaWiki.r85786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15862 Comment: What if $wgDBprefix contained some character that needs quoting? I think tableName() should have a parameter to not quote the resulting variable (ie. it needs to be passed to addIdentifierQuotes before usage). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added
User MaxSem posted a comment on MediaWiki.r85786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15863 Comment: Why trim tableName? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] About to commit improved DB2 database support
I've been informally mentoring André, Tiago, Diego, and César. They are four students at Minho University who are currently working on a project to improve DB2 database support in MediaWiki. So far, they've: - Fixed several outstanding issues with DB2 support involving character encoding, Windows vs Linux, etc - Added DB2 support to the new MediaWiki 1.17 Installer and Updater - Put in the appropriate Updater sql patches to reflect database schema changes since 1.14 MediaWiki already had some DB2 support, but it's been broken since 1.15 and never complete. As a result of their work, it's now possible to successfully install MediaWiki on DB2 out of the box and to use the core wiki features. I'll shortly commit their first patch using my SVN account (leonsp). I've taken some care to look over the code and make sure it abides by the MediaWiki code guidelines. Regards, Leons Petrazickis http://lpetr.org/blog/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] About to commit improved DB2 database support
2011/4/12 Leons Petrazickis leons.petrazic...@gmail.com: - Added DB2 support to the new MediaWiki 1.17 Installer and Updater - Put in the appropriate Updater sql patches to reflect database schema changes since 1.14 This probably won't get backported into the 1.17 release branch, making 1.18 the first to really support DB2. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] About to commit improved DB2 database support
On 12.04.2011, 20:34 Chad wrote: 2011/4/12 Leons Petrazickis leons.petrazic...@gmail.com: - Added DB2 support to the new MediaWiki 1.17 Installer and Updater - Put in the appropriate Updater sql patches to reflect database schema changes since 1.14 This probably won't get backported into the 1.17 release branch, making 1.18 the first to really support DB2. -Chad It's DB2-only fixes, nothing scary about backporting it. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] ShortURL for Non Latin Mediawiki sites
Hi all, Sharing of URLs of non latin wiki's werent really easy and when copy pasting we get the unicode numerals in the URL like http://ta.wikipedia.org/wiki/%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BF%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AF%80%E0%AE%9F%E0%AE%BF%E0%AE%AF%E0%AE%BE:%E0%AE%86%E0%AE%B2%E0%AE%AE%E0%AE%B0%E0%AE%A4%E0%AF%8D%E0%AE%A4%E0%AE%9F%E0%AE%BF en:User:Mountain had come up with a shortify project[1] and thanks to Yuvipanda its now live on Tamil Wikipedia. All pages have a link on the right side of article title. http://tawp.in/r/262 is the same link and is being displayed there. The feedback from the community is to have this hosted by Wikimedia itself as it would be more reliable than individual running it. So there came the idea of a mediawiki extension and hence Shorturl extension[2] was born by some really quick work by Yuvipanda.Its live here[3].(See the toolbox for short URL) While this may be a small thing, it does help non latin wiki's a lot.Having it in the extension form is more reliable even though the URL length goes up, but still its worthy.The URL length can be shortened with mod_rewrite rules on. I would ideally like this to be used across non latin wikimedia properties as it helps these projects(like echoed here[4]). Please let me know how to do this. Bugs on wikimedia bugzilla will do? Feedback appreciated. [1] https://github.com/mountain/shortify [2] http://www.mediawiki.org/wiki/Extension:ShortUrl [3] http://wiki.busroutes.in/wiki/Chennai [4] http://lists.wikimedia.org/pipermail/wikimediaindia-l/2011-March/002699.html http://lists.wikimedia.org/pipermail/wikimediaindia-l/2011-March/002699.html Regards Srikanth.L ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r85885. Old Status: new New Status: fixme User IAlex also posted a comment on MediaWiki.r85885. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85885#c15864 Comment: * Please set ''svn:eol-style'' property for the files you added * Don't put ? at the end of PHP files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r85885. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r85885. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15865 Comment: Note: I have no experience with lbm_db2. I've looked at the first half dozen diffs, here's some general notes: pre --- includes/db/DatabaseIbm_db2.php +++ includes/db/DatabaseIbm_db2.php 460 + //TODO: Remove commented-out debug code once done debugging 470 + //echo 'preERRORlt;/pre'; 471 + //echo 'pre' . $sql . 'lt;/pre'; 472 $error = db2_stmt_errormsg(); 473 + //echo 'pre' . $error . 'lt;/pre'; /pre This needs to be removed pre 498 - $sql = EOF 498 + /*$sql = EOF 502 + $sql = SELECT COUNT( * ) /pre I guess the new value is better, but the old one doesn't have to stay in /* comments */, should be removed as well. pre 905: - //$this-installPrint( Preparing the following SQL: ); 905 + $this-installPrint( Preparing the following SQL: ); /pre The previous code on that line (which appears to be debug left by a previous developer) was uncommented. Should this be commented out again ? There's probably a bit more of this. I haven't looked further. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85885]: Revision status changed
User MaxSem changed the status of MediaWiki.r85885. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84805]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r84805. Old Status: fixme New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r84805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84805#c15866 Comment: I've worked around that by reverting this change for now in r85889. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84856]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r84856. Old Status: new New Status: reverted User Brion VIBBER also posted a comment on MediaWiki.r84856. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84856#c15867 Comment: Reverted in r85892 to match the revert of r84805 in r85889. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84805]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r84805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84805#c15868 Comment: That's also now reverted, since the updated version broke when this was reverted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85410]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r85410. Old Status: fixme New Status: new User Brion VIBBER also posted a comment on MediaWiki.r85410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85410#c15869 Comment: AbortAutoAccount's description is a copy-paste of AbortNewAccount's description, so if those are problems they're old problems. Doesn't appear to impact any functionality or cause any regressions, so removing the fixme in favor of doc tag. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85888]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r85888. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r85888. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85888#c15870 Comment: pre (2 lines skipped) [12-Apr-2011 17:13:49] PHP Strict Standards: Declaration of DatabaseSqlite::tableName() should be compatible with that of DatabaseBase::tableName() in /www/w/includes/AutoLoader.php on line 843 /pre The argument is not added to DatabaseSqlite::tableName(). Perhaps others as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84805]: New comment added
User Happy-melon posted a comment on MediaWiki.r84805. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84805#c15871 Comment: Thanks Brion. I'm actually no longer convinced that disposing of UsersPager was productive anyway; it's actually better suited to the job in hand here than QueryPage is. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85896]: Revision status changed
User Krinkle changed the status of MediaWiki.r85896. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85896#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85891]: New comment added
User Siebrand posted a comment on MediaWiki.r85891. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85891#c15872 Comment: Not that it really matters, but why change this comment? The [http://www.sil.org/iso639-3/documentation.asp?id=liv standards organisation for ISO 639-3] uses Liv as language name in English. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added
User Leonsp posted a comment on MediaWiki.r85885. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15873 Comment: Thanks for taking a look. * Fixed svn:eol-style, ? in r85890 * Taken out commented-out code in r85896 * Fixed some indentation I missed * Checked to make sure there's no more of the commented out code in the diffs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85891]: New comment added
User Kaldari posted a comment on MediaWiki.r85891. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85891#c15874 Comment: Livonian is the more common name for the language in English. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85901]: New comment added, and revision status changed
User Jack Phoenix changed the status of MediaWiki.r85901. Old Status: new New Status: ok User Jack Phoenix also posted a comment on MediaWiki.r85901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85901#c15875 Comment: Welcome! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85327]: New comment added
User DieBuche posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c15876 Comment: This broke the parserTest.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85902]: New comment added
User Happy-melon posted a comment on MediaWiki.r85902. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85902#c15877 Comment: How does this interact with the privileges option? AFAICT it overrides it? IMO, a script defined with tt[rights=user|default]/tt should be on by default for users and off-and-disabled for anons. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85689]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r85689. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85689#c15878 Comment: Actually there wasn't any regression, since loadFlaggedRevsData() already had the same short-circuit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85902]: New comment added
User MaxSem posted a comment on MediaWiki.r85902. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85902#c15879 Comment: The key here is ttif ( $gadget-isEnabled( $wgUser ) $gadget-isAllowed( $wgUser ) )/tt. It behaves exactly as you want it to:) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
Srikanth Lakshmanan wrote: Hi all, Sharing of URLs of non latin wiki's werent really easy and when copy pasting we get the unicode numerals in the URL like http://ta.wikipedia.org/wiki/%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AF%8D%E0%AE%95%E0%AE%BF%E0%AE%AA%E0%AF%8D%E0%AE%AA%E0%AF%80%E0%AE%9F%E0%AE%BF%E0%AE%AF%E0%AE%BE:%E0%AE%86%E0%AE%B2%E0%AE%AE%E0%AE%B0%E0%AE%A4%E0%AF%8D%E0%AE%A4%E0%AE%9F%E0%AE%BF ... So there came the idea of a mediawiki extension and hence Shorturl extension[2] was born by some really quick work by Yuvipanda ... [1] https://github.com/mountain/shortify [2] http://www.mediawiki.org/wiki/Extension:ShortUrl [3] http://wiki.busroutes.in/wiki/Chennai [4] http://lists.wikimedia.org/pipermail/wikimediaindia-l/2011-March/002699.html http://lists.wikimedia.org/pipermail/wikimediaindia-l/2011-March/002699.html Regards Srikanth.L Looks good, although I'm not sure what the advantage in this case is over using a page id. Both have the same disadvantage: * They are binding to a pageid instead of a pagename. This means whenever the page is (un)deleted, moved, merged, split, or becomes a redirect. The link is longer correct. I saw a different short-url service for en.wikipedia which also uses numbers, but internally converts to a page title. In order words: * http://en.wikipedia.org/wiki/Talk:Foobar = (pageid: 12, namespace: 1, title:Foobar) converted to 1 * shorturl/1 = namespace:1, title:Foobar - en.wikipedia.org/wiki/ Talk:Foobar This will always stay the same. * en.wikipedia.org/wiki/Talk:Foobar = pageid: 12 converted to base64 * (page is re-created, moved, split, merged, whatever) * shorturl/base64 = pageid: 12 = unknown page id, or perhaps http://en.wikipedia.org/wiki/A_different_page If the extension does not use the title, but the pageid, we might as well really use the pageid: * http://ta.wikipedia.org/?curid=2810 (already works) * http://ta.wikipedia.org/wiki/Special:ShortUrl/262 (proposal; // base_convert ( 2810, 10, 36 ); ) Even shorter :-) -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85893]: Revision status changed
User Krinkle changed the status of MediaWiki.r85893. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85893#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85888]: New comment added
User Platonides posted a comment on MediaWiki.r85888. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85888#c15880 Comment: Sqlite done in r85906. DatabaseMssql.php, DatabasePostgres.php and DatabaseOracle.php in r85907. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85902]: Revision status changed
User Krinkle changed the status of MediaWiki.r85902. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85902#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r85786. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r85786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15881 Comment: The parameter added to tableName() in r85888 should remove the quotes for you if needed. I think they ''should'' be there, though. Also test with the addIdentifierQuotes() change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85776]: New comment added
User Platonides posted a comment on MediaWiki.r85776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85776#c15882 Comment: Breaks tests/phpunit/includes/BlockTest.php Table 'my_wiki.unittest_ipblocks' doesn't exist You can't use a separate connection with temporary tables. Create a purger class? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85909]: Revision status changed
User Krinkle changed the status of MediaWiki.r85909. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85909#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85384]: Revision status changed
User Catrope changed the status of MediaWiki.r85384. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85384#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85910]: Revision status changed
User Krinkle changed the status of MediaWiki.r85910. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85910#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
On Tue, Apr 12, 2011 at 8:55 PM, Krinkle krinklem...@gmail.com wrote: * http://ta.wikipedia.org/?curid=2810 (already works) * http://ta.wikipedia.org/wiki/Special:ShortUrl/262 (proposal; // base_convert ( 2810, 10, 36 ); ) I think permalink is the common used term for this kind of url. So Special:Permalink/262. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
On Tue, Apr 12, 2011 at 9:32 PM, Bryan Tong Minh bryan.tongm...@gmail.com wrote: On Tue, Apr 12, 2011 at 8:55 PM, Krinkle krinklem...@gmail.com wrote: * http://ta.wikipedia.org/?curid=2810 (already works) * http://ta.wikipedia.org/wiki/Special:ShortUrl/262 (proposal; // base_convert ( 2810, 10, 36 ); ) I think permalink is the common used term for this kind of url. So Special:Permalink/262. In fact it already exists in 1.18 as of r79036 http://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/79036 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85483]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85483. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r85483. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85483#c15883 Comment: pre + array( + 'afp_key' = 'expertise', + 'afp_user_text' = $wgUser-getName(), + 'afp_user_anon_token' = $this-getAnonToken( $params ), + ), + __METHOD__, + array( 'ORDER BY', 'afp_revision DESC' ) /pre This query is bad. The index is on (revision, user_text, anon_token, key) so you can't to an order by on revision and have a constant WHERE on the other three fields and expect the query to be indexed; the index order is wrong for that. Grabbing the revid from the first row returned was better. pre + 'ORDER BY' = array( 'aa_rating_id', 'aa_revision DESC' ), /pre These changes to the query make it unindexed. The order by aa_rating_id is unnecessary and looks wrong: it's sorting by rating id ''before'' revision ID, and I see no reason to order by rating ID at all. Also, mixed-direction ORDER BYs are not indexed. The WHERE on user_text is needed but is also unindexed, we need to fix the index for that: (aa_user_id, aa_page_id, aa_revision) needs to become (aa_user_id, aa_user_token, aa_page_id, aa_revision) or something like that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85902]: New comment added
User Happy-melon posted a comment on MediaWiki.r85902. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85902#c15884 Comment: tt\o//tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r85022. Old Status: new New Status: fixme User Bryan also posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15885 Comment: This makes TablePagers jump to the center of the parent, which is ugly in most uses. Was this intended? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
Op 12 apr 2011, om 21:35 heeft Bryan Tong Minh het volgende geschreven: On Tue, Apr 12, 2011 at 9:32 PM, Bryan Tong Minh bryan.tongm...@gmail.com wrote: On Tue, Apr 12, 2011 at 8:55 PM, Krinkle krinklem...@gmail.com wrote: * http://ta.wikipedia.org/?curid=2810 (already works) * http://ta.wikipedia.org/wiki/Special:ShortUrl/262 (proposal; // base_convert ( 2810, 10, 36 ); ) I think permalink is the common used term for this kind of url. So Special:Permalink/262. Well, permalink is a permanent link to a certain revision (oldid) And has been in de sidebar for a while now and a specialpage-redirect has been implemented in 1.18. However a permanent link to a revision or a short link to the current page are two very different things. Short-url intends to make a link to [[Article name]] available in a shortform, especially useful for non-latin article names. Permanent-url intends to make the same content available under a permanent location, the fact that the url (can [1]) be shorter is a side-effect. If a page is modified (new revision), the permalink will be outdated. ...if a page recreated the permanent will no longer work at all. So summarized: * Imho a ShortUrl-specialpage extension is redundant as the few characters saved with base64 instead of the page-id (not revision id) directly is not much and only introduced a new number/variable into the mix of things to keep track of * Short page-id links already exist by using /?curid=pageid * Pageid is not a reliable way to link to an article of a certain subject. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Happy-melon posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15886 Comment: Yes, centering was intended (that's the ttmargin: 0 auto/tt). Why do you think this is messy? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85912]: Revision status changed
User Catrope changed the status of MediaWiki.r85912. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85912#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Bryan posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15887 Comment: Because the pager is used mostly on special pages where there is an input form above it which is left aligned. Also, when you are making style changes that change the appearance, please add that to your commit message; it is hard to guess your intention without that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83300]: Revision status changed
User Krinkle changed the status of MediaWiki.r83300. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83300#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
On Tue, Apr 12, 2011 at 10:01 PM, Krinkle krinklem...@gmail.com wrote: Op 12 apr 2011, om 21:35 heeft Bryan Tong Minh het volgende geschreven: On Tue, Apr 12, 2011 at 9:32 PM, Bryan Tong Minh bryan.tongm...@gmail.com wrote: On Tue, Apr 12, 2011 at 8:55 PM, Krinkle krinklem...@gmail.com wrote: * http://ta.wikipedia.org/?curid=2810 (already works) * http://ta.wikipedia.org/wiki/Special:ShortUrl/262 (proposal; // base_convert ( 2810, 10, 36 ); ) I think permalink is the common used term for this kind of url. So Special:Permalink/262. Well, permalink is a permanent link to a certain revision (oldid) And has been in de sidebar for a while now and a specialpage-redirect has been implemented in 1.18. However a permanent link to a revision or a short link to the current page are two very different things. Oh right, I always get confused between curid and oldid. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Krinkle posted a comment on MediaWiki.r85022.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15888
Comment:
The style didn't change afaik (if it did, something may be overriding it)
Look:
pre
- ... align=\center\ ..
+ margin: 0 auto;
/pre
Browsers do this internally:
source lang=css
table[align=center]{
margin-left: auto;
margin-right: auto;
}
/source
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Happy-melon posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15889 Comment: Forms are (or should be) 100% width; IMO having a left-aligned block below that is more ugly, not less, especially when the paging arrows are centered. Most TablePagers are (at least) 100% width anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85502]: Revision status changed
User Catrope changed the status of MediaWiki.r85502. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85502#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85552]: Revision status changed
User Catrope changed the status of MediaWiki.r85552. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85552#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Bryan posted a comment on MediaWiki.r85022.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15890
Comment:
That one corresponds to
pre
+.TablePager_nav {
+ margin: 0 auto;
+}
/pre
which is the navigation. The main table itself never had align=center.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] How to get your extension deployed
Srikanth Lakshmanan srik@gmail.com writes: I would ideally like this to be used across non latin wikimedia properties as it helps these projects. Please let me know how to do this. Bugs on wikimedia bugzilla will do? First, extensions that are deployed should be in subversion. Get commit access if you don't already have it and put it in SVN: http://www.mediawiki.org/wiki/Commit_access This gets the ball rolling. The extension will need to be translated on Translatewiki before it can be deployed anywhere and putting it in SVN with the proper i18n files and such will make that happen almost automatically (http://www.mediawiki.org/wiki/Localisation). You'll likely start to get reviews at this point for code style. You can get a jump on those by reading over http://www.mediawiki.org/wiki/Manual:Coding_conventions and starting to get your code in shape. Next you should try to get two or more reviews by trusted developers. They will help you find any thing that doesn't have a chance of making it past the next step. Find a couple of people to look over your code and point out any flaws in it. Make sure they know you're trying to follow this guide. If they know you're trying to get your code deployed, they'll look for things that would block deployment or alternatives to deployment that you might not be aware of. They may also point you to another extension that is already in use whose functionality duplicates what you want, or could be easily extended to do what you want. In that case, you should use your newly-acquired SVN access to work on the extension that is already in use. Finally, anything that is deployed on the Wikimedia cluster needs to be reviewed by Tim Starling for security and scalability issues. He has written written a page on this on MediaWiki that you should read and use before getting this far: http://www.mediawiki.org/wiki/Security_for_developers Any issues that Tim identifies *must* be addressed before anyone can deploy your code on the cluster. If you've followed the advice of earlier reviewers closely, you probably won't have too much of a problem here. Tim takes his job very seriously, though, so he may well spot a show-stopper that eluded your earlier reviewers. Finally, you need to file a bug in Bugzilla to have it deployed. The bug will need several things: * The “shell” keyword so that people with shell access can find the request. * The bug should point to on-wiki community consensus for having the extension installed on a particular wiki. No extension is deployed across all “non Latin Wikimedia properties” without first getting consensus from the individual wiki. * Finally, an extension that hasn't been deployed yet should acknowledge that fact and point to Tim Starling's approval for deployment. Getting something deployed is not an easy task, but if you can meet the challenge, you know you've done something that not many people are capable of. (I've written the above up on MediaWiki, too: http://www.mediawiki.org/wiki/Writing_an_extension_for_deployment) Good Luck! Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added
User Krinkle posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c15891 Comment: I see, nevermind in that case :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85576]: Revision status changed
User Catrope changed the status of MediaWiki.r85576. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85576#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85575]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85575.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r85575.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85575#c15892
Comment:
Trevor and I discussed this, putting it in here for future reference:
pre
+ protected function getHistoricCounts( $params ) {
+ global $wgArticleFeedbackRatings;
+
+ $res = $this-getDB()-select(
+ 'article_feedback_pages',
+ array(
+ 'aap_rating_id',
+ 'SUM(aap_count) as count',
+ ),
+ array(
+ 'aap_page_id' = $params['pageid'],
+ 'aap_rating_id' = $wgArticleFeedbackRatings,
+ ),
+ __METHOD__,
+ array( 'GROUP BY' = 'aap_rating_id')
+ );
+ $counts = array();
+ foreach ( $res as $row ) {
+ $counts[$row-aap_rating_id] = $row-count;
+ }
+ return $counts;
+ }
/pre
This needs to go in a summary table for efficient querying. Now that we have a
use case for per-page summary data, we might as well restore
article_feedback_pages to its original role of tracking per-page data, and move
the per-revision tracking to a separate table.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85776]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r85776. Old Status: fixme New Status: reverted User Reedy also posted a comment on MediaWiki.r85776. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85776#c15893 Comment: Reverted pending better solution ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85782]: Revision status changed
User Reedy changed the status of MediaWiki.r85782. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85782#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85577]: Revision status changed
User Catrope changed the status of MediaWiki.r85577. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85577#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85916]: Revision status changed
User Platonides changed the status of MediaWiki.r85916. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85916#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
2011/4/12 Krinkle krinklem...@gmail.com: Looks good, although I'm not sure what the advantage in this case is over using a page id. Both have the same disadvantage: * They are binding to a pageid instead of a pagename. Actually just recently i thought of a different idea. It looks like the Interlanguage extension is finally in the beginning of its way to being rolled out (see https://bugzilla.wikimedia.org/15607 ). Maybe this extension can be modified so that typing something like http://mul.wikipedia.org/wiki/Barack_Obama:ar will redirect to http://ar.wikipedia.org/wiki/باراك_أوباما. It wont make the name very short, but it will certainly be better than http://ar.wikipedia.org/wiki/%D8%A8%D8%A7%D8%B1%D8%A7%D9%83_%D8%A3%D9%88%D8%A8%D8%A7%D9%85%D8%A7 for sending by email or instant messaging. The advantage is that it will work for any language. The interlanguage wiki may have the names limited only to characters which don't have to undergo URL-encoding; this doesn't necessarily mean English. (mul is the ISO 639 code for multiple languages. There was no decision to give the future Interlanguage wiki this name; i just made it up. The domain can have any other name.) -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com We're living in pieces, I want to live in peace. - T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85579]: Revision status changed
User Catrope changed the status of MediaWiki.r85579. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85579#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85580]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r85580. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r85580. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85580#c15894 Comment: pre .text( mw.msg( 'articlefeedback-report-empty' ) ) - .end(); /pre Missing semicolon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added
User Freakolowsky posted a comment on MediaWiki.r85786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15895 Comment: The current state of MW oracle abstraction doesn't support quoted naming, because that makes object names case sensitive and not all of the code is currently written to work that way. So currently $wgDBprefix (and all other parts of object names) *should not* contain characters that need quoting. I'll add the parameter and use it in this case. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85786]: New comment added
User Platonides posted a comment on MediaWiki.r85786. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85786#c15896 Comment: Seems that it's the other code what should be fixed. I uppercased $wgDBprefix for you in r85920. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added
User Happy-melon posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15897 Comment: Commit summary? What is this? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85850]: Revision status changed
User Platonides changed the status of MediaWiki.r85850. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85850#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: Revision status changed
User Happy-melon changed the status of MediaWiki.r85922. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Centralize PHP (and other) minimum requirements / Move Defines.php up the call stack
Right now there's a few points: * Minimum php versions are all over the source code, putting it in DefaultSettings.php or Defines.php would make be a good start, that way all hardcoded uses of the versions after those are loaded can be centralized. However there are many php-versions compared before those are included as well ( all (web) entry points and other files parsed before the inclusion of DefaultSettings and/or Defines). So a better solution would be to get those versions available right at the beginning of the web entry points. Possible solutions: 1) Instead of putting the define() or $wg...= in DefaultSettings.php / Defines.php, create namethisfile.php and put them in there and include it in the all entry points. This seems like a simple and quick solution but introduces yet another always-included file and puts them far away from other global variables and defines. 2) Put it in Defines.php * make it independant (ie. only defines(), nothing else, as the filename suggests) * and move it up the call stack Things like inclusion of UtfNormalDefines could be put in the places where Defines.php is currenty included[1] and assignment of the $wgFeedClasses variable shouldn't be in Defines.php anyway. 3) Just put them in DefaultSettings.php and Defines.php and replace all uses with the globals where they are hardcoded and available. Any uses before this file is loaded (entry points) can hard code it The third solution is basically what I was going to do, and can be safely done. But before I do so I'd like to know if the solutions that cover all scenarios are do-able. -- Krinkle [1] UtfNormalDefines.php may not have to be moved though, looks good on second thought. It's included everywhere anyway so it doesn't save load by loading it later or earlier. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] ShortURL for Non Latin Mediawiki sites
This is just another instance of https://bugzilla.wikimedia.org/show_bug.cgi?id=21572 Note that there's javascript there for creating curid links, too. Note those urls may have caching problems. -1 to the base36 thing. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added
User DieBuche posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15898 Comment: Sorry for the comment less commit. Implement tbody, thead tfoot. Fixes Bug 4740 Original patch by bluehairedlaw...@gmail.com, rewritten at some places by me. ParserTests are changed to accommodate the new elements, but no parserTest `logic` is changed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: Revision status changed
User Happy-melon changed the status of MediaWiki.r85922. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Centralize PHP (and other) minimum requirements / MoveDefines.php up the call stack
Krinkle krinklem...@gmail.com wrote in message news:e4c549e9-a115-4afe-b030-3f57f2f9b...@gmail.com... Right now there's a few points: * Minimum php versions are all over the source code, putting it in DefaultSettings.php or Defines.php would make be a good start, that way all hardcoded uses of the versions after those are loaded can be centralized. However there are many php-versions compared before those are included as well ( all (web) entry points and other files parsed before the inclusion of DefaultSettings and/or Defines). So a better solution would be to get those versions available right at the beginning of the web entry points. Possible solutions: 1) Instead of putting the define() or $wg...= in DefaultSettings.php / Defines.php, create namethisfile.php and put them in there and include it in the all entry points. This seems like a simple and quick solution but introduces yet another always-included file and puts them far away from other global variables and defines. 2) Put it in Defines.php * make it independant (ie. only defines(), nothing else, as the filename suggests) * and move it up the call stack Things like inclusion of UtfNormalDefines could be put in the places where Defines.php is currenty included[1] and assignment of the $wgFeedClasses variable shouldn't be in Defines.php anyway. 3) Just put them in DefaultSettings.php and Defines.php and replace all uses with the globals where they are hardcoded and available. Any uses before this file is loaded (entry points) can hard code it The third solution is basically what I was going to do, and can be safely done. But before I do so I'd like to know if the solutions that cover all scenarios are do-able. -- Krinkle [1] UtfNormalDefines.php may not have to be moved though, looks good on second thought. It's included everywhere anyway so it doesn't save load by loading it later or earlier. To add some context here, in r85918 I made some changes to our handling of old PHP versions. Coaxing the PHP 4 parser to even get as far as letting us die() is quite a challenge, and just about every file in the codebase is incompatible with it (structures like wfFoo()-bar() are invalid, for instance). However, PHP 5 versions are equally broken: no version of PHP 5.2.3 that I tried (and I now have eight of them floating around :D) was able to load a page without a fatal error. What I have done is to move the PHP version check from WebStart.php (which was unparseable since Tim added a try/catch block in r85327) to the entry points index.php, api.php, load.php. That way, only those files have to be PHP 4 compatible. It is definitely worth doing this despite the age of PHP 4, because the error message that previously resulted (Parse error: unexpected T_CONST_FOOBAR or somesuch) is so spectacularly unhelpful that people are far more likely to just give up in disgust than actually realise even what the problem is. The issue this raises is that we now have the minimum supported PHP version hardcoded in at least six different places in the codebase. It would be nice to have it centralised in a define() constant, but any file that it's put in then needs to be kept PHP 4 compatible. The two options which stand out are either creating a new file for it, or putting it in Defines.php and moving that file to be included directly from the entry points, rather than from WebStart.php. The question is: are there any gotchas associated with moving that up the call stack? --HM ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] 回复： MediaWiki security release 1.16.3
库ukulm仍啊空说八宝山的人飞蛾
原信息
主题： [Wikitech-l] MediaWiki security release 1.16.3
发件人： Tim Starling tstarl...@wikimedia.org
日期： 2011/04/12 11:24
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I would like to announce the release of MediaWiki 1.16.3, which is a
security release. Three security issues were discovered.
Masato Kinugawa discovered a cross-site scripting (XSS) issue, which
affects Internet Explorer clients only, and only version 6 and
earlier. Web server configuration changes are required to fix this
issue. Upgrading MediaWiki will only be sufficient for people who use
Apache with AllowOverride enabled.
Due to the diversity of uploaded files that we allow, MediaWiki does
not guarantee that uploaded files will be safe if they are interpreted
by the client as some arbitrary file type, such as HTML. We rely on
the web server to send the correct Content-Type header, and we rely on
the web browser to respect it. This XSS issue arises due to IE 6
looking for a file extension in the query string of the URL (i.e.
after the ?), if no extension is found in path part of the URL.
Masato Kinugawa discovered that the file extension in the path part
can be hidden from IE 6 by substituting the . with %2E.
To fix this issue, configure your web server to deny requests with
URLs that have a path part ending in a dot followed by a dangerous
file extension. For example, in Apache with mod_rewrite:
RewriteEngine On
RewriteCond %{QUERY_STRING} \.[a-z]{1,4}$ [nocase]
RewriteRule . - [forbidden]
Upgrading MediaWiki is necessary to fix this issue in
dynamically-generated content. This issue is easier to exploit using
dynamically generated content, since it requires no special
privileges. Accounts on both public and private wikis can be
compromised by clicking a malicious link in an email or website. For
more details, see bug 28235.
Wikipedia user Suffusion of Yellow discovered a CSS validation error
in the wikitext parser. This is an XSS issue for Internet Explorer
clients, and a privacy loss issue for other clients since it allows
the embedding of arbitrary remote images. For more details, see bug 28450.
MediaWiki developer Happy-Melon discovered that the transwiki import
feature neglected to perform access control checks on form submission.
The transwiki import feature is disabled by default. If it is enabled,
it allows wiki pages to be copied from a remote wiki listed in
$wgImportSources. The issue means that any user can trigger such an
import to occur. For more details, see bug 28449.
The localisations were updated using content from translatewiki.net.
**
Download:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.3.tar.gz
Patch to previous version (1.16.2), without interface text:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.3.patch.gz
Interface text changes:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-i18n-1.16.3.patch.gz
GPG signatures:
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.3.tar.gz.sig
http://download.wikimedia.org/mediawiki/1.16/mediawiki-1.16.3.patch.gz.sig
http://download.wikimedia.org/mediawiki/1.16/mediawiki-i18n-1.16.3.patch.gz.sig
Public keys:
https://secure.wikimedia.org/keys.html
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEUEARECAAYFAk2jxbAACgkQgkA+Wfn4zXn38gCWISDEZuC+Ap3Z4aBfibnuNSU1
EgCfeL2lo/4XtCuoKOwah0YbuaHyf5I=
=S2JZ
-END PGP SIGNATURE-
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Centralize PHP (and other) minimum requirements / MoveDefines.php up the call stack
On Tue, Apr 12, 2011 at 4:30 PM, Happy-melon happy-me...@live.com wrote: To add some context here, in r85918 I made some changes to our handling of old PHP versions. Coaxing the PHP 4 parser to even get as far as letting us die() is quite a challenge, and just about every file in the codebase is incompatible with it (structures like wfFoo()-bar() are invalid, for instance). However, PHP 5 versions are equally broken: no version of PHP 5.2.3 that I tried (and I now have eight of them floating around :D) was able to load a page without a fatal error. What I have done is to move the PHP version check from WebStart.php (which was unparseable since Tim added a try/catch block in r85327) to the entry points index.php, api.php, load.php. That way, only those files have to be PHP 4 compatible. Do note though that there's no reason that all that PHP 5 code has to actually be in the entry point and WebStart.php files. They could simply look like: ?php // Check version compatibility; on PHP 4 try redirecting to index.php5, or on old PHP 5 whinge about incompat. require './includes/MWVersionCheck.php'; // The real code below may contain structures that can't be parsed by the older code, so sits in another file. require './includes/do_index.php'; Then the version checks and redirection logic can all be encapsulated in one place. However it may be a reasonable simplification to drop the .php5 files and magic redirection for PHP 4, and just worry about index.php and the installer index.php detecting PHP 4 and throwing up an error message. Then only index.php needs to be PHP4-parseable, and the rest need only parse on PHP 5 and make it to the version check. It should be a very rare case these days that .php files get run through PHP 4 by default with no way to change it; PHP 5 is many years old and very standard. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] About to commit improved DB2 database support
On 04/12/2011 12:32 PM, Leons Petrazickis wrote: I've been informally mentoring André, Tiago, Diego, and César. They are four students at Minho University who are currently working on a project to improve DB2 database support in MediaWiki. Thank you and congrats to your four students! -Sumana ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c15899 Comment: Strict Standards: Only variables should be passed by reference in D:\www\MW_trunk\phase3\includes\parser\Parser.php on line 880 Please use E_ALL | E_STRICT for PHP errors. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85922. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Syntax-highlighting JS CSS code editor gadget embedding Ace
How about disable the editable mode when user views source (if he/she can not edit the page)? 2011/4/13 Brion Vibber br...@pobox.com While pondering some directions for rapid prototyping of new UI stuff, I found myself lamenting the difficulty of editing JS and CSS code for user/site scripts and gadgets: * lots of little things to separately click and edit for gadgets * no syntax highlighting in the edit box * no indication of obvious syntax errors, leading to frequent edit-preview cycles (especially if you have to turn the gadget back off to edit successfully!) * no automatic indentation! * can't use the tab key Naturally, I thought it might be wise to start doing something about it. I've made a small gadget script which hooks into editing of JS and CSS pages, and embeds the ACE code editor (http://ace.ajax.org -- a component of the Cloud9 IDE, formerly Skywriter formerly Mozilla Bespin). This doesn't fix the usability issues in Special:Gadgets, but it's a heck of a lot more pleasant to edit the gadget's JS and CSS once you get there. :) The gadget is available on www.mediawiki.org on the 'Gadgets' tab of preferences. Note that I'm currently loading the ACE JavaScript from toolserver.org, so you may see a mixed-mode content warning if you're editing via secure.wikimedia.org. (Probably an easy fix.) Go try it out! http://www.mediawiki.org/wiki/MediaWiki:Gadget-CodeEditor.js IE 8 kind of explodes and I haven't had a chance to test IE9 yet, but it seems pretty consistently nice on current Firefox and Chrome and (barring some cut-n-paste troubles) Opera. I'd really love to be able to use more content-specific editing tools like this, and using Gadgets is a good way to make this sort of tool available for testing in a real environment -- especially once we devise some ways to share gadgets across all sites more easily. I'll be similarly Gadget-izing the SVG-Edit widget that I've previously done as an extension so folks can play with it while it's still experimental, but we'll want to integrate them better as time goes on. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Syntax-highlighting JS CSS code editor gadget embedding Ace
I never liked jsLint... tries to enforce some overzealous conventions. I've seen some comments on JSHint. Haven't tried it, but it looks nice, lets you decide your coding standard. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On 11-04-12 08:50 PM, Ryan Kaldari wrote: Awesome. It seems to work well in FF4. Now we just need to tack on a jsLint button :) (Although we would have to get an exception to their good not evil licensing clause!) Ryan Kaldari On 4/12/11 5:40 PM, Brion Vibber wrote: While pondering some directions for rapid prototyping of new UI stuff, I found myself lamenting the difficulty of editing JS and CSS code for user/site scripts and gadgets: * lots of little things to separately click and edit for gadgets * no syntax highlighting in the edit box * no indication of obvious syntax errors, leading to frequent edit-preview cycles (especially if you have to turn the gadget back off to edit successfully!) * no automatic indentation! * can't use the tab key Naturally, I thought it might be wise to start doing something about it. I've made a small gadget script which hooks into editing of JS and CSS pages, and embeds the ACE code editor (http://ace.ajax.org -- a component of the Cloud9 IDE, formerly Skywriter formerly Mozilla Bespin). This doesn't fix the usability issues in Special:Gadgets, but it's a heck of a lot more pleasant to edit the gadget's JS and CSS once you get there. :) The gadget is available on www.mediawiki.org on the 'Gadgets' tab of preferences. Note that I'm currently loading the ACE JavaScript from toolserver.org, so you may see a mixed-mode content warning if you're editing via secure.wikimedia.org. (Probably an easy fix.) Go try it out! http://www.mediawiki.org/wiki/MediaWiki:Gadget-CodeEditor.js IE 8 kind of explodes and I haven't had a chance to test IE9 yet, but it seems pretty consistently nice on current Firefox and Chrome and (barring some cut-n-paste troubles) Opera. I'd really love to be able to use more content-specific editing tools like this, and using Gadgets is a good way to make this sort of tool available for testing in a real environment -- especially once we devise some ways to share gadgets across all sites more easily. I'll be similarly Gadget-izing the SVG-Edit widget that I've previously done as an extension so folks can play with it while it's still experimental, but we'll want to integrate them better as time goes on. -- brion -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Syntax-highlighting JS CSS code editor gadget embedding Ace
Yes, JSHint looks more reasonable, although it inherits the same good not evil license-cruft. Sigh. Ryan Kaldari On 4/12/11 9:20 PM, Daniel Friesen wrote: I never liked jsLint... tries to enforce some overzealous conventions. I've seen some comments on JSHint. Haven't tried it, but it looks nice, lets you decide your coding standard. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On 11-04-12 08:50 PM, Ryan Kaldari wrote: Awesome. It seems to work well in FF4. Now we just need to tack on a jsLint button :) (Although we would have to get an exception to their good not evil licensing clause!) Ryan Kaldari On 4/12/11 5:40 PM, Brion Vibber wrote: While pondering some directions for rapid prototyping of new UI stuff, I found myself lamenting the difficulty of editing JS and CSS code for user/site scripts and gadgets: * lots of little things to separately click and edit for gadgets * no syntax highlighting in the edit box * no indication of obvious syntax errors, leading to frequent edit-preview cycles (especially if you have to turn the gadget back off to edit successfully!) * no automatic indentation! * can't use the tab key Naturally, I thought it might be wise to start doing something about it. I've made a small gadget script which hooks into editing of JS and CSS pages, and embeds the ACE code editor (http://ace.ajax.org -- a component of the Cloud9 IDE, formerly Skywriter formerly Mozilla Bespin). This doesn't fix the usability issues in Special:Gadgets, but it's a heck of a lot more pleasant to edit the gadget's JS and CSS once you get there. :) The gadget is available on www.mediawiki.org on the 'Gadgets' tab of preferences. Note that I'm currently loading the ACE JavaScript from toolserver.org, so you may see a mixed-mode content warning if you're editing via secure.wikimedia.org. (Probably an easy fix.) Go try it out! http://www.mediawiki.org/wiki/MediaWiki:Gadget-CodeEditor.js IE 8 kind of explodes and I haven't had a chance to test IE9 yet, but it seems pretty consistently nice on current Firefox and Chrome and (barring some cut-n-paste troubles) Opera. I'd really love to be able to use more content-specific editing tools like this, and using Gadgets is a good way to make this sort of tool available for testing in a real environment -- especially once we devise some ways to share gadgets across all sites more easily. I'll be similarly Gadget-izing the SVG-Edit widget that I've previously done as an extension so folks can play with it while it's still experimental, but we'll want to integrate them better as time goes on. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Syntax-highlighting JS CSS code editor gadget embedding Ace
How about Google's Closure Compiler? Don't need the minification but it does seam to give errors and warnings for code. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On 11-04-12 09:38 PM, Ryan Kaldari wrote: Yes, JSHint looks more reasonable, although it inherits the same good not evil license-cruft. Sigh. Ryan Kaldari On 4/12/11 9:20 PM, Daniel Friesen wrote: I never liked jsLint... tries to enforce some overzealous conventions. I've seen some comments on JSHint. Haven't tried it, but it looks nice, lets you decide your coding standard. ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] On 11-04-12 08:50 PM, Ryan Kaldari wrote: Awesome. It seems to work well in FF4. Now we just need to tack on a jsLint button :) (Although we would have to get an exception to their good not evil licensing clause!) Ryan Kaldari On 4/12/11 5:40 PM, Brion Vibber wrote: While pondering some directions for rapid prototyping of new UI stuff, I found myself lamenting the difficulty of editing JS and CSS code for user/site scripts and gadgets: * lots of little things to separately click and edit for gadgets * no syntax highlighting in the edit box * no indication of obvious syntax errors, leading to frequent edit-preview cycles (especially if you have to turn the gadget back off to edit successfully!) * no automatic indentation! * can't use the tab key Naturally, I thought it might be wise to start doing something about it. I've made a small gadget script which hooks into editing of JS and CSS pages, and embeds the ACE code editor (http://ace.ajax.org -- a component of the Cloud9 IDE, formerly Skywriter formerly Mozilla Bespin). This doesn't fix the usability issues in Special:Gadgets, but it's a heck of a lot more pleasant to edit the gadget's JS and CSS once you get there. :) The gadget is available on www.mediawiki.org on the 'Gadgets' tab of preferences. Note that I'm currently loading the ACE JavaScript from toolserver.org, so you may see a mixed-mode content warning if you're editing via secure.wikimedia.org. (Probably an easy fix.) Go try it out! http://www.mediawiki.org/wiki/MediaWiki:Gadget-CodeEditor.js IE 8 kind of explodes and I haven't had a chance to test IE9 yet, but it seems pretty consistently nice on current Firefox and Chrome and (barring some cut-n-paste troubles) Opera. I'd really love to be able to use more content-specific editing tools like this, and using Gadgets is a good way to make this sort of tool available for testing in a real environment -- especially once we devise some ways to share gadgets across all sites more easily. I'll be similarly Gadget-izing the SVG-Edit widget that I've previously done as an extension so folks can play with it while it's still experimental, but we'll want to integrate them better as time goes on. -- brion -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85939]: New comment added
User NeilK posted a comment on MediaWiki.r85939. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85939#c15901 Comment: This is less clear than it should be -- the only intended changes were for Wiki.php. Everything else reverted in r85940. Probably should have reverted everything and started over, but it's done now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
