Re: [Wikitech-l] IRC Bug Triage
On 28 June 2011 01:28, Mark A. Hershberger mhershber...@wikimedia.org wrote: Tomorrow is the first IRC bug triage (finally!). We'll start the meeting at 2300 UTC (see http://hexm.de/44 for the UTC impaired, like myself). Does tomorrow mean Tuesday - today for me? Better to always include the date too. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90915]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90915. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90915#c18850 Commit summary: Added formatTimePeriod() tests for r90385 and made some fixes Comment: This doesn't look right: pre + $this-assertEquals( + 3d 0h 0m, + $this-lang-formatTimePeriod( 259199.55, 'avoidseconds' ), + 'formatTimePeriod() rounding (48h), avoidminutes' + ); /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90936]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90936. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90936#c0 Commit summary: Use content language in formatting of dates in revertpage message (rollback revert edit summary) and do not adjust for user timezone. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90819]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90819. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c0 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805, XOR passed iff an odd number of subconds passed. It now passes iff exactly one subcond passes. This should be more intuitive, as I highly doubt anyone using 3+ subconds was doing it correctly before. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90812]: Revision status changed
User Hashar changed the status of MediaWiki.r90812. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90812#c0 Commit summary: Removing console.log and other ad-hoc debugging code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90945]: Revision status changed
User Hashar changed the status of MediaWiki.r90945. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90945#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90844]: Revision status changed
User Hashar changed the status of MediaWiki.r90844. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90844#c0 Commit summary: Followup r90839, de-capitali[sz]e api parameter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Reproducing localurl by python urllib.quote()
2011/6/27 Platonides platoni...@gmail.com The relevant function is Title::getLocalURL() I think that in your quote function you need to skip '@$*(),' as well, and .-_ wouldn't be needed there (but urllib.quote could differ from php urlencode). See wfUrlEncode in GlobalFunctions.php Thanks Platonidea, I'll test localurl for your character list. In the meantime, I found that my one was a rather silly question since any html link to wiki pages from mediawiki software has this kind of code: a href=/wiki/Portal:Children%27s_literature title=Portal:Children's literaturePortal:Children's literature/a. t.i., there is both the escaped version of the title of the page into href attribute, and the not-escaped version of the name of the page, inside the title attribute; the latter being mush simpler as a key to select links. :-) Alex ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Server outage
We are currently having a widespread failure with no one on IRC John ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90939]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90939. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90939#c0 Commit summary: very minor clean-up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Server outage
What this message is talking about: Issues with the S4 and S6 clusters. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90940]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90940. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90940#c0 Commit summary: fix bug 29619 - some magic words not working in preview ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86088]: New comment added
User TheDJ posted a comment on MediaWiki.r86088.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86088#c18851
Commit summary:
Completely rewritten table sorting script.
Fixes Bug 8028, Bug 8115, Bug 15406, Bug 17141, Bug 8732
1. Sites can specify custom collations.
The script accepts an object tableSorterCollation which contains a lookup
table, how specific characters should be treated.
For example, after setting tableSorterCollation={'ä':'ae', 'ß':'ss'}; in the
site's common.js any string containing an ä or Ä will be sorted as if it were a
'ae'.
2. Table rows can be forced to use a specific data type.
By setting class=sort-{Parsername}, the row will be parsed with the specified
algorithm. class=sort-date would force date sorting etc.
The following parsers are available: text, IPAddress, number, url, currency,
date, isoDate, usLongDate, time
3. Execution time is reduced by half or more.
Sorting a 935 row * 8 columns table:
Browser Before After
-- -
Chrome 10 90ms42ms
Safari 5115ms 48ms
Firefox 4 412ms 87ms
IE8 720ms 115ms
4. Based on the content language and the mdy vs dmy preference, the parser can
understand dates such as 17. März '11. wgMonthNames=[] and
wgMonthNamesShort=[]
in the content language and the mdy vs dmy preference are exported to js; A
table containing the following dates would be sorted correctly:
17. Jan. 01
23 Feb 1992
9.02.05
13 November 2001
14 Oktober '76
Was tested in ie6-8, chrome, safari 5, ff3 ff4
Comment:
FYI, this breaks sortbottom behavior, because we have no tfoot support in
wikitables yet.
See also: bug 4740
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90944]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90944. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90944#c0 Commit summary: adding example for custom image field, so that it isnt as mysterious ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90938]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90938. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90938#c0 Commit summary: committing photoshop source file for icon images (so people can make more if they want) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90960]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r90960. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r90960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90960#c18856 Commit summary: Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki Comment: PHP Warning: filemtime(): stat failed for /www/w/resources/mediawiki.special/mediawiki.special.js in /www/w/includes/resourceloader/ResourceLoaderFileModule.php on line 369 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90960]: Revision status changed
User Catrope changed the status of MediaWiki.r90960. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90960#c0 Commit summary: Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90960]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r90960. Old Status: new New Status: fixme User Hashar also posted a comment on MediaWiki.r90960. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90960#c18857 Commit summary: Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki Comment: The path got changed meantime. I have originally added the mediawiki.special.js file in: resources/mediawiki/ Catrope moved it to the same place the .css is: resources/mediawiki.special/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90960]: Revision status changed
User Catrope changed the status of MediaWiki.r90960. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90960#c0 Commit summary: Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90967]: New comment added
User JanPaul123 posted a comment on MediaWiki.r90967. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c18858 Commit summary: Followup r90958 for Translatewiki Comment: Ah, I deliberately added the Commons url so that people can change it to a localised Main Page or instructions page on Commons. Is this the right way to go or not? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90967]: New comment added
User JanPaul123 posted a comment on MediaWiki.r90967. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c18859 Commit summary: Followup r90958 for Translatewiki Comment: Also, shouldn't this be under Wiki Love instead of Wikilog? ^_^ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90967]: New comment added
User Raymond posted a comment on MediaWiki.r90967. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c18860 Commit summary: Followup r90958 for Translatewiki Comment: Thanks for the explanation. I have changed the key to optional with r90975. Best to add these kind of explanation in the qqq section too (or feel free to edit http://translatewiki.net/wiki/MediaWiki:Wikilove-commons-url/qqq ). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r90943.
Old Status: new
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r90943.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18863
Commit summary:
Disable ns selector checkboxes when 'all' namespace is selected
* based on an idea by Aaron on r90866
* comes with QUnit test
* expect the special 'all' namespace to be the first in the list
* function build on mediawiki.special form r90941
Comment:
pre
+module( 'mediawiki.special.preferences.js' );
/pre
There is no test suite by that name. Causes black holes on the
[http://toolserver.org/~krinkle/testswarm/user/MediaWiki TestSwarm].
pre
+( function( $, mw ) {
+}(jQuery, mediaWiki ) );
+ ok( mediaWiki.special.recentchanges.init,
/pre
codemw/code is a global alias, you can use it directly.
pre
+ this.select = $( 'select#namespace' );
+ $( 'input#'+id ).attr( 'disabled', isAllNS );
+ strictEqual( $('input#nsinvert').attr('disabled'), enabled);
/pre
IDs should be unique, if they aren't then only one will match the ID selector.
Passing a tagname doens't help other than slowing down the selector.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90981]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90981. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90981#c0 Commit summary: * Fixed documentation * Added GPL header ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90967]: New comment added
User JanPaul123 posted a comment on MediaWiki.r90967. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c18865 Commit summary: Followup r90958 for Translatewiki Comment: Good point, I'll update the qqq section. Thanks for the swift response! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87005]: New comment added
User ✓ posted a comment on MediaWiki.r87005. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87005#c18866 Commit summary: TableSorter: Allow whitespace between digits and percent sign. Fixes Bug 28406 Comment: It allows whitespaces. In short: /\d+\s*%?/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90964]: Revision status changed
User Krinkle changed the status of MediaWiki.r90964. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90964#c0 Commit summary: Fixed bug 28968. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79559]: Revision status changed
User ^demon changed the status of MediaWiki.r79559. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79559#c0 Commit summary: *sigh* I was looking at parser tests, but not notices in a site this time... Followup r79558 fix a small php notice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90971]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90971. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90971#c0 Commit summary: Added id attribute for the li tag of toolbar ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90960]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90960. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90960#c0 Commit summary: Fix r90943: redefined mediawiki.special module that had already been added in r83789 (!), broke loading of special page-specific CSS by addModuleStyles( 'mediawiki.special' ) . Bug originally reported by Nikerabbit as lack of CSS on Special:Search on TranslateWiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90978]: New comment added
User ^demon posted a comment on MediaWiki.r90978. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90978#c18868 Commit summary: Comment: I gave up asking. And Yaron said he's not using CR for this GSoC project anyway, so I wouldn't lose sleep over it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18869 Commit summary: Disable ns selector checkboxes when 'all' namespace is selected * based on an idea by Aaron on r90866 * comes with QUnit test * expect the special 'all' namespace to be the first in the list * function build on mediawiki.special form r90941 Comment: ''mw is a global alias, you can use it directly.'' :Aliasing global variables to a local variable is a common JS pattern; it can allow the JS engine to better optimize lookup (don't have to bump back multiple levels of scoping context every time it's referenced; can potentially be better assured that the value won't change depending on how much of the code the optimizer sees at once). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90966]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r90966. Old Status: new New Status: ok User ^demon also posted a comment on MediaWiki.r90966. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90966#c18870 Commit summary: New eqiad subnets Comment: Comments still say pmtpa. Don't know how much you care about comments :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90904]: Revision status changed
User ^demon changed the status of MediaWiki.r90904. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90904#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-27 20:14:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90983]: Revision status changed
User ^demon changed the status of MediaWiki.r90983. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90983#c0 Commit summary: Added qqq comment per suggestion in r90967. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90982]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90982. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90982. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90982#c18871 Commit summary: mw.special.recentchanges fixes: - using mw globally directly - ID-selectors - JS Effeciency in mw.special.rc.init (chaining instead of re-getting from this.select) - passing function by reference instead of calling inside a new anonymous function - marking checkboxes a private/local variable - whitespace conventions Follows up: r90943 r90960 r90968 r90980 Comment: Cleanup seems ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18872 Commit summary: Disable ns selector checkboxes when 'all' namespace is selected * based on an idea by Aaron on r90866 * comes with QUnit test * expect the special 'all' namespace to be the first in the list * function build on mediawiki.special form r90941 Comment: Test issues seem to have been cleaned up, and Krinkle made some style tweaks as well. It still though assumes that 'all' is the first item -- shouldn't it just check the value of the selected option? '' means none/all, whereas a number means some particular namespace. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18873 Commit summary: Disable ns selector checkboxes when 'all' namespace is selected * based on an idea by Aaron on r90866 * comes with QUnit test * expect the special 'all' namespace to be the first in the list * function build on mediawiki.special form r90941 Comment: oh wikitext. :) make that ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80094]: Revision status changed
User ^demon changed the status of MediaWiki.r80094. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80094#c0 Commit summary: * Use $wgScript for the action parameter to not break ugly URLs * Removed another instance of $wgTitle ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79994]: Revision status changed
User ^demon changed the status of MediaWiki.r79994. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79994#c0 Commit summary: No need to check once more for a correct oldid, it's already passed with the correct value ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79383]: New comment added
User Reedy posted a comment on MediaWiki.r79383. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79383#c18874 Commit summary: Merging Vector's navigation_urls and SkinTemplate's content_actions code into content_navigation. content_actions is now built by folding content_navigation and cleaning it up a bit. content_actions hooks no longer work and have been dropped from the code, the hooks that affected vector before now affect all skins. A few logic changes were made to make for a clean merge: - vector was using vector-???-??? messages while SkinTemplate was using '???' messages. So as a side effect of merging that together all skins now support messages like '$skinname-view-history' which will fallback to the standard message if not defined. - For MediaWiki: pages where the page does not exist but the message does in the i18n system SkinTemplate displayed Edit while Vector displayed Create; All skins now display Edit. - For users without undelete permissions SkinTemplate displayed an Undelete tab if the user had deletedhistory and deletedtext permissions. Vector would only display the tab for users with both deletedhistory and undelete permissions; The new behavior in all skins is to always display a tab if you have deletedhistory (since Special:Undelete will always have something to display) but display a View ... deleted instead of Undelete message if you do not have undelete permissions. - Skins no longer need to hardcode tests for the action= to decide if they should ignore the accesskey on some tabs, tabs which should not have an accesskey in the current page now have a tooltiponly key set to true. Comment: RELEASE-NOTE are needed for the hook rename ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90984]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90984. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90984#c18875 Commit summary: mw.special.recentchanges fixes: - Partial self-revert of r90982 (binding and triggering must not be chained, as the calling function refers to the variable we're setting) - The Qunit tests pass now :) Follows up: r90943 r90960 r90968 r90980 r90982 Comment: To clarify -- there is '''no problem''' with both binding and triggering something in a chained manner. The problem was failing to set rc.$select until after triggering the event, which could cause the handler to be called and attempt to reference rc.$select. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90906]: Revision status changed
User Catrope changed the status of MediaWiki.r90906. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90906#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-27 20:21:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90947]: Revision status changed
User Catrope changed the status of MediaWiki.r90947. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90947#c0 Commit summary: wlil_success boolean should NOT be NULL, as then we would have the values TRUE, FALSE, NULL, which is ambiguous... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90984]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90984. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90984. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90984#c18876 Commit summary: mw.special.recentchanges fixes: - Partial self-revert of r90982 (binding and triggering must not be chained, as the calling function refers to the variable we're setting) - The Qunit tests pass now :) Follows up: r90943 r90960 r90968 r90980 r90982 Comment: This commit also moves the RC special page info setup to the top to force it to load sooner; seems ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85296]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r85296. Old Status: fixme New Status: resolved User ^demon also posted a comment on MediaWiki.r85296. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85296#c18877 Commit summary: Add a getSkin that returns a dummy linker for BC with extensions still abusing it to access the linker. Comment: I agree, and I've fixed REL1_18 in r90987. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84279]: New comment added
User ^demon posted a comment on MediaWiki.r84279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84279#c18878 Commit summary: Follow-ups to r84258 Comment: +1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84258]: New comment added
User ^demon posted a comment on MediaWiki.r84258. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84258#c18879 Commit summary: More cleanup in Block.php. Push Block::encodeExpiry() and Block::decodeExpiry() deeper into the callstack, to DatabaseBase for encode and Language for decode. The vast majority of callers of these functions are not handling block expiries, but expiries generally, particularly page protections. Comment: preI've had a go at building a static method at the Database level for this, but it just seems more ugly still./pre I really don't see what the problem was here. The implementations are identical for all subclasses except DatabaseMssql anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85302]: New comment added
User ^demon posted a comment on MediaWiki.r85302. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85302#c18880 Commit summary: Instead of creating an OutputPage and then setting a context start initializing OutputPages 'with' a context and send depreciated calls to extensions directly creating OutputPage instances. Now that we've taken care of the mess of mTitle inside OutputPage and Skin and made RequestContext track Skin instead of $wgUser we don't need the hack in SpecialPage anymore. Comment: Even more reason to not deprecate things so quickly...most people '''don't''' have that enabled. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85324]: Revision status changed
User ^demon changed the status of MediaWiki.r85324. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85324#c0 Commit summary: Styling for revdel'd revision links for oversighters/admins: make the links still be greyed out, but still active and with underline-on-hover. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90989]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90989. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90989#c0 Commit summary: Revert r85324 (making links grey for rev-del'd info). Per CR: grey is a bad color for links. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90988]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90988#c0 Commit summary: Added some GPL headers ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90985]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90985. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90985#c0 Commit summary: module name is not shortened ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90987]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90987. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90987#c0 Commit summary: Per siebrand on r85296, the proper path to deprecation is: 1) Behavior/doc change 2) Then warnings 3) Then removal 1 and 2 were rolled into the same release (1.18), so revert the wfDeprecated() call in REL1_18. Trunk can still spew warnings, and we shouldn't look to remove until sometime in the 1.20 timeframe. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90975]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90975. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90975#c0 Commit summary: Followup r90958 for Translatewiki and fix for r90967 per JanPaul's CE: * Use correct section Wiki Love, not Wiki Log * Make 'wikilove-commons-url' optional. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90980]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90980. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90980#c0 Commit summary: Update qunit test runner includes for mediawiki.special.js move in r90968 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90967]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90967. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c0 Commit summary: Followup r90958 for Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90864]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90864. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90864#c18881 Commit summary: Babel CSS: follow the content direction instead of the user language direction (support for $wgBetterDirectionality) Comment: Why is this file not just loaded through resource loader like everything else? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90873]: Revision status changed
User Krinkle changed the status of MediaWiki.r90873. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90873#c0 Commit summary: Added gallery height attribute ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79871]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r79871. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79871#c0 Commit summary: Added QuickTemplate::getSkin(), useful for extensions when executing hooks passing only the template as parameter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80792]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r80792. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80792#c0 Commit summary: adding links to other skins in mediaWiki JS test suite. (Previously making sure everything works in all skins was a PITA ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90632]: Revision status changed
User Catrope changed the status of MediaWiki.r90632. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90632#c0 Commit summary: Fixed event names so they aren't so insane! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added
User Hashar posted a comment on MediaWiki.r90943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18882 Commit summary: Disable ns selector checkboxes when 'all' namespace is selected * based on an idea by Aaron on r90866 * comes with QUnit test * expect the special 'all' namespace to be the first in the list * function build on mediawiki.special form r90941 Comment: Yes wikitext. That is why I assumed it as the first element. r90990 makes it look per value as you suggested. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90990]: New comment added
User Hashar posted a comment on MediaWiki.r90990. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c18883 Commit summary: Find 'all' special ns regardless of its rank in the select This is done by looking for an option element with an empty string value which denote the special case 'all'. Also removed a comment in Xml.php asking to keep 'all' as a first element since it is no longer needed. Follow up r90943 (comment 18872 by Brion) Comment: Qunit tests pass on my local machine. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90994]: Revision status changed
User ^demon changed the status of MediaWiki.r90994. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90994#c0 Commit summary: Localization update for he. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90995]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r90995. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90995#c0 Commit summary: Revert of changes in r90288 - changes of else if to elseif are fine in PHP code, but not in Javascript code (which has no elseif) - and these were all in Javascript code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81587]: Revision status changed
User ^demon changed the status of MediaWiki.r81587. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81587#c0 Commit summary: * Converted ConfirmAccount to use RL * Avoid breaking filecache fallback if DB is down * Fixed special page alias notice ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90540]: Revision status changed
User Awjrichards changed the status of MediaWiki.r90540. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90540#c0 Commit summary: Added table cell centering to stylesheet ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84427]: Revision status changed
User ^demon changed the status of MediaWiki.r84427. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84427#c0 Commit summary: Ugly bug 24375 hack ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] should we join the Unicode Constortium?
BTW, I found out that liaison membership in the Unicode Consortium is free (and doesn't require us to do anything specifically). You just have to convince them that the membership would be beneficial to both organizations. Since it sounds like no one objects, I'd be happy to go ahead and write something up and get in touch with them about it. Ryan Kaldari On 6/27/11 6:18 PM, jida...@jidanni.org wrote: AG == Aryeh Gregorsimetrical+wikil...@gmail.com writes: AG It looks like it would cost $7,900 a year in dues I think that would set a bad precedent for the way you fellows spend your money. Next thing you know people will say you joined A, now why don't you join B, even more worthy, etc. P.S., It is spelled Consortium. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90997]: Revision status changed
User ^demon changed the status of MediaWiki.r90997. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90997#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-28 21:03:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90921]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r90921. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r90921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90921#c18884 Commit summary: use new $wgExiv2Command global. Already defined in DefaultSettings so in default/unix case, no need to redefine it. Comment: If this is already set in DefaultSettings, why are you overriding it here? Same thing with $wgImageMagickConvertCommand. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90921]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r90921. Old Status: fixme New Status: ok User ^demon also posted a comment on MediaWiki.r90921. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90921#c18885 Commit summary: use new $wgExiv2Command global. Already defined in DefaultSettings so in default/unix case, no need to redefine it. Comment: Yeah ignore me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Code Review for 1.18
The number of un-reviewed revisions for 1.18 has dropped below 500 for all of /trunk and below 200 for phase3: mysql select count(*),cr_status from code_rev where cr_repo_id = 1 \ and cr_id 47450 and cr_id 87529 and cr_path like \ '/trunk%' group by cr_status; +--+---+ | count(*) | cr_status | +--+---+ |13951 | deferred | | 82 | fixme | | 339 | new | |16534 | ok| | 1240 | old | | 1585 | resolved | | 793 | reverted | +--+---+ 7 rows in set (0.06 sec) mysql This is great news! From this and http://toolserver.org/~robla/crstats/crstats.118all.html, It looks like we *could* drive the number of “new” revisions to 0 by the end of the week. That would be stunning. Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90996]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90996. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90996#c18886 Commit summary: Comment: Please always write a commit message. Extension messages should be prefixed to avoid conflict with core messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] IRC Bug Triage
Niklas Laxström niklas.laxst...@gmail.com writes: On 28 June 2011 01:28, Mark A. Hershberger mhershber...@wikimedia.org wrote: Tomorrow is the first IRC bug triage (finally!). We'll start the meeting at 2300 UTC (see http://hexm.de/44 for the UTC impaired, like myself). Does tomorrow mean Tuesday - today for me? Better to always include the date too. Sorry, yes. And now it is only 1.5 hours away. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91018]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r91018. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91018#c0 Commit summary: Use title accessor ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79417]: New comment added
User Helder.wiki posted a comment on MediaWiki.r79417. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/79417#c18887 Commit summary: Make LiquidThreads use relative URLs instead of absolute URLs. Fixes bug #26526 Comment: Could someone replicate these fixes to the version which is in use on Portuguese Wikibooks? I'm still seeing the icons on pages like [https://secure.wikimedia.org/wikibooks/pt/w/index.php?uselang=entitle=Wikilivros:LiquidThreads#Opini.C3.B5es.2C_testes_e_relatos_de_bugs this] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added
User Nikerabbit posted a comment on MediaWiki.r86705. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c1 Commit summary: * Remove manual query building in search mysql * Remove reference to mysql3, no longer supported * Changed method signatures, I found no class extending this class in extensions * Tested lightly and returns same results Comment: php phpunit.php includes/search/SearchDbTest.php PHPUnit 3.5.14 by Sebastian Bergmann. . Time: 13 seconds, Memory: 75.00Mb OK (5 tests, 16 assertions) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91019]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r91019. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91019#c0 Commit summary: Use getLatest() accessor ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added
User ^demon posted a comment on MediaWiki.r86705. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18889 Commit summary: * Remove manual query building in search mysql * Remove reference to mysql3, no longer supported * Changed method signatures, I found no class extending this class in extensions * Tested lightly and returns same results Comment: Sounds like you might be missing some files there in phpunit, not our suite. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added
User ^demon posted a comment on MediaWiki.r86705. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18890 Commit summary: * Remove manual query building in search mysql * Remove reference to mysql3, no longer supported * Changed method signatures, I found no class extending this class in extensions * Tested lightly and returns same results Comment: I've got the same failure as Brion, both Sqlite and Mysql. Problem is $this-db isn't defined until run(). Could possibly try moving that back into setUp() again, but it broke horribly last time I tried. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90925]: Revision status changed
User Platonides changed the status of MediaWiki.r90925. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90925#c0 Commit summary: Follow-up r90742: the parser should call getFunctionLang() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90795]: Revision status changed
User Reedy changed the status of MediaWiki.r90795. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90795#c0 Commit summary: Follow-up r90792: typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90795]: Revision status changed
User Reedy changed the status of MediaWiki.r90795. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90795#c0 Commit summary: Follow-up r90792: typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90792]: Revision status changed
User Reedy changed the status of MediaWiki.r90792. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90792#c0 Commit summary: Extension to load a different version of jQuery without hacking core. Hooks into startup module and loads a WikiModule for MediaWiki:JQuery.js instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90990]: Revision status changed
User Krinkle changed the status of MediaWiki.r90990. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c0 Commit summary: Find 'all' special ns regardless of its rank in the select This is done by looking for an option element with an empty string value which denote the special case 'all'. Also removed a comment in Xml.php asking to keep 'all' as a first element since it is no longer needed. Follow up r90943 (comment 18872 by Brion) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90740]: Revision status changed
User Reedy changed the status of MediaWiki.r90740. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90740#c0 Commit summary: Export special page alias for 'fa' for bug 29563 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90681]: Revision status changed
User Reedy changed the status of MediaWiki.r90681. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90681#c0 Commit summary: trimming all lines to 80 chars per coding conventions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90990]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90990. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c18892 Commit summary: Find 'all' special ns regardless of its rank in the select This is done by looking for an option element with an empty string value which denote the special case 'all'. Also removed a comment in Xml.php asking to keep 'all' as a first element since it is no longer needed. Follow up r90943 (comment 18872 by Brion) Comment: Shortcut: you can just use $select.val() rather than diving in to find the selected option element manually. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90991]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90991. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90991#c0 Commit summary: rename test for the ns selector checkboxes follow up r90943 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90943. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r90943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18893 Commit summary: Disable ns selector checkboxes when 'all' namespace is selected * based on an idea by Aaron on r90866 * comes with QUnit test * expect the special 'all' namespace to be the first in the list * function build on mediawiki.special form r90941 Comment: Ok, all looks good. marking resolved. :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r205]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r205. Old Status: new New Status: fixme User Awjrichards also posted a comment on Wikimedia.r205. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18894 Commit summary: moving the contents of http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/ for fundraiser analytics and reporting to the wikimedia repository Comment: code /trunk/fundraiser-analysis/settings.py /code You should generecize this file - you don't want to be checking in login credentials or other sensitive configuration settings, even if they'll only work on your local machine. It's bad practice. One way to get around this is to create an 'example' config file - eg settings.py.example - where you have sample values for configuration directives. Then, on whatever system you're running the code, you set up individual and local-only copies of the config file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79905]: Revision status changed
User Reedy changed the status of MediaWiki.r79905. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79905#c0 Commit summary: Convert LQT to resource loader. This probably needs more work, but will do the job for now. Mostly fixes #20934 because resourceloader automatically rtl's when needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91022]: New comment added
User RussNelson posted a comment on MediaWiki.r91022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91022#c18895 Commit summary: UploadStashFile::__construct() can't assume that the mwrepo-produced paths match the temp zone. Comment: The only change is that the checks on the pathname are skipped if the path came from a virtual url. In particular, Swift is returning an actual local pathname (which are always temporary anyway), which doesn't match the temp zone (which is an actual Swift container whose name doesn't match /tmp). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90855]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90855. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90855#c18896 Commit summary: Follow-up r90749: use a new 'autopromote' action for the autopromote rights log entries. Removed the 'rightsautocomment' msg. Comment: Should use tabs in trunk/phase3/maintenance/language/messages.inc. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81190]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r81190. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r81190. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81190#c18897 Commit summary: Follow-up r81074: succumb, though it breaks my heart to do so (:P), to American linguistic imperialism... Comment: British English, fuck yeah! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90856]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90856. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90856#c0 Commit summary: Remove disableaccount stuff from r77558. Left out from r86146 reverts. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83907]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r83907. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83907#c0 Commit summary: Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and also to allow a 'flat list' of options ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91025]: Revision status changed
User Reedy changed the status of MediaWiki.r91025. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91025#c0 Commit summary: contents moved to repository http://svn.wikimedia.org/viewvc/wikimedia/trunk/fundraiser-analysis/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
