[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added, and revision status changed
User Patrick Nagel changed the status of MediaWiki.r89637. Old Status: fixme New Status: new User Patrick Nagel also posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c21653 Commit summary: Initial commit of new extension Notificator Comment: I think besides small non-critical details that I'll get back to later, it's in a good state. Setting to 'new' now. Nikerabbit, do you agree? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95446]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95446. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95446 Commit summary: Merge r94252 to trunk Rewrite to use $dbw-update() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please fix your FIXMEs
On 31/08/11 04:46, Mark A. Hershberger wrote: As promised on wikitech-l (http://hexm.de/5u), I'm sending email to all MediaWiki developers with any FIXME'd revisions. I'll be sending a reminder at least twice a week from now on for any outstanding FIXMEs. Link to all your FIXMEs: http://mediawiki.org/wiki/Special:Code/MediaWiki/status/fixme?author=nikola Rev #: Commit message r86692: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass r74208: Pair to the Interlanguage extension r74204: July 30 2010: Display link(s) to the page(s) on the central wiki with... Please address them as soon as possible. When you think you've addressed one, change its status field from fixme to new and make sure your new revision shows up under Follow-up revisions If you have any questions about this, then please feel free to email me. I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95448]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95448 Commit summary: jquery.spinner: Fix small issues (Follows-up r95445) * Using the same spinner as before, preserving svn history (20px vs. 16px) * Adding a line-break at the end of file and changing indentation per our conventions * Adjusting doc to reflect the plugin itself instead of what it replaces. * Using shorthand utility in jQuery (no / and using the attr-object as second argument) * Adding @return comment to $.fn.injectSpinner * Adding return statement to $.removerSpinner (returning a jQuery object of the element). Could be useful, but better than not having a return value at all. JSHint: * Adding parentheses around the class object property, otherwise it may be interpreted as a class operator which breaks the object. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95468]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95468. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95468 Commit summary: Put mediawiki.special.search in a document ready wrapper ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95486]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95486. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95486 Commit summary: fix bug 30554; not sure if using session like this is a good approach though ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please fix your FIXMEs
Am 31.08.2011 08:14, schrieb Nikola Smolenski: I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? Read the MediaWiki Developer's Guide http://www.mediawiki.org/wiki/MDG Section: Code Review explains the status flags and what you are allowed to change and what not. Tom signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95495]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95495.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95495
Commit summary:
Fix error that was reported as a fixme against r90668, not at fault though
Add __METHOD__ to all DB related call,s so we don't pass array ('campaign_id'
= null) to the database caller as a function name
Probably means other stuff was broken too...
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95545]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95545. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95545 Commit summary: Kill duplicate PROTO_ from defines ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94479]: Revision status changed
User TheDJ changed the status of MediaWiki.r94479. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94479 Commit summary: Use Html::element instead. Follow up to r94385 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79941]: Revision status changed
User TheDJ changed the status of MediaWiki.r79941. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79941 Commit summary: Follow up to r79905. Disabling resource inclusion of LQT api. Don't know how to fix this properly, seems undocumented for Resourceloader. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95548]: New comment added, and revision status changed
User Johnduhart changed the status of MediaWiki.r95548. Old Status: new New Status: ok User Johnduhart also posted a comment on MediaWiki.r95548. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95548#c21654 Commit summary: bug 30577 - re-add profiling into MobileFrontend Comment: I don't think setDefaultLogo needs profiling calls but alright :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95549]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95549. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95549 Commit summary: mft r95548 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95585]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95585. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95585 Commit summary: 1.17wmf1: Revert r95549, was never deployed and I want to have the branch clean for the weekend ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95588]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95588. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95588 Commit summary: Followup r95572 Couple of stylistic tweaks Move calls of extractRequestParams after the initial check that may abort the api call ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89222]: New comment added
User TheDJ posted a comment on MediaWiki.r89222. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89222#c21655 Commit summary: remove unused format name Comment: limiting scope seems like a fine idea to me. This is simply wrong however. You are making the active assumption here that something that announces to support XHTML MP 1.0 will support WML. Since the two don't even look like eachother, there should at the very least be a very visible. FIXME in the source code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89222]: Revision status changed
User TheDJ changed the status of MediaWiki.r89222. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89222 Commit summary: remove unused format name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please fix your FIXMEs
On Wed, Aug 31, 2011 at 4:14 PM, Nikola Smolenski smole...@eunet.rs wrote: I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? A. You need Coder rights on the wiki, so just poke someone in #mediawiki or list your wiki username on here and someone should do it. B. In the follow up revisions (to do it automatically) just mention the revision number in the commit summary (eg: Follow up to rX to fix X, Y and Z) or you can do it manually for revisions that have missed it but i'm not sure how. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Please fix your FIXMEs
On 31/08/11 08:18, Thomas Gries wrote: Am 31.08.2011 08:14, schrieb Nikola Smolenski: I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? Read the MediaWiki Developer's Guide http://www.mediawiki.org/wiki/MDG Section: Code Review explains the status flags and what you are allowed to change and what not. I know what the status flags are, and I still don't see where could I change them. Do I need some access rights or something like that? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95625]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95625. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95625 Commit summary: Plural rules for pywikipedia based on r95194 of plural-gettext.txt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95626]: Revision status changed
User Johnduhart changed the status of MediaWiki.r95626. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95626 Commit summary: moved to pywikipedia ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95642]: New comment added
User Johnduhart posted a comment on MediaWiki.r95642. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95642#c21656 Commit summary: Making revision states, protected states, and flags configurable Comment: Really? Besides CSS what core files need to be edited? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] [RFC] Drop actions in favor of special pages and wiki pages
There's a new RFC page up on the wiki: http://mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favor_of_special_pages_and_wiki_pages ...can't figure out how I would summarize it here so I'll let the RFC page speak for itself. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Please fix your FIXMEs
On Wed, Aug 31, 2011 at 8:31 AM, Nikola Smolenski smole...@eunet.rs wrote: On 31/08/11 08:18, Thomas Gries wrote: Am 31.08.2011 08:14, schrieb Nikola Smolenski: I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? Read the MediaWiki Developer's Guide http://www.mediawiki.org/wiki/MDG Section: Code Review explains the status flags and what you are allowed to change and what not. I know what the status flags are, and I still don't see where could I change them. Do I need some access rights or something like that? Yeah you need to be a member of the 'coder' user group. Anybody who is a coder can add you to that group. Leave your username here and somebody will probably add you. Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89637]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c21657 Commit summary: Initial commit of new extension Notificator Comment: Good enough for me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95800]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95800. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95800 Commit summary: Link content pages and uploaded files to AllPages and FileList respectively ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please fix your FIXMEs
On 31/08/11 08:31, K. Peachey wrote: On Wed, Aug 31, 2011 at 4:14 PM, Nikola Smolenskismole...@eunet.rs wrote: I asked Mark already, but he hasn't answered (or at least I haven't noticed his answer), so I guess it is appropriate to ask the questions here. How can I change the status of a revision from fixme to new? And how can I make a revision show up under Follow-up revisions? A. You need Coder rights on the wiki, so just poke someone in #mediawiki or list your wiki username on here and someone should do it. Wiki username: Nikola Smolenski SVN username: nikola ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95810]: New comment added
User Hashar posted a comment on MediaWiki.r95810. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95810#c21658 Commit summary: Remove wfDie() that Ariel keeps trying to resurrect :) Comment: Alleluia ! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95810]: Revision status changed
User Hashar changed the status of MediaWiki.r95810. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95810 Commit summary: Remove wfDie() that Ariel keeps trying to resurrect :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75433]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r75433. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75433 Commit summary: adding new extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95834]: Revision status changed
User Siebrand changed the status of MediaWiki.r95834. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95834 Commit summary: Followup r95800 - the page is ListFiles ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95848]: Revision status changed
User Siebrand changed the status of MediaWiki.r95848. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95848 Commit summary: Argh, fixing my fix in r95834 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95843]: Revision status changed
User Siebrand changed the status of MediaWiki.r95843. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95843 Commit summary: fu r95739: Fix author per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95841]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r95841. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95841 Commit summary: cleaned up whitespace and indentation according to coding conventions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please fix your FIXMEs
Hi people, same problem here. username: Devayon It's fine if someone else just marks my FIXME as 'new' because I have only one outstanding fixme. Dev ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95642]: New comment added
User Reedy posted a comment on MediaWiki.r95642. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95642#c21661 Commit summary: Making revision states, protected states, and flags configurable Comment: Does magically first creating new i18n messages onwiki actually work? (without said message being defined in the i18n file) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95642]: New comment added
User Catrope posted a comment on MediaWiki.r95642. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95642#c21662 Commit summary: Making revision states, protected states, and flags configurable Comment: Yes, that works for me on trunk at least. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95642]: New comment added
User Siebrand posted a comment on MediaWiki.r95642. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95642#c21663 Commit summary: Making revision states, protected states, and flags configurable Comment: I think that has worked for forever. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95851]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95851. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95851 Commit summary: Move JavaScript files to js/ folder. Move CSS files to css/ folder. Update js/css localisation for resource modules accordingly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21664 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: No, there aren't any unit tests for Special:Contributions. If I've made a b0rked merge, I'm happy to revert out and try again. If there are other issues with the code, that's a separate issue, and shouldn't really be part of the revert and merge... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95845]: Revision status changed
User ^demon changed the status of MediaWiki.r95845. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95845 Commit summary: Tweak 'ps-generatepages-noschema' Update whitespace. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95828]: Revision status changed
User ^demon changed the status of MediaWiki.r95828. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95828 Commit summary: Added unfinished refactoring of es ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95856]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95856. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95856 Commit summary: Followup r95753 per CR: prevent extensions from making isMovable() return true for interwiki titles and immovable namespaces ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95857]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95857 Commit summary: Add an extra cookie_font truthy guard just in case config[0] is empty ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95860]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95860. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95860 Commit summary: made $wgSignupAPIUseAjax global ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95818]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95818.
Old Status: new
New Status: fixme
User Catrope also posted a comment on MediaWiki.r95818.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95818#c21666
Commit summary:
[ResourceLoader2]: Initial go at the GadgetManager.
* Front-end for overview is done
* Front-end for gadgetview is just a stub
* Removed code that was planned to be used with action=modify/action=delete.
This is no longer going to be done from a Special-page. Prop-editor will be
ajax-only.
* Cleaned up log-related stuff that is no longer going to be used in (i18n and
Gadgets.php)
Comment:
pre
- $wgOut-addModuleStyles( 'ext.gadgets.gadgetmanager' );
...
+ $out-addModules( 'ext.gadgets.gadgetmanager' );
/pre
I saw you added code'position' = 'top'/code so there's no FOUC here, but
this still means the overview will be unstyled in noscript mode.
pre
+ if ( $category != '' ) {
/pre
Use strict comparison.
pre
+ $html .= 'table class=mw-gadgetmanager-gadgets
TablePagertr';
/pre
Why does this table have the TablePager CC class if it wasn't output by the
TablePager PHP class?
OK otherwise.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95859]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95859. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95859 Commit summary: Update Wikia MediaWiki extension support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95858]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95858. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95858 Commit summary: Use a fontID function that cleans up font names into a format that is acceptable to be located in an id=. Previously fonts with spaces would have spaces in the id resulting in jQuery selects that had a space breaking the select and not checking off the radio button. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95854]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95854. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95854 Commit summary: Minor css cleanup ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95853]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95853. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95853 Commit summary: Follow up r95852; Erm, missing '}'... but you didn't see that happen ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95852]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95852. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95852 Commit summary: Various js code practice and whitespace cleanups. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95850]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95850. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95850 Commit summary: stylize.php. Use $dir instead of multiple times dirname( __FILE__ ). Various whitespace and indentation updates. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95849]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95849. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95849 Commit summary: stylize.php. Use $dir instead of multiple times dirname( __FILE__ ). Various whitespace and indentation updates. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95839]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95839. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95839 Commit summary: Refactor the menu building code to a seperate method. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95838]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95838.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95838
Commit summary:
Followup r95837; Return the list-style-image for ul{} back to vector since I
ended up deciding not to give the common stylesheet one of the two bullet
points.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95837]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95837. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95837#c21667 Commit summary: Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to a series of css stylesheets which 3rd party skins can include. Havent touched Modern yet. External link icons are too complex to deal with this round due to vector and monobook using different icons. Comment: Could you clarify what is the difference between Content and Element? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95835]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r95835. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r95835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95835#c21668 Commit summary: Add support for font-family style definition if any. Check whether the defined font is present with us, if yes, load it. Comment: This code has been stylized in subsequent commits today. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95837]: New comment added
User Dantman posted a comment on MediaWiki.r95837. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95837#c21669 Commit summary: Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to a series of css stylesheets which 3rd party skins can include. Havent touched Modern yet. External link icons are too complex to deal with this round due to vector and monobook using different icons. Comment: element = styles for basic elements: links, lists, etc... content = styles for complex things which are a standard part of page content (ie: the css classing is built into the system) like the TOC interface = styles for the monobook/vector pattern of laying out common interfaces, these id/classes's are not built into the system and are outputted by the actual MonoBook/Vector code by convention Different 3rd party skins may want different levels of these. A skin that wants the typical content area but doesn't want the MonoBook/Vector patterns would just want element content. A skin that wants the basic links, headers, lists, etc... but doesn't want styles for the complex things built into the system would just want element. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95837]: New comment added
User Dantman posted a comment on MediaWiki.r95837. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95837#c21670 Commit summary: Remove the basic styles that vector coppied from monobook from both monobook and vector and relocate them to a series of css stylesheets which 3rd party skins can include. Havent touched Modern yet. External link icons are too complex to deal with this round due to vector and monobook using different icons. Comment: And there goes my list: * element = styles for basic elements: links, lists, etc... * content = styles for complex things which are a standard part of page content (ie: the css classing is built into the system) like the TOC * interface = styles for the monobook/vector pattern of laying out common interfaces, these id/classes's are not built into the system and are outputted by the actual MonoBook/Vector code by convention ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] A new quizz extension, please try out the prototype
In my spare time I have been coding a MediaWiki extension to generate quizzes automatically from Wikipedia content. I would be *very* interested in your feedback, so I have put a basic prototype online, available at http://wikilearner.net/wiki It's rough on the edges, but I hope you get the basic idea. To be quizzed on content of your choice, simple create a new article on the wiki, copy-pasting your favorite Wikipedia content. I suggest you remove ref tags, templates, and alike which are not yet supported on my wiki. Cheers, Justin ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95861]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95861 Commit summary: Followup r95197, fixed code to display extension specific messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95829]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r95829. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95829#c21671 Commit summary: Revert r94923 The use of cc-zero template was not a copy/paste error. There is no Own-pd template on Commons, so this is causing uploaded files to be marked with a non-existent template (which has been temporarily redirected to Cc-zero). Reverted revision should be deployed ASAP. Comment: Right. Since r95727 this will actually work :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95586]: Revision status changed
User Catrope changed the status of MediaWiki.r95586.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95586
Commit summary:
(bug 30566) Show error message if an IP is given on Special:ViewUserLang
Another slight change: use if() { return ..; } instead of if() { .. } else { ..
}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95605]: Revision status changed
User Catrope changed the status of MediaWiki.r95605. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95605 Commit summary: * InfoPage CSS fixes * fix parameter for displayPrefix() * correct $wgAddGroups and $wgRemoveGroups syntax ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95582]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95582. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r95582. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95582#c21673 Commit summary: Ability to filter list of users based on their test wiki preference Comment: pre + user_id=p1.up_user AND (p1.up_property=$projectPrefName AND p1.up_value=$projectPrefVal) ); /pre This isn't wrong, per se, but you can also use something like: pre $query['join_conds']['p1'] = array( 'JOIN', array( 'user_id=p1.up_user', 'p1.up_property' = $projectPrefName, 'p1.up_value' = $projectPrefVal ) ); /pre (of course you'd have to drop the escaping on code$projectPrefName/code and code$projectPrefVal/code in that case because the Database class will do the escaping for you). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93351]: New comment added
User Krinkle posted a comment on MediaWiki.r93351.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93351#c21674
Commit summary:
AjaxCategories rewrite:
Solving syntax problems, performance improvements and applying code conventions:
* Replaced sprite image with separate images and letting ResourceLoader embed
them with @embed (@embed means 0 http requests, less maintenance, none of the
known limitations with sprites, and more readable code (named files rather than
pixel offsets)
* Many functions were floating in the global namespace (like
window.makeCaseInsensitive). A statement ends after a semi-colon(;). All
functions declared after catUrl were assigned to the window object. I've
instead turned the semi-colons back into comma's, merged some other var
statements and moved them to the top of the closure. Changed local function
declarations into function expressions for clarity.
* fetchSuggestions is called by $.fn.suggestions like .call( $textbox,
$textbox.val() ). So the context (this) isn't the raw element but the jQuery
object, no need to re-construct with $(this) or $(that) which is slow and
shouldn't even work. jQuery methods can be called on it directly. I've also
replaced $(this).val() with the value-argument passed to fetchSuggestions
which has this exact value already.
* Adding more function documentation. And changing @since to 1.19 as this was
merged from js2-branch into 1.19-trunk and new features aren't backported to
1.18.
* Optimizing options/default construction to just options = $.extend( {},
options ). Caching defaultOptions is cool, but doesn't really work if it's in
a context/instance local variable. Moved it up to the module closure var
statements, now it's static across all instances.
* In makeSuggestionBox(): Fixing invalid html fragments passed to jQuery that
fail in IE. Shortcuts (like 'foo' and 'foo/') are only allowed for
createElement triggers, not when creating longer fragments with content and/or
attributes which are created through innerHTML, in the latter case the HTML
must be completely valid and is not auto-corrected by IE.
* Using more jQuery chaining where possible.
* In buildRegex(): Using $.map with join( '|' ), (rather than $.each with +=
'|'; and substr).
* Storing the init instance of mw.ajaxCategories in mw.page for reference
(rather than local/anonymous).
* Applied some best practices and write testable code
** Moved some of the functions created on the fly and assigned to 'this' into
prototype (reference is cheaper)
** Making sure at least all 'do', 'set' and/or 'prototype' functions have a
return value. Even if it's just a simple boolean true or context/this for
chain-ability.
** Rewrote confirmEdit( .., .., .., ) as a prototyped method named
doConfirmEdit which takes a single props-object with named valuas as
argument, instead of list with 8 arguments.
* Removed trailing whitespace and other minor fixes to comply with the code
conventions.
** Removed space between function name and caller: foo () = foo())
** Changing someArray.indexOf() + 1 into someArr.indexOf() !== -1. We want
a Boolean here, not a Number.
** Renamed all underscore-variables to non-underscore variants.
== Bug fixes ==
* When adding a category that is not already on the page as-is but of which the
clean() version is already on the page, the script would fail. Fixed it by
moving the checks up in handleCategoryAdd() and making sure that
createCatLink() actually returned something.
* confirmEdit() wasn't working properly and had unused code (such as
submitButton), removed hidden prepending to #catlinks, no need to, it can be
dialog'ed directly from the jQuery object without being somewhere in the
document.
* in doConfirmEdit() in submitFunction() and multiEdit: Clearing the input
field after adding a category, so that when another category is being added it
doesn't start with the previous value which is not allowed to be added again...
Comment:
Test cases: http://www.mediawiki.org/w/index.php?title=Sandboxoldid=430268
Steps to test this module (todo: Automate this once we have a testing
environment for it)
# Copy
[http://www.mediawiki.org/w/index.php?title=Sandboxoldid=430268action=raw
wikitext] to your wiki's nowiki[[Sandbox]]/nowiki -page
# Try the following tasks After every action check the history/diff and refresh
the page to see what it looks like now
## Add a new category Ajax add
## Remove category Ajax add
## Change Quux, does it preserve sort key ?
## Remove Bar
## Remove Foo, does it remove the right one ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95714]: Revision status changed
User Catrope changed the status of MediaWiki.r95714. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95714 Commit summary: Add support to only return keys in ApiAllMessages * Applying patch from bug 30591 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95573]: Revision status changed
User Catrope changed the status of MediaWiki.r95573. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95573 Commit summary: Followup r95572 to change variable names and use an associative array per Krinkle and Roan on IRC ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95578]: Revision status changed
User Catrope changed the status of MediaWiki.r95578. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95578 Commit summary: Follow-up to r95572, remove $wgAjaxExportList ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [RFC] Drop actions in favor of special pages and wiki pages
On Wed, Aug 31, 2011 at 3:13 AM, Daniel Friesen li...@nadir-seen-fire.com wrote: There's a new RFC page up on the wiki: http://mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favor_of_special_pages_and_wiki_pages ...can't figure out how I would summarize it here so I'll let the RFC page speak for itself. Thanks for writing this up. I've added a few quick comments and put it on my watchlist. I *hate* action urls. They overly complicate Article and related classes, and date from a time before special pages existed. While on the one hand I think the cleanup recently to make Action classes and move the code out was a positive thing...I agree the better course of action is to kill them entirely. Of course, things like action=edit should work as back-compat for near eternity (supporting action=foobar redirects to Special:Foobar/Title would take very little code). -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r86692]: Revision status changed
User Nikola Smolenski changed the status of MediaWiki.r86692. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86692 Commit summary: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r74208]: Revision status changed
User Nikola Smolenski changed the status of MediaWiki.r74208. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74208 Commit summary: Pair to the Interlanguage extension. When a new interlanguage link is added to the central wiki, the Interlanguage Central extension purges the articles on the dependant wikis and updates their interlanguage links. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r74204]: Revision status changed
User Nikola Smolenski changed the status of MediaWiki.r74204. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74204 Commit summary: July 30 2010: Display link(s) to the page(s) on the central wiki with interlanguage links below the edit form. * Displays link(s) to the page(s) on the central wiki with interlanguage * links below the edit form. ** Displays the links when editing. ** Saves the links upon article save (in page_props table) so that they could be displayed. * Now contained in one class. * Updated language sorting to take care of new languages. * More and nicer code comments. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95868]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r95868. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95868 Commit summary: Add 'path' = __FILE__, to Extension:RSS Bug 30659 - correct extension credits ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88772]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r88772. Old Status: fixme New Status: deferred User ^demon also posted a comment on MediaWiki.r88772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88772#c21677 Commit summary: Workaround for duplicate key errors Comment: Marking deferred so I can avoid fixme spam (it's not urgent at all...). This IGNORE issue was later removed, then re-added. The ParserTest - PHPUnit needs cleanup in general, which I've been looking at. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21678 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: Works fine for me on trunk... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21679 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: The inner join on rev_id = rc_this_oldid is still there in your code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81147]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r81147. Old Status: fixme New Status: resolved User ^demon also posted a comment on MediaWiki.r81147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81147#c21680 Commit summary: Fixed bug - skin is passed to the page through ResourceLoaderConfigVars now since it's not page specific, so the MakeGlobalVariableScripts hook this extension uses, which depends on reading the $var param for it's skin value, needs to also use ResourceLoaderConfigVars - besides, it's also not page-specific, so it's better to place it there. Comment: Fixed in r94189. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21681 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: And for Roan/Niklas ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94282]: Revision status changed
User ^demon changed the status of MediaWiki.r94282. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94282 Commit summary: Use Parser::preprocess() instead of Parser::transformMsg() Fixme: couldn't find any use of these two methods, should they be removed entirely? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Reedy posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21682 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: ALSO! Stuff like this is much more useful as a patch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95866]: Revision status changed
User ^demon changed the status of MediaWiki.r95866. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95866 Commit summary: Localisation updates from http://translatewiki.net. Testing new language names in export from Translate after r95862 and r95864. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95863]: Revision status changed
User ^demon changed the status of MediaWiki.r95863. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95863 Commit summary: Improved saving of schema - moved most of it into its own function, replaced creation of a page-save job with a direct save, added Javascript redirect back to category page at end of save, and added an edit-summary field to the interface ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95867]: Revision status changed
User ^demon changed the status of MediaWiki.r95867. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95867 Commit summary: Clarify parameter description added in r95714 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86623]: New comment added
User Nikola Smolenski posted a comment on MediaWiki.r86623. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86623#c21683 Commit summary: (bug 28643) Merge Serbian language variant conversion improvements to trunk (r85224, r85239, r85308) from Nikola's branch Comment: Yes, and this is desired behavior. If you have a text that's mostly Latin with a word in Cyrillic, that word is most likely a foreign word that does not need to be converted to Latin. I agree that tests would be nice though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95862]: Revision status changed
User ^demon changed the status of MediaWiki.r95862. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95862 Commit summary: Add some local names. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95844]: Revision status changed
User ^demon changed the status of MediaWiki.r95844. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95844 Commit summary: Fixing a check for unknown fonts, pointed out by dantman ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95871]: Revision status changed
User ^demon changed the status of MediaWiki.r95871. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95871 Commit summary: Tidy up w/c Remove trailing whitespace, add some documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94426]: Revision status changed
User ^demon changed the status of MediaWiki.r94426. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94426 Commit summary: Add RELEASE-NOTES for r93744 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21684 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: bug 30641 and possibly another... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84395]: New comment added
User Mdale posted a comment on MediaWiki.r84395. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84395#c21687 Commit summary: (bug 27641) purgeThumbnails should support exclusion of expensive files. Add $wgExcludeFromThumbnailPurge and don't purge thumbnails whose extension is in that array when the files they belong to are purged with action=purge. Committing patch by Michael Dale with small coding style tweaks Comment: Any update? I would argue for keeping it around as a good simple solution while the more complicated solution is developed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95697]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r95697. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r95697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95697#c21688 Commit summary: Switched BannerAllocation form from post to get. See bug 30271. Comment: * Has a weird mix of tabs and spaces, we use tabs for indentation. * If tt$locationSubmitted/tt is just going to be a boolean and you don't need the actual value, you can use tt$wgRequest-getBool()/tt and it'll be clearer :) * In tt$this-project = $wgRequest-getText( 'project', 'wikipedia', $wgNoticeProject );/tt, I'm not sure what the 3rd parameter is for. ttgetText()/tt only takes 2 parameters. If you haven't already, I'd recommend reading our [[Manual:Coding conventions|coding conventions]] page. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21689 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Swapped $wgGlobalDB for $wgGlobalDatabase in r95872 $wgWikiID doesn't seem defined anyway, but not sure what it's supposed to be set to.. (in Default Settings) There's also an undefined $prefix (tagged with a FIXME comment in the code) Going to try and ping Peter to help tidy this up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89637]: Revision status changed
User ^demon changed the status of MediaWiki.r89637. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637 Commit summary: Initial commit of new extension Notificator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95595]: Revision status changed
User ^demon changed the status of MediaWiki.r95595. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95595 Commit summary: Fix Bug #30593 : WebFonts set cookies for different paths Use correct path for the cookie value when reset. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95172]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r95172. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95172#c21690 Commit summary: also support OutputPage/ParserOutput-agnostic script loading a la addScript() via SMWOutputs Comment: Markus, can you have a look at r95874? That code was adding resource loader module names as head items for MW = 1.17. Commenting it out does not seem to cause any issues, but I'm not sure what the original purpose of this was, so something might be broken now (esp on 1.16). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95572]: New comment added
User Catrope posted a comment on MediaWiki.r95572.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95572#c21691
Commit summary:
Adds ResourceLoader support to AbuseFilter
Rewrote javascript to use jQuery
Added API modules to replace sajax_* calls
Solves bug 29714
Comment:
pre
+$wgAPIModules['checkfiltersyntax'] = 'ApiCheckFilterSyntax';
/pre
I would feel safer if API module names like these were prefixed to make naming
conflicts less likely. Something like 'abusefilterchecksyntax' or
'checkabusefiltersyntax' (such that 'abusefilter' as a whole is mentioned).
The way information is passed in static member variables of
codeAbuseFilter/code and codeAbuseFilterViewExamine/code is
undocumented and kind of scary, but offhand I wouldn't know a better way. Maybe
you can avoid passing the information instead; it looks like filterBoxName
doesn't need to be passed around if you can make it so that the box always has
the same ID.
pre
+ data = data.checkfiltersyntax;
...
+ if ( data.status == 'ok' ) {
/pre
You need to check whether the first assignment didn't set codedata/code to
codeundefined/code; this may happen if the API module throws an error.
pre
+ $filterBox.text(
data.query.abusefilters[0].pattern );
/pre
Same here, check that these elements are present in these objects or you'll get
a ReferenceError and your entire script dies.
pre
+ var action = this.id.substr( 31 );
/pre
Please add a comment explaining where the number 31 came from.
pre
+ }, function( data ) {
+ $( '#mw-abusefilter-warn-preview' ).html( data )
/pre
Second line should be indented one tab more.
pre
+ insertAtCaret: function(myValue){
/pre
Does code$.textSelection/code's encapsulateSelection functionality not do
what you want?
pre
+ $( '#mw-abusefilter-expr-result' )
+ .html( mw.html.escape( data.evalfilterexpression.result
) );
/pre
Huh? Can't you just use code.text()/code here?
pre
+ $vars = json_decode( $params['vars'], true );
/pre
Use codeFormatJson::decode()/code. This wraps around
codejson_decode()/code except when the JSON module isn't present or a
version with a known bug is present, if which case it falls back to a PHP
implementation.
pre
+ // Same as below
...
+ // Oh god this is so bad but this message uses GENDER
/pre
It seems you refactored this and changed the order, so these comments are
confusing at first, then amusing :)
Looks very good otherwise, thanks!
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95872]: New comment added
User ^demon posted a comment on MediaWiki.r95872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95872#c21692 Commit summary: Followup r95396 Swap $wgGlobalDB for $wgGlobalDatabase Comment: I'm just going on the record, right now, as saying $wgGlobalDatabase has to be the most evil sounding global ever. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95691]: Revision status changed
User Catrope changed the status of MediaWiki.r95691. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95691 Commit summary: make campaign table sortable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95726]: Revision status changed
User Catrope changed the status of MediaWiki.r95726. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95726 Commit summary: address point 2 from bug 30620 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
