Re: [Wikitech-l] should we keep $wgDeprecationWhitelist
Just my 2 cents: I don't think we need this kind of deprecation-warning filter in core. As far as I know deprecation warnings are never shown more than once for every method, so it isn't going to pollute or obfuscate the error output when you're working with the code. And users/production wouldn't be seeing them anyway, right ? And if you maintain compatibility with an older version of MediaWiki, you might also find it useful to raise $wgDeprecationReleaseLimit ocasionally to only if there's any usage of more problematic / longest deprecated methods, and lower it again when you want to see them all. -Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r54363]: Revision status changed
Siebrand changed the status of MediaWiki.r54363 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/54363 Old status: deferred New status: reverted Commit summary for MediaWiki.r54363: Consistent spelling. All-caps rendering vis CSS. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108694]: New comment added, and revision status changed
Raymond changed the status of MediaWiki.r108694 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108694#c29387 Old Status: new New Status: fixme Commit summary for MediaWiki.r108694: Load the Recaptcha class in a way that has some chance of even working Raymond's comment: PHP Fatal error: Class 'ReCaptcha' not found in /www/w/extensions/ConfirmEdit/ConfirmEditHooks.php on line 15 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] MediaWiki security and maintenance release 1.18.1
On Wed, Jan 11, 2012 at 11:11 PM, Sam Reed re...@wikimedia.org wrote: Full release notes: http://svn.wikimedia.org/svnroot/mediawiki/tags/REL1_18_1/phase3/RELEASE-NOT ES This link is broken; should be suffixed -1.18 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108694]: Revision status changed
Siebrand changed the status of MediaWiki.r108694 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108694 Old status: fixme New status: new Commit summary for MediaWiki.r108694: Load the Recaptcha class in a way that has some chance of even working ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108700]: Revision status changed
Siebrand changed the status of MediaWiki.r108700 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108700 Old status: new New status: ok Commit summary for MediaWiki.r108700: spacing fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106780]: New comment added, and revision status changed
Hashar changed the status of MediaWiki.r106780 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106780#c29388 Old Status: fixme New Status: resolved Commit summary for MediaWiki.r106780: Fix for bug 33270: default to 'default' search profile Had this fixed in one of my wikies but not committed Hashar's comment: Resolved by r108712 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106780]: New comment added
Hashar posted a comment on MediaWiki.r106780. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106780#c29389 Commit summary for MediaWiki.r106780: Fix for bug 33270: default to 'default' search profile Had this fixed in one of my wikies but not committed Hashar's comment: uncommented with r108712 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107975]: New comment added
Hashar posted a comment on MediaWiki.r107975. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107975#c29390 Commit summary for MediaWiki.r107975: MFT r105341, t105853, r106780 Hashar's comment: Need a merge of r108712 to be fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108712]: New comment added
Hashar posted a comment on MediaWiki.r108712. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108712#c29391 Commit summary for MediaWiki.r108712: bug 33583 search ns user pref ignored! r106780 to fix bug 33270 introduced a new bug that prevented selected namespaces for search to be applied. This patch fix the issue. Credits to Brad Jorsch Hashar's comment: Tagging 1.18wmf1 since it fix a regression that was applied to live site with r107975. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108713]: Revision status changed
Siebrand changed the status of MediaWiki.r108713 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108713 Old status: new New status: ok Commit summary for MediaWiki.r108713: Fix 3 transliteration rules for Assamese- Use atomic code points instead of decomposed forms for ড়, ঢ়, য় ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108488]: New comment added
Hashar posted a comment on MediaWiki.r108488. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108488#c29392 Commit summary for MediaWiki.r108488: r108353: Distinguish null/false in FileBackend::fileExists(). This is intended for things that might really care. Hashar's comment: Of course my english is crappy. The above question was: doGetFileStat() does not seems to return null. So is that really needed? :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] JavaScript on Special:UserLogin?
On 12 January 2012 02:47, Daniel Barrett d...@vistaprint.com wrote: On 11 January 2012 21:51, Daniel Barrett d...@vistaprint.com wrote: * Remove any trailing @companyname.com from the username. Users in our company are accustomed to logging in this way on their Windows boxes, and we'd get several support calls per week from people who can't log into the wiki because they were adding @companyname.com onto their wiki usernames. The way we do it on our Mantis bugtracker is to use the LDAP server for all logins. Something like that for MediaWiki would do the job too. One password! Yes, we use the LDAPAuthentication extension for MediaWiki. But usernames on the login page still must be foo rather than f...@companyname.com. Hence the JavaScript to remove @.*. DanB Of course, if the login form code wasn't such a swamp, there'd be a hook you could use to preprocess the usernames server-side... :-( --HM ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
Hi DJ and hi everybody! Thanks for the warm welcome :), and DJ thanks for your hints/questions concerning SVN. I am quite busy at the moment so I did not set up my SVN client (Tortoise) for the MW repo yet. But I hope to get it done next week. Afterwards I will start adding some of the announced extensions. The Azure stuff is already in SVN. Markus committed it. I am very excited about your Azure extensions. You said you had everything working with MW 1.18 except the media storage? As far as I know you work on the database abstraction layer for Azure SQL. Is that right? So with the file backend we should have a complete Azure bundle, shouldn't we? -- Robert Vogel Social Web Technologien Softwareentwicklung Hallo Welt! - Medienwerkstatt GmbH __ Untere Bachgasse 15 93047 Regensburg Tel. +49 (0) 941 - 66 0 80 - 198 Fax +49 (0) 941 - 66 0 80 - 189 www.hallowelt.biz vo...@hallowelt.biz Sitz: Regensburg Amtsgericht: Regensburg Handelsregister: HRB 10467 E.USt.Nr.: DE 253050833 Geschäftsführer: Anja Ebersbach, Markus Glaser, Dr. Richard Heigl, Radovan Kubani -Ursprüngliche Nachricht- Von: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] Im Auftrag von DJ Bauch Gesendet: Donnerstag, 12. Januar 2012 02:15 An: Wikimedia developers Betreff: Re: [Wikitech-l] New committer I will be trying again tonight. I got some hints from Ben Lobaugh. It looks like the problem I've been having is that I was using the host name in conjunction with my svn+ssh connection attempt, when I should have been using the name of my PuTTY session. On Wed, Jan 11, 2012 at 5:38 PM, Platonides platoni...@gmail.com wrote: On 11/01/12 18:25, DJ Bauch wrote: Welcome, Robert! You and I should be crossing paths. I have everything working through version 1.18 on Windows Azure, except for the media storage. Right this moment I am trying to figure out how to get my code committed, but I have been struggling with setting up the Subversion access from my Windows 7 box. Any hints or pointers on how to set things up may help me transition from a potential to an actual contributer. So, what are you trying to do? The cli or soething else?, did you read [1]? You will need to use plink on windows to make the ssh tunnel, pageant is recommended but not required (unless it's a plink with no console?). Take a look at [2]. 1-http://www.mediawiki.org/wiki/Commit_access#Getting_started_and_set_up 2-http://agateau.wordpress.com/2007/07/03/windows-svnssh-and-the-subversion-command-line-client/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Please Welcome Andre Engels
Greetings all, I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. For those that don't know ... Andre is one of the 'oldest' Wikipedians (in terms of years on the site). His first edits on Wikipedia were from March 2001 (two things to show how early: 1. That's before the first slashdotting; 2. English Wikipedia several years ago had a list of the oldest still active editors, He was at number 8. Number 7 was Jimbo). Apart from being an editor and sysop he has also been active as both an operator and a programmer of bots (still active as an operator, but only very little as a programmer nowadays), and has Steward rights. He also helped in the creation of Wikimedia Commons. Apart from Wikipedia, he is active in various open content projects. These include PGDP (Project Gutenberg Distributed Proofreaders) and Openstreetmap; recently has done similar things in the area of Dutch etymology. Andre studied mathematics, got his PhD in computer science. His last job was at C-Content, which is a company working in search engines. For them he mostly did harvesting and search request analysis. Before that he worked for the RD department of Ericsson Netherlands. He just celebrated his 40th birthday, and is (and always have been) single, living in the city of ´s-Hertogenbosch. His free time is mostly spent behind his computer, either with the above mentioned projects or playing games. Apart from that he's an avid Go player, having reached the grade of 3 dan. I'm really honored to bring on such a long time community member to the Mobile team. Please join me in welcoming Andre! --tomasz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108715]: Revision status changed
Siebrand changed the status of MediaWiki.r108715 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108715 Old status: new New status: ok Commit summary for MediaWiki.r108715: Add Ahirani(ahr) language support by using Lohit Devanagari font. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108716]: Revision status changed
Siebrand changed the status of MediaWiki.r108716 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108716 Old status: new New status: ok Commit summary for MediaWiki.r108716: (bug 32508) Fix updater output site_stats updated is still a database action. Purge cache is now the very last one. Output: snip ...site_stats is populated...done. Purging caches...done. Done. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108717]: Revision status changed
Siebrand changed the status of MediaWiki.r108717 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108717 Old status: new New status: deferred Commit summary for MediaWiki.r108717: new extension: PrivatePageProtection ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108717]: New comment added
Duesentrieb posted a comment on MediaWiki.r108717. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108717#c29394 Commit summary for MediaWiki.r108717: new extension: PrivatePageProtection Duesentrieb's comment: this extension is complementary to Lockdown. It implements group based access on a per-page basis, using a parser function to list the groups on-page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108717]: New comment added
Siebrand posted a comment on MediaWiki.r108717.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108717#c29395
Commit summary for MediaWiki.r108717:
new extension: PrivatePageProtection
Siebrand's comment:
pre
+ 'privatepp-desc' = 'Allowes restricting page access based on user
group',
+
+ 'privatepp-lockout-prevented' = 'Lockout prevented: You have tried to
restrict access to this page to {{PLURAL:$2|the group|one of the groups}} $1. '
+ .
'Since you are not a member of {{PLURAL:$2|this group|any of these groups}},
you would not be able to access the page after saving it. '
+ .
'Saving was aborted to avoid this.',
/pre
* typo: Allowes - Allows
* please do not concatenate strings, but just add newlines.
[[extension:localisationUpdate]] chokes on it, I believe, and
[[extension:translate]] cannot handle it either.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108549]: New comment added
MaxSem posted a comment on MediaWiki.r108549. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108549#c29396 Commit summary for MediaWiki.r108549: Added localisation MaxSem's comment: Thanks, fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108710]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108710 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108710 Old status: new New status: ok Commit summary for MediaWiki.r108710: Fix fatal in r108694. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108711]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108711 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108711 Old status: new New status: ok Commit summary for MediaWiki.r108711: stylize.php, some indentation fixes and some brackets added. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108715]: New comment added
Nikerabbit posted a comment on MediaWiki.r108715. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108715#c29397 Commit summary for MediaWiki.r108715: Add Ahirani(ahr) language support by using Lohit Devanagari font. Nikerabbit's comment: Did you also update docs on mediawiki.org? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108720]: New comment added
Nikerabbit posted a comment on MediaWiki.r108720.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108720#c29398
Commit summary for MediaWiki.r108720:
Follow-up r108549: {{PLURAL}}
Nikerabbit's comment:
You don't and shouldn't pass the number twice. Plural expects formatted numbers.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108701]: Revision status changed
Catrope changed the status of MediaWiki.r108701 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108701 Old status: new New status: ok Commit summary for MediaWiki.r108701: Bug fix: incorrect impressions on form load in modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js: - Updated load(): - to accept a second argument from so that the location can be passed in, - to allow auto as the first argument (what to display), - and to pass from on to showForm() and showCTA() - Updated showForm() and showCTA() to accept from as an argument, and to use that for the tracking id - Updated both uses of load(), and the use of showCTA() on success, to send the new arguments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please Welcome Andre Engels
On 1/12/12, Tomasz Finc tf...@wikimedia.org wrote: Greetings all, I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. Yay, another Dutchman :) . The Dutch cabal is taking over, slowly but surely, I tell you. Welcome, Andre! Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108574]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r108574. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108574#c29399 Commit summary for MediaWiki.r108574: Don't include files with $magicWords, but use $wgExtensionMessagesFiles. Inspired by r108558. Jeroen De Dauw's comment: You updated the version of SRF from 1.7 to 1.7.1. For all extensions I maintain, please never do this, and rather change it to 1.7.1 alpha, or leave it as it is if there already is some kind of status identifier after the version number. Right now I will not be able to distinguish between people reporting bugs that have version 1.7.1 that has been pulled from svn at some point before the rel or actually got the rel :/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80495]: New comment added
Fomafix posted a comment on MediaWiki.r80495.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80495#c29400
Commit summary for MediaWiki.r80495:
This override is no longer needed.
Tables in div class=toccolours or in other places no longer force a white
background which was only added to avoid underlines from h2 headings from
shining through (which is no longer the case since bug 26449 was solved in
r79087 and r79091)
* This commit fixes bug 26708
Fomafix's comment:
In
[[svn:trunk/phase3/resources/mediawiki.action/mediawiki.action.history.diff.css]]
syntaxhighlight lang=css
table.diff,
td.diff-otitle,
td.diff-ntitle {
background-color: transparent;
}
/syntaxhighlight
from r105280 is not necessary anymore.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108721]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108721 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108721 Old status: new New status: ok Commit summary for MediaWiki.r108721: Fix r108720: No need to introduce 2 Consistency tweaks in preparation for adding extension to translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108722]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108722 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108722 Old status: new New status: ok Commit summary for MediaWiki.r108722: r108549: Register extension for translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108706]: Revision status changed
^demon changed the status of MediaWiki.r108706 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108706 Old status: new New status: ok Commit summary for MediaWiki.r108706: Reverted r108695: as these are still used by upload stash and I don't feel like changing that or thumb-handler.php. The whole public temp file usage by MediaWiki needs to be thought out more, but this can happen later. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102972]: Revision status changed
^demon changed the status of MediaWiki.r102972 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102972 Old status: new New status: ok Commit summary for MediaWiki.r102972: (bug 17865) Fix double-parsed error messages in Cite. Modified patch by Brad Jorsch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103761]: Revision status changed
^demon changed the status of MediaWiki.r103761 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103761 Old status: new New status: ok Commit summary for MediaWiki.r103761: (bug 32451) Clicking on a special characters section loses the selection in IE8. Patch by Lupo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r101611]: Revision status changed
^demon changed the status of MediaWiki.r101611 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101611 Old status: new New status: ok Commit summary for MediaWiki.r101611: Fix r101532 which was so broken that I refuse to believe it was tested even once: * Feeding a fully-qualified URL through mw.util.wikiGetlink() prefixes wgServer, which breaks the link * articlefeedback-survey-disclaimer containted wiki syntax for an external link, but this doesn't work in JS * Links in the survey dialog show up in black due to some annoying JUI CSS, so even if that wiki syntax had worked, it wouldn't have produced a visually discernable link Fixes: * Remove mw.util.wikiGetLink() calls * Split up articlefeedback-survey-disclaimer the way articlefeedback-form-panel-helpimprove-note is, with a separate message for the link text ** Document these split messages in qqq * Move the link target out of a message and into a global * Add a CSS workaround to make the privacy link in the survey dialog show up in blue rather than in black ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106679]: Revision status changed
^demon changed the status of MediaWiki.r106679 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106679 Old status: new New status: ok Commit summary for MediaWiki.r106679: Remove server-side validation of redirect URLs, not needed and getting in the way for AFTv5 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r107425]: Revision status changed
^demon changed the status of MediaWiki.r107425 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107425 Old status: new New status: ok Commit summary for MediaWiki.r107425: Followup r105574 per CR: clone arrays from mw.config so we can modify them safely, rather than corrupting the global arrays ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please Welcome Andre Engels
On 01/12/2012 06:22 AM, Tomasz Finc wrote: Greetings all, I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. For those that don't know ... Andre is one of the 'oldest' Wikipedians (in terms of years on the site). His first edits on Wikipedia were from March 2001 (two things to show how early: 1. That's before the first slashdotting; 2. English Wikipedia several years ago had a list of the oldest still active editors, He was at number 8. Number 7 was Jimbo). Apart from being an editor and sysop he has also been active as both an operator and a programmer of bots (still active as an operator, but only very little as a programmer nowadays), and has Steward rights. He also helped in the creation of Wikimedia Commons. Apart from Wikipedia, he is active in various open content projects. These include PGDP (Project Gutenberg Distributed Proofreaders) and Openstreetmap; recently has done similar things in the area of Dutch etymology. Andre studied mathematics, got his PhD in computer science. His last job was at C-Content, which is a company working in search engines. For them he mostly did harvesting and search request analysis. Before that he worked for the RD department of Ericsson Netherlands. He just celebrated his 40th birthday, and is (and always have been) single, living in the city of ´s-Hertogenbosch. His free time is mostly spent behind his computer, either with the above mentioned projects or playing games. Apart from that he's an avid Go player, having reached the grade of 3 dan. I'm really honored to bring on such a long time community member to the Mobile team. Please join me in welcoming Andre! --tomasz I'm constantly awed at the caliber of people I get to work with. Welcome, Andre! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] postgreSQL testing
Hello, I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/ As of now, there are two tests failing. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] proposed tech conference anti-harassment policy
The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP I don't imagine I'll get much response on this, but just wanted to put it out there before implementing. I intend on putting this into place by the middle of next week, in time for the San Francisco hackathon (starting January 20th). Comments on the talk page, please. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] proposed tech conference anti-harassment policy
On 12 January 2012 16:00, Sumana Harihareswara suma...@wikimedia.org wrote: The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP Nice one :-) A candidate for WMF and wider Wikimedia events in general, too. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] proposed tech conference anti-harassment policy
On Thu, Jan 12, 2012 at 11:04 AM, David Gerard dger...@gmail.com wrote: On 12 January 2012 16:00, Sumana Harihareswara suma...@wikimedia.org wrote: The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP Nice one :-) A candidate for WMF and wider Wikimedia events in general, too. I don't see anything preventing harassment over choice of DBMS ;-) All kidding aside, this looks great. Agree with David wholeheartedly here. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] proposed tech conference anti-harassment policy
On 12 January 2012 17:09, Chad innocentkil...@gmail.com wrote: On Thu, Jan 12, 2012 at 11:04 AM, David Gerard dger...@gmail.com wrote: On 12 January 2012 16:00, Sumana Harihareswara suma...@wikimedia.org wrote: The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP Nice one :-) A candidate for WMF and wider Wikimedia events in general, too. I don't see anything preventing harassment over choice of DBMS ;-) All kidding aside, this looks great. Agree with David wholeheartedly here. Is amazing how this whole wikimedia thing as changed since 2002. I don't understand half the messages on this mail list. This is really a complex and professional organization, that has advanced a lot in the past years. I lurk on the mail list, tryiing to find a way to help, but is really hard, because there are here top-notch profesionals doing things the best way that is possible. You guys rocks. -- -- ℱin del ℳensaje. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
As MediaWiki 1.19 is getting ready, I'd like to offer information on how
MediaWiki 1.18.0 was the most difficult MW upgrade I've ever been through.
Some background: my team administers an internal wiki at a major company with
~2000 users, over 100 extensions (many of them custom/unreleased), and 100K
articles. I've been upgrading MW regularly since 1.11 - every release and patch
- and have never had this much trouble before, mainly because of extensions
that broke in 1.18. The typical MW upgrade takes me a day or two including
regression-testing our extensions. But 1.18 has taken me weeks and I'm still
not done.
This message is meant to be constructive helpful, not blameful: it's quite
possible that every issue was our fault for not keeping up on exactly which
functions globals were being deprecated, etc. I'd just like to describe what
kinds of things broke for a reasonably active wiki run by well-meaning people,
and to document how we fixed them.
So, here's the list of what we had trouble with, and what we did. I welcome
any improvements to our fixes!
1. The global variable $action disappeared, breaking a bunch of our
extensions. I switched to $wgRequest-getVal('action').
2. The removal of Xml::hidden() caused one of our extensions to break. I
switched to Xml::input(..., array('type', 'hidden'))
3. A few of our older extensions were not ported to ResourceLoader yet and
were adding JS and CSS via $wgOut-add... calls. They worked in 1.17 and all
broke in 1.18. I ported them to use ResourceLoader, but this is not a good
solution yet because of bug 31676 (the 32-stylesheet limit of IE,
https://bugzilla.wikimedia.org/show_bug.cgi?id=31676) which IMHO is a very
serious time-bomb waiting to explode. I hope it makes it into 1.19wmf
deployment as planned.
4. Some of our parser tag extensions had a bug, in that they didn't return
a value in the tag callback. (These tags had no visual display.) This didn't
cause problems in 1.17 and earlier, but in 1.18.0 it caused a UNIQ.QINU
string to render on the page. I fixed our extensions to return the empty
string, and the problem went away.
5. The removal of $wgMessageCache-addMessage() broke many extensions,
some ours and some from mediawiki.org like SimpleForms. Some fixes just
required use of the i18n file. Our more difficult issue was that we were
injecting system messages into articles to add tracking categories. On advice
from this list (thanks!), we used code patterned after
Parser::addTrackingCategory() to inject categories and it works fine, actually
much better than what we had.
6. The removal of ts_makeSortable() from wikibits.js threw off a bunch of
our JavaScript: we were using the function to sort on a different column than
the first one on render, and in extensions that create tables within dialogs.
We left the problem unfixed until I can understand the new jQuery UI way of
doing things (jquery.ui.sortable.js).
7. Nearly 100% of our customizations to WikiEditor 1.17 broke in 1.18. We
had followed the documented rules on mediawiki.org, using extensions,
ResourceLoader, etc., and everything worked in 1.17. Nevertheless in 1.18,
toolbars and menus disappeared in IE. Menus appeared multiple times instead of
once in Firefox. JavaScript objects in one module became undefined in others,
even with proper dependencies. Some of these issues are still not worked out,
but most were fixed by a variety of changes.
8. Our MediaWiki:common.js stopped running on the login page. I realize
this was a security fix; it just took me by surprise. Fixed by writing a
custom extension using the hook UserLoginForm to inject the few lines of JS we
needed, and I'm evaluating other non-JS solutions for more security.
9. The addHandler() function in JavaScript does not seem to work in IE8
anymore. We worked around this by using jQuery's bind function.
At this point, our test wiki is stable and I am not anticipating any further
large issues, so we should roll out in the next two weeks or so.
Thanks for reading, and I hope this helps someone,
DanB
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
On 01/12/2012 11:31 AM, Daniel Barrett wrote: So, here's the list of what we had trouble with, and what we did. I welcome any improvements to our fixes! Daniel, thank you so much for taking the time to list these out. And my sympathies that your upgrade was so troublesome! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108075]: Revision status changed
Hashar changed the status of MediaWiki.r108075 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108075 Old status: ok New status: resolved Commit summary for MediaWiki.r108075: [TestSwarm] Update testswarm-mw-fetcher.php script * Improve, add, update inline documentation * Add ability to set TestSwarmAPI::doAddJob options from configuration file * Change default job_name to include anchor tag to MW.org CR (fixes bug 33501) UNTESTED - TO BE TESTED IN TESTSWARM.WMFLABS ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108602]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r108602. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108602#c29401 Commit summary for MediaWiki.r108602: fix bug 16985 based on attached patch by Nakon Jeroen De Dauw's comment: I was thinking the same thing when applying the patch but did not see any obvious way to not do this. Then again, I'm not that familiar with the relevant part of the schema, so if you know a better way to get the needed info, I'd be very welcome :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] proposed tech conference anti-harassment policy
2012/1/12 Chad innocentkil...@gmail.com On Thu, Jan 12, 2012 at 11:04 AM, David Gerard dger...@gmail.com wrote: On 12 January 2012 16:00, Sumana Harihareswara suma...@wikimedia.org wrote: The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP Nice one :-) A candidate for WMF and wider Wikimedia events in general, too. I don't see anything preventing harassment over choice of DBMS ;-) In all seriousness, i was harassed more than once IRL and online for saying that SVN doesn't suck as much as die-hard Git fans say it does. This policy can say preferred technology in addition to Creative Commons license. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
On 12 January 2012 16:31, Daniel Barrett d...@vistaprint.com wrote: So, here's the list of what we had trouble with, and what we did. I welcome any improvements to our fixes! This deserves a page on mediawiki.org. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Please Welcome Andre Engels
Welcome Andre! Great to have you on the engineering team finally! -- Alolita Sharma - Reply message - From: Roan Kattouw roan.katt...@gmail.com To: Wikimedia developers wikitech-l@lists.wikimedia.org Cc: wmf...@lists.wikimedia.org Subject: [Wikitech-l] Please Welcome Andre Engels Date: Thu, Jan 12, 2012 5:46 am On 1/12/12, Tomasz Finc tf...@wikimedia.org wrote: Greetings all, I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. Yay, another Dutchman :) . The Dutch cabal is taking over, slowly but surely, I tell you. Welcome, Andre! Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
Skipping most of this, but there's a few I at least have an answer for.
On Thu, Jan 12, 2012 at 11:31 AM, Daniel Barrett d...@vistaprint.com wrote:
1. The global variable $action disappeared, breaking a bunch of our
extensions. I switched to $wgRequest-getVal('action').
This may have been available in the global context, but as far as I know it
was never documented as a stable global that should be used.
2. The removal of Xml::hidden() caused one of our extensions to break.
I switched to Xml::input(..., array('type', 'hidden'))
Xml::hidden() was removed entirely? There *is* Html::hidden() which should be
functionally similar.
5. The removal of $wgMessageCache-addMessage() broke many extensions,
some ours and some from mediawiki.org like SimpleForms. Some fixes just
required use of the i18n file. Our more difficult issue was that we were
injecting system messages into articles to add tracking categories. On advice
from this list (thanks!), we used code patterned after
Parser::addTrackingCategory() to inject categories and it works fine,
actually much better than what we had.
MessageCache::addMessages() has been on a clear deprecation path for awhile
now and should've been well-documented. Even before it was removed entirely,
it should've already been a no-op.
8. Our MediaWiki:common.js stopped running on the login page. I realize
this was a security fix; it just took me by surprise. Fixed by writing a
custom extension using the hook UserLoginForm to inject the few lines of JS
we needed, and I'm evaluating other non-JS solutions for more security.
This hasn't changed any time recently as far as I can tell...we've had this
in place for quite awhile.
-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
Me: 8. Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise. Fixed by writing a custom extension using the hook UserLoginForm to inject the few lines of JS we needed, and I'm evaluating other non-JS solutions for more security. Chad writes: This hasn't changed any time recently as far as I can tell...we've had this in place for quite awhile. Thanks Chad. FYI, MediaWiki:common.js definitely runs on Special:UserLogin in 1.17.1, the immediately previous release. DanB ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
Yes. The database abstraction layer is working. A bug in the MS SQL driver prevents viewing of pages 2-x of some special pages (like Most Wanted Templates, etc.), but page 1 of each of those comes up fine. The problem is that scrollable cursors are being demoted to forward-only cursors for queries using CTEs. I would expect this to change in a future release of the drivers or I will have to come up with a workaround. The other notable issue is that pages for oddball characters like fleur-de-lis and happy face (single character page names) get confused with one another. I haven't had the spare time to figure out ways to address these yet. I have about a six-week period in which I have another project that is consuming all of my time for what would otherwise be working on the Azure code. On Thu, Jan 12, 2012 at 5:16 AM, Robert Vogel vo...@hallowelt.biz wrote: Hi DJ and hi everybody! Thanks for the warm welcome :), and DJ thanks for your hints/questions concerning SVN. I am quite busy at the moment so I did not set up my SVN client (Tortoise) for the MW repo yet. But I hope to get it done next week. Afterwards I will start adding some of the announced extensions. The Azure stuff is already in SVN. Markus committed it. I am very excited about your Azure extensions. You said you had everything working with MW 1.18 except the media storage? As far as I know you work on the database abstraction layer for Azure SQL. Is that right? So with the file backend we should have a complete Azure bundle, shouldn't we? -- Robert Vogel Social Web Technologien Softwareentwicklung Hallo Welt! - Medienwerkstatt GmbH __ Untere Bachgasse 15 93047 Regensburg Tel. +49 (0) 941 - 66 0 80 - 198 Fax +49 (0) 941 - 66 0 80 - 189 www.hallowelt.biz vo...@hallowelt.biz Sitz: Regensburg Amtsgericht: Regensburg Handelsregister: HRB 10467 E.USt.Nr.: DE 253050833 Geschäftsführer: Anja Ebersbach, Markus Glaser, Dr. Richard Heigl, Radovan Kubani -Ursprüngliche Nachricht- Von: wikitech-l-boun...@lists.wikimedia.org [mailto:wikitech-l-boun...@lists.wikimedia.org] Im Auftrag von DJ Bauch Gesendet: Donnerstag, 12. Januar 2012 02:15 An: Wikimedia developers Betreff: Re: [Wikitech-l] New committer I will be trying again tonight. I got some hints from Ben Lobaugh. It looks like the problem I've been having is that I was using the host name in conjunction with my svn+ssh connection attempt, when I should have been using the name of my PuTTY session. On Wed, Jan 11, 2012 at 5:38 PM, Platonides platoni...@gmail.com wrote: On 11/01/12 18:25, DJ Bauch wrote: Welcome, Robert! You and I should be crossing paths. I have everything working through version 1.18 on Windows Azure, except for the media storage. Right this moment I am trying to figure out how to get my code committed, but I have been struggling with setting up the Subversion access from my Windows 7 box. Any hints or pointers on how to set things up may help me transition from a potential to an actual contributer. So, what are you trying to do? The cli or soething else?, did you read [1]? You will need to use plink on windows to make the ssh tunnel, pageant is recommended but not required (unless it's a plink with no console?). Take a look at [2]. 1-http://www.mediawiki.org/wiki/Commit_access#Getting_started_and_set_up 2-http://agateau.wordpress.com/2007/07/03/windows-svnssh-and-the-subversion-command-line-client/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer
On Thu, Jan 12, 2012 at 11:51 AM, Daniel Barrett d...@vistaprint.com wrote: Me: 8. Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise. Fixed by writing a custom extension using the hook UserLoginForm to inject the few lines of JS we needed, and I'm evaluating other non-JS solutions for more security. Chad writes: This hasn't changed any time recently as far as I can tell...we've had this in place for quite awhile. Thanks Chad. FYI, MediaWiki:common.js definitely runs on Special:UserLogin in 1.17.1, the immediately previous release. DanB Hrm...I distinctly remember user's personal JS was disabled on that page. I wonder if ResourceLoader by grouping the JS also ends up disabling it. In either case, it is a security issue and there's not much we can do about it right now. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108729]: New comment added
Hashar posted a comment on MediaWiki.r108729. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108729#c29402 Commit summary for MediaWiki.r108729: testswarm: catch exception to avoid trace :) This happen because we do svn log on a revision that does not exist. Returning null is fine. Hashar's comment: submitted as https://gerrit.wikimedia.org/r/1871 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108727]: New comment added
Hashar posted a comment on MediaWiki.r108727. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108727#c29403 Commit summary for MediaWiki.r108727: testswarm: fix submitted job name Hashar's comment: https://gerrit.wikimedia.org/r/1871 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108075]: New comment added
Hashar posted a comment on MediaWiki.r108075. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108075#c29404 Commit summary for MediaWiki.r108075: [TestSwarm] Update testswarm-mw-fetcher.php script * Improve, add, update inline documentation * Add ability to set TestSwarmAPI::doAddJob options from configuration file * Change default job_name to include anchor tag to MW.org CR (fixes bug 33501) UNTESTED - TO BE TESTED IN TESTSWARM.WMFLABS Hashar's comment: Deployed live with https://gerrit.wikimedia.org/r/1867 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108725]: New comment added
Hashar posted a comment on MediaWiki.r108725. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108725#c29405 Commit summary for MediaWiki.r108725: update .ini following r108075 also had to rename 'username' to 'user' Hashar's comment: Deployed live with https://gerrit.wikimedia.org/r/1867 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108488]: New comment added
Aaron Schulz posted a comment on MediaWiki.r108488. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108488#c29406 Commit summary for MediaWiki.r108488: r108353: Distinguish null/false in FileBackend::fileExists(). This is intended for things that might really care. Aaron Schulz's comment: Swift does, and I may change FS to do so as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108710]: New comment added
Reedy posted a comment on MediaWiki.r108710. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108710#c29407 Commit summary for MediaWiki.r108710: Fix fatal in r108694. Reedy's comment: Thanks Siebrand! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] postgreSQL testing
On Thu, 12 Jan 2012 16:17:00 +0100, Antoine Musso wrote: Hello, I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/ As of now, there are two tests failing. Excellent. Thank you for this. -- -- Dan Nessett ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108463]: New comment added
Mglaser posted a comment on MediaWiki.r108463. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108463#c29408 Commit summary for MediaWiki.r108463: include Windows Azure SDK for PHP into extension Mglaser's comment: I talked to Ben Lobaugh about this and we decided to remove the not so important bits of Azure SDK for PHP. This has two benefits: the lint tests should not break anymore and we reduced size. Done so in r108463 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] postgreSQL testing
On Thu, Jan 12, 2012 at 7:17 AM, Antoine Musso hashar+...@free.fr wrote: I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/ Awesome! This'll be a big help in protecting against some common regressions. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108693]: New comment added
Reedy posted a comment on MediaWiki.r108693. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108693#c29409 Commit summary for MediaWiki.r108693: Make some things conditional for = 1.17 Reedy's comment: Lol, yup. Fixed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108465]: New comment added
Mglaser posted a comment on MediaWiki.r108465. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108465#c29410 Commit summary for MediaWiki.r108465: Added installation instructions Made path to SDK configurable Mglaser's comment: Since the Azure SDK now comes with the extension, I removed the $wgWindowsAzureSDKRoot settings entirely. r108737 should fix this issue. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99909]: New comment added, and revision status changed
Platonides changed the status of MediaWiki.r99909 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99909#c29411 Old Status: new New Status: resolved Commit summary for MediaWiki.r99909: Followup r80375: let PreprocessorTest work on Preprocessor_Hash etc as well as Preprocessor_Dom Using same technique as ApiExpandTemplates to serialize the object tree back to XML, rather than asking for the DOM implementation's internal XML return function. Have to also perform normalization on the test cases, as they aren't normalized to what libxml2 serializes. :P Note that there are 4 test failures currently with Preprocessor_Hash, as it makes a separate equals element around = which doesn't appear to be in Preprocessor_Dom's output. Platonides's comment: Yes, it's ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] postgreSQL testing
On Thu, 12 Jan 2012 16:17:00 +0100, Antoine Musso wrote: Hello, I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/ As of now, there are two tests failing. While I am grateful for the inclusion of a postgres backend in the integration tests, I just ran make safe on MW 108734 and got 1 error, 25 failures and 12 incomplete tests. Any idea why the local run has different results that the automated run? I have attached the most recent run output to bug 33663. -- -- Dan Nessett ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] New committer
MrBlueSky now has core and extensions access and aims on working on Core and extensions: small bugfixes and enhancements, adding and updating documentation (comments), writing unit-tests. In general: small things that need to be done. Welcome, MrBlueSky! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] postgreSQL testing
On Thu, 12 Jan 2012 17:59:09 +, Dan Nessett wrote: On Thu, 12 Jan 2012 16:17:00 +0100, Antoine Musso wrote: Hello, I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is: https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/ As of now, there are two tests failing. While I am grateful for the inclusion of a postgres backend in the integration tests, I just ran make safe on MW 108734 and got 1 error, 25 failures and 12 incomplete tests. Any idea why the local run has different results that the automated run? I have attached the most recent run output to bug 33663. Sorry, my mistake. I forgot to run update. After doing so, I also get only 2 failures. -- -- Dan Nessett ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] JavaScript on Special:UserLogin?
Of course, if the login form code wasn't such a swamp, there'd be a hook you could use to preprocess the usernames server-side... :-( The getCanonicalName function in the auth plugins will do this. I was actually thinking of adding a hook to LdapAuthentication in that function to let users munge the name however they'd like before LdapAuthentication munges it further. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] postgreSQL testing
Dan Nessett wrote: Sorry, my mistake. I forgot to run update. After doing so, I also get only 2 failures. Good to know your previous issues were solved :-) Now we need people to correct the last 2 ones :b -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] proposed tech conference anti-harassment policy
What if you need more attention and want to be harassed? Amir: Also, SVN does kinda suck :P Seriously though, this looks great. I've been fortunate enough to not have been harassed at a conference much more than being trolled on occasion, but I think that's a more borderline case that doesn't quite warrant any serious actions. That said, I think there's an excuse game that gets played a lot. When I've expressed concern in the past I've often been told things like like yeah, but they are a really good contributor, that's just how they are, deal with it or they're [enter country of origin here], that's just how they are, deal with it. This lays some ground rules that are fair in any venue around the world. Thanks for putting this together. - Trevor On Thu, Jan 12, 2012 at 8:35 AM, Amir E. Aharoni amir.ahar...@mail.huji.ac.il wrote: 2012/1/12 Chad innocentkil...@gmail.com On Thu, Jan 12, 2012 at 11:04 AM, David Gerard dger...@gmail.com wrote: On 12 January 2012 16:00, Sumana Harihareswara suma...@wikimedia.org wrote: The Wikimedia Foundation is dedicated to a harassment-free conference experience for everyone. I'm proposing a fairly short and standard anti-harassment policy of the type that's becoming best practice for tech conferences and hackathons. Draft: https://www.mediawiki.org/wiki/User:Sumanah/AHP Nice one :-) A candidate for WMF and wider Wikimedia events in general, too. I don't see anything preventing harassment over choice of DBMS ;-) In all seriousness, i was harassed more than once IRL and online for saying that SVN doesn't suck as much as die-hard Git fans say it does. This policy can say preferred technology in addition to Creative Commons license. -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] New committer
Sumana Harihareswara wrote: MrBlueSky now has core and extensions access and aims on working on Core and extensions: small bugfixes and enhancements, adding and updating documentation (comments), writing unit-tests. In general: small things that need to be done. Welcome, MrBlueSky! Watch out for MissWhiteCloud :-b Welcome! -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Wmfall] Please Welcome Andre Engels
On Thu, Jan 12, 2012 at 3:22 AM, Tomasz Finc tf...@wikimedia.org wrote: I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. Welcome to the WMF team, Andre! Great to have your help. :-) All best, Erik -- Erik Möller VP of Engineering and Product Development, Wikimedia Foundation Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Please Welcome Andre Engels
On 12 January 2012 11:22, Tomasz Finc tf...@wikimedia.org wrote: Greetings all, I'm pleased to announce that Andre Engles has decided to join the Mobile team as our data analyst contractor. In this role he'll provide the mobile team with key metrics to guide our software development efforts. He'll be working closely with Diederik, Phil, Erick Zachte, me, and others to standardize, automate, and expand our growing analytics needs. Fantastic news, congratulations Andre (or perhaps, congratulations WMF)! J. -- James D. Forrester jdforres...@wikimedia.org | jdforres...@gmail.com [[Wikipedia:User:Jdforrester|James F.]] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Small-ish gadget project: Bug update gadget
Very cool. Nice work Mark! On Wed, Jan 11, 2012 at 9:10 PM, Mark A. Hershberger mhershber...@wikimedia.org wrote: mhershber...@wikimedia.org (Mark A. Hershberger) writes: Rob Moen rm...@wikimedia.org writes: I fiddled with the request parameters for a while trying to get the JSON RPC to not throw errors. I settled with a URL request for now which is working nicely. Feel free to shoot me ideas / thoughts on how this could be improved. I can think of all sorts of ways to improve this. I may take a crack at it soon. You can see my improvements here: http://labs.wikimedia.deployment.wmflabs.org/wiki/Problem_reports (Following up here even though I mentioned it in another email because that one may have be TL;DR for some people.) Mark. -- Rob Moen Wikimedia Foundation rm...@wikimedia.org ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108727]: New comment added
Nikerabbit posted a comment on MediaWiki.r108727. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108727#c29412 Commit summary for MediaWiki.r108727: testswarm: fix submitted job name Nikerabbit's comment: //mediawiki.org will not work btw, it will aways redirect to http://www.mediawiki.org ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r106642]: Revision status changed
GWicke changed the status of MediaWiki.r106642 to ok
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106642
Old status: new
New status: ok
Commit summary for MediaWiki.r106642:
ParserFunctions: made {{#time}} respect parser's timestamp, just as
{{CURRENTDATE}} and friends do
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105459]: New comment added, and revision status changed
GWicke changed the status of MediaWiki.r105459 to ok and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105459#c29413
Old Status: new
New Status: ok
Commit summary for MediaWiki.r105459:
(bug 32351) Make #time[l] support explicitly specified timezones. Patch by Van
de Bugger.
This would make something like {{#time:H:i:s| 9:30 January 1, 2012 MST}}
convert the time from 9:30 mountatin standard time to whatever it is in UTC.
I made one minor change from the patch on bugzilla in changing an @ to a
wfSuppressWarnings. (The @ was already in the code, it wasn't introduced by the
patch).
GWicke's comment:
Minor nitpick: s/default inpu /default input /. Ran the parser tests, but did
not test with PHP 5.2.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108734]: New comment added, and revision status changed
Nikerabbit changed the status of MediaWiki.r108734 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108734#c29414 Old Status: new New Status: ok Commit summary for MediaWiki.r108734: Consistency: made all API examples a verbs Nikerabbit's comment: Both form as verbs, in fact. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108736]: Revision status changed
Nikerabbit changed the status of MediaWiki.r108736 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108736 Old status: new New status: ok Commit summary for MediaWiki.r108736: Simplify r108693 Also fix stupid logic error noticed by Niklas ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108743]: New comment added
Aaron Schulz posted a comment on MediaWiki.r108743. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108743#c29416 Commit summary for MediaWiki.r108743: Kill * @return void Aaron Schulz's comment: Whhhy? It distinguishes a lack of documentation with someone deliberately saying that nothing should be returned? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99840]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r99840 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99840 Old status: new New status: ok Commit summary for MediaWiki.r99840: Followup to r99653 (bug 31643) -- reenable client-side thumbnailing of SVGs on Special:Upload, with workaround for Firefox 7 regression. Upstream firefox bug for hang loading some SVGs via data URI: https://bugzilla.mozilla.org/show_bug.cgi?id=694165 A fix may land as soon as Firefox 8. This rev works around the bug by using window.URL.createObjectURL() instead of loading a data URI via FileReader; the object URL loads more cleanly and doesn't have the same hanging bug. Needs to be replicated to UploadWizard (or moved to a shared lib!), some other fixes coming so no rush. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89706]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r89706 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89706 Old status: new New status: resolved Commit summary for MediaWiki.r89706: Reinstate r79122 (fix for bug 14404), reverting r83868. The real bug seem to have been r86131, fixed in r88902 (1.17) and r88902 (1.18). This is not merged with the r86131 change to Article::getParserOptions() since I don't see the point for the new function yet. Reenabled its test ArticleTablesTest which was disabled in r85618 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] postgreSQL testing
On Thu, Jan 12, 2012 at 12:46 PM, Antoine Musso hashar+...@free.fr wrote: Dan Nessett wrote: Sorry, my mistake. I forgot to run update. After doing so, I also get only 2 failures. Good to know your previous issues were solved :-) Now we need people to correct the last 2 ones :b One should be fixed[1], not sure on why the JobQueue related issue is still broken. Only reason I can think of is it's not pulling from the right table, or the job isn't being inserted correctly. 1 - https://integration.mediawiki.org/ci/job/MediaWiki-postgres-phpunit/7/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r108743]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r108743 to reverted URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108743 Old status: new New status: reverted Commit summary for MediaWiki.r108743: Kill * @return void ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108745]: New comment added
Reedy posted a comment on MediaWiki.r108745. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108745#c29417 Commit summary for MediaWiki.r108745: Reverted r108743 per CR comment. This should at least be discussed first. Reedy's comment: And everytime I have (accidentally!) added @return void in doing much documentation stuff, I've always been told to remove it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108745]: New comment added
Aaron Schulz posted a comment on MediaWiki.r108745. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108745#c29418 Commit summary for MediaWiki.r108745: Reverted r108743 per CR comment. This should at least be discussed first. Aaron Schulz's comment: By whom? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r102112]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r102112 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102112 Old status: new New status: ok Commit summary for MediaWiki.r102112: * Made OuputPage::showPermissionsErrorPage() show a different messages for 'read', 'edit', 'create' and 'upload' actions to saying You need to log in to do this action when 1) The user is not logged in 2) The only error is a permissions error (no block or something else) and 3) The error can simply be avoided by logging in * This replaces OuputPage::loginToUse() functionnality, made it simply throw a PermissionsEror exception and updated all calls in core * Same for the check in SpecialUpload::execute(), EditPage::userNotLoggedInPage() and EditPage::noCreatePermission() * Throw the same exception in EditPage::attemptSave() whether the user is logged in or not and let OuputPage::showPermissionsErrorPage() decide which message to display * Replaced call to deprecated OutputPage::blockedPage() in SpecialUpload * Displayed messages are the same as now, except the title is always loginreqtitle * 'nocreatetitle' and 'uploadnologin' messages are still used by extensions, so I kept them, but the message 'whitelistedittitle' is not used anymore and has been removed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108746]: Revision status changed
Preilly changed the status of MediaWiki.r108746 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108746 Old status: new New status: ok Commit summary for MediaWiki.r108746: Minor type cleanups ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108744]: Revision status changed
Preilly changed the status of MediaWiki.r108744 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108744 Old status: new New status: ok Commit summary for MediaWiki.r108744: * Fixed a bit of bogus code left in r108740 * Added some class comments ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108742]: Revision status changed
Preilly changed the status of MediaWiki.r108742 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108742 Old status: new New status: ok Commit summary for MediaWiki.r108742: Unindent code to use elseif ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108741]: Revision status changed
Preilly changed the status of MediaWiki.r108741 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108741 Old status: new New status: ok Commit summary for MediaWiki.r108741: Documentation Wrap some long lines ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108704]: Revision status changed
Preilly changed the status of MediaWiki.r108704 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108704 Old status: new New status: ok Commit summary for MediaWiki.r108704: added basic file handler to script and added a new arg to specify output file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108705]: Revision status changed
Preilly changed the status of MediaWiki.r108705 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108705 Old status: new New status: ok Commit summary for MediaWiki.r108705: changed the day ranges for edit count periods ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108712]: Revision status changed
Preilly changed the status of MediaWiki.r108712 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108712 Old status: new New status: ok Commit summary for MediaWiki.r108712: bug 33583 search ns user pref ignored! r106780 to fix bug 33270 introduced a new bug that prevented selected namespaces for search to be applied. This patch fix the issue. Credits to Brad Jorsch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108745]: New comment added
Reedy posted a comment on MediaWiki.r108745. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108745#c29419 Commit summary for MediaWiki.r108745: Reverted r108743 per CR comment. This should at least be discussed first. Reedy's comment: I wonder if I'm confusing it with @static... Just gone back through my contribs, and can't see anything suggesting not to add @return void HMM ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108720]: Revision status changed
Preilly changed the status of MediaWiki.r108720 to resolved
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108720
Old status: new
New status: resolved
Commit summary for MediaWiki.r108720:
Follow-up r108549: {{PLURAL}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108725]: Revision status changed
Preilly changed the status of MediaWiki.r108725 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108725 Old status: new New status: ok Commit summary for MediaWiki.r108725: update .ini following r108075 also had to rename 'username' to 'user' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r108726]: Revision status changed
Preilly changed the status of MediaWiki.r108726 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108726 Old status: new New status: ok Commit summary for MediaWiki.r108726: swap assertEquals parameters in TemplateCategoriesTest First parameter is expected, second is the result ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
