[MediaWiki-CodeReview] [MediaWiki r39787]: Revision status changed
Siebrand changed the status of MediaWiki.r39787 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/39787 Old status: fixme New status: new Commit summary for MediaWiki.r39787: Grammar tweak (bug 14239) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96847]: New comment added
Siebrand posted a comment on MediaWiki.r96847. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96847#c32284 Commit summary for MediaWiki.r96847: Start producing new style move log entries Siebrand's comment: There's nothing wrong with this as such. This is how the new log system works, and this is no reason for fixme, I think. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111180]: New comment added
Duplicatebug posted a comment on MediaWiki.r80.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80#c32285
Commit summary for MediaWiki.r80:
Fix bug 12021 - Provide additional links on Special:Listusers
Patch from John N.
Duplicatebug's comment:
Need LinkBatch. There is already a LinkBatch in UsersPager::getBody. The best
is to move that code into method doBatchLookups and add the user talk page.
pre
function doBatchLookups() {
$this-mResult-rewind();
$batch = new LinkBatch;
foreach ( $this-mResult as $row ) {
$batch-add( NS_USER, $row-user_name );
$batch-add( NS_USER_TALK, $row-user_name );
}
$batch-execute();
$this-mResult-rewind();
}
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114081]: New comment added, and revision status changed
Raymond changed the status of MediaWiki.r114081 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081#c32286
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r114081:
adding special page with scaffolding for caching chunks of HTML
Raymond's comment:
Especially for the content of $1:
{{messagedocumentation}}
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added
Duplicatebug posted a comment on MediaWiki.r114067. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32287 Commit summary for MediaWiki.r114067: adding a duration function to language that converts seconds to text Duplicatebug's comment: Where is the difference between Language::formatDuration and Language::formatTimePeriod? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Using PHP's assert in MediaWiki code
Dear all, should we allow using PHP's assert [1] in MediaWiki code? It would allow us to formulate and automatically verify conditions about code, while at the same time providing readable documentation of code for free. Possible, exemplary use cases would be: - automatically verifyable documentation of code's intent - guarding against logic pitfalls like forgetting to set a variable in all branches of switches, if/else cascades - guarding against using uninitialized variables What do you think? Kind regards, Christian P.S.: For typical MediaWiki use cases, PHP's assert is even faster than throwing exceptions behind 'if'-guards. [1] http://php.net/manual/en/function.assert.php (Not to confuse with PHPUnit's functions for assertions, which solve a different problem.) -- quelltextlich e.U. \\ Christian Aistleitner Companies' registry: 360296y in Linz Christian Aistleitner Gruendbergstrasze 65aEmail: christ...@quelltextlich.at 4040 Linz, Austria Phone: +43 732 / 26 95 63 Fax:+43 732 / 26 95 63 Homepage: http://quelltextlich.at/ --- signature.asc Description: Digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r111180]: New comment added
Duplicatebug posted a comment on MediaWiki.r80. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80#c32288 Commit summary for MediaWiki.r80: Fix bug 12021 - Provide additional links on Special:Listusers Patch from John N. Duplicatebug's comment: Why not using Linker::userToolLinks? Makes the discussion link a little bit standardised (Have a look at [[Special:ActiveUsers]]) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Test suite for dumping MediaWikis using xmldumps-backup
Hi Saper,
On Sat, Mar 17, 2012 at 09:22:11PM +, Marcin Cieslak wrote:
Christian Aistleitner christ...@quelltextlich.at wrote:
[ xmldumps-{backup,test} ]
Ok so those are two separate pieces of software, [...]
Yes.
My consfusion came from the fact that I started reading
README.installation (of -test) that starts with description
of -backup.
You are right. Maybe this is too confusing. I'll update the
documentation to make the distinction more obvious.
Kind regards,
Christian
--
quelltextlich e.U. \\ Christian Aistleitner
Companies' registry: 360296y in Linz
Christian Aistleitner
Gruendbergstrasze 65aEmail: christ...@quelltextlich.at
4040 Linz, Austria Phone: +43 732 / 26 95 63
Fax:+43 732 / 26 95 63
Homepage: http://quelltextlich.at/
---
signature.asc
Description: Digital signature
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114097]: Revision status changed
Raymond changed the status of MediaWiki.r114097 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114097 Old status: new New status: ok Commit summary for MediaWiki.r114097: New messages to translate for the monuments api. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114098]: Revision status changed
Raymond changed the status of MediaWiki.r114098 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114098 Old status: new New status: ok Commit summary for MediaWiki.r114098: First letter uppercase. Looks better in table header and in lists. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules
Hi!
Can a JavaScript / ResourceLoader guru explain what's wrong with my code?
Module definitions at server side:
http://pastebin.com/8cmRbNxe
modules are loaded correctly by the following code:
http://pastebin.com/MFWk6znv
It is checked many times during extension development, 'localBasePath'
and 'remoteExtPath' is set up correctly.
* By default, the module with the following code is loaded:
http://pastebin.com/0u96aMep
Then it loads either 'ext.jqgmap.view' module or 'ext.jqgmap.edit'
module, depending on data provided in generated html page.
This is made for two reasons:
1. Editor code is larger and when the page does not need the editor, it
loads only viewer code, which is faster to load.
2. Editor modifies the mw.jqgmap.MapController.prototype.createEditor
and in the future may also introduce or modify more prototypes. This
makes code more modular.
However, I have very big problem loading 'ext.jqgmap.view' from
'ext.jqgmap.edit':
1.
mw.loader.using( 'ext.jqgmap.view', function() {
2.
console.log(mw.jqgmap);
When callback function is executed, Chrome console does not show
mw.jqgmap as being defined. So console.log(mw.jqgmap) returns
'undefined' and only when that happens, actual execution of
'ext.jqgmap.view' begins. It seems that ResourceLoader loads the code
wrapped into exception handler which tries to detect when the code has
to be loaded. That would be ok, however, when I execute
'ext.jqgmap.view' code step by step:
1.
if ( mw.jqgmap ) {
2.
return;
3.
}
4.
5.
mw.jqgmap = (function () {
First line
if ( mw.jqgmap ) {
}
is executed second time, when mw.jqgmap value is set with closure
result. Then the further execution of code just stops. No further errors
in Chrome console. And, even mw.jqgmap is correctly defined!
There used to be no if (mw.jqgmap) ( return; ) check originally, then
another code (Google maps) complained about being included twice, which
may cause unpredictable results.
How can I fix the chain of loading so it will correctly setup
mw.jqgmap.MapController and mw.jqgmap.MarkerController so they will be
different in edit and view mode and available to use in 'ext,jqgmap' code?
I also have the whole extension under development however I haven't
comitted it into svn yet - I don't know whether yet another map
extension is desirable there. Although there was no rule against
duplicate functionality in extensions?
ResourceLoader is a bit hard to me.
Dmitriy
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Using prototypical inheritance in dynamically loaded ResourceLoader modules
On 18.03.2012 18:26, Dmitriy Sintsov wrote: replaced 'new MarkerController(...)' calls to 'new mw.jqgmap.MarkerController(...)' calls left from incomplete refactoring of early working (non-broken) revision, however refactored separate view / edit modules code still does not work, with the same js code being stopped without additional Chrome errors - so it hard to guess the reason what's broken in my js code. Dmitriy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Call for Submissions I-SEMANTICS 2012 (Deadline: April 13th)
apologies for multiple posts Call for Papers I-SEMANTICS 2012 8th International Conference on Semantic Systems Graz, Austria, 5 - 7 September 2012 http://www.i-semantics.at including Call for Submissions 5th Linked Data Cup Latest News: = Wolters Kluwer Germany main sponsor of I-SEMANTICS 2012 I-SEMANTICS proceedings published by ACM ICPS Important Dates (Research Application Papers I-Challenge) + Abstract Submission Deadline : April 2, 2012 + Paper Submission Deadline : April 13, 2012 + Notification of Acceptance: May 7, 2012 + Camera-Ready Paper: June 4, 2012 Important Dates (I-Challenge) + Paper Submission Deadline : April 13, 2012 + Notification of Acceptance: May 7, 2012 + Camera-Ready Paper: June 4, 2012 Important Dates (Posters Demo Papers PhD Track) + Submission Deadline: May 21, 2012 + Notification of Acceptance: June 18, 2012 = Hashtag for I-SEMANTICS 2012: #isem2012 Scope = I-SEMANTICS 2012 (www.i-semantics.at) is the 8th International Conference within the I-SEMANTICS series. I-SEMANTICS 2012 brings together both researchers and practitioners in the areas of Semantic Technologies, Linked Data and the Semantic Web in order to showcase cutting edge research, demonstrators and applications for the Corporate and Social Semantic Web. I-SEMANTICS 2012 is proud to announce the new format ?I-CHALLENGE?, which brings to you the 5th Linked Data Cup (formerly Triplification Challenge), the Best Paper Award and the Best Poster Award. As in the past years the I-SEMANTICS Conference will be complemented by I-KNOW (www.i-know.at), the 12th International Conference on Knowledge Management, aiming to reflect the increasing importance and convergence of knowledge management and semantic systems. Topics == As a conference aiming to bring together science and industry, I-SEMANTICS encourages scientific research and application-oriented contributions in the field of Semantic Technologies, Semantic Web and Linked Data. The topics of interest for this year?s conference include but are not limited to: The Web of Data + (Large scale) triplification of existing (structured) data + Vocabularies, taxonomies and schemas for the Web of Data + Querying, searching and browsing over the Web of Data + Data integration and interlinking for the Web of Data + User interaction and innovative visualizations for the Web of Data + Languages, tools and methodologies for representing, managing and reasoning on the Web of Data + (Mashup) applications utilizing (large scale) Linked Data resources + Recommender systems making use of the Web of Data + Integrating microposts into the Web of Data + Linked Enterprise Data and (Open) Linked Government Data + Connecting the Web of Data with real world sensor data + Location-based services and mobile semantic applications Quality of Semantic Data on the Web + Provenance information for the Web of Data + Large scale ontology inspection and repair + Co-reference detection and dataset reconciliation + Maintenance of Linked Data models + Trust, privacy and security in Semantic Web applications Corporate Semantic Web + Corporate thesauri, business vocabularies, ontologies and rules + Semantic business, e-commerce and m-commerce systems + Semantic procurement for enterprises and governments + Semantics, pragmatics and semiotics in organizations + Enterprise trust and reputation management Semantic Content Engineering + Collaborative ontology engineering + Ontology modularity, alignment and merging + Ontology design patterns and life cycle management + Ontology learning and knowledge acquisition + Quality criteria for collaboratively generated semantic content + Semantic annotation and tagging + Making sense of microposts + Semantic content management systems Semantic Multimedia + Semantic-driven multimedia applications + Multimedia ontologies and infrastructures + Content-based semantic multimedia analysis and data mining + Semantic-driven multimedia indexing and retrieval + Named entity recognition and disambiguation in multimedia documents + Human-computer interfaces for multimedia data access + Smart visualization and browsing of multimedia documents + User-generated semantic metadata for multimedia documents Studies, Metrics Benchmarks + Case studies of and benchmarks in semantic systems usage + Evaluation perspectives, methods and Semantic Web research methodologies + Technology assessment, acceptance/media choice theories + Usability and user interaction with semantic technologies + Applications with clear
[MediaWiki-CodeReview] [MediaWiki r114067]: New comment added
Reedy posted a comment on MediaWiki.r114067.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114067#c32290
Commit summary for MediaWiki.r114067:
adding a duration function to language that converts seconds to text
Reedy's comment:
formatTimePeriod only does days... Whereas formatDuration now does upto
millenia!
pre
'seconds'= '{{PLURAL:$1|$1 second|$1 seconds}}',
'minutes'= '{{PLURAL:$1|$1 minute|$1 minutes}}',
'hours' = '{{PLURAL:$1|$1 hour|$1 hours}}',
'days' = '{{PLURAL:$1|$1 day|$1 days}}',
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114100]: Revision status changed
Reedy changed the status of MediaWiki.r114100 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114100 Old status: new New status: ok Commit summary for MediaWiki.r114100: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114081]: New comment added
Reedy posted a comment on MediaWiki.r114081. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081#c32291 Commit summary for MediaWiki.r114081: adding special page with scaffolding for caching chunks of HTML Reedy's comment: duration needs to become formatDuration ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114081]: Revision status changed
Jeroen De Dauw changed the status of MediaWiki.r114081 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114081 Old status: fixme New status: new Commit summary for MediaWiki.r114081: adding special page with scaffolding for caching chunks of HTML ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114023]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r114023. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114023#c32292 Commit summary for MediaWiki.r114023: work on special:studentactivity and adding frank his images Jeroen De Dauw's comment: Indeed - 114059 :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114066]: Revision status changed
SVG changed the status of MediaWiki.r114066 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114066 Old status: new New status: ok Commit summary for MediaWiki.r114066: r114064: Update keys. Ignored message was deleted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10024]: Revision status changed
Xqt changed the status of pywikipedia.r10024 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10024 Old status: new New status: ok Commit summary for pywikipedia.r10024: Split off section recognition functionality to textlib.py. See also: pywikipediabot-Bugs-2776438 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10026]: Revision status changed
Xqt changed the status of pywikipedia.r10026 to ok URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10026 Old status: new New status: ok Commit summary for pywikipedia.r10026: Applies r10024 to the rewrite ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114108]: New comment added
Reedy posted a comment on MediaWiki.r114108. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114108#c32293 Commit summary for MediaWiki.r114108: WhiteSpace: Initial revision. Reedy's comment: Are you going to get that core patch into trunk phase3? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Google Summer of Code update how we'll run it
On 03/10/2012 12:40 PM, Sumana Harihareswara wrote: I submitted our application to Google and we're just waiting for March 16th, when we'll hear whether we've been accepted. We were accepted. Students won't be able to formally apply till March 26th, but until then we encourage students to start proposals on subpages of their mediawiki.org userpages, get feedback, and look for mentors. I'm also thankful to everyone who's offering to mentor this year - https://www.mediawiki.org/wiki/Summer_of_Code_2012#Mentor_signup . If you're interested in mentoring, please read https://www.mediawiki.org/wiki/Summer_of_Code_2012/management#GSoC_management_philosophy and http://en.flossmanuals.net/GSoCMentoring/ . I want to make sure all our students have excellent experiences, and mentoring is a big part of that. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114109]: Revision status changed
Krinkle changed the status of MediaWiki.r114109 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114109 Old status: new New status: ok Commit summary for MediaWiki.r114109: Localisation updates for Toolserver i18n from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114092]: New comment added
Amire80 posted a comment on MediaWiki.r114092. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114092#c32294 Commit summary for MediaWiki.r114092: qqq++ Amire80's comment: indicatiuon? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114112]: New comment added
SPQRobin posted a comment on MediaWiki.r114112. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114112#c32295 Commit summary for MediaWiki.r114112: When it's an unrecognised project (wikimedia.org domain), redirect to a default Meta page instead of any useless Incubator page. See bug 33809. (I'll create the Meta page when this is marked ok.) SPQRobin's comment: I'm tagging this with 1.19wmf1, for deployment, although it's independent from the MediaWiki checkout. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114092]: New comment added
Jeroen De Dauw posted a comment on MediaWiki.r114092. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114092#c32296 Commit summary for MediaWiki.r114092: qqq++ Jeroen De Dauw's comment: double typo o-my-god! Fixed by r114115 :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114115]: Revision status changed
Amire80 changed the status of MediaWiki.r114115 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114115 Old status: new New status: ok Commit summary for MediaWiki.r114115: follow up to r114092, fix typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Mark Hershberger departing Wikimedia Foundation in May
On 03/16/2012 01:31 PM, Rob Lanphier wrote: Mark has been a passionate advocate for community developers, and hasn't shied away from asking for what they need. He has been a friendly and approachable representative for WMF; enthusiastic and cheerful with everyone he deals with. Thank you, Mark, for setting this example! I second this strongly. Mark, you have our gratitude. You've always had our community at the front of your thoughts and your heart. Thank you. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114092]: Revision status changed
Amire80 changed the status of MediaWiki.r114092 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114092 Old status: new New status: ok Commit summary for MediaWiki.r114092: qqq++ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114107]: Revision status changed
Amire80 changed the status of MediaWiki.r114107 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114107 Old status: new New status: deferred Commit summary for MediaWiki.r114107: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Using PHP's assert in MediaWiki code
On 18/03/12 20:37, Christian Aistleitner wrote: Dear all, should we allow using PHP's assert [1] in MediaWiki code? It would allow us to formulate and automatically verify conditions about code, while at the same time providing readable documentation of code for free. Possible, exemplary use cases would be: - automatically verifyable documentation of code's intent - guarding against logic pitfalls like forgetting to set a variable in all branches of switches, if/else cascades - guarding against using uninitialized variables What do you think? We use exceptions for that. P.S.: For typical MediaWiki use cases, PHP's assert is even faster than throwing exceptions behind 'if'-guards. That's funny, for me if is about 10 times faster than assert() in the non-throwing case. Micro-optimisation in PHP usually revolves around minimising the number of function calls, since a function call is relatively complex and expensive compared to other opcodes. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added
Krinkle posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32297 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure but somehow it slipped through this one (it's a 2 line wrapper, easy to miss). * Added unit test (which failed before this commit) * Fixes: -- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the return this.each loop. Krinkle's comment: Bug isn't new in 1.19, but in 1.19 there is new code that triggers this bug so it is a regression, tagging for backport ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added
IAlex posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32298 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure but somehow it slipped through this one (it's a 2 line wrapper, easy to miss). * Added unit test (which failed before this commit) * Fixes: -- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the return this.each loop. IAlex's comment: Please add new RELEASE-NOTES in the Changes since 1.19 beta 1 section now that the beta is out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114107]: New comment added
Nikerabbit posted a comment on MediaWiki.r114107. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114107#c32299 Commit summary for MediaWiki.r114107: Localisation updates for core and extension messages from translatewiki.net Nikerabbit's comment: Why was duration-millennia message removed from MessagesEn? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114107]: New comment added
ST47 posted a comment on MediaWiki.r114107. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114107#c32300 Commit summary for MediaWiki.r114107: Localisation updates for core and extension messages from translatewiki.net ST47's comment: Because it was typoed in messages.inc. bug 35309. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GSoC project : Implement pre- or post-commit checks in code repositories
Hi If somebody wants to be the mentor for this project please let me know. I'm really interested in doing it this summer. On Sun, Mar 18, 2012 at 3:03 AM, Akash Nawani akash.naw...@gmail.comwrote: Hi Everyone I am a 4th year Engineering student from India. I would love to work on the Implementing pre- or post-commit checks in code repositories project if somebody can mentor this project. It is a great idea to have this kind of hooks on the repositories. This project is surely going to save a lot of time of code reviewers. Looking forward for a mentor. Thanks. -- Cheers, Akash -- Cheers, Akash ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114091]: Revision status changed
Amire80 changed the status of MediaWiki.r114091 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114091 Old status: new New status: ok Commit summary for MediaWiki.r114091: qqq++ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Using PHP's assert in MediaWiki code
+1 to what Tim said. I effectively said as much about a week ago when this was brought up on IRC. I'd also add that the behavior of assertions vary based on configuration, which is confusing at best. Unlike MWExceptions, which are all handled the same. -Chad On Mar 18, 2012 6:10 PM, Tim Starling tstarl...@wikimedia.org wrote: On 18/03/12 20:37, Christian Aistleitner wrote: Dear all, should we allow using PHP's assert [1] in MediaWiki code? It would allow us to formulate and automatically verify conditions about code, while at the same time providing readable documentation of code for free. Possible, exemplary use cases would be: - automatically verifyable documentation of code's intent - guarding against logic pitfalls like forgetting to set a variable in all branches of switches, if/else cascades - guarding against using uninitialized variables What do you think? We use exceptions for that. P.S.: For typical MediaWiki use cases, PHP's assert is even faster than throwing exceptions behind 'if'-guards. That's funny, for me if is about 10 times faster than assert() in the non-throwing case. Micro-optimisation in PHP usually revolves around minimising the number of function calls, since a function call is relatively complex and expensive compared to other opcodes. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114118]: Revision status changed
Amire80 changed the status of MediaWiki.r114118 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114118 Old status: new New status: ok Commit summary for MediaWiki.r114118: Bug 35309 - formatDuration message missing/inconsistent Patch by Dan Collins ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] reject edits that cause two links for the same language
http://en.wikipedia.org/wiki/Diabetes_mellitus Languages * 中文 * Afrikaans * አማርኛ * العربية ... * 粵語 * Žemaitėška * 中文 The first and last are the same. The first is a link to a template. Maybe there should be some error detection system put in place to reject edits that cause two links for the same language. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r110209]: New comment added
Krinkle posted a comment on MediaWiki.r110209. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110209#c32301 Commit summary for MediaWiki.r110209: [Special:MovePage] Split new title input, fix bug 29454 (byteLimit), namespaceSelector * Two reasons: -- Limit bug: Limit can't be enforced if the two are together because only page_title is limited, the namespace prefix is not part of the title. Plus even then, there is still ambiguity with the various ways to denote namespaces (aliases) and whitespace freedom between namespace, colon and title. -- Extra feature: Now that the two are separate it' s easier for users to move across namespaces as one doesn't have to type, can't make spelling mistakes. Also, in the future we could exclude certain target namespaces that are not possible or not allowed (now one can perfectly submit a request to move from NS_CATEGORY or NS_FILE, only to get a warning on submission). By showing them disabled in the drop down this becomes clearer). * Keeps backwards compatibility for gadgets and permalinks generated by templates on wikis so that they can still pre-set the new title from a url the old way. The new way can also be pre-set from the url, and allows them to be set separately (wpNewTitleNs=10wpNewTitleMain=Infobox) * Gadgets and templates linking to Special:MovePage with a preset target -- Old way (still works): wpNewTitle=Template:Infobox -- New way: wpNewTitleNs=10 (and/or) wpNewTitleMain=Infobox * Fixes bug 29454; Depends on r109990; -- (bug 29454) Enforce byteLimit for page title input on Special:MovePage Krinkle's comment: It doesn't make a problem, it triggers an existing problem. Thanks for discovering, fixed in r114116. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] reject edits that cause two links for the same language
On Sun, 18 Mar 2012 17:39:19 -0700, jida...@jidanni.org wrote: http://en.wikipedia.org/wiki/Diabetes_mellitus Languages * 中文 * Afrikaans * አማርኛ * العربية ... * 粵語 * Žemaitėška * 中文 The first and last are the same. The first is a link to a template. Maybe there should be some error detection system put in place to reject edits that cause two links for the same language. That's a template bug http://en.wikipedia.org/wiki/Template:OGTT doesn't noinclude it's own zh link. ;) I believe we've told you to report en.wp errors to en.wp instead of here before. WikiText is loose, we don't throw errors for small mistakes, we try to work around them. Rejecting edits for something that may not even be their fault is a bad user experience too. In this case the user adding a [[zh:]] to a page shouldn't be punished because a template author forgot to includeonly the language link meant only for the template. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
Well OK, but in no case could Languages * 中文 * 中文 be legitimate. We observer the illegal ones float to the very top of the list to boot. At least they could be made a different color. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Auto-created gerrit accounts for users that had enough info in USERINFO
On 03/17/2012 06:05 PM, Platonides wrote: On 17/03/12 22:08, Bináris wrote: I have an account to Pywikibot only (still on SVN), not MediaWiki. Is there any sense for me to get a git account at this point? I just want to familiarize myself with the system, will I be able to do anything in practice? Sure. I think there is a test repository somewhere precisely for that. A couple of test repositories: https://gerrit.wikimedia.org/r/p/test/mediawiki/core.git and https://gerrit.wikimedia.org/r/p/test/mediawiki.git You can see their histories at https://gerrit.wikimedia.org/r/gitweb?p=test/mediawiki/core.git;a=summary and https://gerrit.wikimedia.org/r/gitweb?p=test/mediawiki.git;a=summary You can view all the repositories at this link: https://gerrit.wikimedia.org/r/#admin,projects -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
On Sun, 18 Mar 2012 19:47:48 -0700, jida...@jidanni.org wrote: Well OK, but in no case could Languages * 中文 * 中文 be legitimate. We observer the illegal ones float to the very top of the list to boot. At least they could be made a different color. They don't flot to the top of the list. That one was just the first language link defined on the page. And there's no metadata where we could put making them a different color. Color of the ui is skin business not the business of the parser. Besides, ;) color doesn't show up in your precious text browsers. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Bugzilla Weekly Report
MediaWiki Bugzilla Report for March 12, 2012 - March 19, 2012 Status changes this week Bugs NEW : 225 Bugs ASSIGNED : 18 Bugs REOPENED : 33 Bugs RESOLVED : 175 Total bugs still open: 7340 Resolutions for the week: Bugs marked FIXED : 107 Bugs marked REMIND : 0 Bugs marked INVALID: 26 Bugs marked DUPLICATE : 19 Bugs marked WONTFIX: 18 Bugs marked WORKSFORME : 6 Bugs marked LATER : 4 Bugs marked MOVED : 0 Specific Product/Component Resolutions User Metrics New Bugs Per Component Site requests 8 Javascript 4 UploadWizard4 Semantic MediaWiki 3 Blocking3 New Bugs Per Product MediaWiki 26 Wikimedia 12 MediaWiki extensions24 Wikimedia Mobile2 Wikimedia Labs 1 Top 5 Bug Resolvers sam [AT] reedyboy.net 17 mah [AT] everybody.org 13 marcin.cieslak [AT] gmail.com 11 EN.WP.ST47 [AT] gmail.com 9 brion [AT] wikimedia.org7 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Mark Hershberger departing Wikimedia Foundation in May
Thanks hexmode, for helping make this community welcoming and awesome to me as a Volunteer dev. -- Yuvi Panda ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r114006]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r114006 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114006 Old status: new New status: ok Commit summary for MediaWiki.r114006: Update for cldr 21.0, unfortunately some rules were renumbered ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] reject edits that cause two links for the same language
Ah, all along the seemingly consistent order of available languages on the bottom of each page depends on hand sorting them in the source of each page. Let's imagine it is the year 2050 and each article has been translated into each language. A simple misplaced language would e.g., cause ZH users, who are used to looking for their language at the bottom, to not find it. Also some authors might think, ZH is the worlds most populous language, it belongs on the top! So to prevent anarchy consider some standard sort automatically implemented. OK, enough FUD from me today, bye. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
On 19 March 2012 03:47, jida...@jidanni.org wrote: Well OK, but in no case could Languages * 中文 * 中文 be legitimate. I disagree. There are plenty of examples where an English article (for instance) is covered in two or more languages in another language, where it makes no sense to link to a disambiguous page. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
On Mon, Mar 19, 2012 at 09:52, jida...@jidanni.org wrote: Let's imagine it is the year 2050 and each article has been translated into each language. A simple misplaced language would e.g., cause ZH users, who are used to looking for their language at the bottom, to not find it. Much before that happens, Universal Language Selector[1] should fix that issue. [1] http://mediawiki.org/wiki/Universal_Language_Selector -- Regards Srikanth.L ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
On Sun, 18 Mar 2012 21:22:03 -0700, jida...@jidanni.org wrote: Ah, all along the seemingly consistent order of available languages on the bottom of each page depends on hand sorting them in the source of each page. Pretty much... just like categories. Let's imagine it is the year 2050 and each article has been translated into each language. A simple misplaced language would e.g., cause ZH users, who are used to looking for their language at the bottom, to not find it. Also some authors might think, ZH is the worlds most populous language, it belongs on the top! So to prevent anarchy consider some standard sort automatically implemented. Except language sorting is even more chaotic than sorting category names on a multilingual wiki (different languages sort the same set of special letters differently). What do you sort by? By lang code? But that's a technical bit that has nothing to do with the user. By name in English? But that has nothing to do with the name the user is expecting. By native name? But that's sorting by letters, with multiple scripts, different languages sort things differently, and some don't even have rules for how to sort some characters. Things still end up in places people aren't expecting. And it 'still' isn't a fair way to sort things. By wiki size, activity, link popularity? Now the language system has to start tracking piles of data that isn't even available locally. It has to fetch data from remote wikis and some of that data might not even exist. It's also an immense amount of code. By language we expect the user to want? Sure... but that's only part of the list. And worse our pages our static. We can't go and start varying by Accept-Language causing the cache size Wikipedia takes up to be multiplied by over 100. OK, enough FUD from me today, bye. ;) Long as you know where you stand. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
S == Svip svi...@gmail.com writes: S On 19 March 2012 03:47, jida...@jidanni.org wrote: Well OK, but in no case could Languages * 中文 * 中文 be legitimate. S I disagree. There are plenty of examples where an English article S (for instance) is covered in two or more languages in another S language, where it makes no sense to link to a disambiguous page. All I know is make sure the links look different then. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] reject edits that cause two links for the same language
On Sun, 18 Mar 2012 21:39:19 -0700, Srikanth Lakshmanan srik@gmail.com wrote: On Mon, Mar 19, 2012 at 09:52, jida...@jidanni.org wrote: Let's imagine it is the year 2050 and each article has been translated into each language. A simple misplaced language would e.g., cause ZH users, who are used to looking for their language at the bottom, to not find it. Much before that happens, Universal Language Selector[1] should fix that issue. [1] http://mediawiki.org/wiki/Universal_Language_Selector A relevant article: http://www.gpaumier.org/blog/628_universal-language-picker/ -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] New committer
Gave Hannes Röst (hroest) access to work on pywikipediabot (pywikibot). Also gave Christian Aistleitner core MediaWiki commit access (he'd previously only had extensions access). I imagine this is the last email we'll send about MediaWiki commit access (this week I'll change https://www.mediawiki.org/wiki/Commit_access_requests ), but the pywikipediabot community wants to stay with Subversion for the time being so you'll see a trickle of those. :-) -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113669]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113669 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113669#c32302 Old Status: ok New Status: fixme Commit summary for MediaWiki.r113669: Completing the form fields. Santhosh.thottingal's comment: Please define the variable $m as array() somewhere in the beginning. And it would be better if the variable is renamed to a more descriptive name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112457]: New comment added
Krinkle posted a comment on MediaWiki.r112457. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112457#c32303 Commit summary for MediaWiki.r112457: [mediawik.special.changeslist] Remove ugly arrow swapping hack * Use CSS and change the background image, instead of displaying 2 img tags and hiding one based on the parent element's class * touches bug 17616 a bit, although it doesn't address the focus issue yet, but does improve the overal structure of this module * Also speeds up by: - Outputting less markup - Having 1 embedded images in the CSS file instead of (N changes)*img tags * jquery.makeCollapsible: Krinkle's comment: I was expecting that the jQuery makeCollapsible plugin would take care of that (since it's not a custom-collapsible). Will checkout soon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
