[Wikitech-l] Re: Facing error in pushing the patch

2022-02-04 Thread Andre Klapper
Hi,

On Sat, 2022-02-05 at 11:57 +0530, Shreyaans Jain wrote:
> Hey everyone I was working on Videocuttool
> issue https://phabricator.wikimedia.org/T297992 and now the issue is
> resolved but I am unable to push the patch. I have properly
> set the ssh key on both my system as well as gerrit and also did the
> steps many times but still facing the problem. It will be great if
> anyone can help me in it .

Please follow https://www.mediawiki.org/wiki/Gerrit/Tutorial

Thanks,
andre
-- 
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing a Problem in issue #105

2022-02-04 Thread Greg Grossmeier
Hi,

Searching for "afch-rewrite" leads me to
https://github.com/WPAFC/afch-rewrite with the homepage of
https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script
.
I presume that is what this is about.

Their documentation says they use a Zulip for communication:
https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing#Need_help?


Might want to try there if the github issue isn't proving helpful.

Best,

Greg

On Fri, Feb 4, 2022 at 9:08 PM AMEY Gupta  wrote:

> Hey I am facing a problem in issue #105  in ( afch-rewrite). I am
> following this approach for (avoiding empty comments) . At first I wrote a
> function to calculate the length of the text area and if the text area's
> length is 0 then I,ll disabled the button . but I am getting confused about
> how to get the button disabled .
>
>   Screenshot (302)_LI.jpg
> 
>
>   Screenshot (303)_LI.jpg
> 
>
>
>
>
>
>
>
>
>
> On Fri, 4 Feb, 2022, 10:07 pm Andre Klapper, 
> wrote:
>
>> On Fri, 2022-02-04 at 20:31 +0530, Ameygupta wrote:
>> > Hey I am facing a problem in issue #105 (Don.t enter empty comments)
>> > can anyone help me about it ?
>>
>> Not without further context, I'm afraid. :) What and where is "issue
>> #105"? Please provide sufficient context, as this is a mailing list
>> with hundreds of members and about any kind of Wikimedia related
>> development (which means thousands of software projects).
>>
>> Thanks,
>> andre
>> --
>> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
>> https://blogs.gnome.org/aklapper/
>> ___
>> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
>> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
>>
>> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>>
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing a Problem in issue #105

2022-02-04 Thread Andre Klapper
Hi,

On Sat, 2022-02-05 at 10:36 +0530, AMEY Gupta wrote:
> Hey I am facing a problem in issue #105  in ( afch-rewrite). I am
> following this approach for (avoiding empty comments) . At first I
> wrote a function to calculate the length of the text area and if the
> text area's length is 0 then I,ll disabled the button . but I am
> getting confused about how to get the button disabled .
> 
>  Screenshot (302)_LI.jpg
> 
>  Screenshot (303)_LI.jpg

Please always provide links and sufficient context.
Most people here do not know what "afch-rewrite" is.

If you have a specific question about
https://github.com/WPAFC/afch-rewrite/issues/105
you probably want to bring it up in that ticket.

See also
https://www.mediawiki.org/wiki/New_Developers#Some_general_communication_tips

Cheers,
andre
-- 
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing a Problem in issue #105

2022-02-04 Thread AMEY Gupta
Hey I am facing a problem in issue #105  in ( afch-rewrite). I am following
this approach for (avoiding empty comments) . At first I wrote a function
to calculate the length of the text area and if the text area's length is 0
then I,ll disabled the button . but I am getting confused about how to get
the button disabled .

  Screenshot (302)_LI.jpg


  Screenshot (303)_LI.jpg










On Fri, 4 Feb, 2022, 10:07 pm Andre Klapper,  wrote:

> On Fri, 2022-02-04 at 20:31 +0530, Ameygupta wrote:
> > Hey I am facing a problem in issue #105 (Don.t enter empty comments)
> > can anyone help me about it ?
>
> Not without further context, I'm afraid. :) What and where is "issue
> #105"? Please provide sufficient context, as this is a mailing list
> with hundreds of members and about any kind of Wikimedia related
> development (which means thousands of software projects).
>
> Thanks,
> andre
> --
> Andre Klapper (he/him) | Bugwrangler / Developer Advocate
> https://blogs.gnome.org/aklapper/
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
>
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread Kunal Mehta



Hi,

On 2/4/22 08:58, Adam Baso wrote:
Thanks for sharing this. I was wondering, might it be possible to help 
bring this sort of functionality into Code Search ( 
https://codesearch.wmflabs.org  ) ? I 
noticed the presentation of the search UI looked similar, but I see how 
the symbol resolution might be something useful for Code Search and 
upstream Hound. 


Indeed, we've been discussing and exploring symbol-based search for a 
while now: . There are some 
pretty neat upstream projects that do this like  
and zoekt, which is designed for Gerrit integration. I would also note 
that things are likely to change whenever we migrate to GitLab, which 
has its own search functionality built-in 
(). My assumption is that 
GitLab will add symbol-based search eventually to compete with GitHub, 
hopefully that ends up in the CE version someday...


While I very much disagree with the opening proposition that "Working 
with Wikimedia code is time-consuming and risky", I think symbol search 
of the MediaWiki codebase would be incredibly powerful and unlock a new 
level of tooling, just like Codesearch did when it was first introduced, 
so I'm glad to see people looking into it! For example we could do stuff 
like  with it.


There were two main principles in building MediaWiki Codesearch, first 
that everything be licensed as free software[1] (which Bryan covered as 
well) and that we try to use upstream as much as possible. Our 
modifications are injected by a proxy rather than patch the upstream 
code...which has turned out to be incredibly stable over the years.


If you want to collaborate, all the code and setup is in Git and can add 
you to the project, but I see little to no value in building proprietary 
tools or reinventing what other projects have done pretty well rather 
than building on top of them.


[1] https://mako.cc/writing/hill-free_tools.html

-- Legoktm
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/


[Wikitech-l] Re: [Ops] Re: Tendril shutdown

2022-02-04 Thread Daniel Zahn
Yes, it's much prettier than dbtree.  Nice!

On Thu, Feb 3, 2022 at 4:48 PM Aaron Schulz  wrote:
>
> I really like the visual tree on https://orchestrator.wikimedia.org/ . Good 
> work!
>
> On Tue, Jan 4, 2022 at 3:18 AM Manuel Arostegui  
> wrote:
>>
>> Hello,
>>
>> If you don’t use tendril.wikimedia.org or dbtree.wikimedia.org, feel free to 
>> ignore this message.
>>
>>
>> As of today, tendril is now retired and the main page is replaced with a 
>> list of replacement for different services tendril used to provide:
>>
>>
>> For checking out our dbtree and replication data:
>>
>> if you are in the NDA LDAP group, use Orchestrator
>>
>> otherwise, use the information page on noc.wikimedia.org. For more detail 
>> you can also check eqiad.json or codfw.json
>>
>> If you are looking for slow queries log, go to slow queries dashboard using 
>> our standard observability platform (logstash) (NDA required)
>>
>>
>> Tendril has been a great tool for us during the years, but unfortunately it 
>> is impossible to maintain with modern MariaDB versions (it uses TokuDB, 
>> which is no longer available on MariaDB after 10.1 and needs to be compiled 
>> separately) nor its webservice is compatible with modern php versions. Its 
>> database is still running on Stretch and on MariaDB 10.1 (which has not been 
>> supported for a year already) and it is having serious scalability issues. 
>> This would unblock us from removing a lot of legacy home-brew craft and 
>> replace them with more modern toolings such as orchestrator.
>>
>>
>> Orchestrator has been in place for a few months now, and provides us with a 
>> great way to see and (in the future) manage replication topologies. For now 
>> we are using it only for visualization purposes but in the future we’d like 
>> it to also help us to handle replication changes (it can be done from the UI 
>> or via CLI) and recover topologies automatically if they fail and involve 
>> masters or intermediate masters.
>>
>>
>> The slow queries dashboard in logstash offer multiple advantages over 
>> tendril. You can set the threshold to see slow queries that took longer to 
>> run. You can filter out code paths you’re not interested in or zoom in to 
>> relevenet code paths. You can limit it to write queries or read queries 
>> only. Also, it provides id of the request making the slow query, so you can 
>> cross check it with the rest of logstash or hadoop to identify problematic 
>> behavior.
>>
>>
>> If you need it for the transition period, you can still access it in 
>> tendril-legacy.wikimedia.org. But it will be shut down in a month. You can 
>> follow the work of shutting down tendril in 
>> https://phabricator.wikimedia.org/T297605.
>>
>>
>> Thank you.
>>
>>
>> ___
>> Ops mailing list -- o...@lists.wikimedia.org
>> To unsubscribe send an email to ops-le...@lists.wikimedia.org
>
> ___
> Ops mailing list -- o...@lists.wikimedia.org
> To unsubscribe send an email to ops-le...@lists.wikimedia.org



-- 
Daniel Zahn 
Operations Engineer
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread Bryan Davis
On Fri, Feb 4, 2022 at 9:40 AM  wrote:
>
> saves to MongoDB

This is problematic from the point of view of shared use within the
Wikimedia movement. MongoDB is a source available product under the
non-free SSPL license [0]. This license was invented by MongoDB and
submitted to the Open Source Initiative (OSI) for OSI approval and
then later withdrawn [1]. The OSI now have a page explaining why this
license is not likely to ever be given OSI approval [2].

This is all esoteric property rights management things to many people,
but the Wikimedia Cloud Services environment (Cloud VPS and Toolforge)
Terms of Use [3] requires that software installed in these
environments is licensed under an OSI approved license. Thus MongoDB,
modern versions of Elasticsearch, and other SSPL licensed software are
not allowed. Even if SSPL was OSI approved it would be problematic in
Cloud VPS & Toolforge as the main point of the license is to restrict
cloud service providers from offering SSPL licensed software as a
service to their clients.

[0]: https://en.wikipedia.org/wiki/Server_Side_Public_License
[1]: 
https://lists.opensource.org/pipermail/license-review_lists.opensource.org/2019-March/003989.html
[2]: https://opensource.org/node/1099
[3]: 
https://wikitech.wikimedia.org/wiki/Wikitech:Cloud_Services_Terms_of_use#What_uses_of_Cloud_Services_do_we_not_like?

Bryan
-- 
Bryan Davis  Technical Engagement  Wikimedia Foundation
Principal Software Engineer   Boise, ID USA
[[m:User:BDavis_(WMF)]]  irc: bd808
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/


[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread Jay prakash
Hi Dima,

It looks very identical to our current code search tool
https://codesearch.wmcloud.org/. I am curious how much is fast
from hound-search.[1]


Jay Prakash

[1] https://github.com/hound-search/hound

On Fri, Feb 4, 2022 at 10:10 PM  wrote:

> Speed & Function prototyped a ClassCrawler - extremely fast and structured
> code search engine.
>
> PROBLEM:
> Working with Wikimedia code is time-consuming and risky. It takes a lot of
> time and effort when it comes to research of classes and methods with
> specific characteristics, research of dependencies and complexity, and
> understanding how refactoring impacts the whole system.
>
> SOLUTION FROM S&F:
> - ClassCrawler code search tool - https://classcrawler.prettyclear.com/
> - Project repository in GitLab - https://gitlab.com/snf1/classcrawler;
> https://gitlab.com/snf1/classcrawler-php
>
> WHAT IS a ClassCrawler?
> ClassCrawler is a code search engine.
>
> It parses PHP code into structure → saves to MongoDB → provides results in
> simple Web interface, so you can use all power of MongoDB query to find
> exactly what you need.
>
> See the Guide and Use Cases - https://classcrawler.prettyclear.com/guide
>
> …And this is just the beginning of what can be done in the future.
>
> WE NEED YOUR FEEDBACK
>
> - We share this idea from developers (us) to developers – YOU! So you can
> start using this capable and powerful tool in your everyday workflow when
> it is released.
> - Your feedback is extremely valuable. Please tell us what you think and
> help us make it perfect for you and other developers.
> - You can share your feedback directly through ClassCrawler –
> https://classcrawler.prettyclear.com/feedback
>
> Your friends from S&F
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread Adam Baso
Dima,

Thanks for sharing this. I was wondering, might it be possible to help
bring this sort of functionality into Code Search (
https://codesearch.wmflabs.org ) ? I noticed the presentation of the search
UI looked similar, but I see how the symbol resolution might be something
useful for Code Search and upstream Hound. One thing I've missed from the
now olden days of Windows native development was the ability of some of the
tooling to do this kind of stuff elegantly. Just to be clear: we don't
necessarily have lots of support for some of the tools that are up and
running, but I know longtime contributors Legoktm and Ladsgroup are on the
list here as well.

Adam Baso (he/him/his/Adam)
Director of Engineering
Product Engineering
Wikimedia Foundation



On Fri, Feb 4, 2022 at 10:40 AM  wrote:

> Speed & Function prototyped a ClassCrawler - extremely fast and structured
> code search engine.
>
> PROBLEM:
> Working with Wikimedia code is time-consuming and risky. It takes a lot of
> time and effort when it comes to research of classes and methods with
> specific characteristics, research of dependencies and complexity, and
> understanding how refactoring impacts the whole system.
>
> SOLUTION FROM S&F:
> - ClassCrawler code search tool - https://classcrawler.prettyclear.com/
> - Project repository in GitLab - https://gitlab.com/snf1/classcrawler;
> https://gitlab.com/snf1/classcrawler-php
>
> WHAT IS a ClassCrawler?
> ClassCrawler is a code search engine.
>
> It parses PHP code into structure → saves to MongoDB → provides results in
> simple Web interface, so you can use all power of MongoDB query to find
> exactly what you need.
>
> See the Guide and Use Cases - https://classcrawler.prettyclear.com/guide
>
> …And this is just the beginning of what can be done in the future.
>
> WE NEED YOUR FEEDBACK
>
> - We share this idea from developers (us) to developers – YOU! So you can
> start using this capable and powerful tool in your everyday workflow when
> it is released.
> - Your feedback is extremely valuable. Please tell us what you think and
> help us make it perfect for you and other developers.
> - You can share your feedback directly through ClassCrawler –
> https://classcrawler.prettyclear.com/feedback
>
> Your friends from S&F
> ___
> Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
> To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
> https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] ClassCrawler – extremely fast and structured code search engine

2022-02-04 Thread dima . batt
Speed & Function prototyped a ClassCrawler - extremely fast and structured code 
search engine.

PROBLEM:
Working with Wikimedia code is time-consuming and risky. It takes a lot of time 
and effort when it comes to research of classes and methods with specific 
characteristics, research of dependencies and complexity, and understanding how 
refactoring impacts the whole system.

SOLUTION FROM S&F:
- ClassCrawler code search tool - https://classcrawler.prettyclear.com/ 
- Project repository in GitLab - https://gitlab.com/snf1/classcrawler; 
https://gitlab.com/snf1/classcrawler-php

WHAT IS a ClassCrawler?
ClassCrawler is a code search engine.

It parses PHP code into structure → saves to MongoDB → provides results in 
simple Web interface, so you can use all power of MongoDB query to find exactly 
what you need. 

See the Guide and Use Cases - https://classcrawler.prettyclear.com/guide

…And this is just the beginning of what can be done in the future.

WE NEED YOUR FEEDBACK

- We share this idea from developers (us) to developers – YOU! So you can start 
using this capable and powerful tool in your everyday workflow when it is 
released.
- Your feedback is extremely valuable. Please tell us what you think and help 
us make it perfect for you and other developers.
- You can share your feedback directly through ClassCrawler – 
https://classcrawler.prettyclear.com/feedback

Your friends from S&F
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Re: Facing a Problem in issue #105

2022-02-04 Thread Andre Klapper
On Fri, 2022-02-04 at 20:31 +0530, Ameygupta wrote:
> Hey I am facing a problem in issue #105 (Don.t enter empty comments)
> can anyone help me about it ?

Not without further context, I'm afraid. :) What and where is "issue
#105"? Please provide sufficient context, as this is a mailing list
with hundreds of members and about any kind of Wikimedia related
development (which means thousands of software projects).

Thanks,
andre
-- 
Andre Klapper (he/him) | Bugwrangler / Developer Advocate
https://blogs.gnome.org/aklapper/
___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/


[Wikitech-l] Production Excellence #40: January 2022

2022-02-04 Thread Krinkle
How’d we do in our strive for operational excellence last month? Read on to 
find out!

Incidents
There were no incidents this January. Pfew! Remember to review and schedule 
Incident Follow-up work  
in Phabricator. These are preventive measures and tech debt mitigations written 
down after an incident is concluded. Read about past incidents at Incident 
status  on Wikitech.

Trends
During 2021, I compared us to the median of 4 incidents per month, as measured 
over the two years prior (2019-2020).

I'm glad to announce our median has lowered to 3 per month over the past two 
years (2020-2021). For more plots and numbers about our incident documentation, 
refer to Incident stats .

Since the previous edition, we resolved 17 tasks from previous months. In 
January, there were 45 new error reports 
 of which 28 
have been resolved within the same month, the remaining 17 have carried over to 
February.

With precisely 17 tasks both closed and added, the workboard remains at the 
exact total of 298 open tasks, for the third month in a row. That's quite the 
coincidence.

Figure 1: Unresolved error reports by month. 


Take a look at the workboard and look for tasks that could use your help.
→  https://phabricator.wikimedia.org/tag/wikimedia-production-error/

Thanks!
Thank you to everyone who helped by reporting, investigating, or resolving 
problems in Wikimedia production. Thanks!

Until next time,

– Timo Tijhof

*🎸 Doc Brown *: *It 
could mean that that point in time contains some cosmic significance.., as if 
it were the temporal junction point of the entire space-time continuum… Or it 
could just be an amazing coincidence.*



🔗 Share or read later via https://phabricator.wikimedia.org/phame/post/view/266/

___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/

[Wikitech-l] Facing a Problem in issue #105

2022-02-04 Thread Ameygupta
Hey I am facing a problem in issue #105 (Don.t enter empty comments) can anyone help me about it ?  Sent from Mail for Windows ___
Wikitech-l mailing list -- wikitech-l@lists.wikimedia.org
To unsubscribe send an email to wikitech-l-le...@lists.wikimedia.org
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/