[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added
"SPQRobin" posted a comment on MediaWiki.r112479.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31989
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave "invalid code" when selecting
SPQRobin's comment:
Thought I added @since..
Done in r113385. Are there other indentation issues?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added, and revision status changed
"Nikerabbit" changed the status of MediaWiki.r112479 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31939
Old Status: new
New Status: ok
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave "invalid code" when selecting
Nikerabbit's comment:
Some indentation issues like in docs of fetchLanguageNames and it's missing
@since.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added
"Siebrand" posted a comment on MediaWiki.r112479.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31509
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave "invalid code" when selecting
Siebrand's comment:
Thanks, Robin.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added, and revision status changed
"SPQRobin" changed the status of MediaWiki.r112479 to "new" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31504
Old Status: fixme
New Status: new
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave "invalid code" when selecting
SPQRobin's comment:
When fetchLanguageNames is not found, it takes LanguageNames::getNames, i.e.
CLDR directly, so it doesn't need to use getTranslatedLanguageNames. (It's even
better this way, because the mentioned problem was present when calling
getTranslatedLanguageNames.)
Confirmed that it works using a 1.18 checkout with trunk Translate.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added, and revision status changed
"Siebrand" changed the status of MediaWiki.r112479 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31503
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave "invalid code" when selecting
Siebrand's comment:
Translate needs to remain compatible with the latest stable, which is 1.18.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
