[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c32326 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Reading global variables before they are set opens doors to register globals vulnerability. Fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31811 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Feeling adventurous with GPLv3 and PHP 5.3 only features? Please be direct and specific. I am not aware about your troubles with AGLPv3. (Note the A letter in the front.) I am not a PHP guru, and not aware which feature is specific for PHP 5.3. This code works for me, that's enough. If you want something to be fixed, just express in in Basic English. Please find another place for rhetoric exercises, ok? What advantage $egGenderize gives over setting $wgExtraGenderNamespaces directly, which also supports user talk pages? Do not understand what you talking about. The need to set variables before extension setup file is included is frowned upon. What the problem? Either explain or point me where it is explained. Really? Don't you believe? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Nikerabbit posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31816 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Most of the code around MediaWiki is GPLv2. The license is of course our choice. For example __DIR__ only exists in PHP 5.3.0 onwards. Reading global variables before they are set opens doors to register globals vulnerability. See for example [[Register_globals#Configure_extensions_only_after_their_setup_file_is_included]] Your commenting style is awfully verbose. I cannot figure any reason why comment saying end of file is useful. One more thing. PHP does not need semicolon after if/foreach/while blocks, so the convention is to not use them there. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Nikerabbit posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31817 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Meant to say ''your choice''. Obviously everyone takes what suits them best and fits the contraints. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Siebrand posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31819 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Siebrand's comment: Why write this as an extension and not as a proposed patch for core? (That would require a relicense, though) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Van de Bugger posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31822 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Van de Bugger's comment: Why write this as an extension and not as a proposed patch for core? Because (a) Pushing a patch to core even for fixing a bug requires a lot of efforts and time-consuming; this is not a bug but a missed feature and I am not sure how serious it is for core maintainers; (b) Anyway, patch will not be included into 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112924]: New comment added
Nikerabbit posted a comment on MediaWiki.r112924. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112924#c31799 Commit summary for MediaWiki.r112924: Initial revision of Genderize extension. Nikerabbit's comment: Feeling adventurous with GPLv3 and PHP 5.3 only features? What advantage $egGenderize gives over setting $wgExtraGenderNamespaces directly, which also supports user talk pages? The need to set variables before extension setup file is included is frowned upon. Should use a hook or $wgExtensionSetupFunctions. pre!-- end of file --/pre Really? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
