[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added
Krinkle posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32335 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure but somehow it slipped through this one (it's a 2 line wrapper, easy to miss). * Added unit test (which failed before this commit) * Fixes: -- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the return this.each loop. Krinkle's comment: Done in r114121. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added
Krinkle posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32297 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure but somehow it slipped through this one (it's a 2 line wrapper, easy to miss). * Added unit test (which failed before this commit) * Fixes: -- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the return this.each loop. Krinkle's comment: Bug isn't new in 1.19, but in 1.19 there is new code that triggers this bug so it is a regression, tagging for backport ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114116]: New comment added
IAlex posted a comment on MediaWiki.r114116. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114116#c32298 Commit summary for MediaWiki.r114116: [jquery.byteLimit] Set vars in return this.each loop * Set vars in return this.each loop. This is the defacto standard plugin structure but somehow it slipped through this one (it's a 2 line wrapper, easy to miss). * Added unit test (which failed before this commit) * Fixes: -- (bug 35294) jquery.byteLimit shouldn't set element specific variables outside the return this.each loop. IAlex's comment: Please add new RELEASE-NOTES in the Changes since 1.19 beta 1 section now that the beta is out. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
