[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added, and revision status changed
"Aaron Schulz" changed the status of MediaWiki.r114117 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32395 Old Status: new New Status: ok Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Aaron Schulz's comment: Block could use some more accessors. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added
"Bawolff" posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32349 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Bawolff's comment: Thanks for fixing this. The block notice the user sees for this is a little confusing. However its quite possible it was always like that. For reference the user sees (assuming its localhost that was blocked, as was the case on my test wiki. Note: the DNSBL in the text actually links to [[user:DNSBL]]). You do not have permission to edit this page, for the following reason: Your username or IP address has been blocked. The block was made by DNSBL. The reason given is Your IP address is listed as an open proxy in the DNSBL used by Test.. * Start of block: 15:01, 19 March 2012 * Expiry of block: 15:01, 19 March 2012 * Intended blockee: 0:0:0:0:0:0:0:1 You can contact DNSBL or another administrator to discuss the block. You cannot use the 'e-mail this user' feature unless a valid e-mail address is specified in your account preferences and you have not been blocked from using it. Your current IP address is ::1, and the block ID is #. Please include all above details in any queries you make. Perhaps having a FakeBlock object that various classes can detect and do something more intelligent when displaying the error message would be a good approach. Should probably also have a regression test. (DNS blacklist would be difficult, but checking against $wgProxyList should be straightforward). I'll try to get around to adding a regression test for that at some point or another. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added
"Krinkle" posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32336 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Krinkle's comment: It also makes it less obvious to merge to 1.19wmf1. btw: should this be backported to REL1_18 (for a potential 1.18.x release) or is this a 1.19 regression? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added
"Krinkle" posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32334 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Krinkle's comment: Could you please stop committing to trunk and REL1_19 at the same time? I noticed it a few times now. It makes it harder to filter things for mediawiki-core (since common-rootpath is no longer /trunk/phase3) and puts unreviewed code in a release branch. Everybody gets reviewed, no exceptions please. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r114117]: New comment added
"Nikerabbit" posted a comment on MediaWiki.r114117. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114117#c32317 Commit summary for MediaWiki.r114117: * (bug 35303) Make proxy and DNS blacklist blocking work again Nikerabbit's comment: It's not immediately obvious why this fixes the bug. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
