[MediaWiki-CodeReview] [MediaWiki r114240]: New comment added

2012-03-20 Thread MediaWiki Mail 
Dantman posted a comment on MediaWiki.r114240.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114240#c32367

Commit summary for MediaWiki.r114240:

redesign for toggle buttons

see http://www.mediawiki.org/wiki/File:Mobile_article_expand.png

Dantman's comment:

Ooohh... now ''that'' looks like a mobile app.

I think you should use an :active to create a highlight bg that shows up when 
the user touches the collapse. A light bluish one. Make sure that the area 
covered fills the screen horizontally and includes the top and bottom padding 
of the block. Something like that should give it a feel very much like what the 
user should be used to with the rest of mobile device's interface.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r114240]: New comment added

2012-03-20 Thread MediaWiki Mail 
Jdlrobson posted a comment on MediaWiki.r114240.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114240#c32380

Commit summary for MediaWiki.r114240:

redesign for toggle buttons

see http://www.mediawiki.org/wiki/File:Mobile_article_expand.png

Jdlrobson's comment:

@Dantman this is a nice idea but note that :active will also be invoked when a 
touchstart or touchend event happens on the section. As a user slides up and 
down the screen the result of this would be a flashing section between blue and 
grey... not good!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r114240]: New comment added

2012-03-20 Thread MediaWiki Mail 
Robmoen posted a comment on MediaWiki.r114240.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/114240#c32384

Commit summary for MediaWiki.r114240:

redesign for toggle buttons

see http://www.mediawiki.org/wiki/File:Mobile_article_expand.png

Robmoen's comment:

corrected svn props on pngs.  marking ok  see r114287.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview