[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added

2011-04-14 Thread MediaWiki Mail 
User Leonsp posted a comment on MediaWiki.r85885.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15969
Commit summary:

Fixes to DB2 support. DB2 support integration with 1.17 Installer and Updater. 
Developed by Andre, Tiago, Diego, and Cesar as described in wikitech-l message. 
Reviewed by me.

Comment:

Updated the message in r86079 to:

* Your DB2 database has a default tablespace with insufficient pagesize. The 
pagesize has to be '''32K''' or greater.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added

2011-04-13 Thread MediaWiki Mail 
User MaxSem posted a comment on MediaWiki.r85885.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15917

Comment:

The message There must be a tablespace with at least 32k of pagesize looks 
like it needs some tweaks.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added, and revision status changed

2011-04-12 Thread MediaWiki Mail 
User IAlex changed the status of MediaWiki.r85885.

Old Status: new
New Status: fixme

User IAlex also posted a comment on MediaWiki.r85885.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85885#c15864

Comment:

* Please set ''svn:eol-style'' property for the files you added
* Don't put ? at the end of PHP files

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added, and revision status changed

2011-04-12 Thread MediaWiki Mail 
User Krinkle changed the status of MediaWiki.r85885.

Old Status: fixme
New Status: new

User Krinkle also posted a comment on MediaWiki.r85885.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15865

Comment:

Note: I have no experience with lbm_db2.

I've looked at the first half dozen diffs, here's some general notes:

pre
--- includes/db/DatabaseIbm_db2.php
+++ includes/db/DatabaseIbm_db2.php

460 + //TODO: Remove commented-out debug code once done debugging
470 + //echo 'preERRORlt;/pre';
471 + //echo 'pre' . $sql . 'lt;/pre';
472   $error = db2_stmt_errormsg();
473 + //echo 'pre' . $error . 'lt;/pre';
/pre

This needs to be removed


pre
498 - $sql =  EOF
498 + /*$sql =  EOF
502 + $sql = SELECT COUNT( * )
/pre
I guess the new value is better, but the old one doesn't have to stay in /* 
comments */, should be removed as well.


pre
905: - //$this-installPrint( Preparing the following SQL: );
905 + $this-installPrint( Preparing the following SQL: ); 
/pre
The previous code on that line (which appears to be debug left by a previous 
developer) was uncommented. Should this be commented out again ?


There's probably a bit more of this. I haven't looked further.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r85885]: New comment added

2011-04-12 Thread MediaWiki Mail 
User Leonsp posted a comment on MediaWiki.r85885.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85885#c15873

Comment:

Thanks for taking a look.

* Fixed svn:eol-style, ? in r85890
* Taken out commented-out code in r85896
* Fixed some indentation I missed 
* Checked to make sure there's no more of the commented out code in the diffs

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview