[MediaWiki-CodeReview] [MediaWiki r86011]: New comment added

2011-04-14 Thread MediaWiki Mail 
User Nimish Gautam posted a comment on MediaWiki.r86011.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15977
Commit summary:

Created BeforeWelcomeCreation hook to be run before any welcome message gets 
displayed

Comment:

hooks.txt modified in r86103

This also exists now: 
http://www.mediawiki.org/wiki/Manual:Hooks/BeforeWelcomeCreation

I feel a little weird about using a CamelCase variable name when the rest of 
the function uses underscore_variables, so I didn't change that.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86011]: New comment added

2011-04-13 Thread MediaWiki Mail 
User Jack Phoenix posted a comment on MediaWiki.r86011.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15935

Comment:

Some minor [[Manual:Coding conventions|coding style]] issues here:
*$welcome_creation_msg should be called $welcomeCreationMsg
*I'd prefer a space after the double slashes: code// let any extensions 
change what message is shown/code
*space after ) and before { (codeif( $msgname ) {/code)

docs/hooks.txt should also be updated.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86011]: New comment added

2011-04-13 Thread MediaWiki Mail 
User Reedy posted a comment on MediaWiki.r86011.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86011#c15937

Comment:

Also, an onwiki Manual page should be created for the hook

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview