[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Valhallasw posted a comment on pywikipedia.r10089.
URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32783
Commit summary for pywikipedia.r10089:
Enable ignore list for repeated runs + some error handling.
Valhallasw's comment:
It's not the *script* that should be fixed, it's this *commit* that should be
fixed because it creates code duplication, which makes maintenance in the long
term more difficult ('technical debt'/'code rot')
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Xqt posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32784 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Xqt's comment: We also have -skipfile in interwiki.py ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Valhallasw posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32779 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Valhallasw's comment: Yep, I'm a moron. I had the patch from http://sourceforge.net/tracker/?func=detailaid=2790445group_id=93107atid=603140 applied. So you're right, it's not in pagegenerators *yet*. However, this still is duplicate code, which should be refactored to a more general method (preferrably in pagegenerators.py). It's also a bonus this patch hasn't been applied yet, because the naming wasn't well thought-out... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Bináris posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32780 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Bináris's comment: Then you might set pagegenerators to fixme and my script to OK. :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Xqt posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32778 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Xqt's comment: I didn't found such a method neighter in rewrite nor in trunk version of pagegenerators.py. %-| ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Valhallasw posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32777 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Valhallasw's comment: There is also a pagegenerators.FilteredGenerator method (pagegenerators.py:602) which wraps TextfilePageGenerator(). TextfilePageGenerator returns a list of pages which the FilteredGenerator uses to filter pages from another generator. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Xqt posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32765 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Xqt's comment: Unfortunatelly there is no pagegenerators.FilteredGenerator() method yet. We only have PageTitleFilterPageGenerator() which expects a dictionary and TextfilePageGenerator() which is able to read a file is the same manner as above; interwiki.py uses it for ignoring some pages listed on a file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added, and revision status changed
Valhallasw changed the status of pywikipedia.r10089 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32750 Old Status: new New Status: fixme Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Valhallasw's comment: This should use pagegenerators.FilteredGenerator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Bináris posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32759 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Bináris's comment: Currently I don't have time to rewrite it or understand what the trouble is with my solution, but feel free do improve it. :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Valhallasw posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32760 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Valhallasw's comment: The issue is that the code to filter a list of pages using an ignore list *already exists* (pagegenerators.FilteredGenerator). Instead of using that one, this code implements it's own version (=code duplication) but with slightly different behaviour (= bug!). In addition, it is much nicer to have filtering where it belongs (in the pagegenerator, and not in the bot code). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r10089]: New comment added
Bináris posted a comment on pywikipedia.r10089. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10089#c32761 Commit summary for pywikipedia.r10089: Enable ignore list for repeated runs + some error handling. Bináris's comment: Some day I will look into it but I am afraid it won't be one of these weeks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
