Re: [Wikitech-l] Continuous integration workflow post-Git migration

2012-03-28 Thread Antoine Musso
Erik Moeller wrote:
snip
 This video BTW has a nice explanation of a working git/gerrit/jenkins
 integration.
 http://vimeo.com/20084957
 
 Notice the Jenkins user posting a build started comment the moment a
 change goes into Gerrit, and then adding a +1 on test or a -1 on
 failure (although that should arguably be a -2).

That is exactly what I am aiming for following a discussion with the
OpenStack developers.  Now that git and 1.19 are on rails, I will
probably switch back to finish up the git jobs in Jenkins :-)

Thanks for posting that screencast. It is a good introduction to Gerrit.


-- 
Antoine hashar Musso



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Re: [Wikitech-l] Continuous integration workflow post-Git migration

2012-03-26 Thread Erik Moeller
On Sat, Mar 17, 2012 at 9:08 AM, Krinkle krinklem...@gmail.com wrote:
 Feel free to discuss it either on the talk page[1] or here on wikitech-l
 and the workflow is also posted to this wiki page:
        https://www.mediawiki.org/wiki/Continuous_integration/Workflow
 so feel free to edit it as you would any other wiki page.

Left a note on talk to clarify that the tests run before any human
review gets involved. :)

I'm noticing that the current GIT-Fetching job in Jenkins already is
running builds against unmerged changesets, so I'm assuming the
workflow page is just in error about builds only being run if changes
are merged?

This video BTW has a nice explanation of a working git/gerrit/jenkins
integration.
http://vimeo.com/20084957

Notice the Jenkins user posting a build started comment the moment a
change goes into Gerrit, and then adding a +1 on test or a -1 on
failure (although that should arguably be a -2).

-- 
Erik Möller
VP of Engineering and Product Development, Wikimedia Foundation

Support Free Knowledge: https://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


[Wikitech-l] Continuous integration workflow post-Git migration

2012-03-17 Thread Krinkle
Hey all,

I've created a thread at MediaWiki.org describing a proposed workflow for
how continous integration works and how it affects the Gerrit workflow
after we finished the migration to Git. Most if not all of the points were
are already discussed, but I wanted to make sure this is indeed what we
want and also to have it properly documented.

Some of it is already being brought into production as we speak.

Feel free to discuss it either on the talk page[1] or here on wikitech-l
and the workflow is also posted to this wiki page:
https://www.mediawiki.org/wiki/Continuous_integration/Workflow
so feel free to edit it as you would any other wiki page.

-- Krinkle

[1] 
https://www.mediawiki.org/wiki/Talk:Continuous_integration#Proposal_for_continuous_integration_.28post-Git_migration.29_13216
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l