Re: [Wikitech-l] Gerrit actively discourages discussion
On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron jer...@tuxmachine.com wrote: Another big one is (1 comment) which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). This one drives me crazy, especially after I've responded to existing comments on Patch Set N. When someone new comments on the same patch set, how can I find the new comments? The best I can do is visit every file in the patch set that has comments and Ctrl+F/Ctrl+G to search for the new reviewer's name. It's already filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=46792 -- =S Page software engineer on E3 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
On Mon, Apr 8, 2013 at 7:32 PM, S Page sp...@wikimedia.org wrote: On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron jer...@tuxmachine.com wrote: Another big one is (1 comment) which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). This one drives me crazy, especially after I've responded to existing comments on Patch Set N. When someone new comments on the same patch set, how can I find the new comments? The best I can do is visit every file in the patch set that has comments and Ctrl+F/Ctrl+G to search for the new reviewer's name. It's already filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=46792 This used to work, but the output format changed a couple of upgrades ago. The hook scripts for Gerrit are all in the puppet repo if anyone cares to hack at them. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation fails, its ok to click to expand just that comment. Or maybe just expand the last jenkin-bot comment, but hide all the previous ones. On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan yastrak...@wikimedia.orgwrote: This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com wrote: I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Yuri Great minds think alike ;-) https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57003797ba9ecb1134797d4 On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan yastrak...@wikimedia.orgwrote: Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation fails, its ok to click to expand just that comment. Or maybe just expand the last jenkin-bot comment, but hide all the previous ones. On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan yastrak...@wikimedia.org wrote: This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com wrote: I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
hehe, thanks! :), just pulled again, but, its broken a bit :( https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it deleted comment lines, but apparently its just in indecipherable colors, until clicked On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson jdlrob...@gmail.com wrote: Yuri Great minds think alike ;-) https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57003797ba9ecb1134797d4 On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan yastrak...@wikimedia.org wrote: Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation fails, its ok to click to expand just that comment. Or maybe just expand the last jenkin-bot comment, but hide all the previous ones. On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan yastrak...@wikimedia.org wrote: This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com wrote: I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
You'll need to reload the extension in chrome://extensions It purposely doesn't delete the comment lines - it just makes them invisible just in case you might want to see them. It's all one big hack so might be wrong but it works for me ;-) On Wed, Apr 3, 2013 at 12:17 PM, Yuri Astrakhan yastrak...@wikimedia.orgwrote: hehe, thanks! :), just pulled again, but, its broken a bit :( https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it deleted comment lines, but apparently its just in indecipherable colors, until clicked On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson jdlrob...@gmail.com wrote: Yuri Great minds think alike ;-) https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57003797ba9ecb1134797d4 On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan yastrak...@wikimedia.org wrote: Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation fails, its ok to click to expand just that comment. Or maybe just expand the last jenkin-bot comment, but hide all the previous ones. On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan yastrak...@wikimedia.org wrote: This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com wrote: I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
on both monitors i checked, 0.2 opacity is too low, plus I don't think it
should apply to the border, just the header inside it, which also removes
the need to restore it on click. What do you think?
function silentNoise( $commentPanel ) {
// makes jenkins comments less prominent
$commentPanel.find( '.commentPanelHeader' ).css( 'opacity', 0.6 );
}
On Wed, Apr 3, 2013 at 3:19 PM, Jon Robson jdlrob...@gmail.com wrote:
You'll need to reload the extension in chrome://extensions
It purposely doesn't delete the comment lines - it just makes them
invisible just in case you might want to see them. It's all one big hack so
might be wrong but it works for me ;-)
On Wed, Apr 3, 2013 at 12:17 PM, Yuri Astrakhan yastrak...@wikimedia.org
wrote:
hehe, thanks! :), just pulled again, but, its broken a bit :(
https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it
deleted
comment lines, but apparently its just in indecipherable colors, until
clicked
On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson jdlrob...@gmail.com wrote:
Yuri
Great minds think alike ;-)
https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b57003797ba9ecb1134797d4
On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan
yastrak...@wikimedia.org
wrote:
Jon, do you think it might make sense to hide all those jenkin-bot
comments? They are mostly noise, and the only time when compilation
fails,
its ok to click to expand just that comment. Or maybe just expand the
last
jenkin-bot comment, but hide all the previous ones.
On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan
yastrak...@wikimedia.org
wrote:
This is awesome!!! Thanks Jon :) And no, I didn't look at the code,
too
scared :)
On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com
wrote:
I feel very dirty having done this but I made a chrome extension
that
autoexpands all comments and adds a comment count next to
unexpanded
older
patchsets.
The code's horrible but it works - feel free to try it out:
https://github.com/jdlrobson/gerrit-be-nice-to-me
I suspect the best long term solution might be to rewrite the
interface.
The fact it is so ajaxay makes enhancements hard unless someone
actually
wants to get to know and work on the gerrit codebase themselves...
On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com
wrote:
Christian Aistleitner wrote:
while I do not want to discourage discussion of those items on
wikitech-l, I nevertheless filed them in bugzilla, so we can
keep
track of the issues / solutions.
This is wonderful. Thank you for filing these bugs, Christian.
I'll
take a
look at them now.
MZMcBride
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
--
Jon Robson
http://jonrobson.me.uk
@rakugojon
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
--
Jon Robson
http://jonrobson.me.uk
@rakugojon
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
--
Jon Robson
http://jonrobson.me.uk
@rakugojon
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Thanks for bringing this up MZ. I completely agree with you. The amount of times I've had to link people on irc to a comment to see it is ridiculous. I'm not sure what the exact solution is but I feel we need to improve it in gerrit itself rather than move to bugzilla. On Mon, Apr 1, 2013 at 7:39 PM, MZMcBride z...@mzmcbride.com wrote: Hi. I'm concerned that Gerrit actively discourages discussion currently. I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the add comment feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Le 02/04/13 04:39, MZMcBride a écrit : I'm concerned that Gerrit actively discourages discussion currently. So do not use it? We have lists, wiki and private emails. I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the add comment feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. The basic misconception is that people attempt to comment the code using the 'cover message' feature when they should really use the inline commenting feature. The cover message is only intended to summarize what you have commented inline, that is also what is shown in the mail notification. When doing inline comments, they are shown in the diff. So if one commented on patchset 2 and is willing to find out whether his suggestion has been achieved, he could use the PS2 as a basis for a diff. All his comments will be shown as well as the following up changes. When I amend a patchset, I will use the [Done] button on each change to confirm the reviewers that I have corrected the issues. Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic. I would prefer having all the code and implementations discussion where the code is, aka in Gerrit. Leaving Bugzilla for confirming the bug resolution or talk about possible policy issues. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Hi, while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. On Mon, Apr 01, 2013 at 10:39:50PM -0400, MZMcBride wrote: * auto-collapsing all comments except the most recent; https://bugzilla.wikimedia.org/show_bug.cgi?id=46774 * no reply feature or support for quoting (similar to what Bugzilla uses); https://bugzilla.wikimedia.org/show_bug.cgi?id=46776 * the add comment feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. https://bugzilla.wikimedia.org/show_bug.cgi?id=46777 Best regards, Christian -- quelltextlich e.U. \\ Christian Aistleitner Companies' registry: 360296y in Linz Christian Aistleitner Gruendbergstrasze 65aEmail: christ...@quelltextlich.at 4040 Linz, Austria Phone: +43 732 / 26 95 63 Fax:+43 732 / 26 95 63 Homepage: http://quelltextlich.at/ --- signature.asc Description: Digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Antoine Musso wrote: Le 02/04/13 04:39, MZMcBride a écrit : I'm concerned that Gerrit actively discourages discussion currently. So do not use it? We have lists, wiki and private emails. [...] I would prefer having all the code and implementations discussion where the code is, aka in Gerrit. Leaving Bugzilla for confirming the bug resolution or talk about possible policy issues. You're being a little silly here. :-) I think I agree with you that keeping the change and the related discussion together would be nice. The question is: how do we make Gerrit less painful to use? Would it be possible to have Gerrit import a JavaScript page from MediaWiki.org (e.g., MediaWiki:Gerrit.js)? This might allow dedicated users to override some of the default behavior (such as the block-level comment auto-collapsing) or add new functionality (such as a reply link similar to Bugzilla's). The basic misconception is that people attempt to comment the code using the 'cover message' feature when they should really use the inline commenting feature. The cover message is only intended to summarize what you have commented inline, that is also what is shown in the mail notification. Gerrit supports both inline commenting and block-level commenting. The inline commenting is actually even more difficult to find and follow than block-level commenting, in my opinion. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
On Tue, Apr 2, 2013 at 9:03 AM, MZMcBride z...@mzmcbride.com wrote: Would it be possible to have Gerrit import a JavaScript page from MediaWiki.org (e.g., MediaWiki:Gerrit.js)? This might allow dedicated users to override some of the default behavior (such as the block-level comment auto-collapsing) or add new functionality (such as a reply link similar to Bugzilla's). There's functionality to write custom Javascript and inject it within Gerrit. So yes, we could easily have our own JS that overrides default behavior here. I wouldn't feel entirely comfortable fetching it from MediaWiki.org on the fly--but we can host the code within Gerrit. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
For my own changes I have a workflow that's a little clunky, but works for me. I'll comment or mark done on every comment, so if I see the same number of drafts as comments, I know I've addressed them all. The workflow I have not found is a way to efficiently re-review other people's changes that I've previously reviewed. It takes a lot of time to properly review a big change, and I don't know an easy way to say Show me all my comments on previous patch sets so I can see if they have been addressed. Luke Welling On Tue, Apr 2, 2013 at 9:10 AM, Chad innocentkil...@gmail.com wrote: On Tue, Apr 2, 2013 at 9:03 AM, MZMcBride z...@mzmcbride.com wrote: Would it be possible to have Gerrit import a JavaScript page from MediaWiki.org (e.g., MediaWiki:Gerrit.js)? This might allow dedicated users to override some of the default behavior (such as the block-level comment auto-collapsing) or add new functionality (such as a reply link similar to Bugzilla's). There's functionality to write custom Javascript and inject it within Gerrit. So yes, we could easily have our own JS that overrides default behavior here. I wouldn't feel entirely comfortable fetching it from MediaWiki.org on the fly--but we can host the code within Gerrit. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson jdlrob...@gmail.com wrote: I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride z...@mzmcbride.com wrote: Christian Aistleitner wrote: while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Jon Robson http://jonrobson.me.uk @rakugojon ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Gerrit actively discourages discussion
Hi. I'm concerned that Gerrit actively discourages discussion currently. I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the add comment feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
You are definitely not the only one who finds these issues annoying. I too worry about the same. ~Matt Walker Wikimedia Foundation Fundraising Technology Team On Mon, Apr 1, 2013 at 7:39 PM, MZMcBride z...@mzmcbride.com wrote: Hi. I'm concerned that Gerrit actively discourages discussion currently. I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the add comment feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker mwal...@wikimedia.org wrote: You are definitely not the only one who finds these issues annoying. I too worry about the same. +1 Another big one is (1 comment) which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). OTOH, the email notifs about inline code comments are often useful. -Jeremy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
On 2013-04-02 12:32 AM, Jeremy Baron jer...@tuxmachine.com wrote: On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker mwal...@wikimedia.org wrote: You are definitely not the only one who finds these issues annoying. I too worry about the same. +1 Another big one is (1 comment) which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). OTOH, the email notifs about inline code comments are often useful. -Jeremy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l +1 to both emails. It can be very frustrating trying to follow a conversation on gerrit after the fact. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Gerrit actively discourages discussion
On 02/04/13 06:43, Brian Wolff wrote: On 2013-04-02 12:32 AM, Jeremy Baron jer...@tuxmachine.com wrote: On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker mwal...@wikimedia.org wrote: You are definitely not the only one who finds these issues annoying. I too worry about the same. +1 Another big one is (1 comment) which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). OTOH, the email notifs about inline code comments are often useful. -Jeremy ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l +1 to both emails. It can be very frustrating trying to follow a conversation on gerrit after the fact. -bawolff ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l This is especially true when considering the results of submitting a new patchset - it can cause all old comments to get lost, in a sense - inline ones are hidden in the previous patchset (which is collapsed), and a new comment covers previous comments, obfuscating any current discussion. -- -— Isarra ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
