[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

--- Comment #7 from Ashish Shukla  ---
Version wireshark-2.3.0-2736-ga847884 does not generate 'geninfo' 
Version 2.2.6rc0-21-gd1d28ea does not have this problem: generates geninfo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

--- Comment #6 from Ashish Shukla  ---
Thanks. I got opportunity to play with -J flag and it seems working fine.
However, I noticed that pdml output no longer has 'geninfo' protocol section.
So something caused missing geninfo proto section since 2.2.6rc0-21-gd1d28ea.
Version 2.2.6rc0-21-gd1d28ea does not have this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

--- Comment #5 from Gerrit Code Review  ---
Change 19671 merged by Alexis La Goutte:
PDML: protocol filter incorrectly filters desired subfields

https://code.wireshark.org/review/19671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

Gerrit Code Review  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

Alexis La Goutte  changed:

   What|Removed |Added

 CC||alexis.lagou...@gmail.com

--- Comment #4 from Alexis La Goutte  ---
For info
There is a patch in review... https://code.wireshark.org/review/#/c/19671

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

Martin Kacer  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
   Severity|Major   |Enhancement

--- Comment #3 from Martin Kacer  ---
I think new switch -J can be added which could work in this way to check only
top level nodes (i.e. protocol level). And keep -j option as it is. Or
something similar (or maybe -j and -jj)

Switch -e (fields filter) was not working for all the output formats when
switch -j was introduced, therefor it was designed in this way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

--- Comment #2 from Ashish Shukla  ---
Thanks for the background!
In some use-cases e.g., analyzing most, if not all, part of the protocol tree
would be easier to just specify a top level protocol filter e.g., 'radiotap',
'wlan'
This make life much simpler as not all fields within this protocol is present
in each packet and also to know e.g., which all fields are present and analyze
differently.

On the other hand, I was under impression that there is already a way to filter
based on set of specified fields. So this was more of selecting entire
protocol/layer e.g., 'radiotap', 'wlan'.
I am fine with adding another option as well if we think we should leave
current option as is to support this new behavior?
Please comment?
Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

--- Comment #1 from Martin Kacer  ---
Currently it was designed in this way. There is the exact match function in the
code. So it is required to include all parent fields in -j filter which should
be included in the output. 

Previously during development there was the substring comparison function which
 worked in similar way as the proposed behavior. But the exact match function
seems to be better to reduce the size of the output. The filtered nodes (e.g. 
) can be added into -j filter
(by adding radiotap.flags).

But suggestions are welcomed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 12847] pdml protocol filter incorrectly filters desired subfields

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=12847

Peter Wu  changed:

   What|Removed |Added

 CC||kacer.mar...@gmail.com,
   ||pe...@lekensteyn.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe