[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

Gerrit Code Review  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

--- Comment #4 from Gerrit Code Review  ---
Change 18297 merged by Anders Broman:
Exclude scanner-generated headers from ABI check

https://code.wireshark.org/review/18297

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

--- Comment #3 from Gerrit Code Review  ---
Change 18297 had a related patch set uploaded by Balint Reczey:
Fix headers for ABI check

https://code.wireshark.org/review/18297

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

--- Comment #2 from Gerrit Code Review  ---
Change 18296 had a related patch set uploaded by Balint Reczey:
Use the proper include dirs for ABI check

https://code.wireshark.org/review/18296

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

Balint Reczey  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||bal...@balintreczey.hu
 Ever confirmed|0   |1

--- Comment #1 from Balint Reczey  ---
No, the proper include paths are always collected in abi-descriptor.xml.

I have fixed this step, but now I'm seeing issues with the header files.

I'm trying to fix the headers up, too, but this patch solved the missing header
problem:

diff --git a/Makefile.am.inc b/Makefile.am.inc
index 49c5579..c19ed62 100644
--- a/Makefile.am.inc
+++ b/Makefile.am.inc
@@ -80,8 +80,8 @@ am__v_YACC_0 = @echo "  YACC" $@;
$(AM_V_RUNLEX)$(RUNLEX) "$(LEX)" "$(SED)" -o$@ $<

 # abi-compliance-checker descriptor
-abi_incdirs = $(subst -I,NEWLINE,$(filter -I%,$(WS_CFLAGS) -I$(abs_top_srcdir)
-I$(abs_srcdir)))
-abi_sysdirs = $(subst -isystem,NEWLINE,$(filter -isystem%,$(WS_CFLAGS)))
+abi_incdirs = $(subst -I,NEWLINE,$(filter -I%,$(AM_CPPFLAGS)
-I$(abs_top_srcdir) -I$(abs_srcdir)))
+abi_sysdirs = $(subst -isystem,NEWLINE,$(filter -isystem%,$(AM_CPPFLAGS)))
 abi_includes = $(abi_incdirs) $(abi_sysdirs)
 abi-descriptor.xml: ../abi-descriptor.template
$(AM_V_SED)$(SED) \

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

[Wireshark-bugs] [Bug 13018] abi-compliance-checker isn't finding glib.h in the "check abi" step

[bugzilla-daemon]

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=13018

Guy Harris  changed:

   What|Removed |Added

Summary|abi-compliance-checker  |abi-compliance-checker
   |isn't finding glib in the   |isn't finding glib.h in the
   |"check abi" step|"check abi" step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Sent via:Wireshark-bugs mailing list 
Archives:https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
 mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe