Re: [Wireshark-dev] TDS : TLS Exchange

[Craig Jackson]

I had thought about trying to decode that, but all of the test traces I had
were proprietary. I'm hoping that the TDS isn't decodable (without other
key information) but the TLS exchange should be. It requires knowing more
about TLS. :-)

Craig

On Fri, Aug 14, 2020 at 10:31 AM Graham Bloice 
wrote:

> Yep, that's what's happening, see here:
> https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-tds/60f56408-0188-4cd5-8b90-25c6f2423868,
> somewhat similar to the STARTTLS behaviour in SMTP for example.
>
> There's currently no code in the TDS dissector to hand-off to the TLS
> dissector.
>
> On Fri, 14 Aug 2020 at 14:50, nalini.elk...@insidethestack.com <
> nalini.elk...@insidethestack.com> wrote:
>
>> Hello List,
>>
>> I have a trace from a Microsoft SQL server using TDS.
>>
>> Tabular Data Stream 
>>
>> Tabular Data Stream
>>
>> During the early development of Sybase SQL Server, the developers at
>> Sybase perceived the lack of a commonly acc...
>> 
>>
>>
>> It looks like the first part of it is the TLS exchange.   I am attaching
>> trace.   Any thoughts on a potential breakout of this?
>>
>> If I decode as TLS, then the application data packets appear to decode
>> fine but not the TLS handshake.
>>
>> Thoughts?
>>
>> Nalini Elkins
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
> Graham Bloice
> Software Developer
> Trihedral UK Limited
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Question about asn2wrs

[Craig Jackson]

Darien,

That is indeed the conclusion I had come to. I'll see if I can incorporate
that detail in the documentation somewhere.

Craig

On Fri, Nov 9, 2018 at 1:34 PM Darien Spencer  wrote:

> Just wanted to add my 2 cents.
> I believe when dealing with reassembled TCP packets the packet info you
> are accessing is that of the latest segment, since it's the one the payload
> will be shown in it's tree in Wireshark.
> If you need this information available between different ASN.1 fields of
> the same packet, the packet info should be the right place to store it.
> If you need this information available between different reassembled
> payload, you should use the conversation.
>
> -- Darien
>
> *Sent:* Friday, November 09, 2018 at 5:37 PM
> *From:* "Pascal Quantin" 
> *To:* "Developer support list for Wireshark" 
> *Subject:* Re: [Wireshark-dev] Question about asn2wrs
>
> Le ven. 9 nov. 2018 à 16:27, Craig Jackson  a
> écrit :
>
>> I think I figured out my path for this particular case. I can remember
>> the current attribute set, and then use custom functions for the display of
>> AttributeElement/attributeType and AttributeElement/attributeValue/numeric.
>> (I'll handle the other choice later.)
>>
>> Now to choose where to store the current attribute set. It could either
>> go into a record associated with the packet, or a record associated with
>> the conversation. The "packet" in this case will be a reassembled TCP
>> stream. I'm not sure what per-packet storage means in that case. I guess
>> it's time for "Use the Source, Luke".
>>
>
> Per packet seems the right choice. See the s1ap_get_private_data()
> function in packet-s1ap-template.c for an example.
>
> Pascal.
>
>
>>
>> Craig
>>
>> On Thu, Nov 8, 2018 at 2:06 PM Pascal Quantin 
>> wrote:
>>
>>> Hi Craig,
>>>
>>> Le jeu. 8 nov. 2018 à 19:44, Craig Jackson  a
>>> écrit :
>>>
>>>> I'm working on a decoder for the NISO Z39.50 protocol. This is an
>>>> ASN.1/BER protocol used in the library automation community.
>>>>
>>>> There some things I'm having trouble figuring out how to configure, and
>>>> there are also a bunch of things which have never been documented in
>>>> asn2wrs. I'm wondering if one or more of the undocumented things could help
>>>> me.
>>>>
>>>> Here's a problematic type definition:
>>>>
>>>>AttributeElement  ::=  SEQUENCE{
>>>>   attributeSet[1]   IMPLICIT AttributeSetId OPTIONAL,
>>>>   attributeType   [120]  IMPLICIT INTEGER,
>>>>   attributeValue  CHOICE{
>>>>  numeric[121]   IMPLICIT INTEGER,
>>>>
>>>> complex[224] IMPLICIT SEQUENCE{
>>>>   list [1] IMPLICIT SEQUENCE OF
>>>> StringOrNumeric,
>>>>semanticAction  [2] IMPLICIT SEQUENCE OF INTEGER
>>>> OPTIONAL}}}
>>>>
>>>> The issue is that the "attributeType" values are actually enumerations
>>>> chosen based on the value of "attributeSet". I see how I can supply a fixed
>>>> set of strings using FIELD_ATTR (poorly documented), but I can't figure out
>>>> how to get control so I could specify different sets of strings. (This
>>>> might be done by specifying alternate hf values, perhaps.)
>>>>
>>>> I think I could hard-code the type specifying my own choice array, but
>>>> I'm wondering if there's a better way.
>>>>
>>>
>>> Several ASN.1 dissectors have fields with a dissection depending on
>>> another field. See for example s1ap.cnf file and the code for HandoverType
>>> and Source-ToTarget-TransparentContainer fields.
>>> So you could store the attributeSet value in the packet (using the
>>> p_add_proto_data() function) and retrieve it when decoding the
>>> attributeType value (thanks to the p_get_proto_data() function) and select
>>> the right value_string (by selecting the relevant hg value, taht could be
>>> manually defined in your template file - like what is done in
>>> packet-s1ap-template.c). the PER dissector allows you to define a hf value
>>> to -1 to avoid getting the item added to the tree automatically and
>>> retrieving the field so as to manually select the right hf to use. I'm not
>>> playing with BER but presumably either i

Re: [Wireshark-dev] Question about asn2wrs

[Craig Jackson]

I think I figured out my path for this particular case. I can remember the
current attribute set, and then use custom functions for the display of
AttributeElement/attributeType and AttributeElement/attributeValue/numeric.
(I'll handle the other choice later.)

Now to choose where to store the current attribute set. It could either go
into a record associated with the packet, or a record associated with the
conversation. The "packet" in this case will be a reassembled TCP stream.
I'm not sure what per-packet storage means in that case. I guess it's time
for "Use the Source, Luke".

Craig

On Thu, Nov 8, 2018 at 2:06 PM Pascal Quantin 
wrote:

> Hi Craig,
>
> Le jeu. 8 nov. 2018 à 19:44, Craig Jackson  a
> écrit :
>
>> I'm working on a decoder for the NISO Z39.50 protocol. This is an
>> ASN.1/BER protocol used in the library automation community.
>>
>> There some things I'm having trouble figuring out how to configure, and
>> there are also a bunch of things which have never been documented in
>> asn2wrs. I'm wondering if one or more of the undocumented things could help
>> me.
>>
>> Here's a problematic type definition:
>>
>>AttributeElement  ::=  SEQUENCE{
>>   attributeSet[1]   IMPLICIT AttributeSetId OPTIONAL,
>>   attributeType   [120]  IMPLICIT INTEGER,
>>   attributeValue  CHOICE{
>>  numeric[121]   IMPLICIT INTEGER,
>>
>> complex[224] IMPLICIT SEQUENCE{
>>   list [1] IMPLICIT SEQUENCE OF
>> StringOrNumeric,
>>semanticAction  [2] IMPLICIT SEQUENCE OF INTEGER
>> OPTIONAL}}}
>>
>> The issue is that the "attributeType" values are actually enumerations
>> chosen based on the value of "attributeSet". I see how I can supply a fixed
>> set of strings using FIELD_ATTR (poorly documented), but I can't figure out
>> how to get control so I could specify different sets of strings. (This
>> might be done by specifying alternate hf values, perhaps.)
>>
>> I think I could hard-code the type specifying my own choice array, but
>> I'm wondering if there's a better way.
>>
>
> Several ASN.1 dissectors have fields with a dissection depending on
> another field. See for example s1ap.cnf file and the code for HandoverType
> and Source-ToTarget-TransparentContainer fields.
> So you could store the attributeSet value in the packet (using the
> p_add_proto_data() function) and retrieve it when decoding the
> attributeType value (thanks to the p_get_proto_data() function) and select
> the right value_string (by selecting the relevant hg value, taht could be
> manually defined in your template file - like what is done in
> packet-s1ap-template.c). the PER dissector allows you to define a hf value
> to -1 to avoid getting the item added to the tree automatically and
> retrieving the field so as to manually select the right hf to use. I'm not
> playing with BER but presumably either is it also supported, or could
> probably be added.
>
> I agree with you that asn2wrs is not well documented. But ther are plenty
> of ASN.1 based dissectors that you can look at to take ideas or check how
> things were done (this is how I learned myself). Looking at the python
> script itself also helps ;)
>
> Best regards,
> Pascal.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Question about asn2wrs

[Craig Jackson]

I'm working on a decoder for the NISO Z39.50 protocol. This is an ASN.1/BER
protocol used in the library automation community.

There some things I'm having trouble figuring out how to configure, and
there are also a bunch of things which have never been documented in
asn2wrs. I'm wondering if one or more of the undocumented things could help
me.

Here's a problematic type definition:

   AttributeElement  ::=  SEQUENCE{
  attributeSet[1]   IMPLICIT AttributeSetId OPTIONAL,
  attributeType   [120]  IMPLICIT INTEGER,
  attributeValue  CHOICE{
 numeric[121]   IMPLICIT INTEGER,

complex[224] IMPLICIT SEQUENCE{
  list [1] IMPLICIT SEQUENCE OF StringOrNumeric,
   semanticAction  [2] IMPLICIT SEQUENCE OF INTEGER
OPTIONAL}}}

The issue is that the "attributeType" values are actually enumerations
chosen based on the value of "attributeSet". I see how I can supply a fixed
set of strings using FIELD_ATTR (poorly documented), but I can't figure out
how to get control so I could specify different sets of strings. (This
might be done by specifying alternate hf values, perhaps.)

I think I could hard-code the type specifying my own choice array, but I'm
wondering if there's a better way.

This is just one of a several questions, so if there's an authority on
asn2wrs, I'd like to learn who it is.

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Wiki account verification?

[Craig Jackson]

When I try to log into the wiki, I get "User account not verified yet."

How would I initiate the verification? Probably some mail I didn't respond
to some time ago, or which went to the spam folder.

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Windows builds on appveyor

[Craig Jackson]

I think you need PLATFORM=x64.

Craig Jackson

On Thu, Jun 7, 2018, 4:37 AM Graham Bloice 
wrote:

> On Thu, 7 Jun 2018 at 07:54, Dario Lombardo  wrote:
>
>> Hi
>> I'm trying to set up an automated windows builder on appveyor.
>>
>> https://ci.appveyor.com/project/crondaemon/wireshark
>>
>> I've followed the windows build instructions except for one step:
>> "2.2.10. Open a Visual Studio Command Prompt". Since this is a CI, I can't
>> open a visual studio prompt.
>>
>> The cmake step looks good, but when the build starts I get
>>
>> error MSB4126: The specified solution configuration
>> "RelWithDebInfo|win64" is invalid. Please specify a valid solution
>> configuration using the Configuration and Platform properties (e.g.
>> MSBuild.exe Solution.sln /p:Configuration=Debug /p:Platform="Any CPU") or
>> leave those properties blank to use the default solution configuration.
>> [C:\Development\wireshark\build\Wireshark.sln]
>>
>> I tried different commands
>>
>> msbuild /m /p:Configuration=RelWithDebInfo Wireshark.sln
>> msbuild /m /p:Configuration=RelWithDebInfo /p:Platform="Any CPU"
>> Wireshark.sln
>> msbuild /m /p:Configuration=RelWithDebInfo /p:Platform="win64"
>> Wireshark.sln
>> msbuild /m Wireshark.sln
>> msbuild /consoleloggerparameters:PerformanceSummary;NoSummary
>> /maxcpucount Wireshark.sln
>>
>> but none of them succeeded. Looking into windows master buildbot logs
>> didn't show anything useful. Any idea on what's going on and/or solutions?
>> Thanks
>> Dario.
>> --
>>
>>
> I have an old appveyor branch in my repo at home which worked at the time,
> but needs some TLC as it was for VS 2013 and had to install the Cygwin
> AsciiDoc package which is no longer required. See here:
> https://github.com/gbloice/wireshark/blob/appveyor/appveyor.yml
>
> Note the (commented out) entry at the bottom of the file that enables RDP
> at the end of a build to allow you to connect and poke around.
>
> --
> Graham Bloice
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Help on packet correlation

[Craig Jackson]

Thanks. That's a good start. I always forget to crawl through that
directory looking for READMEs.

My main problem is that my protocol doesn't match one of the simplifying
assumptions for the PANA code:

> The example below shows how simple this is to add to the dissector IF:
> 1. there is something like a transaction id in the header,
> 2. it is very unlikely that the transaction identifier is reused for the
>   same conversation.

The request has no identifier to ease correlation with the corresponding
response. The only correlation is their position in the conversation.

However, it looks like the example suggests the answer, without explicitly
stating it: If the VISITED flag is not set, then this is the first trip
through the dissector for this packet, and therefore the packets are being
processed in order. This would allow it to remember a pending request name
in the conversation structure, and use it when the response is handled. It
would be useful to have this documented somewhere: "If the VISITED flag is
not true, then the packets are being processed in the order they were
received."

The other interesting point is that both iscsi and rpc choose to use trees
instead of hashes to store their data. It would be interesting to have the
tradeoffs documented, especially with regards to memory overhead.

I think I have enough to proceed now.

Craig Jackson




On Mon, May 28, 2018 at 4:54 PM, Jaap Keuter  wrote:

> Hi,
>
> There’s a specific README.request_response_tracking on this subject in
> the doc directory of the repository.
>
> Thanks,
> Jaap
>
>
> > On 28 May 2018, at 17:36, Craig Jackson  wrote:
> >
> > I'm working improving support for TDS. One part of the Sybase version of
> TDS involves correlation between requests and responses. A request can
> declare a cursor, and the response returns with the cursor id. As far as I
> can tell, they're only related by the request/response relationship of a
> sequence of packets.
> >
> > It seems like this should be a common idiom. Could someone point me to
> another protocol that I can use as a model?
> >
> > Craig Jackson
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Help on packet correlation

[Craig Jackson]

I'm working improving support for TDS. One part of the Sybase version of
TDS involves correlation between requests and responses. A request can
declare a cursor, and the response returns with the cursor id. As far as I
can tell, they're only related by the request/response relationship of a
sequence of packets.

It seems like this should be a common idiom. Could someone point me to
another protocol that I can use as a model?

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Question about building WSDG

[Craig Jackson]

I'm trying to submit some edits to the WSDG. I'm testing them against the
HTML version.

If I change on of the source asciidocs and execute:

C:\development\wsbuild64>*msbuild docbook\developer_guide_html.vcxproj*

Only developer-guide.xml gets rebuilt.

If I make another change to the same file and run:

C:\development\wsbuild64>*msbuild docbook\all_guides.vcxproj*

Then the following files get rebuilt:

developer-guide.xml
developer-guide.chm
developer-guide.pdf
user-guide.chm

It also takes quite a while longer.

I have to use /t:rebuild to get it to actually rebuild the chunked html
files, which are the ones I'm accustomed to looking at.

I'm still learning Cmake, msbuild, and vcxproj files, but this seems like a
bug. Would entering a bug be appropriate?

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Problem with background dumpcap in Windows

[Craig Jackson]

Running on recent builds on Windows, I've had a problem with dumpcap being
started and exiting repeatedly in the background. This seems to happening
when it's being restarted to update the interface statistics, such as
happens after a capture file is closed. The interface statistics update
just fine before opening a capture file.

My assumption is that this has something to do with my environment,
although I've blown away my build directory and rebuilt several times. I've
also rebased regularly against master. However, I don't know enough Windows
debugging to figure out what's going wrong.

I was able to see it happening with Procmon from Sysinternals. Should I
install Sysmon from Sysinternals to capture more information? How would I
get dumpcap to run under the debugger.

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Philosophy question - avoiding g_alloc in dissectors?

[Craig Jackson]

I have a place in my dissector where g_strjoin would fit my needs exactly,
and make clean code. However, it calls g_alloc, which I am assuming is
heavier than the allocator used for wmem_packet_scope.

I see there's a wmem_strconcat, but that doesn't quite fit my needs. It
could but not as well.

The string isn't long (ITEM_LABEL_LENGTH max) and has up to three
components, so I could also write open code to put things into a buffer
allocated on the stack. They would then be copied into a wmem_packet_scope
allocated buffer.

I see three alternatives. Which is preferred?

1. Write my open code, finishing with wmem_strdup().
2. Use g_strjoin(), and then wmem_strdup the result.
3. Add a wmem_strjoin to wmem/wmem_strutl.[ch], modeled after
wmem_strconcat and g_strjoin.

I notice that g_strjoin is only used in dissectors/packet-rtps.c, and this
suggests to me that option (2) is to be avoided.

Many of the other places I see g_alloc/g_free used in dissectors have to do
with things like uats which are long-lived structures.

I'm thinking that (3) is the best, but I want confirmation from the more
experienced developers. Also, if I create wmwm_strjoin, should I fix
packet-rtps.c? I would have to way to test it unless there is an archive of
rtps captures.

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Question about git style

[Craig Jackson]

I'm a dead-tree person when I'm learning things. I do use git-scm.org, but
I find the older O'Reilly a little easier to understand.

Craig

On Jan 18, 2018 1:07 PM, "Jaap Keuter"  wrote:

> On 02-01-18 17:36, Craig Jackson wrote:
> >
> > The moral of the story is Read The O'Reilly Book. (RTORB?) And then read
> it
> > again . . .
>
> In fact read https://git-scm.com/book/en/v2
>
> and this entertaining/geeky video tutorial "Git For Ages 4 And Up" by
> Michael
> Schwern https://www.youtube.com/watch?v=1ffBJ4sVUb4
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Question about git style

[Craig Jackson]

You're correct. I've been using source code control systems since the days
of punched cards and tape. (I even wrote a clone of SCCS in Burroughs ALGOL
once, for my own edification.) However, I only have a reading knowledge of
git.

It looks like I have two options when working with gerrit:

- Using an initial commit and then amending it repeatedly.
- Using multiple commits and then squashing them.

The former is pretty simple. The latter would allow me to revert to points
other than the most recent one.

I guess that both indeed are features of git's distributed nature. You're
free to amend history as long as you do it within the privacy of your own
repository. The classic centralized/single-stream VCSs would think of that
as cooking the books.

The moral of the story is Read The O'Reilly Book. (RTORB?) And then read it
again . . .

Craig Jackson

On Tue, Jan 2, 2018 at 5:21 AM, Jaap Keuter  wrote:

> Hi,
>
> It seems that you’re no stranger to version control systems (VCS), but new
> to git. I think it's important in this case to recognise that git is a
> distributed VCS. That means that you have (a clone of) a repository on your
> own, and gerrit is an online tool on the origin repository. You can commit
> to your own repository as much as you want, and decide to push to gerrit
> when you’re done.
> Being done thus means having your changes completed, or wanting to share
> it with, or reviewed by others. Gerrit provides the infrastructure for
> that. The first case is assumed when a commit appears in gerrit, if it’s a
> Work In Progress a marker ‘[WIP]’ is requested to be prefixed on the commit
> summary line.
> Before you push to gerrit you may manipulate your repository as you like
> (squash commits, rebase the branch, etc). After pushing to gerrit you
> should refrain from ‘changing history’ like this. Additional work and
> commits are however possible.
> I hope this highlights the difference between your own repository and
> gerrit a little.
>
> Thanks,
> Jaap
>
>
> > On 1 Jan 2018, at 23:44, Craig Jackson  wrote:
> >
> > I'm curious whether each submission to gerrit must be a single commit.
> I'm accustomed with other source management systems to making a branch and
> then committing fairly frequently. I would do intermediate commits before I
> had anything complete enough to be added to the mainline code of what I was
> working on.
> >
> > I'm new to git and gerrit, but it seems like gerrit wants each
> submission to be a single commit.
> >
> > What is the best style? Should I do a commit, and then amend it as I
> continue to develop?
> >
> > Craig Jackson
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Question about git style

[Craig Jackson]

I'm curious whether each submission to gerrit must be a single commit. I'm
accustomed with other source management systems to making a branch and then
committing fairly frequently. I would do intermediate commits before I had
anything complete enough to be added to the mainline code of what I was
working on.

I'm new to git and gerrit, but it seems like gerrit wants each submission
to be a single commit.

What is the best style? Should I do a commit, and then amend it as I
continue to develop?

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Documenting Ubuntu requirements

[Craig Jackson]

I see that now. Perhaps it should be mentioned in documentation somewhere?

I'll check to see how well it works on Ubuntu Desktop 17.10.

Craig Jackson

On Wed, Nov 29, 2017 at 12:24 PM, Anders Broman 
wrote:

> In the tools directory there is a setup script for Debian. Is that not
> correct?
> Regards
> Anders
>
> Den 29 nov. 2017 6:21 em skrev "Craig Jackson" :
>
> I've been working on building an Ubuntu development environment. I'm
> starting with a clean build of 17.10, because I managed to corrupt my 17.04
> installation somehow.
>
> The WSDG says that most Unix variants should have the software necessary
> for development, but I'm finding that a Ubuntu Desktop installation needs
> the installation of 20 or so packages. I'm working on developing a minimal
> set. (Because some packages pull in others, the order in which they're
> installed matters.)
>
> How should I document this list?
>
> - Create a README.ubuntu file in the top-level directory?
> - Create a README.ubuntu file in the doc subdirectory?
> - Editing the WSUG?
>
> Craig Jackson
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscr
> ibe
>
>
>
> 
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=
> unsubscribe
>
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Documenting Ubuntu requirements

[Craig Jackson]

I've been working on building an Ubuntu development environment. I'm
starting with a clean build of 17.10, because I managed to corrupt my 17.04
installation somehow.

The WSDG says that most Unix variants should have the software necessary
for development, but I'm finding that a Ubuntu Desktop installation needs
the installation of 20 or so packages. I'm working on developing a minimal
set. (Because some packages pull in others, the order in which they're
installed matters.)

How should I document this list?

- Create a README.ubuntu file in the top-level directory?
- Create a README.ubuntu file in the doc subdirectory?
- Editing the WSUG?

Craig Jackson
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe