Re: [Wireshark-dev] Subtree expand/collapse tracking

[Michael Mann via Wireshark-dev]

I'd just reopen the existing bug.
 
 
-Original Message-
From: Thomas Wiens <th.wi...@gmx.de>
To: wireshark-dev <wireshark-dev@wireshark.org>
Sent: Mon, Jan 15, 2018 12:51 pm
Subject: Re: [Wireshark-dev] Subtree expand/collapse tracking

On 13.01.2018 08:31, Roland Knall wrote:> Could you create a bug entry for 
this, including an example trace,> with which we could demonstrate this 
behavior ?There is still an issue with this. Should I reopen the bug or create 
anew one?The subtree is now opened correctly, but only if you have selected 
atree element under the root tree.For the sample capture within tcp tree:select 
#1, expand tcp, expand tcp.flagsselect #2, tcp is expanded down to tcp.flags as 
expectedselect the ip root nodeselect #1, tcp is closed-- 
CheersThomas___Sent
 via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>Archives:
https://www.wireshark.org/lists/wireshark-devUnsubscribe: 
https://www.wireshark.org/mailman/options/wireshark-dev 
mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list <wireshark-dev@wireshark.org>
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Subtree expand/collapse tracking

[Thomas Wiens]

On 13.01.2018 08:31, Roland Knall wrote:
> Could you create a bug entry for this, including an example trace,
> with which we could demonstrate this behavior ?

There is still an issue with this. Should I reopen the bug or create a
new one?

The subtree is now opened correctly, but only if you have selected a
tree element under the root tree.

For the sample capture within tcp tree:

select #1, expand tcp, expand tcp.flags
select #2, tcp is expanded down to tcp.flags as expected

select the ip root node
select #1, tcp is closed

-- 
Cheers
Thomas
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Subtree expand/collapse tracking

[Guy Harris]

On Jan 13, 2018, at 2:08 AM, Thomas Wiens  wrote:

> On 13.01.2018 08:31, Roland Knall wrote:
>> Could you create a bug entry for this, including an example trace,
>> with which we could demonstrate this behavior ?
> 
> Done.
> 
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340

Yes, 2.5.x redid the way the packet details pane is implemented, and broke 
expansion of all protocol layers above the top layer.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Subtree expand/collapse tracking

[Richard Sharpe]

On Sat, Jan 13, 2018 at 2:08 AM, Thomas Wiens  wrote:
> On 13.01.2018 08:31, Roland Knall wrote:
>> Could you create a bug entry for this, including an example trace,
>> with which we could demonstrate this behavior ?
>
> Done.
>
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=14340
>
> On Windows 7 64 Bit it's the same problem.
> Does no one else notice this?

I think I have seen this under Linux as well with builds from Master
... not sure how far it goes back but I can easily test 2.0.1.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Subtree expand/collapse tracking

[Roland Knall]

Could you create a bug entry for this, including an example trace, with which 
we could demonstrate this behavior ?

Cheers
Roland

> Am 13.01.2018 um 01:24 schrieb Thomas Wiens :
> 
> Hi,
> when I build Wireshark from the current git repository, I get a
> different behaviour in tracking expanded/collapsed subtrees compared to
> the latest stable 2.4.4.
> 
> In 2.4.4 if I have expanded a 2nd level (or deeper) subtree element like
> tcp.flags and then selected another packet, then also the tree was
> expanded to this level.
> I thought the intention of the ett_ variables are to keep track of which
> subtrees are expanded.
> 
> With my compiled version from the git repository, the expanded nodes are
> only tracked on the root node. In tcp for example, if I expand the tcp
> tree then all other tcp root nodes are expanded in all other packets I
> select.
> All subtree elements are closed, but now always. And it does not seem
> like random when an expanded subtree element is tracked.
> 
> Is this an intented "new behaviour" or a bug?
> 
> System: Windows 7, 32 Bit
> 
> -- 
> Thomas
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

[Wireshark-dev] Subtree expand/collapse tracking

[Thomas Wiens]

Hi,
when I build Wireshark from the current git repository, I get a
different behaviour in tracking expanded/collapsed subtrees compared to
the latest stable 2.4.4.

In 2.4.4 if I have expanded a 2nd level (or deeper) subtree element like
tcp.flags and then selected another packet, then also the tree was
expanded to this level.
I thought the intention of the ett_ variables are to keep track of which
subtrees are expanded.

With my compiled version from the git repository, the expanded nodes are
only tracked on the root node. In tcp for example, if I expand the tcp
tree then all other tcp root nodes are expanded in all other packets I
select.
All subtree elements are closed, but now always. And it does not seem
like random when an expanded subtree element is tracked.

Is this an intented "new behaviour" or a bug?

System: Windows 7, 32 Bit

-- 
Thomas
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe