[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 alexxcons changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED|RESOLVED --- Comment #20 from alexxcons --- Works fine for me .. adds a minimal gap, and is still clickable. Well done, Theo ! Pushed to master and 4.14 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #19 from Git Bot --- Theo Linkspfeifer referenced this bugreport in commit 7959c91613dc20c829e36ff14ec60ff901462d3c Increase vertical gap between icon and its label slightly (Bug #16041) https://git.xfce.org/xfce/thunar/commit?id=7959c91613dc20c829e36ff14ec60ff901462d3c -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #18 from Git Bot --- Theo Linkspfeifer referenced this bugreport in commit 743be8c2aae0f118624907920c9c0cfe37b61384 Increase vertical gap between icon and its label slightly (Bug #16041) https://git.xfce.org/xfce/thunar/commit?id=743be8c2aae0f118624907920c9c0cfe37b61384 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #17 from Theo Linkspfeifer --- Created attachment 9604 --> https://bugzilla.xfce.org/attachment.cgi?id=9604=edit patch -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #16 from Theo Linkspfeifer --- Adam, would setting the value to "1u" help (no unclickable gap still)? -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #15 from Adam Purkrt --- Created attachment 9217 --> https://bugzilla.xfce.org/attachment.cgi?id=9217=edit no-visual-gap.png Eh, my fix introduced ugliness when the icon is full size vertically (.pdf thumbnail for example). The visual gap is missing - see the attached file. More sophisticated fix is needed that would keep the visual gap - preferably not 3 pixels fixed, but scalable with zoom. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 Adam Purkrt changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 Sean Davis changed: What|Removed |Added CC||bluesa...@xfce.org URL||FIXED --- Comment #14 from Sean Davis --- Should we also apply the exo patch, or is the thunar patch sufficient? -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 alexxcons changed: What|Removed |Added Resolution|--- |FIXED Product|Exo |Thunar Component|General |General Version|0.12|1.8.9 Target Milestone|Future |1.8.10 Status|NEW |RESOLVED --- Comment #13 from alexxcons --- Looks reasonable to me, and as well seems to fix the bug, thanks alot ! Pushed to master and 4.14 branch. Possibly worth to provide as well a fix for the wrong pixel in exo_icon_view_get_item_at_coords if it should matter somewhere ? (If so, I guess a new bug would be good) -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #12 from Git Bot --- Adam Purkrt referenced this bugreport in commit a9a779d352ca85c5fa087175ecd593e78edf7b16 Remove the vertical gap between icon and its label (Bug #16041) https://git.xfce.org/xfce/thunar/commit?id=a9a779d352ca85c5fa087175ecd593e78edf7b16 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #11 from Git Bot --- Adam Purkrt referenced this bugreport in commit f35be6fd1b138a70f0e4d5003df6539c9cdceed7 Remove the vertical gap between icon and its label (Bug #16041) https://git.xfce.org/xfce/thunar/commit?id=f35be6fd1b138a70f0e4d5003df6539c9cdceed7 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 Adam Purkrt changed: What|Removed |Added Attachment #9137|0 |1 is obsolete|| --- Comment #10 from Adam Purkrt --- Created attachment 9178 --> https://bugzilla.xfce.org/attachment.cgi?id=9178=edit 0001-Remove-the-vertical-gap-between-icon-and-its-label.patch The patch for thunar, bringing the gap to zero. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #9 from Adam Purkrt --- After some more research, I now think my patch (attachment 9137) is not the right way how to remedy this. The cause of the gap is simply padding - it is set to 3 pixels in thunar/thunar-icon-view.c g_object_set (G_OBJECT (THUNAR_STANDARD_VIEW (icon_view)->icon_renderer), "ypad", 3u, NULL); https://git.xfce.org/xfce/thunar/tree/thunar/thunar-icon-view.c#n101 Change the "3u" to "0u", recompile thunar and voila - the gap is gone. This time, though, also visually. But I would be all for this change - I do not miss the three pixels, they do not scale with zoom level anyway and it would make the code less readable to make them clickable (imo). If you are wondering why 3u leads to only 2 pixel unclickable gap (and it is really two pixels, not three), the reason lies in the function exo_icon_view_get_item_at_coords in exo/exo-icon-view.c. The inequalities there should be "<" instead of "<=". The extra "=" brings the extra pixel (I verified this experimentally). https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c#n4359 and also lines 4360, 4373, 4374 -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 Theo Linkspfeifer changed: What|Removed |Added CC||lastonestand...@tutanota.co ||m --- Comment #8 from Theo Linkspfeifer --- I can confirm that the patch works. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #7 from Adam Purkrt --- Created attachment 9137 --> https://bugzilla.xfce.org/attachment.cgi?id=9137=edit exo-patch.p The following patch works for me. Visually, nothing changes - its pixel-to-pixel as before the patch. But functionally, the unclickable gap is gone. Also improves clicking horizontally - before the patch, the rightmost pixel of "example" label was unclickable. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #6 from Adam Purkrt --- Couple of remarks after discussion with Theo over irc: - xfdesktop (icons on the desktop) does not suffer from this - in Nautilus (gnome file manager) there is no such gap - the gap does not depend on the zoom level - it is always 2 pixels -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #5 from Adam Purkrt --- Delving into the code, there is a "spacing" variable in exo/exo-icon-view.c in struct _ExoIconViewPrivate https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c#n552 It is set to zero, afaict (in fact it seems uninitialized). If I increase its value icon_view->priv->spacing = 16; in exo_icon_view_init(...), the gap increases. But I am unable to close the gap with spacing=0. The two pixels always remain. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #4 from Adam Purkrt --- This bug is not new. Just tried xubuntu 18.04, i.e. xfce 4.12, and can reproduce it there - two pixel gap. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #3 from Theo Linkspfeifer --- I am seeing this in Nemo also. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 --- Comment #2 from Adam Purkrt --- Compact view is ok. I doubt it is theme specific, I can reproduce it also with Highcontrast theme. Again 2 pixels. -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 alexxcons changed: What|Removed |Added Component|General |General Target Milestone|1.8.10 |Future Version|git |0.12 Product|Thunar |Exo -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
[Xfce-bugs] [Bug 16041] Unclickable gap between filename and icon in ExoIconView
https://bugzilla.xfce.org/show_bug.cgi?id=16041 alexxcons changed: What|Removed |Added Summary|Unclickable gap between |Unclickable gap between |filename and icon |filename and icon in ||ExoIconView -- You are receiving this mail because: You are the assignee for the bug. ___ Xfce-bugs mailing list Xfce-bugs@xfce.org https://mail.xfce.org/mailman/listinfo/xfce-bugs
