[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-17 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #10 from alexxcons  ---
(In reply to Theo Linkspfeifer from comment #9)
> > Only compact view does not have it yet .. (would require overshoot event on 
> > the left/right)
> It works in Caja which manipulates the event attributes, see:
> https://github.com/mate-desktop/caja/blob/master/src/file-manager/fm-icon-
> view.c#L2538
> 
> Should exo-icon-view copy that approach?
Makes sense to me to do it like that .. so from my POV, we can copy that
approach.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-16 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #9 from Theo Linkspfeifer  ---
> Only compact view does not have it yet .. (would require overshoot event on 
> the left/right)
It works in Caja which manipulates the event attributes, see:
https://github.com/mate-desktop/caja/blob/master/src/file-manager/fm-icon-view.c#L2538

Should exo-icon-view copy that approach?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-15 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #8 from Theo Linkspfeifer  ---
> Afaik Sean is currently working on dropping all gtk2 dependencies, having 
> gtk3 as requirement.
https://gitlab.xfce.org/xfce/exo/-/commit/a978d108f49b7b0f232183473335aca33d1cc550

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-10 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #7 from Theo Linkspfeifer  ---
Interestingly, the effect is missing in Nemo's compact (list) view too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-10 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #6 from Theo Linkspfeifer  ---
> #if GTK_CHECK_VERSION (3, 0, 0)
Not really important, but small mistake here. This second check should check
for 3.4.0 also.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-10 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #5 from alexxcons  ---
(In reply to Theo Linkspfeifer from comment #4)
> Created attachment 9843 [details]
> quick diff

Thanks Theo ! Afaik Sean is currently working on dropping all gtk2
dependencies, having gtk3 as requirement. Possibly best to wait until he is
finished, so the #if GTK_CHECK_VERSION (3, 0, 0) can be dropped, and possibly
the complete method can be simplified

> Note that the overshoot effect is not present in list view (yet).
Works for me for icon and detailed view. Only compact view does not have it yet
.. (would require overshoot event on the left/right)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-05-07 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

Theo Linkspfeifer  changed:

   What|Removed |Added

   Attachment #9794|0   |1
is obsolete||

--- Comment #4 from Theo Linkspfeifer  ---
Created attachment 9843
  --> https://bugzilla.xfce.org/attachment.cgi?id=9843=edit
quick diff

Like this.

Note that the overshoot effect is not present in list view (yet).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-04-26 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #3 from Theo Linkspfeifer  ---
No, exo_icon_view_scroll_event() needs to be tweaked (see bug 15936).

https://git.xfce.org/xfce/exo/tree/exo/exo-icon-view.c#n2860

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-04-26 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #2 from alexxcons  ---
> However, simply adding it to the event mask breaks Thunar's list view because 
> exo_icon_view_scroll_event() expects the non-smooth scrolling data.
So if I get it right, the attached patch will break Thunar's list view ... so
we will need a thunar patch at the same time ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 16759] No overshoot effect when scrolling in exo-icon-view

2020-04-25 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=16759

--- Comment #1 from Theo Linkspfeifer  ---
Relevant: Bug 15936

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs