[Xfce-bugs] [Bug 14576] Add support for folder.jpg

2018-08-13 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=14576

--- Comment #43 from alexxcons  ---
Here some doc regarding gtk3 Object Properties: [0]  not taht much, I did
not find a better doc for it so far.

Here is some doc. regarding exo bindings:  [1]
Think you will only need one exo_binding between the property
"PROP_FOLDER_THUMBNAIL_FILES" of thunar-icon-factory.c and the
"PROP_MISC_FOLDER_THUMBNAIL_FILES" of thunar-preferences.c

Take your time, we are not in a hurry ;)

[0]
https://python-gtk-3-tutorial.readthedocs.io/en/latest/basics.html#properties 
[1]  https://git.xfce.org/xfce/exo/tree/exo/exo-binding.c#n32

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 14576] Add support for folder.jpg

2018-08-13 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=14576

--- Comment #44 from Andre Miranda  ---
I think we are overthinking this feature, ["folder.png", ".folder.png",
"folder.jpg", ".folder.jpg"] should be enough, not need to customize it via a
hidden property.
As performance is a concern, I guess an option to enable/disable it in
preferences dialog wouldn't hurt, something like "Show custom icons for
folders", a tooltip explaining the supported files and (maybe) the GFile
Metadata (the latter has precedence over the former IMO).
This could be disabled by default until a proper analysis is run to assess the
performance hit, i.e. check with a profile, for instance gnome builder, for hot
spots on thousands of folders with custom icons.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 14601] Cancel button in progress dialog missing cast

2018-08-13 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=14601

--- Comment #2 from Git Bot  ---
Andre Miranda referenced this bugreport in commit
31b7686dad5b416b2b18fdc3fbd2bde2b96972d0

Fix compile warning (GtkButton cast) (Bug #14601)

https://git.xfce.org/xfce/thunar/commit?id=31b7686dad5b416b2b18fdc3fbd2bde2b96972d0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 14601] Cancel button in progress dialog missing cast

2018-08-13 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=14601

Andre Miranda  changed:

   What|Removed |Added

 CC||andre...@xfce.org
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Andre Miranda  ---
Thanks ToZ, I didn't notice this warning because gcc 8.1 enabled new warnings,
so the compile output is noisy for now, I'll get rid of them soon-ish...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs


[Xfce-bugs] [Bug 14576] Add support for folder.jpg

2018-08-13 Thread bugzilla-daemon
https://bugzilla.xfce.org/show_bug.cgi?id=14576

--- Comment #42 from HYPERION  ---
I need some help to understand the way exo_binding ; Object properties ; and
all these API work.

For the moment it's obscure, and unfortunately I have not enough time to
investigate :/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Xfce-bugs mailing list
Xfce-bugs@xfce.org
https://mail.xfce.org/mailman/listinfo/xfce-bugs