Re: [PATCH] list.h: don't crash when removing an element from a NULL list
Peter Hutterer peter.hutte...@who-t.net writes: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Keith, please merge this directly if you're happy with it. It looks fine, but I don't see any place that this actually matters in current code? (the more I see of these twisty list macros, the more I prefer open-coded lists though; wow this is hard to understand). -- keith.pack...@intel.com pgpIKgA91Bh3F.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] list.h: don't crash when removing an element from a NULL list
On Wed, Jul 04, 2012 at 11:32:38PM -0700, Keith Packard wrote: Peter Hutterer peter.hutte...@who-t.net writes: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Keith, please merge this directly if you're happy with it. It looks fine, but I don't see any place that this actually matters in current code? no, but the selinux fix will need it (partially out of laziness, partially to make the code nicer). (the more I see of these twisty list macros, the more I prefer open-coded lists though; wow this is hard to understand). given how often we've found bugs in open-coded lists I disagree. yes, they're hairy but they're tested, the macro behaves the same everywhere. and if you really worry about the code being wrong, run it through the pre-processor and it will look like an open-coded list. Cheers, Peter ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] list.h: don't crash when removing an element from a NULL list
Peter Hutterer peter.hutte...@who-t.net writes: no, but the selinux fix will need it (partially out of laziness, partially to make the code nicer). Ok. I'll merged it in then. (the more I see of these twisty list macros, the more I prefer open-coded lists though; wow this is hard to understand). given how often we've found bugs in open-coded lists I disagree. yes, they're hairy but they're tested, the macro behaves the same everywhere. and if you really worry about the code being wrong, run it through the pre-processor and it will look like an open-coded list. It's all a tradeoff -- I just don't like having to learn a new programming language each time I see a new set of list macros (or other macro programming of this nature). Reminds me of how loathsome C++ templates are. -- keith.pack...@intel.com pgpMw7u14z701.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] list.h: don't crash when removing an element from a NULL list
Peter Hutterer peter.hutte...@who-t.net writes: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Keith, please merge this directly if you're happy with it. Merged. 8aa6d49..1679932 master - master -- keith.pack...@intel.com pgpEneA48ChhX.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
