Re: [PATCH xserver] test: Remember to swap the window argument to XIQueryPointer
On Wed, Aug 17, 2016 at 10:43:27AM -0400, Adam Jackson wrote: > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer > manually emitted its own error before (bogusly) returning Success to the > main loop. Since these tests only look at the return value of the > dispatch function we'd think things succeeded even when we'd generated > an error. > > With that fixed, the test code's failure to swap the window id would > make dixLookupWindow (rightly) throw BadWindow. > > Signed-off-by: Adam Jackson woops, sorry. Reviewed-by: Peter Hutterer Cheers, Peter > --- > test/xi2/protocol-xiquerypointer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/xi2/protocol-xiquerypointer.c > b/test/xi2/protocol-xiquerypointer.c > index c0421f6..2bf18fa 100644 > --- a/test/xi2/protocol-xiquerypointer.c > +++ b/test/xi2/protocol-xiquerypointer.c > @@ -140,6 +140,7 @@ request_XIQueryPointer(ClientPtr client, > xXIQueryPointerReq * req, int error) > > client_request.swapped = TRUE; > swaps(&req->deviceid); > +swapl(&req->win); > swaps(&req->length); > rc = SProcXIQueryPointer(&client_request); > assert(rc == error); > -- > 2.7.4 > ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] test: Remember to swap the window argument to XIQueryPointer
On Wed, Aug 17, 2016 at 10:43:27 -0400, Adam Jackson wrote: > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer > manually emitted its own error before (bogusly) returning Success to the > main loop. Since these tests only look at the return value of the > dispatch function we'd think things succeeded even when we'd generated > an error. > > With that fixed, the test code's failure to swap the window id would > make dixLookupWindow (rightly) throw BadWindow. > > Signed-off-by: Adam Jackson > --- > test/xi2/protocol-xiquerypointer.c | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Julien Cristau Cheers, Julien ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] test: Remember to swap the window argument to XIQueryPointer
On Wed, 2016-08-17 at 23:57 +0900, Michel Dänzer wrote: > On 17/08/16 11:43 PM, Adam Jackson wrote: > > > > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer > > manually emitted its own error before (bogusly) returning Success to the > > main loop. Since these tests only look at the return value of the > > dispatch function we'd think things succeeded even when we'd generated > > an error. > > > > With that fixed, the test code's failure to swap the window id would > > make dixLookupWindow (rightly) throw BadWindow. > > > > Signed-off-by: Adam Jackson > > Reviewed-and-Tested-by: Michel Dänzer Merged (and my pre-push hook actually ran this time!): remote: I: patch #105654 updated using rev 6acd0d098add5a14f23d326ac6ee8cebab14b86a. remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 5c69cb6..6acd0d0 master -> master - ajax ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] test: Remember to swap the window argument to XIQueryPointer
On 17/08/16 11:43 PM, Adam Jackson wrote: > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer > manually emitted its own error before (bogusly) returning Success to the > main loop. Since these tests only look at the return value of the > dispatch function we'd think things succeeded even when we'd generated > an error. > > With that fixed, the test code's failure to swap the window id would > make dixLookupWindow (rightly) throw BadWindow. > > Signed-off-by: Adam Jackson Reviewed-and-Tested-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
