[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709640#comment-16709640
]
Akhil PB edited comment on YARN-8914 at 12/5/18 6:15 AM:
-
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2 in v9 patch.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
was (Author: akhilpb):
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch, YARN-8914.008.patch,
> YARN-8914.009.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709640#comment-16709640
]
Akhil PB edited comment on YARN-8914 at 12/5/18 6:16 AM:
-
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2 in v9 patch.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used. Since we only need
nodeHttpAddress, containerId and user for termLink.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
was (Author: akhilpb):
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2 in v9 patch.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch, YARN-8914.008.patch,
> YARN-8914.009.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709640#comment-16709640
]
Akhil PB edited comment on YARN-8914 at 12/5/18 6:02 AM:
-
[~eyang] Please find the v9 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
Please verify that all your changes are there in v9 patch.
was (Author: akhilpb):
[~eyang] Please find the v8 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch, YARN-8914.008.patch,
> YARN-8914.009.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709640#comment-16709640
]
Akhil PB edited comment on YARN-8914 at 12/5/18 6:01 AM:
-
[~eyang] Please find the v8 patch [^YARN-8914.009.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
was (Author: akhilpb):
[~eyang] Please find the v8 patch [^YARN-8914.008.patch] with latest UI2
changes. The issues were in how requestedUser were accessed.
The code snippet {{this.get('requestedUser')}} should be
{{self.get('requestedUser')}}.
The following changes were made related to UI2.
# Removed DOM access and termLink code from {{models/yarn-container.js and
serializers/yarn-container.js}}, since these were not used.
# Removed Terminal column from attempts table in
{{components/timeline-view.js}}.
# Fixed requestedUser issues in {{components/timeline-view.js and
templates/components/container-table.hbs}}.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch, YARN-8914.008.patch,
> YARN-8914.009.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707522#comment-16707522
]
Eric Yang edited comment on YARN-8914 at 12/4/18 12:46 AM:
---
[~akhilpb] Thanks for the input.
{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a
link, it's a plain text now. Please change this to a link. I suppose this is
intended to access AM container.{quote}
I will remove Terminal column for application attempt. AM container can be
accessed from container page only when YARN-8962 patch is applied.
{quote}Please add the changes made for yarn-container.js model and serializer
to yarn-timeline-container.js model and serializer too.{quote}
I try to repeat what you listed. However, I have problem to get Graph View to
be able to resolve requestedUser using the code that you listed. What changes
should be done to serializer?
{quote}To access requestedUser, you could use the following code to add
userInfo to yarn-app-attempt.js model. Then we can pass in this model to
timeline-view.js.{quote}
Grid view works by adding the routes/yarn-app-attempt.js and
templates/yarn-app-attempt.js changes, and timeline-view.js having:
{code}
requestedUser: function() {
if (this.get('userInfo')) {
return this.get('userInfo.requestedUser');
}
return '';
}
{code}
Without .property('user'). Otherwise, browser throws an exception that
requestedUser is not a descriptor.
{quote}
{{container-table container=selected requestedUser=requestedUser}}
{quote}
I am unable to get this part to work.
was (Author: eyang):
[~akhilpb] Thanks for the input.
{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a
link, it's a plain text now. Please change this to a link. I suppose this is
intended to access AM container.{quote}
I will remove Terminal column for application attempt. AM container can be
accessed from container page only when YARN-8962 patch is applied.
{quote}Please add the changes made for yarn-container.js model and serializer
to yarn-timeline-container.js model and serializer too.{quote}
I try to repeat what you listed. However, I have problem to get Graph View to
be able to resolve requestedUser using the code that you listed. What changes
should be done to serializer?
{quote}To access requestedUser, you could use the following code to add
userInfo to yarn-app-attempt.js model. Then we can pass in this model to
timeline-view.js.{quote}
Grid view works by adding the routes/yarn-app-attempt.js and
templates/yarn-app-attempt.js changes, and timeline-view.js having:
{code}
requestedUser: function() {
if (this.get('userInfo')) {
return this.get('userInfo.requestedUser');
}
return '';
}
{code}
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707522#comment-16707522
]
Eric Yang edited comment on YARN-8914 at 12/4/18 12:43 AM:
---
[~akhilpb] Thanks for the input.
{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a
link, it's a plain text now. Please change this to a link. I suppose this is
intended to access AM container.{quote}
I will remove Terminal column for application attempt. AM container can be
accessed from container page only when YARN-8962 patch is applied.
{quote}Please add the changes made for yarn-container.js model and serializer
to yarn-timeline-container.js model and serializer too.{quote}
I try to repeat what you listed. However, I have problem to get Graph View to
be able to resolve requestedUser using the code that you listed. What changes
should be done to serializer?
{quote}To access requestedUser, you could use the following code to add
userInfo to yarn-app-attempt.js model. Then we can pass in this model to
timeline-view.js.{quote}
Grid view works by adding the routes/yarn-app-attempt.js and
templates/yarn-app-attempt.js changes, and timeline-view.js having:
{code}
requestedUser: function() {
if (this.get('userInfo')) {
return this.get('userInfo.requestedUser');
}
return '';
}
{code}
was (Author: eyang):
[~akhilpb] Thanks for the input.
{quote}The Terminal column in attempts table in {{timeline-view.js}} is not a
link, it's a plain text now. Please change this to a link. I suppose this is
intended to access AM container.{quote}
I will make javascript fix for this JIRA. AM container can only be accessed
when YARN-8962 patch is applied.
{quote}Please add the changes made for yarn-container.js model and serializer
to yarn-timeline-container.js model and serializer too.{quote}
If I understand the code correctly, yarn-timeline-container.js is used for
displaying history of container information. It is not possible to login to
container when data is display through yarn-timeline-container.js. This is the
reason that the same code is not applied to yarn-timeline-container.js.
{quote}To access requestedUser, you could use the following code to add
userInfo to yarn-app-attempt.js model. Then we can pass in this model to
timeline-view.js.{quote}
Thanks for the tip. I will incorporate this in the next patch.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 7:14 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link. I suppose this is intended
to access AM container.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# Please remove the requestedUser DOM access and from {{yarn-container.js}}
model.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user by {{this.get('requestedUser')}} in
{{timeline-view.js}} as following:
{code}
requestedUser: function() {
if (this.get('userInfo')) {
return this.get('userInfo.requestedUser');
}
return ''; // could return some default uer
}.property('userInfo'),
{code}
Now you can pass in userInfo to {{templates/components/container-table.hbs}}:
{code}
{{container-table container=selected requestedUser=requestedUser}}
{code}
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link. I suppose this is intended
to access AM container.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# Please remove the requestedUser DOM access and from {{yarn-container.js}}
model.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 7:01 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link. I suppose this is intended
to access AM container.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# Please remove the requestedUser DOM access and from {{yarn-container.js}}
model.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# Please remove the requestedUser DOM access and from {{yarn-container.js}}
model.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 7:00 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# Please remove the requestedUser DOM access and from {{yarn-container.js}}
model.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:59 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following in {{timeline-view.js}}:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:58 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# To access requestedUser, you could use the following code to add userInfo to
{{yarn-app-attempt.js}} model. Then we can pass in this model to
{{timeline-view.js}}.
{code}
// file: routes/yarn-app-attempt.js
// Adding userInfo to the model
afterModel(model) {
const appContrl = this.controllerFor('application');
model.userInfo = appContrl.get('userInfo');
}
{code}
{code}
// file: templates/yarn-app-attempt.js
// Passing userInfo to the timeline-view.js
{{timeline-view
parent-id="containers-timeline-div"
my-id="timeline-view"
height="400"
rmModel=model.rmContainers
tsModel=model.tsContainers
label="shortAppAttemptId"
attemptModel=false
changeViewType="changeViewType"
viewType=viewType
userInfo=model.userInfo
}}
{code}
Now we could access requested user via following:
{code}
let requestedUser = ''; // could assign some default user.
if (this.get('userInfo')) {
requestedUser = this.get('userInfo.requestedUser')
}
{code}
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column in {{timeline-view.js}}, please use
{{row.get('requestedUser')}} to get the user. So that if we want to change the
implementation of accessing the user, we have to change only in model class.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:27 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table in {{timeline-view.js}} is not a link,
it's a plain text now. Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column in {{timeline-view.js}}, please use
{{row.get('requestedUser')}} to get the user. So that if we want to change the
implementation of accessing the user, we have to change only in model class.
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column in {{timeline-view.js}}, please use
{{row.get('requestedUser')}} to get the user. So that if we want to change the
implementation of accessing the user, we have to change only in model class.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:26 AM:
-
[~eyang] I have found a couple of issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column, please use {{row.get('requestedUser')}} to get the
user. So that if we want to change the implementation of accessing the user, we
have to change only in model class.
was (Author: akhilpb):
[~eyang] I have found a couple of issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:27 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column in {{timeline-view.js}}, please use
{{row.get('requestedUser')}} to get the user. So that if we want to change the
implementation of accessing the user, we have to change only in model class.
was (Author: akhilpb):
[~eyang] I have found a few issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column, please use {{row.get('requestedUser')}} to get the
user. So that if we want to change the implementation of accessing the user, we
have to change only in model class.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:26 AM:
-
[~eyang] I have found a few issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column, please use {{row.get('requestedUser')}} to get the
user. So that if we want to change the implementation of accessing the user, we
have to change only in model class.
was (Author: akhilpb):
[~eyang] I have found a couple of issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
# For Container ID column, please use {{row.get('requestedUser')}} to get the
user. So that if we want to change the implementation of accessing the user, we
have to change only in model class.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[
https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706715#comment-16706715
]
Akhil PB edited comment on YARN-8914 at 12/3/18 6:15 AM:
-
[~eyang] I have found a couple of issues.
# The Terminal column in attempts table is not a link, it's a plain text now.
Please change this to a link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
was (Author: akhilpb):
[~eyang] I have found a couple of issues.
# The Terminal column in attempts table is not a link. Please change this to a
link.
# Please add the changes made for {{yarn-container.js}} model and serializer to
{{yarn-timeline-container.js}} model and serializer too.
> Add xtermjs to YARN UI2
> ---
>
> Key: YARN-8914
> URL: https://issues.apache.org/jira/browse/YARN-8914
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: yarn-ui-v2
>Reporter: Eric Yang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-8914.001.patch, YARN-8914.002.patch,
> YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch,
> YARN-8914.006.patch, YARN-8914.007.patch
>
>
> In the container listing from UI2, we can add a link to connect to docker
> container using xtermjs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704966#comment-16704966 ] Akhil PB edited comment on YARN-8914 at 11/30/18 4:46 PM: -- Hi [~eyang] I think its good to get username from userInfo object which is available in application controller, instead of reading from html element. Because there could be another html element with same classname. I have tested the patch and was able to build and run the ui2. I was able to open the xterm terminal in a new tab. But the terminal is frozen, not accepting any inputs. What is the behavior we are looking for? was (Author: akhilpb): Hi [~eyang] I think its good to get username from userInfo object which is available in application controller, instead of reading from html element. Because there could be another html element with same classname. > Add xtermjs to YARN UI2 > --- > > Key: YARN-8914 > URL: https://issues.apache.org/jira/browse/YARN-8914 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-ui-v2 >Reporter: Eric Yang >Assignee: Eric Yang >Priority: Major > Attachments: YARN-8914.001.patch, YARN-8914.002.patch, > YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch, > YARN-8914.006.patch, YARN-8914.007.patch > > > In the container listing from UI2, we can add a link to connect to docker > container using xtermjs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704966#comment-16704966 ] Akhil PB edited comment on YARN-8914 at 11/30/18 4:15 PM: -- Hi [~eyang] I think its good to get username from userInfo object which is available in application controller, instead of reading from html element. Because there could be another html element with same classname. was (Author: akhilpb): Hi [~eyang] I think its good to get username from userInfo object which is avaialble in application controller, instead of reading from html element. Because there could be another html element with same classname. > Add xtermjs to YARN UI2 > --- > > Key: YARN-8914 > URL: https://issues.apache.org/jira/browse/YARN-8914 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-ui-v2 >Reporter: Eric Yang >Assignee: Eric Yang >Priority: Major > Attachments: YARN-8914.001.patch, YARN-8914.002.patch, > YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch, > YARN-8914.006.patch, YARN-8914.007.patch > > > In the container listing from UI2, we can add a link to connect to docker > container using xtermjs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700198#comment-16700198 ] Akhil PB edited comment on YARN-8914 at 11/27/18 10:40 AM: --- Hi [~eyang], I am reviewing the patch. What are the steps required to test the patch? was (Author: akhilpb): Hi [~eyang], I am reviewing the patch. What are the steps to test the patch? > Add xtermjs to YARN UI2 > --- > > Key: YARN-8914 > URL: https://issues.apache.org/jira/browse/YARN-8914 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-ui-v2 >Reporter: Eric Yang >Assignee: Eric Yang >Priority: Major > Attachments: YARN-8914.001.patch, YARN-8914.002.patch, > YARN-8914.003.patch, YARN-8914.004.patch, YARN-8914.005.patch, > YARN-8914.006.patch, YARN-8914.007.patch > > > In the container listing from UI2, we can add a link to connect to docker > container using xtermjs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (YARN-8914) Add xtermjs to YARN UI2
[ https://issues.apache.org/jira/browse/YARN-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663305#comment-16663305 ] Akhil PB edited comment on YARN-8914 at 10/25/18 6:23 AM: -- Hi [~eyang] Couple of comments. # Patch looks huge in size. Could we remove js.map files since addon files are already in non-minified? # Where is overlay.js used? Could we wrap the functions in this file in an IIFE? was (Author: akhilpb): [~eyang] Couple of comments. # Patch looks huge in size. Could we remove js.map files since addon files are already in non-minified? # Where is overlay.js used? Could we wrap the functions in this file in an IIFE? > Add xtermjs to YARN UI2 > --- > > Key: YARN-8914 > URL: https://issues.apache.org/jira/browse/YARN-8914 > Project: Hadoop YARN > Issue Type: Sub-task > Components: yarn-ui-v2 >Reporter: Eric Yang >Assignee: Eric Yang >Priority: Major > Attachments: YARN-8914.001.patch > > > In the container listing from UI2, we can add a link to connect to docker > container using xtermjs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
