[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007666#comment-14007666
]
Hadoop QA commented on YARN-2073:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12646441/yarn-2073-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3799//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3799//console
This message is automatically generated.
FairScheduler starts preempting resources even with free resources on the
cluster
-
Key: YARN-2073
URL: https://issues.apache.org/jira/browse/YARN-2073
Project: Hadoop YARN
Issue Type: Bug
Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch,
yarn-2073-3.patch, yarn-2073-4.patch
Preemption should kick in only when the currently available slots don't match
the request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007744#comment-14007744
]
Hadoop QA commented on YARN-2073:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12646441/yarn-2073-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3805//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3805//console
This message is automatically generated.
FairScheduler starts preempting resources even with free resources on the
cluster
-
Key: YARN-2073
URL: https://issues.apache.org/jira/browse/YARN-2073
Project: Hadoop YARN
Issue Type: Bug
Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch,
yarn-2073-3.patch, yarn-2073-4.patch
Preemption should kick in only when the currently available slots don't match
the request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[ https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14007821#comment-14007821 ] Sandy Ryza commented on YARN-2073: -- +1 FairScheduler starts preempting resources even with free resources on the cluster - Key: YARN-2073 URL: https://issues.apache.org/jira/browse/YARN-2073 Project: Hadoop YARN Issue Type: Bug Components: scheduler Affects Versions: 2.4.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch, yarn-2073-3.patch, yarn-2073-4.patch Preemption should kick in only when the currently available slots don't match the request. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006682#comment-14006682
]
Sandy Ryza commented on YARN-2073:
--
{code}
+ /** Preemption related variables */
{code}
Nit: use // like the other comments.
Can you add the new property in the Fair Scheduler doc?
{code}
+ updateRootQueueMetrics();
{code}
My understanding is that this shouldn't be needed in shouldAttemptPreemption.
Have you observed otherwise?
Would it be possible to move the TestFairScheduler refactoring to a separate
JIRA? If it's too difficult to entangle at this point, I'm ok with it.
FairScheduler starts preempting resources even with free resources on the
cluster
-
Key: YARN-2073
URL: https://issues.apache.org/jira/browse/YARN-2073
Project: Hadoop YARN
Issue Type: Bug
Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch,
yarn-2073-3.patch
Preemption should kick in only when the currently available slots don't match
the request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14006705#comment-14006705
]
Hadoop QA commented on YARN-2073:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12646425/yarn-2073-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3790//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3790//console
This message is automatically generated.
FairScheduler starts preempting resources even with free resources on the
cluster
-
Key: YARN-2073
URL: https://issues.apache.org/jira/browse/YARN-2073
Project: Hadoop YARN
Issue Type: Bug
Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch,
yarn-2073-3.patch
Preemption should kick in only when the currently available slots don't match
the request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[ https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004175#comment-14004175 ] Wei Yan commented on YARN-2073: --- [~kasha], if we move preemption-related test code to a separate .java file, we may also need to move the previous preemption-related test functions (testChoiceOfPreemptedContainers and testPreemptionDecision) to the new file. And so next step we'll divide the TestFairScheduler into several test files according to different scheduler operations? FairScheduler starts preempting resources even with free resources on the cluster - Key: YARN-2073 URL: https://issues.apache.org/jira/browse/YARN-2073 Project: Hadoop YARN Issue Type: Bug Components: scheduler Affects Versions: 2.4.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-2073-0.patch, yarn-2073-1.patch Preemption should kick in only when the currently available slots don't match the request. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[ https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004181#comment-14004181 ] Karthik Kambatla commented on YARN-2073: bq. we may also need to move the previous preemption-related test functions (testChoiceOfPreemptedContainers and testPreemptionDecision) to the new file Moving them might require slightly more work, and I was planning on doing that in a separate JIRA along with splitting the tests into multiple files. FairScheduler starts preempting resources even with free resources on the cluster - Key: YARN-2073 URL: https://issues.apache.org/jira/browse/YARN-2073 Project: Hadoop YARN Issue Type: Bug Components: scheduler Affects Versions: 2.4.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-2073-0.patch, yarn-2073-1.patch Preemption should kick in only when the currently available slots don't match the request. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[
https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004241#comment-14004241
]
Hadoop QA commented on YARN-2073:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12645920/yarn-2073-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3783//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3783//console
This message is automatically generated.
FairScheduler starts preempting resources even with free resources on the
cluster
-
Key: YARN-2073
URL: https://issues.apache.org/jira/browse/YARN-2073
Project: Hadoop YARN
Issue Type: Bug
Components: scheduler
Affects Versions: 2.4.0
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Critical
Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch
Preemption should kick in only when the currently available slots don't match
the request.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[ https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004290#comment-14004290 ] Sandy Ryza commented on YARN-2073: -- There are some situations where preemption with free resources on the cluster is the right thing to do. For example, if I'm requesting 2 GB containers, I have no resources, and 100 nodes on the cluster each have 1GB remaining, containers should get preempted on my behalf. There are also cases arising from requests with strict locality - the cluster might have resources available because I'm waiting on a subset of nodes. (In this case, we'd probably want to make sure preemption only happens on the nodes being waited for; otherwise we'd kill containers needlessly). If the goal is to make sure that we aren't preempting on behalf of an application that's actually receiving resources, it might also be worth considering time-based approaches. E.g. only preempt on behalf of an application that hasn't received resources in some amount of time. FairScheduler starts preempting resources even with free resources on the cluster - Key: YARN-2073 URL: https://issues.apache.org/jira/browse/YARN-2073 Project: Hadoop YARN Issue Type: Bug Components: scheduler Affects Versions: 2.4.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch Preemption should kick in only when the currently available slots don't match the request. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (YARN-2073) FairScheduler starts preempting resources even with free resources on the cluster
[ https://issues.apache.org/jira/browse/YARN-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14004315#comment-14004315 ] Karthik Kambatla commented on YARN-2073: Sandy - you make very good points. In other words, we want to have an absoluteMinSharePreemptionTimeout. Now, the question becomes whether we should express this as a separate timeout config or a scaling factor which determines this absolute timeout for both min-share and fair-share? Also, we can make it a per-queue config or a single factor for the cluster. Eventually, we need a better story for preemption. Currently, it is like a spray gun, we preempt some resources and hope that helps this application. Instead, we should preempt resources that match the application's ask. In that case, this new config will be moot. FairScheduler starts preempting resources even with free resources on the cluster - Key: YARN-2073 URL: https://issues.apache.org/jira/browse/YARN-2073 Project: Hadoop YARN Issue Type: Bug Components: scheduler Affects Versions: 2.4.0 Reporter: Karthik Kambatla Assignee: Karthik Kambatla Priority: Critical Attachments: yarn-2073-0.patch, yarn-2073-1.patch, yarn-2073-2.patch Preemption should kick in only when the currently available slots don't match the request. -- This message was sent by Atlassian JIRA (v6.2#6252)
