[jira] [Commented] (YARN-2534) FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal

2014-09-10 Thread zhihai xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129582#comment-14129582
 ] 

zhihai xu commented on YARN-2534:
-

I uploaded a patch YARN-2534.000.patch for review.
I added a test case in this patch to prove this issue exit:
Two queues: QueueA's maxShare is 1073741824 and QueueB's  maxShare is 
1073741824,
the sum of two maxShare is more than Integer.MAX_VALUE.
Without the fix, the test will fail.

 FairScheduler: totalMaxShare is not calculated correctly in 
 computeSharesInternal
 -

 Key: YARN-2534
 URL: https://issues.apache.org/jira/browse/YARN-2534
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.5.0
Reporter: zhihai xu
Assignee: zhihai xu
 Fix For: 2.6.0

 Attachments: YARN-2534.000.patch


 FairScheduler: totalMaxShare is not calculated correctly in 
 computeSharesInternal for some cases.
 If the sum of MAX share of all Schedulables is more than Integer.MAX_VALUE 
 ,but each individual MAX share is not equal to Integer.MAX_VALUE. then 
 totalMaxShare will be a negative value, which will cause all fairShare are 
 wrongly calculated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2534) FairScheduler: totalMaxShare is not calculated correctly in computeSharesInternal

2014-09-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129611#comment-14129611
 ] 

Hadoop QA commented on YARN-2534:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12667934/YARN-2534.000.patch
  against trunk revision 4be9517.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/4882//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/4882//console

This message is automatically generated.

 FairScheduler: totalMaxShare is not calculated correctly in 
 computeSharesInternal
 -

 Key: YARN-2534
 URL: https://issues.apache.org/jira/browse/YARN-2534
 Project: Hadoop YARN
  Issue Type: Bug
  Components: scheduler
Affects Versions: 2.5.0
Reporter: zhihai xu
Assignee: zhihai xu
 Attachments: YARN-2534.000.patch


 FairScheduler: totalMaxShare is not calculated correctly in 
 computeSharesInternal for some cases.
 If the sum of MAX share of all Schedulables is more than Integer.MAX_VALUE 
 ,but each individual MAX share is not equal to Integer.MAX_VALUE. then 
 totalMaxShare will be a negative value, which will cause all fairShare are 
 wrongly calculated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)