[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[ https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14316232#comment-14316232 ] Steve Loughran commented on YARN-2616: -- +1 applying to branch-2+ > Add CLI client to the registry to list/view entries > --- > > Key: YARN-2616 > URL: https://issues.apache.org/jira/browse/YARN-2616 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Affects Versions: 2.6.0 >Reporter: Steve Loughran >Assignee: Akshay Radia > Attachments: YARN-2616-003.patch, YARN-2616-008.patch, > YARN-2616-008.patch, yarn-2616-v1.patch, yarn-2616-v2.patch, > yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch, yarn-2616-v7.patch > > > registry needs a CLI interface -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314236#comment-14314236
]
Hadoop QA commented on YARN-2616:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12697704/YARN-2616-008.patch
against trunk revision e0ec071.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6574//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6574//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Affects Versions: 2.6.0
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, YARN-2616-008.patch,
> YARN-2616-008.patch, yarn-2616-v1.patch, yarn-2616-v2.patch,
> yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch, yarn-2616-v7.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305459#comment-14305459
]
Hadoop QA commented on YARN-2616:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12696489/YARN-2616-008.patch
against trunk revision ba58da2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:red}-1 eclipse:eclipse{color}. The patch failed to build with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6508//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6508//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, YARN-2616-008.patch,
> yarn-2616-v1.patch, yarn-2616-v2.patch, yarn-2616-v4.patch,
> yarn-2616-v5.patch, yarn-2616-v6.patch, yarn-2616-v7.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282230#comment-14282230
]
Hadoop QA commented on YARN-2616:
-
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12693027/yarn-2616-v7.patch
against trunk revision 19cbce3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6357//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6357//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch,
> yarn-2616-v6.patch, yarn-2616-v7.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[ https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14271493#comment-14271493 ] Akshay Radia commented on YARN-2616: Steve can address your test code change comments. I guess I have to wait for YARN-2683 to close before addressing all your comments (config and docs). Or do you prefer finishing the parts that can be done right now and open a 2nd jira for the remaining that blocks on YARN-2683. Prefer the later. > Add CLI client to the registry to list/view entries > --- > > Key: YARN-2616 > URL: https://issues.apache.org/jira/browse/YARN-2616 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Steve Loughran >Assignee: Akshay Radia > Attachments: YARN-2616-003.patch, yarn-2616-v1.patch, > yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch > > > registry needs a CLI interface -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265959#comment-14265959
]
Steve Loughran commented on YARN-2616:
--
thanks for doing the tests; without that the code that was checked in earlier
doesn't officially exist.
There's an outstanding patch, YARN-2683, which I'm trying to get in; this moves
all registry config settings to core-default and documents the registry in the
hadoop site docs. This impacts the CLI in a couple of ways:
*config*
Once YARN-2683 is in, all registry options will move to the core config, not
yarn config; this helps the registry
to run without any other YARN dependencies. Can you switch to using the basic
{{Configuration}}?
* docs*
The YARN-2683 patch will provide the structure for adding documentation on the
CLI
If we can get that patch in then it'll be easy to round off the CLI with a
basic manpage
h3. Testing
* test assertions*
There's lots of test operations like
{code}
result = cli.run(new String[] { "ls", "NonSlashPath"});
assertEquals(-1, result);
{code}
This could be factored out into some method
assertResult(cli, int code, String...args)
which included the arg list on a failure
minor: lots of tabs in the source. Indent with (two) spaces please.
* failure testing *
Can you add some tests with invalid bindings and see how the CLI fails? e.g: no
valid ZK host/port.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263424#comment-14263424
]
Hadoop QA commented on YARN-2616:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689911/yarn-2616-v6.patch
against trunk revision 947578c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6233//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6233//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch, yarn-2616-v6.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14263238#comment-14263238
]
Hadoop QA commented on YARN-2616:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689877/yarn-2616-v5.patch
against trunk revision 947578c.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6231//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6231//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch, yarn-2616-v4.patch, yarn-2616-v5.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262741#comment-14262741
]
Hadoop QA commented on YARN-2616:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689765/yarn-2616-v4.patch
against trunk revision e7257ac.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:red}-1 release audit{color}. The applied patch generated 1
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6229//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-YARN-Build/6229//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6229//console
This message is automatically generated.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch, yarn-2616-v4.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168458#comment-14168458
]
Steve Loughran commented on YARN-2616:
--
the core code is checked in YARN-2652, but without tests and documentations it
doesn't exist, Please add.
SLIDER-365 implements a resolve operation; the lessons from using that can help
define what is needed here. Key early learning is SLIDER-306, the path {{~}}
should refer to the user's home dir. That means that a path
{{~/services/hbase}} is valid across all users, so ideal for testing, scripting
&c.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155624#comment-14155624
]
Steve Loughran commented on YARN-2616:
--
features of 003 patch
# registry instance created via factory
# uses configuration instance built up on command line (though it is also
creating a {{YarnConfiguration()}} around that.
# pulls out all exception-to-error-text mapping to single method
# covered the current set of errors
# and also log @ debug if enabled.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: YARN-2616-003.patch, yarn-2616-v1.patch,
> yarn-2616-v2.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[
https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155530#comment-14155530
]
Steve Loughran commented on YARN-2616:
--
the patch I just posted doesn't {{stop()}} the registry service, so will leak a
curator instance/threads.
> Add CLI client to the registry to list/view entries
> ---
>
> Key: YARN-2616
> URL: https://issues.apache.org/jira/browse/YARN-2616
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: client
>Reporter: Steve Loughran
>Assignee: Akshay Radia
> Attachments: yarn-2616-v1.patch, yarn-2616-v2.patch
>
>
> registry needs a CLI interface
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-2616) Add CLI client to the registry to list/view entries
[ https://issues.apache.org/jira/browse/YARN-2616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155098#comment-14155098 ] Steve Loughran commented on YARN-2616: -- thanks. I'm going to pull this down into the main YARN-913 patch & sync up with changes, but will then post the patch here for it to be reviewed/completed in isolation. # I'll set things up for tests to go in, though I won't do the tests...I'll leave that as half the challenge. # Here's my evolving [[Updated Hadoop style guide|https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md]] > Add CLI client to the registry to list/view entries > --- > > Key: YARN-2616 > URL: https://issues.apache.org/jira/browse/YARN-2616 > Project: Hadoop YARN > Issue Type: Sub-task > Components: client >Reporter: Steve Loughran >Assignee: Akshay Radia > Attachments: yarn-2616-v1.patch, yarn-2616-v2.patch > > > registry needs a CLI interface -- This message was sent by Atlassian JIRA (v6.3.4#6332)
