[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-06 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530647#comment-14530647
 ] 

Hadoop QA commented on YARN-3018:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 37s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | tests included |   0m  0s | The patch appears to 
include 1 new or modified test files. |
| {color:green}+1{color} | javac |   7m 35s | There were no new javac warning 
messages. |
| {color:green}+1{color} | javadoc |   9m 32s | There were no new javadoc 
warning messages. |
| {color:green}+1{color} | release audit |   0m 21s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 48s | There were no new checkstyle 
issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| {color:green}+1{color} | install |   1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with 
eclipse:eclipse. |
| {color:green}+1{color} | findbugs |   1m 16s | The patch does not introduce 
any new Findbugs (version 2.0.3) warnings. |
| {color:red}-1{color} | yarn tests |  58m 18s | Tests failed in 
hadoop-yarn-server-resourcemanager. |
| | |  94m 37s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | 
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730800/YARN-3018-4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / a583a40 |
| hadoop-yarn-server-resourcemanager test log | 
https://builds.apache.org/job/PreCommit-YARN-Build/7735/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
 |
| Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/7735/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7735/console |


This message was automatically generated.

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch, 
 YARN-3018-4.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-06 Thread nijel (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14530699#comment-14530699
 ] 

nijel commented on YARN-3018:
-

The test failure can be solved by changing the following lines in 
TestLeafQueue.testLocalityConstraints() 

-verify(app_0,never()).allocate(eq(NodeType.RACK_LOCAL), eq(node_1_1),  - 
line number 2394
+verify(app_0, never()).allocate(eq(NodeType.NODE_LOCAL), eq(node_1_1),  
 any(Priority.class), any(ResourceRequest.class), any(Container.class));
 assertEquals(0, app_0.getSchedulingOpportunities(priority)); 
-assertEquals(1, app_0.getTotalRequiredResources(priority));- line 
number 2397
+assertEquals(0, app_0.getTotalRequiredResources(priority));

But i am not sure about the impact. Can any one help me in this ? 

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch, 
 YARN-3018-4.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-04 Thread nijel (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526307#comment-14526307
 ] 

nijel commented on YARN-3018:
-

Thanks [~leftnoteasy]
Uploaded the patch

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526309#comment-14526309
 ] 

Hadoop QA commented on YARN-3018:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | release audit |   0m 14s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:red}-1{color} | whitespace |   0m  0s | The patch has 2  line(s) that 
end in whitespace. Use git apply --whitespace=fix. |
| | |   0m 19s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730124/YARN-3018-1.patch |
| Optional Tests |  |
| git revision | trunk / 3ba1836 |
| whitespace | 
https://builds.apache.org/job/PreCommit-YARN-Build/7683/artifact/patchprocess/whitespace.txt
 |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7683/console |


This message was automatically generated.

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526435#comment-14526435
 ] 

Hadoop QA commented on YARN-3018:
-

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply 
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730139/YARN-3018-2.patch |
| Optional Tests |  |
| git revision | trunk / bb9ddef |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7684/console |


This message was automatically generated.

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch, YARN-3018-2.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-04 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526466#comment-14526466
 ] 

Hadoop QA commented on YARN-3018:
-

\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |   0m  0s | Pre-patch trunk compilation is 
healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any 
@author tags. |
| {color:green}+1{color} | release audit |   0m 15s | The applied patch does 
not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that 
end in whitespace. |
| | |   0m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | 
http://issues.apache.org/jira/secure/attachment/12730144/YARN-3018-3.patch |
| Optional Tests |  |
| git revision | trunk / bb9ddef |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP 
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/7685/console |


This message was automatically generated.

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-04 Thread Jian He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527612#comment-14527612
 ] 

Jian He commented on YARN-3018:
---

hi [~nijel], 
below code in CapacitySchedulerConfiguration actually uses 0 instead. How about 
change it to be 0 ? and simplify below code to {{return 
getInt(NODE_LOCALITY_DELAY, DEFAULT_NODE_LOCALITY_DELAY);}}
{code}
  public int getNodeLocalityDelay() {
int delay = getInt(NODE_LOCALITY_DELAY, DEFAULT_NODE_LOCALITY_DELAY);
return (delay == DEFAULT_NODE_LOCALITY_DELAY) ? 0 : delay;
  }
{code}

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial
 Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch


 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-05-01 Thread Wangda Tan (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14524340#comment-14524340
 ] 

Wangda Tan commented on YARN-3018:
--

Thanks for reporting this [~nijel].

bq. I prefer to have the value as -1 in file also
+1 to make both to be -1.

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Assignee: nijel
Priority: Trivial

 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

2015-01-08 Thread nijel (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269058#comment-14269058
 ] 

nijel commented on YARN-3018:
-

Please give your opinion.
I prefer to have the value as -1 in file also

If it sounds good, i can upload a patch

 Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
 code and default xml file
 

 Key: YARN-3018
 URL: https://issues.apache.org/jira/browse/YARN-3018
 Project: Hadoop YARN
  Issue Type: Bug
  Components: capacityscheduler
Reporter: nijel
Priority: Trivial

 For the configuration item yarn.scheduler.capacity.node-locality-delay the 
 default value given in code is -1
 public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
 In the default capacity-scheduler.xml file in the resource manager config 
 directory it is 40.
 Can it be unified to avoid confusion when the user creates the file without 
 this configuration. IF he expects the values in the file to be default 
 values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)