[jira] [Commented] (YARN-3018) Unify the default value for yarn.scheduler.capacity.node-locality-delay in code and default xml file

[Jian He (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-3018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527612#comment-14527612
 ] 

Jian He commented on YARN-3018:
-------------------------------

hi [~nijel], 
below code in CapacitySchedulerConfiguration actually uses 0 instead. How about 
change it to be 0 ? and simplify below code to {{return 
getInt(NODE_LOCALITY_DELAY, DEFAULT_NODE_LOCALITY_DELAY);}}
{code}
  public int getNodeLocalityDelay() {
    int delay = getInt(NODE_LOCALITY_DELAY, DEFAULT_NODE_LOCALITY_DELAY);
    return (delay == DEFAULT_NODE_LOCALITY_DELAY) ? 0 : delay;
  }
{code}

> Unify the default value for yarn.scheduler.capacity.node-locality-delay in 
> code and default xml file
> ----------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3018
>                 URL: https://issues.apache.org/jira/browse/YARN-3018
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: capacityscheduler
>            Reporter: nijel
>            Assignee: nijel
>            Priority: Trivial
>         Attachments: YARN-3018-1.patch, YARN-3018-2.patch, YARN-3018-3.patch
>
>
> For the configuration item "yarn.scheduler.capacity.node-locality-delay" the 
> default value given in code is "-1"
> public static final int DEFAULT_NODE_LOCALITY_DELAY = -1;
> In the default capacity-scheduler.xml file in the resource manager config 
> directory it is 40.
> Can it be unified to avoid confusion when the user creates the file without 
> this configuration. IF he expects the values in the file to be default 
> values, then it will be wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)