[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512409#comment-14512409
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #908 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/908/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-yarn-project/CHANGES.txt
* hadoop-mapreduce-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512391#comment-14512391
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #174 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/174/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-mapreduce-project/CHANGES.txt
* hadoop-yarn-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512533#comment-14512533
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #175 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/175/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-yarn-project/CHANGES.txt
* hadoop-mapreduce-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512438#comment-14512438
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2106 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2106/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-yarn-project/CHANGES.txt
* hadoop-mapreduce-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512456#comment-14512456
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #165 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/165/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-yarn-project/CHANGES.txt
* hadoop-mapreduce-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512557#comment-14512557
]
Hudson commented on YARN-3472:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2124 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2124/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-mapreduce-project/CHANGES.txt
* hadoop-yarn-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512096#comment-14512096
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7673 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7673/])
Moving YARN-3351, YARN-3382, YARN-3472, MAPREDUCE-6238 to the 2.7.1 CHANGES.txt
(vinodkv: rev 2f82ae042a6f3110742aaa57c076bb9ebd7888d1)
* hadoop-mapreduce-project/CHANGES.txt
* hadoop-yarn-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.7.1
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493986#comment-14493986
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #154 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/154/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493972#comment-14493972
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #897 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/897/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
* hadoop-yarn-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493939#comment-14493939
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #163 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/163/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
* hadoop-yarn-project/CHANGES.txt
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493956#comment-14493956
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2095 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2095/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14494277#comment-14494277
]
Hudson commented on YARN-3472:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2113 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2113/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492879#comment-14492879
]
Hadoop QA commented on YARN-3472:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724921/0002-YARN-3472.patch
against trunk revision 174d8b3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestAllocationFileLoaderService
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7317//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7317//console
This message is automatically generated.
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493080#comment-14493080
]
Jian He commented on YARN-3472:
---
+1
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14493109#comment-14493109
]
Hudson commented on YARN-3472:
--
FAILURE: Integrated in Hadoop-trunk-Commit #7577 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7577/])
YARN-3472. Fixed possible leak in DelegationTokenRenewer#allTokens. Contributed
by Rohith Sharmaks (jianhe: rev a1afbc48b53f6bdbd30dc8eb56a7621d49c5d6db)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Fix For: 2.8.0
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492228#comment-14492228
]
Rohith commented on YARN-3472:
--
bq. But I am surprised why the test were not failing earlier? Am I missing
something?
Ignore this, I was referring appTokens instead of allTokens
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492128#comment-14492128
]
Rohith commented on YARN-3472:
--
IIUC the test method
{{TestDelegationTokenRenwer#testReplaceExpiringDelegationToken}} , there is
already check for token1 from allTokens should be removed. Otherwise the
waitFor method throw TimeoutException.
{code}
// wait for the initial expiring hdfs token to be removed.
GenericTestUtils.waitFor(new SupplierBoolean() {
public Boolean get() {
return !rm.getRMContext().getDelegationTokenRenewer()
.getDelegationTokens().contains(token1);
}
}, 1000, 2);
{code}
But I am surprised why the test were not failing earlier? Am I missing
something?
I was chekcing earlier jenkins result and observed that jenkins has run only
HDFS tests but not RM package tests eventhough RM package tests has changed.
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492332#comment-14492332
]
Hadoop QA commented on YARN-3472:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724921/0002-YARN-3472.patch
against trunk revision f8f5887.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:
org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart
org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/7314//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7314//console
This message is automatically generated.
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch, 0002-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3472) Possible leak in DelegationTokenRenewer#allTokens
[
https://issues.apache.org/jira/browse/YARN-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14490374#comment-14490374
]
Jian He commented on YARN-3472:
---
[~rohithsharma], thanks for the patch. Could you add a test case?
In TestDelegationTokenRenwer#testReplaceExpiringDelegationToken, after this
check {code}// wait for the initial expiring hdfs token to be removed. {code},
we can add a simple check that the token is removed from allTokens.
Possible leak in DelegationTokenRenewer#allTokens
--
Key: YARN-3472
URL: https://issues.apache.org/jira/browse/YARN-3472
Project: Hadoop YARN
Issue Type: Bug
Reporter: Jian He
Assignee: Rohith
Attachments: 0001-YARN-3472.patch
When old token is expiring and being removed, it's not removed from the
allTokens map, resulting in possible leak.
{code}
if (t.token.getKind().equals(new Text(HDFS_DELEGATION_TOKEN))) {
iter.remove();
t.cancelTimer();
LOG.info(Removed expiring token + t);
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
