[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636092#comment-16636092 ] Haibo Chen commented on YARN-3525: -- Closing this. > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch, YARN-3525.003.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636079#comment-16636079 ] Zoltan Siegl commented on YARN-3525: [~haibochen] Yes, I have seen that both are deprecated by now, but as they still are usable, for the sake of consistency it might be a good idea to use the new namespace still. If this is not needed at all, could you close this issue? > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch, YARN-3525.003.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631174#comment-16631174 ] Haibo Chen commented on YARN-3525: -- I'm not sure if we still need to address this. The two properties have now been deprecated by yarn.resource-types.memory-mb.increment-allocation and yarn.resource-types.vcores.increment-allocation after resource type is merged. Because cpu and vcores are two built-in resource types, people should use the resource-types-prefixed configuration properties, which are scheduler agnostic. > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch, YARN-3525.003.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617680#comment-16617680 ] Szilard Nemeth commented on YARN-3525: -- Hi [~zsiegl]! Thanks for the updated patch! LGTM, +1 (non-binding) > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch, YARN-3525.003.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617675#comment-16617675 ] Zoltan Siegl commented on YARN-3525: Javac bug increase is intentional. > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch, YARN-3525.003.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16617616#comment-16617616 ] Hadoop QA commented on YARN-3525: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 50s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 41s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 54s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 16m 49s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 34s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 19s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 9m 19s{color} | {color:red} hadoop-yarn-project_hadoop-yarn generated 2 new + 107 unchanged - 0 fixed = 109 total (was 107) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 32s{color} | {color:green} hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 36s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 80m 27s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 29s{color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 48s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}168m 21s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 | | JIRA Issue | YARN-3525 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12939966/YARN-3525.003.patch | | Optional Tests | dupname asflicense compile javac javadoc
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612193#comment-16612193 ] Szilard Nemeth commented on YARN-3525: -- Hi [~zsiegl]! Thanks for the patch, I like this deprecation approach. Please use String constants for {{yarn.scheduler.fair.increment-allocation-mb yarn.scheduler.fair.increment-allocation-vcores}} and {{yarn.scheduler.fair.increment-allocation-mb yarn.scheduler.fair.increment-allocation-vcores}} in the test where possible. Otherwise the patch looks good to me. > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611819#comment-16611819 ] Zoltan Siegl commented on YARN-3525: Hi [~ywskycn]. I see that this is a long pending request. Both keys are deprecated by now, but for the sake of consistency I have created a patch where we deprecated the old names on favour of the new namespaces. If you have a few secs, please check if you like this approach. Thanks. > Rename fair scheduler properties increment-allocation-mb and > increment-allocation-vcores > > > Key: YARN-3525 > URL: https://issues.apache.org/jira/browse/YARN-3525 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Bibin A Chundatt >Assignee: Zoltan Siegl >Priority: Minor > Attachments: YARN-3525.001.patch > > > Rename below two properties since only used by fair scheduler > {color:blue}yarn.scheduler.increment-allocation-mb{color} to > {color:red}yarn.scheduler.fair.increment-allocation-mb{color} > {color:blue}yarn.scheduler.increment-allocation-vcores{color} to > {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} > All other properties only for fair scheduler are using {color:red} > yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610632#comment-16610632 ] Hadoop QA commented on YARN-3525: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 22s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 3m 26s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 12s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 0s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 10s{color} | {color:green} hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 10 unchanged - 2 fixed = 10 total (was 12) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 10m 25s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 71m 11s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 23s{color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 40s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}144m 39s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:ba1ab08 | | JIRA Issue | YARN-3525 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12939236/YARN-3525.001.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | |
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507381#comment-14507381 ] Wei Yan commented on YARN-3525: --- Hi, [~bibinchundatt], I think the reason is These properties are looked up in the yarn-site.xml. Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores Key: YARN-3525 URL: https://issues.apache.org/jira/browse/YARN-3525 Project: Hadoop YARN Issue Type: Bug Reporter: Bibin A Chundatt Assignee: Bibin A Chundatt Priority: Minor Rename below two properties since only used by fair scheduler {color:blue}yarn.scheduler.increment-allocation-mb{color} to {color:red}yarn.scheduler.fair.increment-allocation-mb{color} {color:blue}yarn.scheduler.increment-allocation-vcores{color} to {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} All other properties only for fair scheduler are using {color:red} yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3525) Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores
[ https://issues.apache.org/jira/browse/YARN-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507449#comment-14507449 ] Bibin A Chundatt commented on YARN-3525: Hi [~ywskycn] , Thank you for looking in to the issue. All the fair scheduler properties we mention in yarn-site only except queue level configuration. (About 13 properties) Reference :http://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/FairScheduler.html Except the mentioned properties all of them follow the same prefix pattern specific to fair. So i feel we should sync these two properties also. Rename fair scheduler properties increment-allocation-mb and increment-allocation-vcores Key: YARN-3525 URL: https://issues.apache.org/jira/browse/YARN-3525 Project: Hadoop YARN Issue Type: Bug Reporter: Bibin A Chundatt Assignee: Bibin A Chundatt Priority: Minor Rename below two properties since only used by fair scheduler {color:blue}yarn.scheduler.increment-allocation-mb{color} to {color:red}yarn.scheduler.fair.increment-allocation-mb{color} {color:blue}yarn.scheduler.increment-allocation-vcores{color} to {color:red}yarn.scheduler.fair.increment-allocation-vcores{color} All other properties only for fair scheduler are using {color:red} yarn.scheduler.fair{color} prefix . -- This message was sent by Atlassian JIRA (v6.3.4#6332)