[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614105#comment-14614105
]
Karthik Kambatla commented on YARN-3860:
bq. That is true only if RM restart is enabled and ZKRMStateStore is used but
other settings should be cared.
bq. getServiceState is expected to return or fail immediately if the node is
down.
Do we support other configurations? My only concern is the case when
getServiceState fails because we can't reach the other node, but the node and
the RM are actually active. If someone uses rmadmin -transitionToActive, they
might falsely assume that a split-brain scenario is not possible.
Just to be clear, I agree the patch is benign. I want to make sure we are clear
on why we are adding it.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605508#comment-14605508
]
Hudson commented on YARN-3860:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #243 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/243/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605517#comment-14605517
]
Hudson commented on YARN-3860:
--
SUCCESS: Integrated in Hadoop-Yarn-trunk #973 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/973/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605673#comment-14605673
]
Hudson commented on YARN-3860:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2171 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2171/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605704#comment-14605704
]
Hudson commented on YARN-3860:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #232 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/232/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605851#comment-14605851
]
Hudson commented on YARN-3860:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2189 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2189/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605883#comment-14605883
]
Hudson commented on YARN-3860:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #241 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/241/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606588#comment-14606588
]
Karthik Kambatla commented on YARN-3860:
Also, I wonder if this affects the latency of transitioning active by any
significant amount? [~iwasakims] - any observations here?
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606586#comment-14606586
]
Karthik Kambatla commented on YARN-3860:
I am not convinced we need this.
The only reason we don't want both RMs to be active is to avoid the split-brain
situation. Today, if both RMs become active, one of them fails to create the
fencing-node and should automatically transition to standby.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605207#comment-14605207
]
Masatake Iwasaki commented on YARN-3860:
Thanks, [~zxu] and [~djp]!
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606870#comment-14606870
]
Junping Du commented on YARN-3860:
--
bq. The only reason we don't want both RMs to be active is to avoid the
split-brain situation. Today, if both RMs become active, one of them fails to
create the fencing-node and should automatically transition to standby.
Actually, this behavior could confuse user as it sounds like which RM is chosen
by randomly. The expected behavior here is: if user doesn't specify
--forceactive which means user may not know other RM get activated now -
nothing should get updated by YARN and a warning message from CLI get thrown
out if already another RM in activated state. No?
bq. I wonder if this affects the latency of transitioning active by any
significant amount.
The only latency to add here is reading a YARN configuration which doesn't
sounds like a problem for user experience especially we support RM down with
work preserving.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607191#comment-14607191
]
Masatake Iwasaki commented on YARN-3860:
bq. Today, if both RMs become active, one of them fails to create the
fencing-node and should automatically transition to standby.
That is true only if RM restart is enabled and ZKRMStateStore is used but other
settings should be cared. Also users can know failure reason from console
output such as rmX is already active by the status checking.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607196#comment-14607196
]
Masatake Iwasaki commented on YARN-3860:
bq. I wonder if this affects the latency of transitioning active by any
significant amount?
I think the time to check state of other nodes is small and not to be problem
especially when user is doing manual transition. getServiceState is expected to
return or fail immediately if the node is down. I'll check corner cases but it
is a bug if getServiceState blocks long time.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605073#comment-14605073
]
Junping Du commented on YARN-3860:
--
Thanks [~iwasakims] for nice catching and the patch! Latest patch LGTM.
[~zxu], thanks for review here. I think times(1) is quite useful here as the
calling times indicate the other nodes loops into consideration. If we have
rm1, rm2, rm3 in config settings before, here we should get times(2). If you
agree with it, I will go ahead to commit this patch soon.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605108#comment-14605108
]
zhihai xu commented on YARN-3860:
-
yes, it makes sense. Although they are equivalent, it is easier to change from
times(1) to times(2) if we have rm1, rm2, rm3 in config settings.
+1(non-binding) for the latest patch.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605131#comment-14605131
]
Hudson commented on YARN-3860:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8082 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8082/])
YARN-3860. rmadmin -transitionToActive should check the state of non-target
node. (Contributed by Masatake Iwasaki) (junping_du: rev
a95d39f9d08b3b215a1b33e77e9ab8a2ee59b3a9)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RMAdminCLI.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestRMAdminCLI.java
* hadoop-yarn-project/CHANGES.txt
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Components: resourcemanager
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Fix For: 2.8.0
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604506#comment-14604506
]
Hadoop QA commented on YARN-3860:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 41s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 29s | The applied patch generated 1
new checkstyle issues (total was 38, now 39). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests | 19m 52s | Tests failed in
hadoop-yarn-client. |
| | | 56m 34s | |
\\
\\
|| Reason || Tests ||
| Timed out tests |
org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742365/YARN-3860.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 79ed0f9 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/8365/artifact/patchprocess/diffcheckstylehadoop-yarn-client.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8365/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-client test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8365/artifact/patchprocess/testrun_hadoop-yarn-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8365/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8365/console |
This message was automatically generated.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
Attachments: YARN-3860.001.patch, YARN-3860.002.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604531#comment-14604531
]
Hadoop QA commented on YARN-3860:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 15s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 31s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 28s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 6m 55s | Tests passed in
hadoop-yarn-client. |
| | | 43m 9s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742371/YARN-3860.003.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 79ed0f9 |
| hadoop-yarn-client test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8367/artifact/patchprocess/testrun_hadoop-yarn-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8367/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8367/console |
This message was automatically generated.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604509#comment-14604509
]
Hadoop QA commented on YARN-3860:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 37s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 36s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 30s | The applied patch generated 1
new checkstyle issues (total was 38, now 39). |
| {color:red}-1{color} | whitespace | 0m 1s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 6m 55s | Tests passed in
hadoop-yarn-client. |
| | | 43m 42s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742367/YARN-3860.002.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 79ed0f9 |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/8366/artifact/patchprocess/diffcheckstylehadoop-yarn-client.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-YARN-Build/8366/artifact/patchprocess/whitespace.txt
|
| hadoop-yarn-client test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8366/artifact/patchprocess/testrun_hadoop-yarn-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8366/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8366/console |
This message was automatically generated.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
Attachments: YARN-3860.001.patch, YARN-3860.002.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604539#comment-14604539
]
zhihai xu commented on YARN-3860:
-
[~iwasakims], thanks for working on this issue. This looks like a good catch.
One nit: I think times(1) is used by default, Can we just use
{{verify(haadmin).getServiceStatus();}}? because all other tests didn't have
times(1) in verify.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
Attachments: YARN-3860.001.patch, YARN-3860.002.patch,
YARN-3860.003.patch
Users can make both ResouceManagers active by {{rmadmin -transitionToActive}}
even if {{\--forceactive}} option is not given. {{haadmin
-transitionToActive}} of HDFS checks whether non-target nodes are already
active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3860) rmadmin -transitionToActive should check the state of non-target node
[
https://issues.apache.org/jira/browse/YARN-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14604474#comment-14604474
]
Masatake Iwasaki commented on YARN-3860:
HAAdmin#isOtherTargetNodeActive does not checks the other nodes are active
without overriding HAAdmin#getTargetIds which returns list including only given
target id. RMAdminCLI should have getTargetIds method which returns list of all
node ids as DFSHAAdmin do.
rmadmin -transitionToActive should check the state of non-target node
-
Key: YARN-3860
URL: https://issues.apache.org/jira/browse/YARN-3860
Project: Hadoop YARN
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
Priority: Minor
{{haadmin -transitionToActive}} of HDFS checks whether non-target nodes are
already active but {{rmadmin -transitionToActive}} does not do.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
