[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[
https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15932381#comment-15932381
]
Hadoop QA commented on YARN-5153:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 3s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-5153 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12859524/YARN-5153.002.patch |
| Optional Tests | asflicense |
| uname | Linux 399f1e74346e 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 34a931c |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/15331/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> [YARN-3368] Add a toggle to switch timeline view / table view for containers
> information inside application-attempt page
>
>
> Key: YARN-5153
> URL: https://issues.apache.org/jira/browse/YARN-5153
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: webapp
>Reporter: Wangda Tan
>Assignee: Akhil PB
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png, screenshot-5.png, YARN-5153.001.patch, YARN-5153.002.patch,
> YARN-5153.preliminary.1.patch, YARN-5153-YARN-3368.1.patch
>
>
> Now we only support timeline view for containers on app-attempt page, it will
> be also very useful to show table of containers in some cases. For example,
> user can short containers based on priority, etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[ https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904886#comment-15904886 ] Sunil G commented on YARN-5153: --- Few comments: # If attempts are empty, then proper error message has to be showed. # Default size of appId/ContainerID must be bigger enough to see the name. > [YARN-3368] Add a toggle to switch timeline view / table view for containers > information inside application-attempt page > > > Key: YARN-5153 > URL: https://issues.apache.org/jira/browse/YARN-5153 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Reporter: Wangda Tan >Assignee: Akhil PB > Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, > screenshot-4.png, screenshot-5.png, YARN-5153.001.patch, > YARN-5153.preliminary.1.patch, YARN-5153-YARN-3368.1.patch > > > Now we only support timeline view for containers on app-attempt page, it will > be also very useful to show table of containers in some cases. For example, > user can short containers based on priority, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[
https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904806#comment-15904806
]
Hadoop QA commented on YARN-5153:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
40s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 1m 47s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-5153 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12857295/YARN-5153.001.patch |
| Optional Tests | asflicense |
| uname | Linux 9b921dba7da0 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / fd26783 |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/15225/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> [YARN-3368] Add a toggle to switch timeline view / table view for containers
> information inside application-attempt page
>
>
> Key: YARN-5153
> URL: https://issues.apache.org/jira/browse/YARN-5153
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: webapp
>Reporter: Wangda Tan
>Assignee: Akhil PB
> Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png,
> screenshot-4.png, screenshot-5.png, YARN-5153.001.patch,
> YARN-5153.preliminary.1.patch, YARN-5153-YARN-3368.1.patch
>
>
> Now we only support timeline view for containers on app-attempt page, it will
> be also very useful to show table of containers in some cases. For example,
> user can short containers based on priority, etc.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[ https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893785#comment-15893785 ] Akhil PB commented on YARN-5153: Hi [~wangda], assigning the ticket to myself since I have a patch done along with [YARN-5705|https://issues.apache.org/jira/browse/YARN-5705]. I will separate the timeline/table view patch from YARN-5705 and will fix in this ticket so that YARN-5705 can be an independent one. cc [~sunilg] > [YARN-3368] Add a toggle to switch timeline view / table view for containers > information inside application-attempt page > > > Key: YARN-5153 > URL: https://issues.apache.org/jira/browse/YARN-5153 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp >Reporter: Wangda Tan >Assignee: Akhil PB > Attachments: screenshot-1.png, screenshot-2.png, screenshot-3.png, > screenshot-4.png, screenshot-5.png, YARN-5153.preliminary.1.patch, > YARN-5153-YARN-3368.1.patch > > > Now we only support timeline view for containers on app-attempt page, it will > be also very useful to show table of containers in some cases. For example, > user can short containers based on priority, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[
https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323923#comment-15323923
]
Sunil G commented on YARN-5153:
---
Thanks [~leftnoteasy] for the patch and screen shots:
Few comments
1. User has to click on one container/app attempt from the below table to see
the time line view at the top of the page, Am I correct?. If so, is it better
to keep the table at the top and we can show the timeline view below table. We
can fix the size of the table for this. Or did you see some other advantages
for keeping the timeline view at the top?
2. If containers life time is lesser, we are going to see more active table for
listing containers. If one container is finished and if the entry is still
present in table, we may show more error logs. Do you prefer to keep a
*Refresh* button?
3.
in {{containers-table arr1=rmModel arr2=tsModel
table-id="app-attempts-table"}}, could we name
arr1 -> rmContainers
arr2 -> timelineContainers
for better readability.
4. In {{yarn-app-attempt.hbs}}
{code}
+ {{timeline-view parent-id="containers-timeline-div"
my-id="timeline-view" height="400" rmModel=model.rmContainers
tsModel=model.tsContainers
+label="shortAppAttemptId" attemptModel=false
timelineView=isTimelineView}}
{code}
I think {{timelineView}} is no longer used.
> [YARN-3368] Add a toggle to switch timeline view / table view for containers
> information inside application-attempt page
>
>
> Key: YARN-5153
> URL: https://issues.apache.org/jira/browse/YARN-5153
> Project: Hadoop YARN
> Issue Type: Sub-task
>Reporter: Wangda Tan
>Assignee: Wangda Tan
> Attachments: YARN-5153-YARN-3368.1.patch,
> YARN-5153.preliminary.1.patch, screenshot-1.png, screenshot-2.png,
> screenshot-3.png, screenshot-4.png, screenshot-5.png
>
>
> Now we only support timeline view for containers on app-attempt page, it will
> be also very useful to show table of containers in some cases. For example,
> user can short containers based on priority, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[ https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321397#comment-15321397 ] Wangda Tan commented on YARN-5153: -- Attached screenshot-5 to show the latest changes. > [YARN-3368] Add a toggle to switch timeline view / table view for containers > information inside application-attempt page > > > Key: YARN-5153 > URL: https://issues.apache.org/jira/browse/YARN-5153 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-5153-YARN-3368.1.patch, > YARN-5153.preliminary.1.patch, screenshot-1.png, screenshot-2.png, > screenshot-3.png, screenshot-4.png, screenshot-5.png > > > Now we only support timeline view for containers on app-attempt page, it will > be also very useful to show table of containers in some cases. For example, > user can short containers based on priority, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[ https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307513#comment-15307513 ] Sunil G commented on YARN-5153: --- Hi [~leftnoteasy], Thank you very much for sharing the patch. I have few comments on this UI and in code. - Having a tick box will definitely help us having this functionality. But how about having a sub-tab instead of tick box. Tab1 can show *List View* and Tab2 can show *Timeline View*. Thoughts? - When we have multiple app attempts or containers, i think current UI will only show one item (attempt/container) for timeline page. But list page will show many entries. So is it possible to move/iterate against multiple entries of attempts/container in timeline view. I got this doubt because current screen shots were showing only one item per timeline view. - As you mentioned, we could do some cleanup in app-attempt.hbs and container.hbs file to avoid duplicated code. > [YARN-3368] Add a toggle to switch timeline view / table view for containers > information inside application-attempt page > > > Key: YARN-5153 > URL: https://issues.apache.org/jira/browse/YARN-5153 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Wangda Tan >Assignee: Wangda Tan > Attachments: YARN-5153.preliminary.1.patch, screenshot-1.png, > screenshot-2.png, screenshot-3.png, screenshot-4.png > > > Now we only support timeline view for containers on app-attempt page, it will > be also very useful to show table of containers in some cases. For example, > user can short containers based on priority, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5153) [YARN-3368] Add a toggle to switch timeline view / table view for containers information inside application-attempt page
[ https://issues.apache.org/jira/browse/YARN-5153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15303189#comment-15303189 ] Wangda Tan commented on YARN-5153: -- Attached a preliminary patch, it has a "timeline view" checkbox so user can choose to view timeline view or table view (See attached screenshots) TODO: - Add a search box and make column sortable for table views - Code cleanup / de-dup, etc. > [YARN-3368] Add a toggle to switch timeline view / table view for containers > information inside application-attempt page > > > Key: YARN-5153 > URL: https://issues.apache.org/jira/browse/YARN-5153 > Project: Hadoop YARN > Issue Type: Sub-task >Reporter: Wangda Tan >Assignee: Wangda Tan > > Now we only support timeline view for containers on app-attempt page, it will > be also very useful to show table of containers in some cases. For example, > user can short containers based on priority, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
