[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447399#comment-15447399 ] Jonathan Hung commented on YARN-5550: - Awesome, thanks [~zhz]! > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement > Components: client, test >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Minor > Fix For: 2.7.4 > > Attachments: YARN-5550.001.patch, YARN-5550.002.patch, > YARN-5550.003.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447185#comment-15447185 ] Hudson commented on YARN-5550: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10369 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10369/]) YARN-5550. TestYarnCLI#testGetContainers should format according to (zhz: rev ed6ff5cd789cab621fbfb88c8e8de4f215cd2961) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/cli/TestYarnCLI.java > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement > Components: client, test >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Minor > Fix For: 2.7.4 > > Attachments: YARN-5550.001.patch, YARN-5550.002.patch, > YARN-5550.003.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447182#comment-15447182 ] Hadoop QA commented on YARN-5550: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 12s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 22s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 26s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 32s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 17s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 23s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 57s {color} | {color:green} hadoop-yarn-client in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 29m 38s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12826077/YARN-5550.003.patch | | JIRA Issue | YARN-5550 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux b416dec0f69c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 5d1609d | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/12930/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/12930/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement > Components: client, test >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Minor > Fix For: 2.7.4 > > Attachments: YARN-5550.001.patch, YARN-5550.002.patch, >
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15447096#comment-15447096 ] Jonathan Hung commented on YARN-5550: - Thanks [~zhz] for the review! Attached patch. > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Minor > Attachments: YARN-5550.001.patch, YARN-5550.002.patch, > YARN-5550.003.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446717#comment-15446717 ] Zhe Zhang commented on YARN-5550: - Thanks [~jhung] for taking on the work. Patch LGTM overall. A couple of very minor nits: # Can we move {{CONTAINER_PATTERN}} below the private variables? # We can also consider using the {{VisibleForTesting}} annotation here +1 pending above > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Assignee: Jonathan Hung >Priority: Minor > Attachments: YARN-5550.001.patch, YARN-5550.002.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431940#comment-15431940 ] Hadoop QA commented on YARN-5550: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 52s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 19s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 25s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 14s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 29s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 14s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 16s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 21s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 33s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 1s {color} | {color:red} hadoop-yarn-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 7s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.client.api.impl.TestYarnClient | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824958/YARN-5550.002.patch | | JIRA Issue | YARN-5550 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 4afee793280e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 3ca4d6d | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/12855/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/12855/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/12855/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/12855/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 >
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431889#comment-15431889 ] Jonathan Hung commented on YARN-5550: - Fixed whitespace issue. Test case failures seem unrelated to this patch (seems related to [YARN-5389|https://issues.apache.org/jira/browse/YARN-5389]). > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Priority: Minor > Attachments: YARN-5550.001.patch, YARN-5550.002.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431870#comment-15431870 ] Hadoop QA commented on YARN-5550: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 12s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 25s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 15s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 31s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s {color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 22s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 16m 4s {color} | {color:red} hadoop-yarn-client in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 28m 45s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.client.api.impl.TestYarnClient | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12824951/YARN-5550.001.patch | | JIRA Issue | YARN-5550 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 0e636773259c 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 3ca4d6d | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/12853/artifact/patchprocess/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/12853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt | | unit test logs | https://builds.apache.org/job/PreCommit-YARN-Build/12853/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/12853/testReport/ | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/12853/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > TestYarnCLI#testGetContainers should
[jira] [Commented] (YARN-5550) TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN
[ https://issues.apache.org/jira/browse/YARN-5550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431829#comment-15431829 ] Jonathan Hung commented on YARN-5550: - Attached patch. > TestYarnCLI#testGetContainers should format according to CONTAINER_PATTERN > -- > > Key: YARN-5550 > URL: https://issues.apache.org/jira/browse/YARN-5550 > Project: Hadoop YARN > Issue Type: Improvement >Affects Versions: 2.6.4 >Reporter: Jonathan Hung >Priority: Minor > Attachments: YARN-5550.001.patch > > > TestYarnCLI#testGetContainers hard codes expected output of getting list of > containers via Yarn CLI. If the timestamp is shorter than the number of > expected characters in ApplicationCLI#CONTAINER_PATTERN (which is 20), the > assert will fail due to whitespace. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org