[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729545#comment-15729545 ] Sunil G commented on YARN-5965: --- Test case failure looks not related. Committing the patch. > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He >Assignee: Rohith Sharma K S > Attachments: YARN-5965.0.patch, YARN-5965.1.patch > > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[
https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729445#comment-15729445
]
Hadoop QA commented on YARN-5965:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
59s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
23s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
51s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
40s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 48s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 3 new + 314 unchanged - 0 fixed = 317 total (was 314) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
31s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
29s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 42m 37s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
20s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}112m 38s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.server.resourcemanager.TestRMRestart |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-5965 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12842108/YARN-5965.1.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle cc |
| uname | Linux da5959d299e8 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12
17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 563480d |
|
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15729280#comment-15729280 ] Sunil G commented on YARN-5965: --- Still jenkins has not ran on latest patch. I triggered a build manually now. > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He >Assignee: Rohith Sharma K S > Attachments: YARN-5965.0.patch, YARN-5965.1.patch > > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728059#comment-15728059 ] Sunil G commented on YARN-5965: --- +1 from my end as well. i could commit the same in a day if there are no objections. > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He >Assignee: Rohith Sharma K S > Attachments: YARN-5965.0.patch, YARN-5965.1.patch > > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728033#comment-15728033 ] Jian He commented on YARN-5965: --- lgtm > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He >Assignee: Rohith Sharma K S > Attachments: YARN-5965.0.patch, YARN-5965.1.patch > > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[
https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725641#comment-15725641
]
Hadoop QA commented on YARN-5965:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
59s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
14s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
39s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
43s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
6s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}
0m 53s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch
generated 3 new + 319 unchanged - 0 fixed = 322 total (was 319) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
35s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
44s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 39m 7s{color}
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
19s{color} | {color:green} hadoop-yarn-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}111m 59s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:a9ad5d6 |
| JIRA Issue | YARN-5965 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12841945/YARN-5965.0.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle cc |
| uname | Linux 6109507ea2ca 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18
21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[
https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725677#comment-15725677
]
Sunil G commented on YARN-5965:
---
Thanks [~rohithsharma]
Few minor nits:
{noformat}
optional string appNodeLabelExpression = 24;
optional string amNodeLabelExpression = 25;
repeated AppTimeoutMapProto application_timeouts = 26;
}
message AppTimeoutMapProto {
optional ApplicationTimeoutTypeProto application_timeout_type = 1;
optional ApplicationTimeoutProto application_timeouts = 2;
}
}
{noformat}
1. {{AppTimeoutMapProto application_timeouts}}, could it be like
{{appTimeouts}} and {{AppTimeoutsMapProto}}
2. AppTimeoutMapProto -> AppTimeoutsMapProto
3. application_timeouts -> application_timeout
> Revisit ApplicationReport #getApplicationTimeouts
> -
>
> Key: YARN-5965
> URL: https://issues.apache.org/jira/browse/YARN-5965
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
>Reporter: Jian He
>Assignee: Rohith Sharma K S
> Attachments: YARN-5965.0.patch
>
>
> Currently it returns a list of ApplicationTimeout objects, to get a
> particular timeout, the caller code needs to iterate the list and compare the
> timeoutType to get the corresponding value. Is a map data structure easier
> for use code?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723482#comment-15723482 ] Jian He commented on YARN-5965: --- yep, sounds good to me. > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He >Assignee: Rohith Sharma K S > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[
https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721642#comment-15721642
]
Sunil G commented on YARN-5965:
---
Hi.
Currently we use map in REST end and for cli. So I think we can keep the same
syntax here. Something like below.
{{public abstract Map
getApplicationTimeouts();}}
Thoughts?
> Revisit ApplicationReport #getApplicationTimeouts
> -
>
> Key: YARN-5965
> URL: https://issues.apache.org/jira/browse/YARN-5965
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
>Reporter: Jian He
>Assignee: Rohith Sharma K S
>
> Currently it returns a list of ApplicationTimeout objects, to get a
> particular timeout, the caller code needs to iterate the list and compare the
> timeoutType to get the corresponding value. Is a map data structure easier
> for use code?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5965) Revisit ApplicationReport #getApplicationTimeouts
[ https://issues.apache.org/jira/browse/YARN-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721574#comment-15721574 ] Jian He commented on YARN-5965: --- [~sunilg], [~rohithsharma] your opinion ? I was working on YARN-5768, don't have strong opinion on this, just want to hear your thoughts whether it's worth to change it or not. > Revisit ApplicationReport #getApplicationTimeouts > - > > Key: YARN-5965 > URL: https://issues.apache.org/jira/browse/YARN-5965 > Project: Hadoop YARN > Issue Type: Sub-task > Components: scheduler >Reporter: Jian He > > Currently it returns a list of ApplicationTimeout objects, to get a > particular timeout, the caller code needs to iterate the list and compare the > timeoutType to get the corresponding value. Is a map data structure easier > for use code? -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
